mirror of
https://github.com/qmk/qmk_firmware
synced 2024-11-20 12:15:06 +00:00
dbbab40981
* Moved contents of rgblight_reconfig.h to rgblight_post_config.h. In #3582, rgblight_reconfig.h had to be newly created. Now, the build system of qmk_firmware has a post_cofig feature, so that what was done in rgblight_reconfig.h can now be realized in rgblight_post_config.h. **This commit does not change the build result.** Testing script ```shell # build on master git checkout master echo master > /tmp/master_md5.txt # RGBLIGHT_ENABLE = no make HELIX=verbose helix/rev2:default:clean make HELIX=verbose helix/rev2:default md5 helix_rev2_default.hex >> /tmp/master_md5.txt # RGBLIGHT_ENABLE = yes, with animations make HELIX=verbose helix/rev2/back:default:clean make HELIX=verbose helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt # RGBLIGHT_ENABLE = yes, without animations make HELIX=verbose,no_ani helix/rev2/back:default:clean make HELIX=verbose,no_ani helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/master_md5.txt # build on refactor_rgblight_reconfig.h git checkout refactor_rgblight_reconfig.h echo refactor_rgblight_reconfig.h > /tmp/branch_md5.txt # RGBLIGHT_ENABLE = no make HELIX=verbose helix/rev2:default:clean make HELIX=verbose helix/rev2:default md5 helix_rev2_default.hex >> /tmp/branch_md5.txt # RGBLIGHT_ENABLE = yes, with animations make HELIX=verbose helix/rev2/back:default:clean make HELIX=verbose helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt # RGBLIGHT_ENABLE = yes, without animations make HELIX=verbose,no_ani helix/rev2/back:default:clean make HELIX=verbose,no_ani helix/rev2/back:default md5 helix_rev2_back_default.hex >> /tmp/branch_md5.txt diff -u /tmp/master_md5.txt /tmp/branch_md5.txt ``` Test result: ``` --- /tmp/master_md5.txt 2020-01-03 15:42:22.000000000 +0900 +++ /tmp/branch_md5.txt 2020-01-03 15:42:42.000000000 +0900 @@ -1,4 +1,4 @@ -master +refactor_rgblight_reconfig.h MD5 (helix_rev2_default.hex) = f360032edd522448366d471d8f4f8181 MD5 (helix_rev2_back_default.hex) = 0c663acc6cccc44476b3b969ad22a48f MD5 (helix_rev2_back_default.hex) = e66b1195ff6d38e6e22c975b8ae42fd3 ``` * Expressions that are too long are difficult to read, so wrap them. * Edit the expression again * remove `defined(RGBLIGHT_ANIMATIONS)` in `tmk_core/common/*/suspend.c`, `tmk_core/protocol/*/main.c` move contents of rgblight_reconfig.h to rgblight.h. The following changes were made to rgblight.h. ```diff +#ifdef RGBLIGHT_USE_TIMER void rgblight_task(void); void rgblight_timer_init(void); void rgblight_timer_enable(void); void rgblight_timer_disable(void); void rgblight_timer_toggle(void); +#else +#define rgblight_task() +#define rgblight_timer_init() +#define rgblight_timer_enable() +#define rgblight_timer_disable() +#define rgblight_timer_toggle() +#endif ``` The following changes were made to tmk_core/common/avr/suspend.c, tmk_core/common/chibios/suspend.c, tmk_core/protocol/chibios/main.c, tmk_core/protocol/lufa/lufa.c, tmk_core/protocol/vusb/main.c. ```diff -# ifdef RGBLIGHT_ANIMATIONS rgblight_timer_enable(); -# endif ``` ```diff -#if defined(RGBLIGHT_ANIMATIONS) && defined(RGBLIGHT_ENABLE) +#if defined(RGBLIGHT_ENABLE) rgblight_task(); #endif ``` * remove 'defined(RGBLIGHT_ANIMATIONS)' in tmk_core/common/keyboard.c Co-authored-by: Joel Challis <git@zvecr.com> |
||
|---|---|---|
| .. | ||
| api | ||
| audio | ||
| backlight | ||
| debounce | ||
| keymap_extras | ||
| process_keycode | ||
| rgb_matrix_animations | ||
| rgb_matrix_runners | ||
| serial_link | ||
| split_common | ||
| stm32 | ||
| template | ||
| tools | ||
| visualizer | ||
| api.c | ||
| api.h | ||
| color.c | ||
| color.h | ||
| config_common.h | ||
| debounce.h | ||
| dip_switch.c | ||
| dip_switch.h | ||
| dynamic_keymap.c | ||
| dynamic_keymap.h | ||
| dynamic_macro.h | ||
| encoder.c | ||
| encoder.h | ||
| fauxclicky.c | ||
| fauxclicky.h | ||
| keycode_config.c | ||
| keycode_config.h | ||
| keymap.h | ||
| keymap_common.c | ||
| led_matrix.c | ||
| led_matrix_drivers.c | ||
| led_tables.c | ||
| led_tables.h | ||
| ledmatrix.h | ||
| matrix.c | ||
| matrix_common.c | ||
| mcu_selection.mk | ||
| pincontrol.h | ||
| pointing_device.c | ||
| pointing_device.h | ||
| quantum.c | ||
| quantum.h | ||
| quantum_keycodes.h | ||
| rgb.h | ||
| rgb_matrix.c | ||
| rgb_matrix.h | ||
| rgb_matrix_drivers.c | ||
| rgb_matrix_types.h | ||
| rgblight.c | ||
| rgblight.h | ||
| rgblight_breathe_table.h | ||
| rgblight_list.h | ||
| rgblight_modes.h | ||
| rgblight_post_config.h | ||
| send_string_keycodes.h | ||
| variable_trace.c | ||
| variable_trace.h | ||
| velocikey.c | ||
| velocikey.h | ||
| via.c | ||
| via.h | ||