mirror of
https://github.com/qmk/qmk_firmware
synced 2024-09-17 09:19:33 +00:00
bc536b9b6d
Since combos keep local state about what keys have been previously pressed, when combos are layered, multiple keypresses will register for any key with multiple combos assigned to it. In order to fix this, I switched process_combo to use a global keycode / keyrecord register and timer. When a keypress is consumed by a combo, it gets stored in the register and the timer is updated; when the next keypress takes too long or a key is pressed that isn't part of any combo, the buffer is emitted and the timer reset. This has a few side effects. For instance, I couldn't _not_ fix combo keys printing out of order while also fixing this bug, so combo keys print in order correctly when a combo fails. since combos no longer have local timers, the logic around when combos time out has changed. now that there is a single timer pressing any combo key (including one in a different combo) will reset the timer for all combos, making combo entry a little more lenient. Since combos no longer have local keycode / keyrecord state, there is an edge case where incomplete combo keys can be consumed. if you have a combo for a+s = tab and a combo for b+n = space, if you press a+b+n, only a space will be emitted. This is because when b+n completes successfully, it drops the register. |
||
|---|---|---|
| .. | ||
| api | ||
| audio | ||
| debounce | ||
| keymap_extras | ||
| process_keycode | ||
| rgb_matrix_animations | ||
| serial_link | ||
| split_common | ||
| stm32 | ||
| template | ||
| tools | ||
| visualizer | ||
| api.c | ||
| api.h | ||
| color.c | ||
| color.h | ||
| config_common.h | ||
| debounce.h | ||
| dynamic_keymap.c | ||
| dynamic_keymap.h | ||
| dynamic_macro.h | ||
| encoder.c | ||
| encoder.h | ||
| fauxclicky.c | ||
| fauxclicky.h | ||
| keycode_config.c | ||
| keycode_config.h | ||
| keymap.h | ||
| keymap_common.c | ||
| led_matrix.c | ||
| led_matrix_drivers.c | ||
| led_tables.c | ||
| led_tables.h | ||
| ledmatrix.h | ||
| matrix.c | ||
| mcu_selection.mk | ||
| pincontrol.h | ||
| pointing_device.c | ||
| pointing_device.h | ||
| quantum.c | ||
| quantum.h | ||
| quantum_keycodes.h | ||
| rgb.h | ||
| rgb_matrix.c | ||
| rgb_matrix.h | ||
| rgb_matrix_drivers.c | ||
| rgb_matrix_types.h | ||
| rgblight.c | ||
| rgblight.h | ||
| rgblight_list.h | ||
| rgblight_reconfig.h | ||
| rgblight_types.h | ||
| send_string_keycodes.h | ||
| variable_trace.c | ||
| variable_trace.h | ||
| velocikey.c | ||
| velocikey.h | ||