From 2b8ad391aed15d41358c09d4b925e6a2bfc85ac6 Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Thu, 1 Jul 2021 10:07:37 +0200 Subject: [PATCH] [Keyboard] update debounce time on kint boards (#13351) related to https://github.com/kinx-project/kint/issues/39 related to https://github.com/qmk/qmk_firmware/pull/12626 --- keyboards/kinesis/kint2pp/config.h | 8 ++++++-- keyboards/kinesis/kint36/config.h | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/keyboards/kinesis/kint2pp/config.h b/keyboards/kinesis/kint2pp/config.h index ff5761b6bc9..a5530bc2f74 100644 --- a/keyboards/kinesis/kint2pp/config.h +++ b/keyboards/kinesis/kint2pp/config.h @@ -32,8 +32,12 @@ #define LED_COMPOSE_PIN C3 #define LED_PIN_ON_STATE 0 -/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ -#define DEBOUNCE 5 +/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the + * Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce + * algorithm, this debounce latency only affects key releases (not key + * presses). */ +#undef DEBOUNCE +#define DEBOUNCE 20 #define IGNORE_MOD_TAP_INTERRUPT diff --git a/keyboards/kinesis/kint36/config.h b/keyboards/kinesis/kint36/config.h index be57526036a..17a2b715f03 100644 --- a/keyboards/kinesis/kint36/config.h +++ b/keyboards/kinesis/kint36/config.h @@ -50,8 +50,12 @@ /* COL2ROW or ROW2COL */ #define DIODE_DIRECTION COL2ROW -/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */ -#define DEBOUNCE 5 +/* Well-worn Cherry MX key switches can bounce for up to 20ms, despite the + * Cherry data sheet specifying 5ms. Because we use the sym_eager_pk debounce + * algorithm, this debounce latency only affects key releases (not key + * presses). */ +#undef DEBOUNCE +#define DEBOUNCE 20 #define IGNORE_MOD_TAP_INTERRUPT