darkkirb/qmk_firmware
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Always read two bytes from the endpoint if we have two bytes to read

Browse source 
When this if statement is false, it will cause the report ID to be read as the LED state.
We already know there are two bytes in the endpoint, which is a reasonably good indicator that it contains a report ID, so we should always read both.
This commit is contained in:
fauxpark 2019-01-22 21:43:17 +11:00 committed by Drashna Jaelre
parent 8cf7265f8f
commit ae79b60e6b
1 changed files with 1 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tmk_core/protocol/lufa/lufa.c
View file

@ -519,11 +519,7 @@ void EVENT_USB_Device_ControlRequest(void)
} }
if (Endpoint_BytesInEndpoint() == 2) { if (Endpoint_BytesInEndpoint() == 2) {
uint8_t report_id = REPORT_ID_KEYBOARD; uint8_t report_id = Endpoint_Read_8();
if (keyboard_protocol) {
report_id = Endpoint_Read_8();
}
if (report_id == REPORT_ID_KEYBOARD || report_id == REPORT_ID_NKRO) { if (report_id == REPORT_ID_KEYBOARD || report_id == REPORT_ID_NKRO) {
keyboard_led_stats = Endpoint_Read_8(); keyboard_led_stats = Endpoint_Read_8();