9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
498 lines
14 KiB
C
498 lines
14 KiB
C
/* Target-dependent code for GNU/Linux running on the Fujitsu FR-V,
|
||
for GDB.
|
||
|
||
Copyright (C) 2004-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "gdbcore.h"
|
||
#include "target.h"
|
||
#include "frame.h"
|
||
#include "osabi.h"
|
||
#include "regcache.h"
|
||
#include "elf-bfd.h"
|
||
#include "elf/frv.h"
|
||
#include "frv-tdep.h"
|
||
#include "trad-frame.h"
|
||
#include "frame-unwind.h"
|
||
#include "regset.h"
|
||
#include "linux-tdep.h"
|
||
|
||
/* Define the size (in bytes) of an FR-V instruction. */
|
||
static const int frv_instr_size = 4;
|
||
|
||
enum {
|
||
NORMAL_SIGTRAMP = 1,
|
||
RT_SIGTRAMP = 2
|
||
};
|
||
|
||
static int
|
||
frv_linux_pc_in_sigtramp (struct gdbarch *gdbarch, CORE_ADDR pc,
|
||
const char *name)
|
||
{
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
gdb_byte buf[frv_instr_size];
|
||
LONGEST instr;
|
||
int retval = 0;
|
||
|
||
if (target_read_memory (pc, buf, sizeof buf) != 0)
|
||
return 0;
|
||
|
||
instr = extract_unsigned_integer (buf, sizeof buf, byte_order);
|
||
|
||
if (instr == 0x8efc0077) /* setlos #__NR_sigreturn, gr7 */
|
||
retval = NORMAL_SIGTRAMP;
|
||
else if (instr == 0x8efc00ad) /* setlos #__NR_rt_sigreturn, gr7 */
|
||
retval = RT_SIGTRAMP;
|
||
else
|
||
return 0;
|
||
|
||
if (target_read_memory (pc + frv_instr_size, buf, sizeof buf) != 0)
|
||
return 0;
|
||
instr = extract_unsigned_integer (buf, sizeof buf, byte_order);
|
||
if (instr != 0xc0700000) /* tira gr0, 0 */
|
||
return 0;
|
||
|
||
/* If we get this far, we'll return a non-zero value, either
|
||
NORMAL_SIGTRAMP (1) or RT_SIGTRAMP (2). */
|
||
return retval;
|
||
}
|
||
|
||
/* Given NEXT_FRAME, the "callee" frame of the sigtramp frame that we
|
||
wish to decode, and REGNO, one of the frv register numbers defined
|
||
in frv-tdep.h, return the address of the saved register (corresponding
|
||
to REGNO) in the sigtramp frame. Return -1 if the register is not
|
||
found in the sigtramp frame. The magic numbers in the code below
|
||
were computed by examining the following kernel structs:
|
||
|
||
From arch/frv/kernel/signal.c:
|
||
|
||
struct sigframe
|
||
{
|
||
void (*pretcode)(void);
|
||
int sig;
|
||
struct sigcontext sc;
|
||
unsigned long extramask[_NSIG_WORDS-1];
|
||
uint32_t retcode[2];
|
||
};
|
||
|
||
struct rt_sigframe
|
||
{
|
||
void (*pretcode)(void);
|
||
int sig;
|
||
struct siginfo *pinfo;
|
||
void *puc;
|
||
struct siginfo info;
|
||
struct ucontext uc;
|
||
uint32_t retcode[2];
|
||
};
|
||
|
||
From include/asm-frv/ucontext.h:
|
||
|
||
struct ucontext {
|
||
unsigned long uc_flags;
|
||
struct ucontext *uc_link;
|
||
stack_t uc_stack;
|
||
struct sigcontext uc_mcontext;
|
||
sigset_t uc_sigmask;
|
||
};
|
||
|
||
From include/asm-frv/signal.h:
|
||
|
||
typedef struct sigaltstack {
|
||
void *ss_sp;
|
||
int ss_flags;
|
||
size_t ss_size;
|
||
} stack_t;
|
||
|
||
From include/asm-frv/sigcontext.h:
|
||
|
||
struct sigcontext {
|
||
struct user_context sc_context;
|
||
unsigned long sc_oldmask;
|
||
} __attribute__((aligned(8)));
|
||
|
||
From include/asm-frv/registers.h:
|
||
struct user_int_regs
|
||
{
|
||
unsigned long psr;
|
||
unsigned long isr;
|
||
unsigned long ccr;
|
||
unsigned long cccr;
|
||
unsigned long lr;
|
||
unsigned long lcr;
|
||
unsigned long pc;
|
||
unsigned long __status;
|
||
unsigned long syscallno;
|
||
unsigned long orig_gr8;
|
||
unsigned long gner[2];
|
||
unsigned long long iacc[1];
|
||
|
||
union {
|
||
unsigned long tbr;
|
||
unsigned long gr[64];
|
||
};
|
||
};
|
||
|
||
struct user_fpmedia_regs
|
||
{
|
||
unsigned long fr[64];
|
||
unsigned long fner[2];
|
||
unsigned long msr[2];
|
||
unsigned long acc[8];
|
||
unsigned char accg[8];
|
||
unsigned long fsr[1];
|
||
};
|
||
|
||
struct user_context
|
||
{
|
||
struct user_int_regs i;
|
||
struct user_fpmedia_regs f;
|
||
|
||
void *extension;
|
||
} __attribute__((aligned(8))); */
|
||
|
||
static LONGEST
|
||
frv_linux_sigcontext_reg_addr (struct frame_info *this_frame, int regno,
|
||
CORE_ADDR *sc_addr_cache_ptr)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
CORE_ADDR sc_addr;
|
||
|
||
if (sc_addr_cache_ptr && *sc_addr_cache_ptr)
|
||
{
|
||
sc_addr = *sc_addr_cache_ptr;
|
||
}
|
||
else
|
||
{
|
||
CORE_ADDR pc, sp;
|
||
gdb_byte buf[4];
|
||
int tramp_type;
|
||
|
||
pc = get_frame_pc (this_frame);
|
||
tramp_type = frv_linux_pc_in_sigtramp (gdbarch, pc, 0);
|
||
|
||
get_frame_register (this_frame, sp_regnum, buf);
|
||
sp = extract_unsigned_integer (buf, sizeof buf, byte_order);
|
||
|
||
if (tramp_type == NORMAL_SIGTRAMP)
|
||
{
|
||
/* For a normal sigtramp frame, the sigcontext struct starts
|
||
at SP + 8. */
|
||
sc_addr = sp + 8;
|
||
}
|
||
else if (tramp_type == RT_SIGTRAMP)
|
||
{
|
||
/* For a realtime sigtramp frame, SP + 12 contains a pointer
|
||
to a ucontext struct. The ucontext struct contains a
|
||
sigcontext struct starting 24 bytes in. (The offset of
|
||
uc_mcontext within struct ucontext is derived as follows:
|
||
stack_t is a 12-byte struct and struct sigcontext is
|
||
8-byte aligned. This gives an offset of 8 + 12 + 4 (for
|
||
padding) = 24.) */
|
||
if (target_read_memory (sp + 12, buf, sizeof buf) != 0)
|
||
{
|
||
warning (_("Can't read realtime sigtramp frame."));
|
||
return 0;
|
||
}
|
||
sc_addr = extract_unsigned_integer (buf, sizeof buf, byte_order);
|
||
sc_addr += 24;
|
||
}
|
||
else
|
||
internal_error (__FILE__, __LINE__, _("not a signal trampoline"));
|
||
|
||
if (sc_addr_cache_ptr)
|
||
*sc_addr_cache_ptr = sc_addr;
|
||
}
|
||
|
||
switch (regno)
|
||
{
|
||
case psr_regnum :
|
||
return sc_addr + 0;
|
||
/* sc_addr + 4 has "isr", the Integer Status Register. */
|
||
case ccr_regnum :
|
||
return sc_addr + 8;
|
||
case cccr_regnum :
|
||
return sc_addr + 12;
|
||
case lr_regnum :
|
||
return sc_addr + 16;
|
||
case lcr_regnum :
|
||
return sc_addr + 20;
|
||
case pc_regnum :
|
||
return sc_addr + 24;
|
||
/* sc_addr + 28 is __status, the exception status.
|
||
sc_addr + 32 is syscallno, the syscall number or -1.
|
||
sc_addr + 36 is orig_gr8, the original syscall arg #1.
|
||
sc_addr + 40 is gner[0].
|
||
sc_addr + 44 is gner[1]. */
|
||
case iacc0h_regnum :
|
||
return sc_addr + 48;
|
||
case iacc0l_regnum :
|
||
return sc_addr + 52;
|
||
default :
|
||
if (first_gpr_regnum <= regno && regno <= last_gpr_regnum)
|
||
return sc_addr + 56 + 4 * (regno - first_gpr_regnum);
|
||
else if (first_fpr_regnum <= regno && regno <= last_fpr_regnum)
|
||
return sc_addr + 312 + 4 * (regno - first_fpr_regnum);
|
||
else
|
||
return -1; /* not saved. */
|
||
}
|
||
}
|
||
|
||
/* Signal trampolines. */
|
||
|
||
static struct trad_frame_cache *
|
||
frv_linux_sigtramp_frame_cache (struct frame_info *this_frame,
|
||
void **this_cache)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
|
||
enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);
|
||
struct trad_frame_cache *cache;
|
||
CORE_ADDR addr;
|
||
gdb_byte buf[4];
|
||
int regnum;
|
||
CORE_ADDR sc_addr_cache_val = 0;
|
||
struct frame_id this_id;
|
||
|
||
if (*this_cache)
|
||
return (struct trad_frame_cache *) *this_cache;
|
||
|
||
cache = trad_frame_cache_zalloc (this_frame);
|
||
|
||
/* FIXME: cagney/2004-05-01: This is is long standing broken code.
|
||
The frame ID's code address should be the start-address of the
|
||
signal trampoline and not the current PC within that
|
||
trampoline. */
|
||
get_frame_register (this_frame, sp_regnum, buf);
|
||
addr = extract_unsigned_integer (buf, sizeof buf, byte_order);
|
||
this_id = frame_id_build (addr, get_frame_pc (this_frame));
|
||
trad_frame_set_id (cache, this_id);
|
||
|
||
for (regnum = 0; regnum < frv_num_regs; regnum++)
|
||
{
|
||
LONGEST reg_addr = frv_linux_sigcontext_reg_addr (this_frame, regnum,
|
||
&sc_addr_cache_val);
|
||
if (reg_addr != -1)
|
||
trad_frame_set_reg_addr (cache, regnum, reg_addr);
|
||
}
|
||
|
||
*this_cache = cache;
|
||
return cache;
|
||
}
|
||
|
||
static void
|
||
frv_linux_sigtramp_frame_this_id (struct frame_info *this_frame,
|
||
void **this_cache,
|
||
struct frame_id *this_id)
|
||
{
|
||
struct trad_frame_cache *cache
|
||
= frv_linux_sigtramp_frame_cache (this_frame, this_cache);
|
||
trad_frame_get_id (cache, this_id);
|
||
}
|
||
|
||
static struct value *
|
||
frv_linux_sigtramp_frame_prev_register (struct frame_info *this_frame,
|
||
void **this_cache, int regnum)
|
||
{
|
||
/* Make sure we've initialized the cache. */
|
||
struct trad_frame_cache *cache
|
||
= frv_linux_sigtramp_frame_cache (this_frame, this_cache);
|
||
return trad_frame_get_register (cache, this_frame, regnum);
|
||
}
|
||
|
||
static int
|
||
frv_linux_sigtramp_frame_sniffer (const struct frame_unwind *self,
|
||
struct frame_info *this_frame,
|
||
void **this_cache)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (this_frame);
|
||
CORE_ADDR pc = get_frame_pc (this_frame);
|
||
const char *name;
|
||
|
||
find_pc_partial_function (pc, &name, NULL, NULL);
|
||
if (frv_linux_pc_in_sigtramp (gdbarch, pc, name))
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
|
||
static const struct frame_unwind frv_linux_sigtramp_frame_unwind =
|
||
{
|
||
SIGTRAMP_FRAME,
|
||
default_frame_unwind_stop_reason,
|
||
frv_linux_sigtramp_frame_this_id,
|
||
frv_linux_sigtramp_frame_prev_register,
|
||
NULL,
|
||
frv_linux_sigtramp_frame_sniffer
|
||
};
|
||
|
||
/* The FRV kernel defines ELF_NGREG as 46. We add 2 in order to include
|
||
the loadmap addresses in the register set. (See below for more info.) */
|
||
#define FRV_ELF_NGREG (46 + 2)
|
||
typedef unsigned char frv_elf_greg_t[4];
|
||
typedef struct { frv_elf_greg_t reg[FRV_ELF_NGREG]; } frv_elf_gregset_t;
|
||
|
||
typedef unsigned char frv_elf_fpreg_t[4];
|
||
typedef struct
|
||
{
|
||
frv_elf_fpreg_t fr[64];
|
||
frv_elf_fpreg_t fner[2];
|
||
frv_elf_fpreg_t msr[2];
|
||
frv_elf_fpreg_t acc[8];
|
||
unsigned char accg[8];
|
||
frv_elf_fpreg_t fsr[1];
|
||
} frv_elf_fpregset_t;
|
||
|
||
/* Register maps. */
|
||
|
||
static const struct regcache_map_entry frv_linux_gregmap[] =
|
||
{
|
||
{ 1, psr_regnum, 4 },
|
||
{ 1, REGCACHE_MAP_SKIP, 4 }, /* isr */
|
||
{ 1, ccr_regnum, 4 },
|
||
{ 1, cccr_regnum, 4 },
|
||
{ 1, lr_regnum, 4 },
|
||
{ 1, lcr_regnum, 4 },
|
||
{ 1, pc_regnum, 4 },
|
||
{ 1, REGCACHE_MAP_SKIP, 4 }, /* __status */
|
||
{ 1, REGCACHE_MAP_SKIP, 4 }, /* syscallno */
|
||
{ 1, REGCACHE_MAP_SKIP, 4 }, /* orig_gr8 */
|
||
{ 1, gner0_regnum, 4 },
|
||
{ 1, gner1_regnum, 4 },
|
||
{ 1, REGCACHE_MAP_SKIP, 8 }, /* iacc0 */
|
||
{ 1, tbr_regnum, 4 },
|
||
{ 31, first_gpr_regnum + 1, 4 }, /* gr1 ... gr31 */
|
||
|
||
/* Technically, the loadmap addresses are not part of `pr_reg' as
|
||
found in the elf_prstatus struct. The fields which communicate
|
||
the loadmap address appear (by design) immediately after
|
||
`pr_reg' though, and the BFD function elf32_frv_grok_prstatus()
|
||
has been implemented to include these fields in the register
|
||
section that it extracts from the core file. So, for our
|
||
purposes, they may be viewed as registers. */
|
||
|
||
{ 1, fdpic_loadmap_exec_regnum, 4 },
|
||
{ 1, fdpic_loadmap_interp_regnum, 4 },
|
||
{ 0 }
|
||
};
|
||
|
||
static const struct regcache_map_entry frv_linux_fpregmap[] =
|
||
{
|
||
{ 64, first_fpr_regnum, 4 }, /* fr0 ... fr63 */
|
||
{ 1, fner0_regnum, 4 },
|
||
{ 1, fner1_regnum, 4 },
|
||
{ 1, msr0_regnum, 4 },
|
||
{ 1, msr1_regnum, 4 },
|
||
{ 8, acc0_regnum, 4 }, /* acc0 ... acc7 */
|
||
{ 1, accg0123_regnum, 4 },
|
||
{ 1, accg4567_regnum, 4 },
|
||
{ 1, fsr0_regnum, 4 },
|
||
{ 0 }
|
||
};
|
||
|
||
/* Unpack an frv_elf_gregset_t into GDB's register cache. */
|
||
|
||
static void
|
||
frv_linux_supply_gregset (const struct regset *regset,
|
||
struct regcache *regcache,
|
||
int regnum, const void *gregs, size_t len)
|
||
{
|
||
int regi;
|
||
char zerobuf[MAX_REGISTER_SIZE];
|
||
|
||
memset (zerobuf, 0, MAX_REGISTER_SIZE);
|
||
|
||
/* gr0 always contains 0. Also, the kernel passes the TBR value in
|
||
this slot. */
|
||
regcache_raw_supply (regcache, first_gpr_regnum, zerobuf);
|
||
|
||
/* Fill gr32, ..., gr63 with zeros. */
|
||
for (regi = first_gpr_regnum + 32; regi <= last_gpr_regnum; regi++)
|
||
regcache_raw_supply (regcache, regi, zerobuf);
|
||
|
||
regcache_supply_regset (regset, regcache, regnum, gregs, len);
|
||
}
|
||
|
||
/* FRV Linux kernel register sets. */
|
||
|
||
static const struct regset frv_linux_gregset =
|
||
{
|
||
frv_linux_gregmap,
|
||
frv_linux_supply_gregset, regcache_collect_regset
|
||
};
|
||
|
||
static const struct regset frv_linux_fpregset =
|
||
{
|
||
frv_linux_fpregmap,
|
||
regcache_supply_regset, regcache_collect_regset
|
||
};
|
||
|
||
static void
|
||
frv_linux_iterate_over_regset_sections (struct gdbarch *gdbarch,
|
||
iterate_over_regset_sections_cb *cb,
|
||
void *cb_data,
|
||
const struct regcache *regcache)
|
||
{
|
||
cb (".reg", sizeof (frv_elf_gregset_t), &frv_linux_gregset,
|
||
NULL, cb_data);
|
||
cb (".reg2", sizeof (frv_elf_fpregset_t), &frv_linux_fpregset,
|
||
NULL, cb_data);
|
||
}
|
||
|
||
|
||
static void
|
||
frv_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
||
{
|
||
linux_init_abi (info, gdbarch);
|
||
|
||
/* Set the sigtramp frame sniffer. */
|
||
frame_unwind_append_unwinder (gdbarch, &frv_linux_sigtramp_frame_unwind);
|
||
|
||
set_gdbarch_iterate_over_regset_sections
|
||
(gdbarch, frv_linux_iterate_over_regset_sections);
|
||
}
|
||
|
||
static enum gdb_osabi
|
||
frv_linux_elf_osabi_sniffer (bfd *abfd)
|
||
{
|
||
int elf_flags;
|
||
|
||
elf_flags = elf_elfheader (abfd)->e_flags;
|
||
|
||
/* Assume GNU/Linux if using the FDPIC ABI. If/when another OS shows
|
||
up that uses this ABI, we'll need to start using .note sections
|
||
or some such. */
|
||
if (elf_flags & EF_FRV_FDPIC)
|
||
return GDB_OSABI_LINUX;
|
||
else
|
||
return GDB_OSABI_UNKNOWN;
|
||
}
|
||
|
||
/* Provide a prototype to silence -Wmissing-prototypes. */
|
||
void _initialize_frv_linux_tdep (void);
|
||
|
||
void
|
||
_initialize_frv_linux_tdep (void)
|
||
{
|
||
gdbarch_register_osabi (bfd_arch_frv, 0, GDB_OSABI_LINUX,
|
||
frv_linux_init_abi);
|
||
gdbarch_register_osabi_sniffer (bfd_arch_frv,
|
||
bfd_target_elf_flavour,
|
||
frv_linux_elf_osabi_sniffer);
|
||
}
|