old-cross-binutils/gdb/cli
Joel Brobecker 7c647d6155 warn if "source" fails to open the file when from_tty == 0
Consider the following example:

    % gdb -q -batch -ex 'source nonexistant-file'
    [nothing]

One would have at least expected the debugger to warn about
not finding the file, similar to the error shown when using
a more interactive mode. Eg:

    (gdb) source nonexistant-file
    nonexistant-file: No such file or directory.

Not raising an error appears to be intentional, presumably in order
to prevent this situation from stoping the execution of a GDB script.
But the lack of at least a warning makes it harder for a user to
diagnose any issue, if the file was expected to be there and readable.

This patch adds a warning in that case:

    % gdb -q -batch -ex 'source nonexistant-file'
    warning: nonexistant-file: No such file or directory.

gdb/ChangeLog:

        * utils.h (perror_warning_with_name): Add declaration.
        * utils.c (perror_warning_with_name): New function.
        * cli/cli-cmds.c (source_script_with_search): Add call to
        perror_warning_with_name if from_tty is nul.

gdb/testsuite/ChangeLog:

        * gdb.base/source-nofile.gdb: New file.
        * gdb.base/source.exp: Add two tests verifying the behavior when
        the "source" command is given a non-existant filename.
2013-10-11 08:23:11 +00:00
..
cli-cmds.c warn if "source" fails to open the file when from_tty == 0 2013-10-11 08:23:11 +00:00
cli-cmds.h * gdbcmd.h (togglelist): Delete. 2013-07-17 19:01:48 +00:00
cli-decode.c * cli/cli-decode.c: Remove unnecessary inclusion of tui/tui.h. 2013-10-01 23:52:45 +00:00
cli-decode.h Constify strings in tracepoint.c, lookup_cmd and the completers. 2013-03-13 18:34:55 +00:00
cli-dump.c Remove unnecessary XMALLOC definitions. 2013-08-09 15:41:46 +00:00
cli-interp.c Give every interpreter a command_loop_proc. 2013-09-06 08:53:09 +00:00
cli-logging.c simplify cli-logging.c for analysis 2013-05-30 17:13:19 +00:00
cli-script.c Remove error_pre_print and quit_pre_print. 2013-08-01 09:09:58 +00:00
cli-script.h Constify strings in tracepoint.c, lookup_cmd and the completers. 2013-03-13 18:34:55 +00:00
cli-setshow.c Constification of parse_linespec and fallout: 2013-10-02 00:46:07 +00:00
cli-setshow.h New commands "mt set per-command {space,time,symtab} {on,off}". 2013-03-21 17:37:30 +00:00
cli-utils.c * ada-lang.c (ada_read_renaming_var_value): Pass const 2013-03-12 17:39:45 +00:00
cli-utils.h * ada-lang.c (ada_read_renaming_var_value): Pass const 2013-03-12 17:39:45 +00:00