a8454a7c5a
Checking whether the gcore command is included in the GDB build as
proxy for checking whether core dumping is supported by the target is
useless, as gcore.o has been in COMMON_OBS since git 9b4eba8e:
2009-10-26 Michael Snyder <msnyder@vmware.com>
Hui Zhu <teawater@gmail.com>
* Makefile.in (SFILES): Add gcore.c.
(COMMON_OBS): Add gcore.o.
* config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
* config/alpha/fbsd.mh (NATDEPFILES): Ditto.
...
IOW, the command is always included in the build.
Instead, nowadays, tests bail out if actually trying to generate a
core fails with an indication the target doesn't support it. See
gdb_gcore_cmd and callers.
Tested on x86_64 Fedora 20.
gdb/testsuite/ChangeLog:
* gdb.base/gcore-buffer-overflow.exp: Remove "help gcore" test.
* gdb.base/gcore-relro-pie.exp: Likewise.
* gdb.base/gcore-relro.exp: Likewise.
* gdb.base/gcore.exp: Likewise.
* gdb.base/print-symbol-loading.exp: Likewise.
* gdb.threads/gcore-thread.exp: Likewise.
* lib/gdb.exp (gdb_gcore_cmd): Don't expect "Undefined command".
62 lines
2.1 KiB
Text
62 lines
2.1 KiB
Text
# Copyright 2013-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# PR 11786 (Gold and strip differ on flags,align fields of PT_GNU_RELRO).
|
|
# Generate a core file from the stripped version of the program,
|
|
# and then try to debug the core with the unstripped version.
|
|
|
|
standard_testfile
|
|
|
|
if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug additional_flags=-fpie "ldflags=-pie -Wl,-z,relro"}]} {
|
|
return -1
|
|
}
|
|
|
|
set stripped_binfile ${binfile}.stripped
|
|
set gcorefile ${binfile}.gcore
|
|
|
|
set strip_program [transform strip]
|
|
remote_file host delete ${stripped_binfile}
|
|
if [run_on_host "strip" "$strip_program" "-g -o ${stripped_binfile} $binfile"] {
|
|
return -1
|
|
}
|
|
|
|
# Workaround PR binutils/10802:
|
|
# Preserve the 'x' bit also for PIEs (Position Independent Executables).
|
|
set perm [file attributes ${binfile} -permissions]
|
|
file attributes ${stripped_binfile} -permissions $perm
|
|
|
|
clean_restart ${stripped_binfile}
|
|
|
|
# The binary is stripped of debug info, but not minsyms.
|
|
if ![runto break_here] {
|
|
fail "Can't run to break_here"
|
|
return -1
|
|
}
|
|
|
|
if {![gdb_gcore_cmd $gcorefile "save a corefile"]} {
|
|
return -1
|
|
}
|
|
|
|
# Now restart gdb with the unstripped binary and load the corefile.
|
|
|
|
clean_restart ${binfile}
|
|
|
|
gdb_test "core ${gcorefile}" \
|
|
"Core was generated by .*" "re-load generated corefile"
|
|
|
|
# Put $pc in gdb.log for debug purposes for comparison with stripped case.
|
|
gdb_test "x/i \$pc" "break_here.*"
|
|
|
|
gdb_test "frame" "#0 \[^\r\n\]* break_here .*" "unstripped + core ok"
|