9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
501 lines
16 KiB
Text
501 lines
16 KiB
Text
# Copyright 1988-2015 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This file was written by Rob Savoye. (rob@cygnus.com)
|
|
|
|
load_lib selftest-support.exp
|
|
|
|
# are we on a target board
|
|
if { [is_remote target] || ![isnative] } then {
|
|
return
|
|
}
|
|
|
|
# Not all of the lines of code near the start of main are executed for
|
|
# every machine. Also, optimization may reorder some of the lines.
|
|
# So all we do is try to step or next over everything until we get
|
|
# to a line that we know is always executed.
|
|
|
|
proc do_steps_and_nexts {} {
|
|
global gdb_prompt
|
|
global srcdir
|
|
|
|
gdb_reinitialize_dir $srcdir/..
|
|
|
|
set unlikely_line 0
|
|
for {set count 0} {$count < 32} {incr count} {
|
|
# NOTE: carlton/2002-12-11: The "initial brace" and
|
|
# "current_directory initialization" possibilities happen to
|
|
# me with GCC 3.1 on i686-pc-linux-gnu when I compile with
|
|
# optimization.
|
|
gdb_test_multiple "list" "list" {
|
|
-re ".*context = \\(struct captured_main_args \\*\\) data.*$gdb_prompt $" {
|
|
set description "step over context initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*argc = context->argc.*$gdb_prompt $" {
|
|
set description "step over argc initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*argv = context->argv.*$gdb_prompt $" {
|
|
set description "step over argv initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*quiet = 0.*$gdb_prompt $" {
|
|
set description "step over quiet initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*batch = 0.*$gdb_prompt $" {
|
|
set description "step over batch initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*symarg = NULL.*$gdb_prompt $" {
|
|
set description "step over symarg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*execarg = NULL.*$gdb_prompt $" {
|
|
set description "step over execarg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*pidarg = NULL.*$gdb_prompt $" {
|
|
set description "step over pidarg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*corearg = NULL.*$gdb_prompt $" {
|
|
set description "step over corearg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*pid_or_core_arg = NULL.*$gdb_prompt $" {
|
|
set description "step over pid_or_core_arg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*cdarg = NULL.*$gdb_prompt $" {
|
|
set description "step over cdarg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*ttyarg = NULL.*$gdb_prompt $" {
|
|
set description "step over ttyarg initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*cmdarg_vec = NULL.*$gdb_prompt $" {
|
|
set description "step over cmdarg_vec initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*pre_stat_chain = make_command_stats_cleanup.*$gdb_prompt $" {
|
|
set description "next over make_command_stats_cleanup and everything it calls"
|
|
set command "next"
|
|
}
|
|
-re ".*START_PROGRESS.*$gdb_prompt $" {
|
|
# Note: ezannoni/2004/02/17: This check should be
|
|
# removed, since as of today that source line is not
|
|
# in gdb anymore.
|
|
set description "next over START_PROGRESS and everything it calls"
|
|
set command "next"
|
|
}
|
|
-re ".*mac_init.*$gdb_prompt $" {
|
|
set description "next over mac_init and everything it calls"
|
|
set command "next"
|
|
}
|
|
-re ".*init_malloc.*$gdb_prompt $" {
|
|
# gdb 6.2.X is the last gdb which called init_malloc
|
|
set description "next over init_malloc and everything it calls"
|
|
set command "next"
|
|
}
|
|
-re ".*lim_at_start.*$gdb_prompt $" {
|
|
set description "next over lim_at_start initialization"
|
|
set command "next"
|
|
}
|
|
-re ".*count . 0x3.*$gdb_prompt $" {
|
|
set description "next over conditional stack alignment code 1"
|
|
set command "next"
|
|
}
|
|
-re ".*if .i != 0.*$gdb_prompt $" {
|
|
set description "next over conditional stack alignment code 2"
|
|
set command "next"
|
|
}
|
|
-re ".*alloca .i - 4.*$gdb_prompt $" {
|
|
set description "next over conditional stack alignment alloca"
|
|
set command "next"
|
|
}
|
|
-re ".*dirsize = 1.*$gdb_prompt $" {
|
|
set description "next over dirsize initialization"
|
|
set command "next"
|
|
}
|
|
-re ".*dirarg = .* xmalloc.*$gdb_prompt $" {
|
|
return
|
|
}
|
|
-re ".*setlocale .LC_MESSAGES,.*$gdb_prompt $" {
|
|
set description "next over setlocale LC_MESSAGES"
|
|
set command "next"
|
|
}
|
|
-re ".*setlocale .LC_CTYPE,.*$gdb_prompt $" {
|
|
set description "next over setlocale LC_CTYPE"
|
|
set command "next"
|
|
}
|
|
-re ".*bindtextdomain .PACKAGE, LOCALEDIR.;.*$gdb_prompt $" {
|
|
set description "next over bindtextdomain"
|
|
set command "next"
|
|
}
|
|
-re ".*textdomain .PACKAGE.;.*$gdb_prompt $" {
|
|
set description "next over textdomain PACKAGE"
|
|
set command "next"
|
|
}
|
|
-re ".*bfd_init ..;.*$gdb_prompt $" {
|
|
set description "next over bfd_init"
|
|
set command "next"
|
|
}
|
|
-re ".*notice_open_fds ..;.*$gdb_prompt $" {
|
|
set description "next over notice_open_fds"
|
|
set command "next"
|
|
}
|
|
-re ".*VEC_cleanup .cmdarg_s.*$gdb_prompt $" {
|
|
set description "next over cmdarg_s VEC_cleanup"
|
|
set command "next"
|
|
}
|
|
-re "\[0-9\]+\[\t \]+\{\r\n$gdb_prompt $" {
|
|
set description "step over initial brace"
|
|
set command "step"
|
|
}
|
|
-re ".*current_directory = gdb_dirbuf.*$gdb_prompt $" {
|
|
set description "step over current_directory initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*gdb_sysroot = .*$gdb_prompt $" {
|
|
# NOTE: carlton/2003-01-15: More optimization reordering,
|
|
# observed on GCC 3.1.
|
|
set description "step over gdb_sysroot initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*ndir = 0.*$gdb_prompt $" {
|
|
set description "step over ndir initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*instream = stdin.*$gdb_prompt $" {
|
|
set description "step over instream initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*getcwd .gdb_dirbuf, sizeof .gdb_dirbuf.*$gdb_prompt $" {
|
|
set description "next over getcwd"
|
|
set command "next"
|
|
}
|
|
-re ".*gdb_program_name = xstrdup.*$gdb_prompt $" {
|
|
set description "next over xstrdup"
|
|
set command "next"
|
|
}
|
|
-re ".*quit_flag = 0.*$gdb_prompt $" {
|
|
set description "step over quit_flag initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*gdb_stdout = stdio_fileopen .stdout.;.*$gdb_prompt $" {
|
|
set description "step over gdb_stdout initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*gdb_stderr = stdio_fileopen .stderr.;.*$gdb_prompt $" {
|
|
set description "step over gdb_stderr initialization"
|
|
set command "step"
|
|
}
|
|
-re ".*main.c.*No such file or directory.*$gdb_prompt $" {
|
|
setup_xfail "rs6000-*-aix3*"
|
|
fail "must be able to list source lines"
|
|
return
|
|
}
|
|
-re ".*interpreter_p = xstrdup.*$gdb_prompt $" {
|
|
if { $unlikely_line == 0 } {
|
|
# This is a GCC optimization bug; a constant has been
|
|
# associated with the wrong line number.
|
|
setup_xfail "*-*-*" gcc/26475
|
|
fail "$description (unlikely line from gcc)"
|
|
set unlikely_line 1
|
|
}
|
|
set description "next over xstrdup"
|
|
set command "next"
|
|
}
|
|
-re ".*$gdb_prompt $" {
|
|
# If $description hasn't been set yet, it's likely the file
|
|
# has been edited but gdb hasn't been recompiled.
|
|
if [info exists description] {
|
|
fail "unknown source line (after $description)"
|
|
} else {
|
|
fail "unknown source line"
|
|
}
|
|
return
|
|
}
|
|
default {
|
|
fail "unknown source line near main"
|
|
return
|
|
}
|
|
}
|
|
gdb_test_multiple "$command" "$description" {
|
|
-re ".*No such file or directory.\r\n$gdb_prompt $" {
|
|
fail "$description (no source available)"
|
|
}
|
|
-re ".*A file or directory .* does not exist..\r\n$gdb_prompt $" {
|
|
fail "$description (no source available)"
|
|
}
|
|
-re ".*$gdb_prompt $" {
|
|
pass "$description"
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
proc test_with_self { executable } {
|
|
global gdb_prompt
|
|
global tool
|
|
global det_file
|
|
global decimal
|
|
global timeout
|
|
global INTERNAL_GDBFLAGS
|
|
global inferior_spawn_id gdb_spawn_id
|
|
|
|
# load yourself into the debugger
|
|
# This can take a relatively long time, particularly for testing where
|
|
# the executable is being accessed over a network, or where gdb does not
|
|
# support partial symbols for a particular target and has to load the
|
|
# entire symbol table. Set the timeout to 10 minutes, which should be
|
|
# adequate for most environments (it *has* timed out with 5 min on a
|
|
# SPARCstation SLC under moderate load, so this isn't unreasonable).
|
|
# After gdb is started, set the timeout to 30 seconds for the duration
|
|
# of this test, and then back to the original value.
|
|
|
|
set oldtimeout $timeout
|
|
set timeout 600
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
|
|
global gdb_file_cmd_debug_info
|
|
set gdb_file_cmd_debug_info "unset"
|
|
|
|
set result [gdb_load $executable]
|
|
set timeout $oldtimeout
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
|
|
if { $result != 0 } then {
|
|
return -1
|
|
}
|
|
|
|
if { $gdb_file_cmd_debug_info != "debug" } then {
|
|
untested "No debug information, skipping testcase."
|
|
return -1
|
|
}
|
|
|
|
# When GDB is built as a C++ program, disassemble shows the full
|
|
# prototype.
|
|
set cxx_main_args_re [string_to_regexp "(int, char**)"]
|
|
|
|
# disassemble yourself
|
|
gdb_test "x/10i main" \
|
|
"x/10i.*main.*main($cxx_main_args_re)?.$decimal.*main($cxx_main_args_re)?.$decimal.*" \
|
|
"Disassemble main"
|
|
|
|
# Set a breakpoint at main
|
|
gdb_test "break captured_main" \
|
|
"Breakpoint.*at.* file.*, line.*" \
|
|
"breakpoint in captured_main"
|
|
|
|
# We'll need this when we send a ^C to GDB. Need to do it before we
|
|
# run the program and gdb starts saving and restoring tty states.
|
|
gdb_test "shell stty intr '^C'" ".*" \
|
|
"set interrupt character in test_with_self"
|
|
|
|
# FIXME: If we put this after the run to main, the first list
|
|
# command doesn't print the same line as the current line where
|
|
# gdb is stopped.
|
|
gdb_test_no_output "set listsize 1" "set listsize to 1"
|
|
|
|
# run yourself
|
|
# It may take a very long time for the inferior gdb to start (lynx),
|
|
# so we bump it back up for the duration of this command.
|
|
set timeout 600
|
|
|
|
set description "run until breakpoint at captured_main"
|
|
gdb_test_multiple "run $INTERNAL_GDBFLAGS" "$description" {
|
|
-re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.* at .*main.c:.*$gdb_prompt $" {
|
|
pass "$description"
|
|
}
|
|
-re "Starting program.*Breakpoint \[0-9\]+,.*captured_main .data.*$gdb_prompt $" {
|
|
xfail "$description (line numbers scrambled?)"
|
|
}
|
|
-re "vfork: No more processes.*$gdb_prompt $" {
|
|
fail "$description (out of virtual memory)"
|
|
set timeout $oldtimeout
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
return -1
|
|
}
|
|
-re ".*$gdb_prompt $" {
|
|
fail "$description"
|
|
set timeout $oldtimeout
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
return -1
|
|
}
|
|
}
|
|
|
|
set timeout $oldtimeout
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
|
|
# do we have a version number ?
|
|
gdb_test_multiple "print version" "printed version" {
|
|
-re ".\[0-9\]+ = .\[0-9.\]+.*$gdb_prompt $" {
|
|
pass "printed version as string"
|
|
}
|
|
-re ".\[0-9\]+ = +0x.*\[0-9.\]+.*$gdb_prompt $" {
|
|
pass "printed version as pointer"
|
|
}
|
|
-re ".\[0-9\]+ = +.+ +0x.*\[0-9.\]+.*$gdb_prompt $" {
|
|
pass "printed version with cast"
|
|
}
|
|
}
|
|
|
|
do_steps_and_nexts
|
|
|
|
gdb_test "print \"foo\"" ".\[0-9\]+ = \"foo\"" "print a string"
|
|
|
|
# do_steps_and_nexts left us ready to execute an xmalloc call,
|
|
# so give that a try.
|
|
# If we don't actually enter the xmalloc call when we give a
|
|
# step command that seems like a genuine bug. It seems to happen
|
|
# on most RISC processors.
|
|
# NOTE drow/2003-06-22: However, if we step back to the preceding two
|
|
# lines, just keep stepping until we enter.
|
|
set stepped_back 0
|
|
setup_xfail "alpha-*-*" "mips-*-*"
|
|
set description "step into xmalloc call"
|
|
gdb_test_multiple "step" "$description" {
|
|
-re "ncmd = 0;.*$gdb_prompt $" {
|
|
set stepped_back 1
|
|
send_gdb "step\n"
|
|
exp_continue
|
|
}
|
|
-re ".*cmdarg = .* xmalloc.*$gdb_prompt $" {
|
|
set stepped_back 1
|
|
send_gdb "step\n"
|
|
exp_continue
|
|
}
|
|
-re "dirsize = 1;.*$gdb_prompt $" {
|
|
set stepped_back 1
|
|
send_gdb "step\n"
|
|
exp_continue
|
|
}
|
|
-re ".*dirarg = .* xmalloc.*$gdb_prompt $" {
|
|
if { $stepped_back == 1 } {
|
|
send_gdb "step\n"
|
|
exp_continue
|
|
} else {
|
|
fail "$description"
|
|
}
|
|
}
|
|
-re "xmalloc.*size=.*at.*utils.c.*$gdb_prompt $" {
|
|
pass "$description"
|
|
}
|
|
-re ".*No such file or directory.\r\n$gdb_prompt $" {
|
|
pass "$description (no source available)"
|
|
}
|
|
-re "A file or directory .* does not exist..\r\n$gdb_prompt $" {
|
|
pass "$description (no source available)"
|
|
}
|
|
}
|
|
|
|
# start the "xgdb" process
|
|
if [target_info exists gdb,noinferiorio] {
|
|
# With no way to interact with the inferior GDB, all we can do
|
|
# is let it run.
|
|
send_gdb "continue\n"
|
|
# Wait a bit while the inferior gdb gets to its prompt.
|
|
sleep 1
|
|
} else {
|
|
set test "xgdb is at prompt"
|
|
gdb_test_multiple "continue" $test {
|
|
-i "$inferior_spawn_id"
|
|
-re "GNU gdb \[0-9\.\]*.*Copyright \\(C\\) \[0-9\]* Free Software Foundation, Inc.*License GPLv3\\+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>.*This is free software: you are free to change and redistribute it.*There is NO WARRANTY, to the extent permitted by law. Type \"show copying\".*and \"show warranty\" for details.*This GDB was configured as .*$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
}
|
|
|
|
# set xgdb prompt so we can tell which is which
|
|
send_inferior "set prompt (xgdb) \n"
|
|
set msg "Set xgdb_prompt"
|
|
gdb_test_multiple "" $msg {
|
|
-i "$inferior_spawn_id"
|
|
-re "\[(\]xgdb\[)\].*\[(\]xgdb\[)\] $" {
|
|
pass $msg
|
|
}
|
|
}
|
|
}
|
|
|
|
# kill the xgdb process
|
|
set description "send ^C to child process"
|
|
send_gdb "\003"
|
|
gdb_expect {
|
|
-re "Program received signal SIGINT.*$gdb_prompt $" {
|
|
pass "$description"
|
|
}
|
|
-re ".*$gdb_prompt $" {
|
|
fail "$description"
|
|
}
|
|
timeout {
|
|
fail "$description (timeout)"
|
|
}
|
|
}
|
|
|
|
set description "send SIGINT signal to child process"
|
|
gdb_test "signal SIGINT" \
|
|
"Continuing with signal SIGINT.*" \
|
|
"$description"
|
|
|
|
# get a stack trace
|
|
#
|
|
# This fails on some linux systems for unknown reasons. On the
|
|
# systems where it fails, sometimes it works fine when run manually.
|
|
# The testsuite failures may not be limited to just aout systems.
|
|
setup_xfail "i*86-pc-linuxaout-gnu"
|
|
set description "backtrace through signal handler"
|
|
gdb_test_multiple "backtrace" "$description" {
|
|
-re "#0.*(read|poll).*in main \\(.*\\) at .*gdb\\.c.*$gdb_prompt $" {
|
|
pass "$description"
|
|
}
|
|
}
|
|
|
|
|
|
# Set the timeout back to the value it had when we were called.
|
|
set timeout $oldtimeout
|
|
verbose "Timeout is now $timeout seconds" 2
|
|
|
|
# Restart gdb in case next test expects it to be started already.
|
|
return 0
|
|
}
|
|
|
|
# Run the test with self.
|
|
# Copy the file executable file in case this OS doesn't like to edit its own
|
|
# text space.
|
|
|
|
set GDB_FULLPATH [find_gdb $GDB]
|
|
|
|
if {[is_remote host]} {
|
|
set xgdb x$tool
|
|
} else {
|
|
set xgdb [standard_output_file x$tool]
|
|
}
|
|
|
|
# Remove any old copy lying around.
|
|
remote_file host delete $xgdb
|
|
|
|
gdb_start
|
|
set file [remote_download host $GDB_FULLPATH $xgdb]
|
|
set result [test_with_self $file]
|
|
gdb_exit
|
|
catch "remote_file host delete $file"
|
|
|
|
if {$result <0} then {
|
|
warning "Couldn't test self"
|
|
return -1
|
|
}
|