23f238d345
On GNU/Linux, this test sometimes FAILs like this: (gdb) run Starting program: /home/pedro/gdb/mygit/build/gdb/testsuite/gdb.threads/killed [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib64/libthread_db.so.1". ptrace: No such process. (gdb) Program terminated with signal SIGKILL, Killed. The program no longer exists. FAIL: gdb.threads/killed.exp: run program to completion (timeout) Note the suspicious "No such process" line (that's errno==ESRCH). Adding debug output we see: linux_nat_wait: [process -1], [TARGET_WNOHANG] LLW: enter LNW: waitpid(-1, ...) returned 18465, ERRNO-OK LLW: waitpid 18465 received Stopped (signal) (stopped) LNW: waitpid(-1, ...) returned 18461, ERRNO-OK LLW: waitpid 18461 received Trace/breakpoint trap (stopped) LLW: Handling extended status 0x03057f LHEW: Got clone event from LWP 18461, new child is LWP 18465 LNW: waitpid(-1, ...) returned 0, ERRNO-OK RSRL: resuming stopped-resumed LWP LWP 18465 at 0x3b36af4b51: step=0 RSRL: resuming stopped-resumed LWP LWP 18461 at 0x3b36af4b51: step=0 sigchld ptrace: No such process. (gdb) linux_nat_wait: [process -1], [TARGET_WNOHANG] LLW: enter LNW: waitpid(-1, ...) returned 18465, ERRNO-OK LLW: waitpid 18465 received Killed (terminated) LLW: LWP 18465 exited. LNW: waitpid(-1, ...) returned 18461, No child processes LLW: waitpid 18461 received Killed (terminated) Process 18461 exited LNW: waitpid(-1, ...) returned -1, No child processes LLW: exit sigchld infrun: target_wait (-1, status) = infrun: 18461 [process 18461], infrun: status->kind = signalled, signal = GDB_SIGNAL_KILL infrun: TARGET_WAITKIND_SIGNALLED Program terminated with signal SIGKILL, Killed. The program no longer exists. infrun: stop_waiting FAIL: gdb.threads/killed.exp: run program to completion (timeout) The issue is that here: RSRL: resuming stopped-resumed LWP LWP 18465 at 0x3b36af4b51: step=0 RSRL: resuming stopped-resumed LWP LWP 18461 at 0x3b36af4b51: step=0 The first line shows we had just resumed LWP 18465, which does: void * child_func (void *dummy) { kill (pid, SIGKILL); exit (1); } So if the kernel manages to schedule that thread fast enough, the process may be killed before GDB has a chance to resume LWP 18461. GDBserver has code at the tail end of linux_resume_one_lwp to cope with this: ~~~ ptrace (step ? PTRACE_SINGLESTEP : PTRACE_CONT, lwpid_of (thread), (PTRACE_TYPE_ARG3) 0, /* Coerce to a uintptr_t first to avoid potential gcc warning of coercing an 8 byte integer to a 4 byte pointer. */ (PTRACE_TYPE_ARG4) (uintptr_t) signal); current_thread = saved_thread; if (errno) { /* ESRCH from ptrace either means that the thread was already running (an error) or that it is gone (a race condition). If it's gone, we will get a notification the next time we wait, so we can ignore the error. We could differentiate these two, but it's tricky without waiting; the thread still exists as a zombie, so sending it signal 0 would succeed. So just ignore ESRCH. */ if (errno == ESRCH) return; perror_with_name ("ptrace"); } ~~~ However, that's not a complete fix, because between starting to handle the resume request and getting that PTRACE_CONTINUE, we run other ptrace calls that can also fail with ESRCH, and that end up throwing an error (with perror_with_name). In the case above, I indeed sometimes see resume_stopped_resumed_lwps fail in the registers read: resume_stopped_resumed_lwps (struct lwp_info *lp, void *data) { ... CORE_ADDR pc = regcache_read_pc (regcache); Or e.g., in 32-bit mode, i386_linux_resume has several calls that can throw too. Whether to ignore ptrace errors or not depends on context that is only available somewhere up the call chain. So the fix is to let ptrace errors throw as they do today, and wrap the resume request in a TRY/CATCH that swallows it iff the lwp that we were trying to resume is no longer ptrace-stopped. gdb/gdbserver/ChangeLog: 2015-03-19 Pedro Alves <palves@redhat.com> * linux-low.c (linux_resume_one_lwp): Rename to ... (linux_resume_one_lwp_throw): ... this. Don't handle ESRCH here, instead call perror_with_name. (check_ptrace_stopped_lwp_gone): New function. (linux_resume_one_lwp): Reimplement as wrapper around linux_resume_one_lwp_throw that swallows errors if the LWP is gone. gdb/ChangeLog: 2015-03-19 Pedro Alves <palves@redhat.com> * linux-nat.c (linux_resume_one_lwp): Rename to ... (linux_resume_one_lwp_throw): ... this. Don't handle ESRCH here, instead call perror_with_name. (check_ptrace_stopped_lwp_gone): New function. (linux_resume_one_lwp): Reimplement as wrapper around linux_resume_one_lwp_throw that swallows errors if the LWP is gone. (resume_stopped_resumed_lwps): Try register reads in TRY/CATCH and swallows errors if the LWP is gone. Use linux_resume_one_lwp_throw instead of linux_resume_one_lwp.
275 lines
6.4 KiB
C
275 lines
6.4 KiB
C
/* Linux-specific PROCFS manipulation routines.
|
|
Copyright (C) 2009-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "common-defs.h"
|
|
#include "linux-procfs.h"
|
|
#include "filestuff.h"
|
|
#include <dirent.h>
|
|
#include <sys/stat.h>
|
|
|
|
/* Return the TGID of LWPID from /proc/pid/status. Returns -1 if not
|
|
found. */
|
|
|
|
static int
|
|
linux_proc_get_int (pid_t lwpid, const char *field, int warn)
|
|
{
|
|
size_t field_len = strlen (field);
|
|
FILE *status_file;
|
|
char buf[100];
|
|
int retval = -1;
|
|
|
|
snprintf (buf, sizeof (buf), "/proc/%d/status", (int) lwpid);
|
|
status_file = gdb_fopen_cloexec (buf, "r");
|
|
if (status_file == NULL)
|
|
{
|
|
if (warn)
|
|
warning (_("unable to open /proc file '%s'"), buf);
|
|
return -1;
|
|
}
|
|
|
|
while (fgets (buf, sizeof (buf), status_file))
|
|
if (strncmp (buf, field, field_len) == 0 && buf[field_len] == ':')
|
|
{
|
|
retval = strtol (&buf[field_len + 1], NULL, 10);
|
|
break;
|
|
}
|
|
|
|
fclose (status_file);
|
|
return retval;
|
|
}
|
|
|
|
/* Return the TGID of LWPID from /proc/pid/status. Returns -1 if not
|
|
found. */
|
|
|
|
int
|
|
linux_proc_get_tgid (pid_t lwpid)
|
|
{
|
|
return linux_proc_get_int (lwpid, "Tgid", 1);
|
|
}
|
|
|
|
/* See linux-procfs.h. */
|
|
|
|
pid_t
|
|
linux_proc_get_tracerpid_nowarn (pid_t lwpid)
|
|
{
|
|
return linux_proc_get_int (lwpid, "TracerPid", 0);
|
|
}
|
|
|
|
/* Fill in BUFFER, a buffer with BUFFER_SIZE bytes with the 'State'
|
|
line of /proc/PID/status. Returns -1 on failure to open the /proc
|
|
file, 1 if the line is found, and 0 if not found. If WARN, warn on
|
|
failure to open the /proc file. */
|
|
|
|
static int
|
|
linux_proc_pid_get_state (pid_t pid, char *buffer, size_t buffer_size,
|
|
int warn)
|
|
{
|
|
FILE *procfile;
|
|
int have_state;
|
|
|
|
xsnprintf (buffer, buffer_size, "/proc/%d/status", (int) pid);
|
|
procfile = gdb_fopen_cloexec (buffer, "r");
|
|
if (procfile == NULL)
|
|
{
|
|
if (warn)
|
|
warning (_("unable to open /proc file '%s'"), buffer);
|
|
return -1;
|
|
}
|
|
|
|
have_state = 0;
|
|
while (fgets (buffer, buffer_size, procfile) != NULL)
|
|
if (startswith (buffer, "State:"))
|
|
{
|
|
have_state = 1;
|
|
break;
|
|
}
|
|
fclose (procfile);
|
|
return have_state;
|
|
}
|
|
|
|
/* See linux-procfs.h declaration. */
|
|
|
|
int
|
|
linux_proc_pid_is_gone (pid_t pid)
|
|
{
|
|
char buffer[100];
|
|
int have_state;
|
|
|
|
have_state = linux_proc_pid_get_state (pid, buffer, sizeof buffer, 0);
|
|
if (have_state < 0)
|
|
{
|
|
/* If we can't open the status file, assume the thread has
|
|
disappeared. */
|
|
return 1;
|
|
}
|
|
else if (have_state == 0)
|
|
{
|
|
/* No "State:" line, assume thread is alive. */
|
|
return 0;
|
|
}
|
|
else
|
|
{
|
|
return (strstr (buffer, "Z (") != NULL
|
|
|| strstr (buffer, "X (") != NULL);
|
|
}
|
|
}
|
|
|
|
/* Return non-zero if 'State' of /proc/PID/status contains STATE. If
|
|
WARN, warn on failure to open the /proc file. */
|
|
|
|
static int
|
|
linux_proc_pid_has_state (pid_t pid, const char *state, int warn)
|
|
{
|
|
char buffer[100];
|
|
int have_state;
|
|
|
|
have_state = linux_proc_pid_get_state (pid, buffer, sizeof buffer, warn);
|
|
return (have_state > 0 && strstr (buffer, state) != NULL);
|
|
}
|
|
|
|
/* Detect `T (stopped)' in `/proc/PID/status'.
|
|
Other states including `T (tracing stop)' are reported as false. */
|
|
|
|
int
|
|
linux_proc_pid_is_stopped (pid_t pid)
|
|
{
|
|
return linux_proc_pid_has_state (pid, "T (stopped)", 1);
|
|
}
|
|
|
|
/* Detect `T (tracing stop)' in `/proc/PID/status'.
|
|
Other states including `T (stopped)' are reported as false. */
|
|
|
|
int
|
|
linux_proc_pid_is_trace_stopped_nowarn (pid_t pid)
|
|
{
|
|
return linux_proc_pid_has_state (pid, "T (tracing stop)", 1);
|
|
}
|
|
|
|
/* Return non-zero if PID is a zombie. If WARN, warn on failure to
|
|
open the /proc file. */
|
|
|
|
static int
|
|
linux_proc_pid_is_zombie_maybe_warn (pid_t pid, int warn)
|
|
{
|
|
return linux_proc_pid_has_state (pid, "Z (zombie)", warn);
|
|
}
|
|
|
|
/* See linux-procfs.h declaration. */
|
|
|
|
int
|
|
linux_proc_pid_is_zombie_nowarn (pid_t pid)
|
|
{
|
|
return linux_proc_pid_is_zombie_maybe_warn (pid, 0);
|
|
}
|
|
|
|
/* See linux-procfs.h declaration. */
|
|
|
|
int
|
|
linux_proc_pid_is_zombie (pid_t pid)
|
|
{
|
|
return linux_proc_pid_is_zombie_maybe_warn (pid, 1);
|
|
}
|
|
|
|
/* See linux-procfs.h declaration. */
|
|
|
|
char *
|
|
linux_proc_pid_get_ns (pid_t pid, const char *ns)
|
|
{
|
|
char buf[100];
|
|
char nsval[64];
|
|
int ret;
|
|
xsnprintf (buf, sizeof (buf), "/proc/%d/ns/%s", (int) pid, ns);
|
|
ret = readlink (buf, nsval, sizeof (nsval));
|
|
if (0 < ret && ret < sizeof (nsval))
|
|
{
|
|
nsval[ret] = '\0';
|
|
return xstrdup (nsval);
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* See linux-procfs.h. */
|
|
|
|
void
|
|
linux_proc_attach_tgid_threads (pid_t pid,
|
|
linux_proc_attach_lwp_func attach_lwp)
|
|
{
|
|
DIR *dir;
|
|
char pathname[128];
|
|
int new_threads_found;
|
|
int iterations;
|
|
|
|
if (linux_proc_get_tgid (pid) != pid)
|
|
return;
|
|
|
|
xsnprintf (pathname, sizeof (pathname), "/proc/%ld/task", (long) pid);
|
|
dir = opendir (pathname);
|
|
if (dir == NULL)
|
|
{
|
|
warning (_("Could not open /proc/%ld/task."), (long) pid);
|
|
return;
|
|
}
|
|
|
|
/* Scan the task list for existing threads. While we go through the
|
|
threads, new threads may be spawned. Cycle through the list of
|
|
threads until we have done two iterations without finding new
|
|
threads. */
|
|
for (iterations = 0; iterations < 2; iterations++)
|
|
{
|
|
struct dirent *dp;
|
|
|
|
new_threads_found = 0;
|
|
while ((dp = readdir (dir)) != NULL)
|
|
{
|
|
unsigned long lwp;
|
|
|
|
/* Fetch one lwp. */
|
|
lwp = strtoul (dp->d_name, NULL, 10);
|
|
if (lwp != 0)
|
|
{
|
|
ptid_t ptid = ptid_build (pid, lwp, 0);
|
|
|
|
if (attach_lwp (ptid))
|
|
new_threads_found = 1;
|
|
}
|
|
}
|
|
|
|
if (new_threads_found)
|
|
{
|
|
/* Start over. */
|
|
iterations = -1;
|
|
}
|
|
|
|
rewinddir (dir);
|
|
}
|
|
|
|
closedir (dir);
|
|
}
|
|
|
|
/* See linux-procfs.h. */
|
|
|
|
int
|
|
linux_proc_task_list_dir_exists (pid_t pid)
|
|
{
|
|
char pathname[128];
|
|
struct stat buf;
|
|
|
|
xsnprintf (pathname, sizeof (pathname), "/proc/%ld/task", (long) pid);
|
|
return (stat (pathname, &buf) == 0);
|
|
}
|