old-cross-binutils/gdb/testsuite/gdb.trace/qtro.exp
Pedro Alves 076855f9e3 Don't suppress errors inserting/removing hardware breakpoints in shared
libraries.

As explained in
https://sourceware.org/ml/gdb-patches/2008-08/msg00361.html, after a
shared library was unloaded, we can no longer insert or remove
breakpoints into/from its (no longer present) code segment.  That'll
fail with memory errors.  However, that concern does not apply to
hardware breakpoints.  By definition, hardware breakpoints are
implemented using a mechanism that is not dependent on being able to
modify the target's memory.  Usually, by setting up CPU debug
registers.  IOW, we should be able to set hw breakpoints in an
unmapped address.  We don't seem to have a test that exercises that,
so this patch adds one.

I noticed the error supression because of a related issue -- the
target_insert_hw_breakpoint/target_remove_hw_breakpoint interfaces
don't really distinguish "not supported" from "error" return, and so
remote.c returns -1 in both cases.  This results in hardware
breakpoints set in shared libraries silently ending up pending forever
even though the target doesn't actually support hw breakpoints.

 (gdb) set breakpoint always-inserted on
 (gdb) set remote Z-packet off
 (gdb) info breakpoints
 No breakpoints or watchpoints.
 (gdb) hbreak shrfunc
 Hardware assisted breakpoint 3 at 0x7ffff7dfb657: file ../../../src/gdb/testsuite/gdb.base/hbreak-in-shr-unsupported-shr.c, line 21.
 (gdb) info break
 Num     Type           Disp Enb Address            What
 3       hw breakpoint  keep y   <PENDING>          shrfunc

After the patch we get the expected:

 (gdb) hbreak shrfunc
 Hardware assisted breakpoint 3 at 0x7ffff7dfb657: file ../../../src/gdb/testsuite/gdb.base/hbreak-in-shr-unsupported-shr.c, line 21.
 Warning:
 Cannot insert hardware breakpoint 3.
 Could not insert hardware breakpoints:
 You may have requested too many hardware breakpoints/watchpoints.

 (gdb) info break
 Num     Type           Disp Enb Address            What
 3       hw breakpoint  keep y   0x00007ffff7dfb657 in shrfunc at ../../../src/gdb/testsuite/gdb.base/hbreak-in-shr-unsupported-shr.c:21

(HW breakpoints set in the main executable, when the target doesn't
support HW breakpoints always resulted in the latter output.)

We probably should improve the insert/remove interface to return a
different error code for unsupported.  But I chose to fix the error
supression first, as it's a deeper and wider issue.

Tested on x86_64 Fedora 17, native and gdbserver.

gdb/
2014-04-23  Pedro Alves  <palves@redhat.com>

	* breakpoint.c (insert_bp_location, remove_breakpoint_1): If
	the breakpoint is set in a shared library, only suppress
	errors for software breakpoints, not hardware breakpoints.

gdb/testsuite/
2014-04-23  Pedro Alves  <palves@redhat.com>

	* gdb.base/hbreak-in-shr-unsupported-shr.c: New file.
	* gdb.base/hbreak-in-shr-unsupported.c: New file.
	* gdb.base/hbreak-in-shr-unsupported.exp: New file.
	* gdb.base/hbreak-unmapped.c: New file.
	* gdb.base/hbreak-unmapped.exp: New file.
	* gdb.trace/qtro.exp (gdb_is_target_remote): Move ...
	* lib/gdb.exp (gdb_is_target_remote): ... here.
2014-04-23 15:06:47 +01:00

157 lines
4.5 KiB
Text

# Copyright 1998-2014 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This test helps making sure QTro support doesn't regress. If the
# stub supports the newer qXfer:traceframe-info:read, then the QTro
# paths in the stub are never exercised. PR remote/15455 is an
# example of a regression that unfortunately went unnoticed for long.
load_lib trace-support.exp
standard_testfile
if {[prepare_for_testing $testfile.exp $testfile $srcfile debug]} {
return -1
}
clean_restart $testfile
if ![runto_main] {
fail "Can't run to main to check for trace support"
return -1
}
# Check whether we're testing with the remote or extended-remote
# targets, and whether the target supports tracepoints.
if ![gdb_is_target_remote] {
return -1
}
if ![gdb_target_supports_trace] {
unsupported "Current target does not support trace"
return -1
}
# Run a trace session, stop it, and then inspect the resulting trace
# frame (IOW, returns while tfind mode is active).
proc prepare_for_trace_disassembly { } {
global gdb_prompt
gdb_breakpoint "end"
gdb_test "trace subr" "Tracepoint .*" \
"tracepoint at subr"
gdb_trace_setactions "define action" \
"" \
"collect parm" "^$"
gdb_test_no_output "tstart"
gdb_test "continue" ".*Breakpoint \[0-9\]+, end .*" \
"advance through tracing"
gdb_test "tstatus" ".*Collected 1 trace frame.*" \
"collected 1 trace frame"
gdb_test_no_output "tstop"
gdb_tfind_test "tfind start" "start" "0"
}
clean_restart $testfile
runto_main
# Trace once, issuing a tstatus, so that GDB tries
# qXfer:trace-frame-info:read.
prepare_for_trace_disassembly
# Now check whether the packet is supported.
set traceframe_info_supported -1
set test "probe for traceframe-info support"
gdb_test_multiple "show remote traceframe-info-packet" $test {
-re ".*Support for .* is auto-detected, currently (\[a-z\]*).*$gdb_prompt $" {
set status $expect_out(1,string)
if { $status == "enabled" } {
set traceframe_info_supported 1
} else {
set traceframe_info_supported 0
}
pass $test
}
}
if { $traceframe_info_supported == -1 } {
return -1
}
# Check whether we're testing with our own GDBserver.
set is_gdbserver -1
set test "probe for GDBserver"
gdb_test_multiple "monitor help" $test {
-re "The following monitor commands are supported.*debug-hw-points.*remote-debug.*GDBserver.*$gdb_prompt $" {
set is_gdbserver 1
pass $test
}
-re "$gdb_prompt $" {
set is_gdbserver 0
pass $test
}
}
if { $is_gdbserver == -1 } {
return -1
}
# Now disassemble (IOW, read from read-only memory) while inspecting a
# trace frame, twice. Once with qXfer:traceframe-info:read left to
# auto, and once with it disabled, exercising the QTro fallback path
# in the stub side.
foreach tfinfo { auto off } {
with_test_prefix "qXfer:traceframe-info:read $tfinfo" {
clean_restart $testfile
runto_main
gdb_test_no_output "set remote traceframe-info-packet $tfinfo"
prepare_for_trace_disassembly
set test "trace disassembly"
gdb_test_multiple "disassemble subr" $test {
-re "<(\.\[0-9\]+|)>:.*End of assembler dump.*$gdb_prompt $" {
pass $test
}
-re "Cannot access memory.*$gdb_prompt $" {
if { $traceframe_info_supported == 0 } {
# If qXfer:traceframe-info:read is not supported,
# then there should be QTro support.
fail $test
} elseif { $tfinfo == off && $is_gdbserver == 1 } {
# We we're testing with GDBserver, we know both
# qXfer:traceframe-info:read and QTro are
# supported (although supporting the former only
# would be sufficient), so issue a FAIL instead of
# UNSUPPORTED, giving us better visibility of QTro
# regressions.
fail $test
} else {
# Otherwise, qXfer:traceframe-info:read is
# supported, making QTro optional, so this isn't
# really a failure.
unsupported "$test (no QTro support)"
}
}
}
}
}