948f8e3d72
-Wpointer-sign catches all these cases across the codebase that should be using gdb_byte for raw target bytes. I think these are all obvious, hence I've collapsed into a single patch. gdb/ 2013-04-19 Pedro Alves <palves@redhat.com> * aarch64-tdep.c (aarch64_default_breakpoint): Change type to gdb_byte[]. (aarch64_breakpoint_from_pc): Change return type to gdb_byte *. * ada-lang.c (ada_value_assign): Use gdb_byte. * alphanbsd-tdep.c (sigtramp_retcode): Change type to gdb_byte[]. (alphanbsd_sigtramp_offset): Use gdb_byte. * arm-linux-tdep.c (arm_linux_arm_le_breakpoint) (arm_linux_arm_be_breakpoint, eabi_linux_arm_le_breakpoint) (eabi_linux_arm_be_breakpoint, arm_linux_thumb_be_breakpoint) (arm_linux_thumb_le_breakpoint, arm_linux_thumb2_be_breakpoint) (arm_linux_thumb2_le_breakpoint): Change type to gdb_byte[]. * arm-tdep.c (arm_stub_unwind_sniffer) (arm_displaced_init_closure): Use gdb_byte. (arm_default_arm_le_breakpoint, arm_default_arm_be_breakpoint) (arm_default_thumb_le_breakpoint) (arm_default_thumb_be_breakpoint): Change type to gdb_byte[]. * arm-tdep.h (struct gdbarch_tdep) <arm_breakpoint, thumb_breakpoint, thumb2_breakpoint>: Change type to gdb_byte *. * arm-wince-tdep.c (arm_wince_le_breakpoint) (arm_wince_thumb_le_breakpoint): Change type to gdb_byte[]. * armnbsd-tdep.c (arm_nbsd_arm_le_breakpoint) (arm_nbsd_arm_be_breakpoint, arm_nbsd_thumb_le_breakpoint) (arm_nbsd_thumb_be_breakpoint): Change type to gdb_byte[]. * armobsd-tdep.c (arm_obsd_thumb_le_breakpoint) (arm_obsd_thumb_be_breakpoint): Change type to gdb_byte[]. * cris-tdep.c (push_stack_item, cris_push_dummy_call) (cris_store_return_value, cris_extract_return_value): Use gdb_byte. (constraint): Change type of parameter to char * from signed char*. Use gdb_byte. * dwarf2loc.c (read_pieced_value, write_pieced_value): Change type of local buffer to gdb_byte *. * dwarf2read.c (read_index_from_section): Use gdb_byte. (create_dwp_hash_table): Change type of locals to gdb_byte *. (add_address_entry): Change type of local buffer to gdb_byte[]. * frv-tdep.c (frv_adjust_breakpoint_address, find_func_descr) (frv_push_dummy_call): Use gdb_byte. * hppa-hpux-tdep.c (hppa_hpux_push_dummy_code) (hppa_hpux_supply_ss_fpblock, hppa_hpux_supply_ss_wide) (hppa_hpux_supply_save_state): Use gdb_byte. * hppa-tdep.c (hppa32_push_dummy_call) (hppa64_convert_code_addr_to_fptr): Use gdb_byte. * ia64-tdep.c (extract_bit_field, replace_bit_field) (slotN_contents, replace_slotN_contents): Change type of parameter to gdb_byte *. (fetch_instruction, ia64_pseudo_register_write) (ia64_register_to_value, ia64_value_to_register) (ia64_extract_return_value, ia64_store_return_value) (ia64_push_dummy_call): Use gdb_byte. * m32c-tdep.c (m32c_return_value): Remove cast. * m68hc11-tdep.c (m68hc11_pseudo_register_write) (m68hc11_push_dummy_call, m68hc11_store_return_value): Use gdb_byte. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Use gdb_byte. * mn10300-tdep.c (mn10300_store_return_value) (mn10300_breakpoint_from_pc, mn10300_push_dummy_call): Use gdb_byte. * moxie-tdep.c (moxie_process_readu): Use gdb_byte. (moxie_process_record): Remove casts. * ppc-ravenscar-thread.c (supply_register_at_address) (ppc_ravenscar_generic_store_registers): Use gdb_byte. * ravenscar-thread.c (get_running_thread_id): Use gdb_byte. * remote-m32r-sdi.c (m32r_fetch_register): Use gdb_byte. * remote-mips.c (mips_xfer_memory): Use gdb_byte. * remote.c (compare_sections_command): Use gdb_byte. * score-tdep.c (score7_free_memblock): Change type of parameter to gdb_byte *. * sh-tdep.c (sh_justify_value_in_reg): Change return type to gdb_byte *. Use gdb_byte. (sh_push_dummy_call_fpu): Use gdb_byte. (sh_extract_return_value_nofpu, sh_extract_return_value_fpu) (sh_store_return_value_nofpu, sh_store_return_value_fpu) (sh_register_convert_to_virtual, sh_register_convert_to_raw): Change parameter type to 'gdb_byte *'. Use gdb_byte. (sh_pseudo_register_read, sh_pseudo_register_write): Use gdb_byte. * sh64-tdep.c (sh64_push_dummy_call): Use gdb_byte. (sh64_store_return_value, sh64_register_convert_to_virtual): Change parameter type to 'gdb_byte *'. Use gdb_byte. (sh64_pseudo_register_write): Use gdb_byte. * solib-darwin.c (darwin_current_sos): Add casts to 'gdb_byte *'. * solib-irix.c (fetch_lm_info): Likewise. Use gdb_byte for byte buffer. (irix_current_sos): Use gdb_byte. * solib-som.c (som_current_sos): Use gdb_byte. * sparc-ravenscar-thread.c (supply_register_at_address) (sparc_ravenscar_generic_store_registers): Use gdb_byte. * spu-multiarch.c (spu_xfer_partial): Add cast to 'char *'. * spu-tdep.c (spu_get_overlay_table): Use gdb_byte. * tic6x-tdep.c (tic6x_breakpoint_from_pc): Change return type to 'gdb_byte *'. * tic6x-tdep.h (struct gdbarch_tdep) <breakpoint>: Change type to 'gdb_byte *'. * tracepoint.c (tfile_fetch_registers): Use gdb_byte. * xstormy16-tdep.c (xstormy16_extract_return_value) (xstormy16_store_return_value): Change parameter type to 'gdb_byte *'. Adjust. (xstormy16_push_dummy_call): Use gdb_byte. * xtensa-tdep.c (xtensa_scan_prologue, call0_ret) (call0_analyze_prologue, execute_code): Use gdb_byte.
194 lines
6.3 KiB
C
194 lines
6.3 KiB
C
/* Ravenscar SPARC target support.
|
|
|
|
Copyright (C) 2004-2013 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "gdbcore.h"
|
|
#include "regcache.h"
|
|
#include "sparc-tdep.h"
|
|
#include "inferior.h"
|
|
#include "ravenscar-thread.h"
|
|
#include "sparc-ravenscar-thread.h"
|
|
|
|
static void sparc_ravenscar_fetch_registers (struct regcache *regcache,
|
|
int regnum);
|
|
static void sparc_ravenscar_store_registers (struct regcache *regcache,
|
|
int regnum);
|
|
static void sparc_ravenscar_prepare_to_store (struct regcache *regcache);
|
|
|
|
/* Register offsets from a referenced address (exempli gratia the
|
|
Thread_Descriptor). The referenced address depends on the register
|
|
number. The Thread_Descriptor layout and the stack layout are documented
|
|
in the GNAT sources, in sparc-bb.h. */
|
|
|
|
static const int sparc_register_offsets[] =
|
|
{
|
|
/* G0 - G7 */
|
|
-1, 0x24, 0x28, 0x2C, 0x30, 0x34, 0x38, 0x3C,
|
|
/* O0 - O7 */
|
|
0x00, 0x04, 0x08, 0x0C, 0x10, 0x14, 0x18, 0x1C,
|
|
/* L0 - L7 */
|
|
0x00, 0x04, 0x08, 0x0C, 0x10, 0x14, 0x18, 0x1C,
|
|
/* I0 - I7 */
|
|
0x20, 0x24, 0x28, 0x2C, 0x30, 0x34, 0x38, 0x3C,
|
|
/* F0 - F31 */
|
|
0x50, 0x54, 0x58, 0x5C, 0x60, 0x64, 0x68, 0x6C,
|
|
0x70, 0x74, 0x78, 0x7C, 0x80, 0x84, 0x88, 0x8C,
|
|
0x90, 0x94, 0x99, 0x9C, 0xA0, 0xA4, 0xA8, 0xAC,
|
|
0xB0, 0xB4, 0xBB, 0xBC, 0xC0, 0xC4, 0xC8, 0xCC,
|
|
/* Y PSR WIM TBR PC NPC FPSR CPSR */
|
|
0x40, 0x20, 0x44, -1, 0x1C, -1, 0x4C, -1
|
|
};
|
|
|
|
/* supply register REGNUM, which has been saved on REGISTER_ADDR, to the
|
|
regcache. */
|
|
|
|
static void
|
|
supply_register_at_address (struct regcache *regcache, int regnum,
|
|
CORE_ADDR register_addr)
|
|
{
|
|
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
|
int buf_size = register_size (gdbarch, regnum);
|
|
gdb_byte *buf;
|
|
|
|
buf = alloca (buf_size);
|
|
read_memory (register_addr, buf, buf_size);
|
|
regcache_raw_supply (regcache, regnum, buf);
|
|
}
|
|
|
|
/* Return true if, for a non-running thread, REGNUM has been saved on the
|
|
stack. */
|
|
|
|
static int
|
|
register_on_stack_p (int regnum)
|
|
{
|
|
return (regnum >= SPARC_L0_REGNUM && regnum <= SPARC_L7_REGNUM)
|
|
|| (regnum >= SPARC_I0_REGNUM && regnum <= SPARC_I7_REGNUM);
|
|
}
|
|
|
|
/* Return true if, for a non-running thread, REGNUM has been saved on the
|
|
Thread_Descriptor. */
|
|
|
|
static int
|
|
register_in_thread_descriptor_p (int regnum)
|
|
{
|
|
return (regnum >= SPARC_O0_REGNUM && regnum <= SPARC_O7_REGNUM)
|
|
|| (regnum == SPARC32_PSR_REGNUM)
|
|
|| (regnum >= SPARC_G1_REGNUM && regnum <= SPARC_G7_REGNUM)
|
|
|| (regnum == SPARC32_Y_REGNUM)
|
|
|| (regnum == SPARC32_WIM_REGNUM)
|
|
|| (regnum == SPARC32_FSR_REGNUM)
|
|
|| (regnum >= SPARC_F0_REGNUM && regnum <= SPARC_F0_REGNUM + 31)
|
|
|| (regnum == SPARC32_PC_REGNUM);
|
|
}
|
|
|
|
/* to_fetch_registers when inferior_ptid is different from the running
|
|
thread. */
|
|
|
|
static void
|
|
sparc_ravenscar_fetch_registers (struct regcache *regcache, int regnum)
|
|
{
|
|
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
|
const int sp_regnum = gdbarch_sp_regnum (gdbarch);
|
|
const int num_regs = gdbarch_num_regs (gdbarch);
|
|
int current_regnum;
|
|
CORE_ADDR current_address;
|
|
CORE_ADDR thread_descriptor_address;
|
|
ULONGEST stack_address;
|
|
|
|
/* The tid is the thread_id field, which is a pointer to the thread. */
|
|
thread_descriptor_address = (CORE_ADDR) ptid_get_tid (inferior_ptid);
|
|
|
|
/* Read the saved SP in the context buffer. */
|
|
current_address = thread_descriptor_address
|
|
+ sparc_register_offsets [sp_regnum];
|
|
supply_register_at_address (regcache, sp_regnum, current_address);
|
|
regcache_cooked_read_unsigned (regcache, sp_regnum, &stack_address);
|
|
|
|
/* Read registers. */
|
|
for (current_regnum = 0; current_regnum < num_regs; current_regnum ++)
|
|
{
|
|
if (register_in_thread_descriptor_p (current_regnum))
|
|
{
|
|
current_address = thread_descriptor_address
|
|
+ sparc_register_offsets [current_regnum];
|
|
supply_register_at_address (regcache, current_regnum,
|
|
current_address);
|
|
}
|
|
else if (register_on_stack_p (current_regnum))
|
|
{
|
|
current_address = stack_address
|
|
+ sparc_register_offsets [current_regnum];
|
|
supply_register_at_address (regcache, current_regnum,
|
|
current_address);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* to_prepare_to_store when inferior_ptid is different from the running
|
|
thread. */
|
|
|
|
static void
|
|
sparc_ravenscar_prepare_to_store (struct regcache *regcache)
|
|
{
|
|
/* Nothing to do. */
|
|
}
|
|
|
|
/* to_store_registers when inferior_ptid is different from the running
|
|
thread. */
|
|
|
|
static void
|
|
sparc_ravenscar_store_registers (struct regcache *regcache, int regnum)
|
|
{
|
|
struct gdbarch *gdbarch = get_regcache_arch (regcache);
|
|
int buf_size = register_size (gdbarch, regnum);
|
|
gdb_byte buf[buf_size];
|
|
ULONGEST register_address;
|
|
|
|
if (register_in_thread_descriptor_p (regnum))
|
|
register_address =
|
|
ptid_get_tid (inferior_ptid) + sparc_register_offsets [regnum];
|
|
else if (register_on_stack_p (regnum))
|
|
{
|
|
regcache_cooked_read_unsigned (regcache, SPARC_SP_REGNUM,
|
|
®ister_address);
|
|
register_address += sparc_register_offsets [regnum];
|
|
}
|
|
else
|
|
return;
|
|
|
|
regcache_raw_collect (regcache, regnum, buf);
|
|
write_memory (register_address,
|
|
buf,
|
|
buf_size);
|
|
}
|
|
|
|
static struct ravenscar_arch_ops sparc_ravenscar_ops =
|
|
{
|
|
sparc_ravenscar_fetch_registers,
|
|
sparc_ravenscar_store_registers,
|
|
sparc_ravenscar_prepare_to_store
|
|
};
|
|
|
|
/* Register ravenscar_arch_ops in GDBARCH. */
|
|
|
|
void
|
|
register_sparc_ravenscar_ops (struct gdbarch *gdbarch)
|
|
{
|
|
set_gdbarch_ravenscar_ops (gdbarch, &sparc_ravenscar_ops);
|
|
}
|