old-cross-binutils/gdb/testsuite/gdb.linespec/ls-errs.exp
Gary Benson ef0b411a11 Add max-completions parameter, and implement tab-completion limiting.
This commit adds a new exception, MAX_COMPLETIONS_REACHED_ERROR, to be
thrown whenever the completer has generated too many candidates to
be useful.  A new user-settable variable, "max_completions", is added
to control this behaviour.  A top-level completion limit is added to
complete_line_internal, as the final check to ensure the user never
sees too many completions.  An additional limit is added to
default_make_symbol_completion_list_break_on, to halt time-consuming
symbol table expansions.

gdb/ChangeLog:

	PR cli/9007
	PR cli/11920
	PR cli/15548
	* cli/cli-cmds.c (complete_command): Notify user if max-completions
	reached.
	* common/common-exceptions.h (enum errors)
	<MAX_COMPLETIONS_REACHED_ERROR>: New value.
	* completer.h (get_max_completions_reached_message): New declaration.
	(max_completions): Likewise.
	(completion_tracker_t): New typedef.
	(new_completion_tracker): New declaration.
	(make_cleanup_free_completion_tracker): Likewise.
	(maybe_add_completion_enum): New enum.
	(maybe_add_completion): New declaration.
	(throw_max_completions_reached_error): Likewise.
	* completer.c (max_completions): New global variable.
	(new_completion_tracker): New function.
	(free_completion_tracker): Likewise.
	(make_cleanup_free_completion_tracker): Likewise.
	(maybe_add_completions): Likewise.
	(throw_max_completions_reached_error): Likewise.
	(complete_line): Remove duplicates and limit result to max_completions
	entries.
	(get_max_completions_reached_message): New function.
	(gdb_display_match_list): Handle max_completions.
	(_initialize_completer): New declaration and function.
	* symtab.c: Include completer.h.
	(completion_tracker): New static variable.
	(completion_list_add_name): Call maybe_add_completion.
	(default_make_symbol_completion_list_break_on_1): Renamed from
	default_make_symbol_completion_list_break_on.  Maintain
	completion_tracker across calls to completion_list_add_name.
	(default_make_symbol_completion_list_break_on): New function.
	* top.c (init_main): Set rl_completion_display_matches_hook.
	* tui/tui-io.c: Include completer.h.
	(tui_old_rl_display_matches_hook): New static global.
	(tui_rl_display_match_list): Notify user if max-completions reached.
	(tui_setup_io): Save/restore rl_completion_display_matches_hook.
	* NEWS (New Options): Mention set/show max-completions.

gdb/doc/ChangeLog:

	* gdb.texinfo (Command Completion): Document new
	"set/show max-completions" option.

gdb/testsuite/ChangeLog:

	* gdb.base/completion.exp: Disable completion limiting for
	existing tests.  Add new tests to check completion limiting.
	* gdb.linespec/ls-errs.exp: Disable completion limiting.
2015-01-31 15:07:22 -08:00

180 lines
6.1 KiB
Text

# Copyright 2012-2015 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Tests for linespec error conditions
standard_testfile
set exefile $testfile
if {[prepare_for_testing $testfile $exefile $srcfile \
{debug nowarnings}]} {
return -1
}
# Turn off the pending breakpoint queries.
gdb_test_no_output "set breakpoint pending off"
# Turn off completion limiting
gdb_test_no_output "set max-completions unlimited"
# We intentionally do not use gdb_breakpoint for these tests.
# Break at 'linespec' and expect the message in ::error_messages indexed by
# msg_id with the associated args.
proc test_break {linespec msg_id args} {
global error_messages
gdb_test "break $linespec" [string_to_regexp \
[eval format \$error_messages($msg_id) $args]]
}
# Common error message format strings.
array set error_messages {
invalid_file "No source file named %s."
invalid_function "Function \"%s\" not defined."
invalid_var_or_func "Undefined convenience variable or function \"%s\" not defined."
invalid_function_f "Function \"%s\" not defined in \"%s\"."
invalid_var_or_func_f \
"Undefined convenience variable or function \"%s\" not defined in \"%s\"."
invalid_label "No label \"%s\" defined in function \"%s\"."
invalid_offset "No line %d in the current file."
invalid_offset_f "No line %d in file \"%s\"."
unexpected "malformed linespec error: unexpected %s"
unexpected_opt "malformed linespec error: unexpected %s, \"%s\""
unmatched_quote "unmatched quote"
}
# Some commonly used whitespace tests around ':'.
set spaces [list ":" ": " " :" " : " "\t: " " :\t" "\t:\t" " \t:\t " \
"\t \t:\t \t \t"]
# A list of invalid offsets.
set invalid_offsets [list -100 +500 1000]
# Try some simple, invalid linespecs involving spaces.
foreach x $spaces {
test_break $x unexpected "colon"
}
# Test invalid filespecs starting with offset. This is done
# first so that default offsets are tested.
foreach x $invalid_offsets {
set offset $x
# Relative offsets are relative to line 16. Adjust
# expected offset from error message accordingly.
if {[string index $x 0] == "+" ||
[string index $x 0] == "-"} {
incr offset 16
}
test_break $x invalid_offset $offset
}
# Test offsets with trailing tokens w/ and w/o spaces.
foreach x $spaces {
test_break "3$x" unexpected "colon"
test_break "+10$x" unexpected "colon"
test_break "-10$x" unexpected "colon"
}
foreach x {1 +1 +100 -10} {
test_break "3 $x" unexpected_opt "number" $x
test_break "+10 $x" unexpected_opt "number" $x
test_break "-10 $x" unexpected_opt "number" $x
}
test_break "3 foo" unexpected_opt "string" "foo"
test_break "+10 foo" unexpected_opt "string" "foo"
test_break "-10 foo" unexpected_opt "string" "foo"
# Test invalid linespecs starting with filename.
foreach x [list "this_file_doesn't_exist.c" \
"this file has spaces.c" \
"\"file::colons.c\"" \
"'file::colons.c'" \
"\"this \"file\" has quotes.c\"" \
"'this \"file\" has quotes.c'" \
"'this 'file' has quotes.c'" \
"\"this 'file' has quotes.c\"" \
"\"spaces: and :colons.c\"" \
"'more: :spaces: :and colons::.c'"] {
# Remove any quoting from FILENAME for the error message.
test_break "$x:3" invalid_file [string trim $x \"']
}
# Test unmatched quotes.
foreach x {"\"src-file.c'" "'src-file.c"} {
test_break "$x:3" unmatched_quote
}
test_break $srcfile invalid_function $srcfile
foreach x {"foo" " foo" " foo "} {
# Trim any leading/trailing whitespace for error messages.
test_break "$srcfile:$x" invalid_function_f [string trim $x] $srcfile
test_break "$srcfile:main:$x" invalid_label [string trim $x] "main"
}
foreach x $spaces {
test_break "$srcfile$x" unexpected "end of input"
test_break "$srcfile:main$x" unexpected "end of input"
}
test_break "${srcfile}::" invalid_function "${srcfile}::"
test_break "$srcfile:3 1" unexpected_opt "number" "1"
test_break "$srcfile:3 +100" unexpected_opt "number" "+100"
test_break "$srcfile:3 -100" unexpected_opt "number" "-100"
test_break "$srcfile:3 foo" unexpected_opt "string" "foo"
foreach x $invalid_offsets {
test_break "$srcfile:$x" invalid_offset_f $x $srcfile
test_break "\"$srcfile:$x\"" invalid_offset_f $x $srcfile
test_break "'$srcfile:$x'" invalid_offset_f $x $srcfile
}
# Test invalid filespecs starting with function.
foreach x {"foobar" "foo::bar" "foo.bar" "foo ." "foo bar" "foo 1" \
"foo 0" "foo +10" "foo -10" "foo +100" "foo -100"} {
test_break $x invalid_function $x
}
foreach x $spaces {
test_break "main${x}there" invalid_label "there" "main"
if {[test_compiler_info {clang-*-*}]} { setup_xfail clang/14500 *-*-* }
test_break "main:here${x}" unexpected "end of input"
}
test_break "main 3" invalid_function "main 3"
test_break "main +100" invalid_function "main +100"
test_break "main -100" invalid_function "main -100"
test_break "main foo" invalid_function "main foo"
foreach x {"3" "+100" "-100" "foo"} {
test_break "main:here $x" invalid_label "here $x" "main"
}
foreach x {"if" "task" "thread"} {
test_break $x invalid_function $x
}
test_break "'main.c'flubber" unexpected_opt "string" "flubber"
test_break "'main.c',21" invalid_function "main.c"
test_break "'main.c' " invalid_function "main.c"
test_break "'main.c'3" unexpected_opt "number" "3"
test_break "'main.c'+3" unexpected_opt "number" "+3"
# Test undefined convenience variables.
set x {$zippo}
test_break $x invalid_var_or_func $x
test_break "$srcfile:$x" invalid_var_or_func_f $x $srcfile