old-cross-binutils/gdb/testsuite/gdb.threads/attach-many-short-lived-threads.exp
Pedro Alves e584fdbc6a Improve gdb.threads/attach-many-short-lived-threads.exp timeout handling
The buildbot shows that this test is still racy, and occasionally
fails with time outs on some machines.  I'd like to get major issues
with load out of the way.

The test currently exits after 180s, which is just a random number,
that has no relation to what the .exp file considers a time out.  This
commit makes the program wait a bit longer than what the .exp file
considers a time out, and, resets the timer for each iteration.

Tested on x86_64 Fedora 20, native and extended-remote gdbserver.

gdb/testsuite/
2015-02-06  Pedro Alves  <palves@redhat.com>

	* gdb.threads/attach-many-short-lived-threads.c (SECONDS): New
	macro.
	(seconds_left, again): New globals.
	(main): Wait seconds_left in a 1-second sleep loop instead of
	sleeping 180 seconds.  If 'again' is set, reset the seconds
	counter.
	* gdb.threads/attach-many-short-lived-threads.exp (test): Set
	'again' in the inferior before detaching.  Print the seconds left.
	(options): New global.
	(top level): Build program with	-DTIMEOUT=$timeout.
2015-02-06 13:24:32 +01:00

143 lines
4.4 KiB
Text

# Copyright 2008-2015 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test attaching to a program that is constantly spawning short-lived
# threads. The stresses the edge cases of attaching to threads that
# have just been created or are in process of dying. In addition, the
# test attaches, debugs, detaches, reattaches in a loop a few times,
# to stress the behavior of the debug API around detach (some systems
# end up leaving stale state behind that confuse the following
# attach).
if {![can_spawn_for_attach]} {
return 0
}
standard_testfile
# The test proper. See description above.
proc test {} {
global binfile
global gdb_prompt
global decimal
clean_restart ${binfile}
set testpid [spawn_wait_for_attach $binfile]
set attempts 10
for {set attempt 1} { $attempt <= $attempts } { incr attempt } {
with_test_prefix "iter $attempt" {
set attached 0
set eperm 0
set test "attach"
gdb_test_multiple "attach $testpid" $test {
-re "new threads in iteration" {
# Seen when "set debug libthread_db" is on.
exp_continue
}
-re "warning: Cannot attach to lwp $decimal: Operation not permitted" {
# On Linux, PTRACE_ATTACH sometimes fails with
# EPERM, even though /proc/PID/status indicates
# the thread is running.
set eperm 1
exp_continue
}
-re "debugger service failed.*$gdb_prompt $" {
fail $test
}
-re "$gdb_prompt $" {
if {$eperm} {
xfail "$test (EPERM)"
} else {
pass $test
}
}
-re "Attaching to program.*process $testpid.*$gdb_prompt $" {
pass $test
}
}
# Sleep a bit and try updating the thread list. We should
# know about all threads already at this point. If we see
# "New Thread" or similar being output, then "attach" is
# failing to actually attach to all threads in the process,
# which would be a bug.
sleep 1
set test "no new threads"
gdb_test_multiple "info threads" $test {
-re "New .*$gdb_prompt $" {
fail $test
}
-re "$gdb_prompt $" {
pass $test
}
}
# Force breakpoints always inserted, so that threads we might
# have failed to attach to hit them even when threads we do
# know about are stopped.
gdb_test_no_output "set breakpoint always-inserted on"
# Run to a breakpoint a few times. A few threads should spawn
# and die meanwhile. This checks that thread creation/death
# events carry on correctly after attaching. Also, be
# detaching from the program and reattaching, we check that
# the program doesn't die due to gdb leaving a pending
# breakpoint hit on a new thread unprocessed.
gdb_test "break break_fn" "Breakpoint.*" "break break_fn"
# Wait a bit, to give time for most threads to hit the
# breakpoint, including threads we might have failed to
# attach.
sleep 2
set bps 3
for {set bp 1} { $bp <= $bps } { incr bp } {
gdb_test "continue" "Breakpoint.*" "break at break_fn: $bp"
}
if {$attempt < $attempts} {
# Kick the time out timer for another round.
gdb_test "print again = 1" " = 1" "reset timer in the inferior"
# Show the time we had left in the logs, in case
# something goes wrong.
gdb_test "print seconds_left" " = .*"
gdb_test "detach" "Detaching from.*"
} else {
gdb_test "kill" "" "kill process" "Kill the program being debugged.*y or n. $" "y"
}
gdb_test_no_output "set breakpoint always-inserted off"
delete_breakpoints
}
}
remote_exec target "kill -9 ${testpid}"
}
# The test program exits after a while, in case GDB crashes. Make it
# wait at least as long as we may wait before declaring a time out
# failure.
set options { "additional_flags=-DTIMEOUT=$timeout" debug pthreads }
if {[prepare_for_testing "failed to prepare" $testfile $srcfile $options] == -1} {
return -1
}
test