9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
849 lines
28 KiB
C
849 lines
28 KiB
C
/* Load module for 'compile' command.
|
|
|
|
Copyright (C) 2014-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "compile-object-load.h"
|
|
#include "compile-internal.h"
|
|
#include "command.h"
|
|
#include "objfiles.h"
|
|
#include "gdbcore.h"
|
|
#include "readline/tilde.h"
|
|
#include "bfdlink.h"
|
|
#include "gdbcmd.h"
|
|
#include "regcache.h"
|
|
#include "inferior.h"
|
|
#include "compile.h"
|
|
#include "block.h"
|
|
#include "arch-utils.h"
|
|
|
|
/* Track inferior memory reserved by inferior mmap. */
|
|
|
|
struct munmap_list
|
|
{
|
|
struct munmap_list *next;
|
|
CORE_ADDR addr, size;
|
|
};
|
|
|
|
/* Add inferior mmap memory range ADDR..ADDR+SIZE (exclusive) to list
|
|
HEADP. *HEADP needs to be initialized to NULL. */
|
|
|
|
static void
|
|
munmap_list_add (struct munmap_list **headp, CORE_ADDR addr, CORE_ADDR size)
|
|
{
|
|
struct munmap_list *head_new = XNEW (struct munmap_list);
|
|
|
|
head_new->next = *headp;
|
|
*headp = head_new;
|
|
head_new->addr = addr;
|
|
head_new->size = size;
|
|
}
|
|
|
|
/* Free list of inferior mmap memory ranges HEAD. HEAD is the first
|
|
element of the list, it can be NULL. After calling this function
|
|
HEAD pointer is invalid and the possible list needs to be
|
|
reinitialized by caller to NULL. */
|
|
|
|
void
|
|
munmap_list_free (struct munmap_list *head)
|
|
{
|
|
while (head)
|
|
{
|
|
struct munmap_list *todo = head;
|
|
|
|
head = todo->next;
|
|
gdbarch_infcall_munmap (target_gdbarch (), todo->addr, todo->size);
|
|
xfree (todo);
|
|
}
|
|
}
|
|
|
|
/* Stub for munmap_list_free suitable for make_cleanup. Contrary to
|
|
munmap_list_free this function's parameter is a pointer to the first
|
|
list element pointer. */
|
|
|
|
static void
|
|
munmap_listp_free_cleanup (void *headp_voidp)
|
|
{
|
|
struct munmap_list **headp = (struct munmap_list **) headp_voidp;
|
|
|
|
munmap_list_free (*headp);
|
|
}
|
|
|
|
/* Helper data for setup_sections. */
|
|
|
|
struct setup_sections_data
|
|
{
|
|
/* Size of all recent sections with matching LAST_PROT. */
|
|
CORE_ADDR last_size;
|
|
|
|
/* First section matching LAST_PROT. */
|
|
asection *last_section_first;
|
|
|
|
/* Memory protection like the prot parameter of gdbarch_infcall_mmap. */
|
|
unsigned last_prot;
|
|
|
|
/* Maximum of alignments of all sections matching LAST_PROT.
|
|
This value is always at least 1. This value is always a power of 2. */
|
|
CORE_ADDR last_max_alignment;
|
|
|
|
/* List of inferior mmap ranges where setup_sections should add its
|
|
next range. */
|
|
struct munmap_list **munmap_list_headp;
|
|
};
|
|
|
|
/* Place all ABFD sections next to each other obeying all constraints. */
|
|
|
|
static void
|
|
setup_sections (bfd *abfd, asection *sect, void *data_voidp)
|
|
{
|
|
struct setup_sections_data *data = (struct setup_sections_data *) data_voidp;
|
|
CORE_ADDR alignment;
|
|
unsigned prot;
|
|
|
|
if (sect != NULL)
|
|
{
|
|
/* It is required by later bfd_get_relocated_section_contents. */
|
|
if (sect->output_section == NULL)
|
|
sect->output_section = sect;
|
|
|
|
if ((bfd_get_section_flags (abfd, sect) & SEC_ALLOC) == 0)
|
|
return;
|
|
|
|
/* Make the memory always readable. */
|
|
prot = GDB_MMAP_PROT_READ;
|
|
if ((bfd_get_section_flags (abfd, sect) & SEC_READONLY) == 0)
|
|
prot |= GDB_MMAP_PROT_WRITE;
|
|
if ((bfd_get_section_flags (abfd, sect) & SEC_CODE) != 0)
|
|
prot |= GDB_MMAP_PROT_EXEC;
|
|
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"module \"%s\" section \"%s\" size %s prot %u\n",
|
|
bfd_get_filename (abfd),
|
|
bfd_get_section_name (abfd, sect),
|
|
paddress (target_gdbarch (),
|
|
bfd_get_section_size (sect)),
|
|
prot);
|
|
}
|
|
else
|
|
prot = -1;
|
|
|
|
if (sect == NULL
|
|
|| (data->last_prot != prot && bfd_get_section_size (sect) != 0))
|
|
{
|
|
CORE_ADDR addr;
|
|
asection *sect_iter;
|
|
|
|
if (data->last_size != 0)
|
|
{
|
|
addr = gdbarch_infcall_mmap (target_gdbarch (), data->last_size,
|
|
data->last_prot);
|
|
munmap_list_add (data->munmap_list_headp, addr, data->last_size);
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"allocated %s bytes at %s prot %u\n",
|
|
paddress (target_gdbarch (), data->last_size),
|
|
paddress (target_gdbarch (), addr),
|
|
data->last_prot);
|
|
}
|
|
else
|
|
addr = 0;
|
|
|
|
if ((addr & (data->last_max_alignment - 1)) != 0)
|
|
error (_("Inferior compiled module address %s "
|
|
"is not aligned to BFD required %s."),
|
|
paddress (target_gdbarch (), addr),
|
|
paddress (target_gdbarch (), data->last_max_alignment));
|
|
|
|
for (sect_iter = data->last_section_first; sect_iter != sect;
|
|
sect_iter = sect_iter->next)
|
|
if ((bfd_get_section_flags (abfd, sect_iter) & SEC_ALLOC) != 0)
|
|
bfd_set_section_vma (abfd, sect_iter,
|
|
addr + bfd_get_section_vma (abfd, sect_iter));
|
|
|
|
data->last_size = 0;
|
|
data->last_section_first = sect;
|
|
data->last_prot = prot;
|
|
data->last_max_alignment = 1;
|
|
}
|
|
|
|
if (sect == NULL)
|
|
return;
|
|
|
|
alignment = ((CORE_ADDR) 1) << bfd_get_section_alignment (abfd, sect);
|
|
data->last_max_alignment = max (data->last_max_alignment, alignment);
|
|
|
|
data->last_size = (data->last_size + alignment - 1) & -alignment;
|
|
|
|
bfd_set_section_vma (abfd, sect, data->last_size);
|
|
|
|
data->last_size += bfd_get_section_size (sect);
|
|
data->last_size = (data->last_size + alignment - 1) & -alignment;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_multiple_definition (struct bfd_link_info *link_info,
|
|
struct bfd_link_hash_entry *h, bfd *nbfd,
|
|
asection *nsec, bfd_vma nval)
|
|
{
|
|
bfd *abfd = link_info->input_bfds;
|
|
|
|
if (link_info->allow_multiple_definition)
|
|
return TRUE;
|
|
warning (_("Compiled module \"%s\": multiple symbol definitions: %s"),
|
|
bfd_get_filename (abfd), h->root.string);
|
|
return FALSE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_warning (struct bfd_link_info *link_info, const char *xwarning,
|
|
const char *symbol, bfd *abfd, asection *section,
|
|
bfd_vma address)
|
|
{
|
|
warning (_("Compiled module \"%s\" section \"%s\": warning: %s"),
|
|
bfd_get_filename (abfd), bfd_get_section_name (abfd, section),
|
|
xwarning);
|
|
/* Maybe permit running as a module? */
|
|
return FALSE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_undefined_symbol (struct bfd_link_info *link_info,
|
|
const char *name, bfd *abfd, asection *section,
|
|
bfd_vma address, bfd_boolean is_fatal)
|
|
{
|
|
warning (_("Cannot resolve relocation to \"%s\" "
|
|
"from compiled module \"%s\" section \"%s\"."),
|
|
name, bfd_get_filename (abfd), bfd_get_section_name (abfd, section));
|
|
return FALSE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_reloc_overflow (struct bfd_link_info *link_info,
|
|
struct bfd_link_hash_entry *entry,
|
|
const char *name, const char *reloc_name,
|
|
bfd_vma addend, bfd *abfd, asection *section,
|
|
bfd_vma address)
|
|
{
|
|
/* TRUE is required for intra-module relocations. */
|
|
return TRUE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_reloc_dangerous (struct bfd_link_info *link_info,
|
|
const char *message, bfd *abfd,
|
|
asection *section, bfd_vma address)
|
|
{
|
|
warning (_("Compiled module \"%s\" section \"%s\": dangerous "
|
|
"relocation: %s\n"),
|
|
bfd_get_filename (abfd), bfd_get_section_name (abfd, section),
|
|
message);
|
|
return FALSE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static bfd_boolean
|
|
link_callbacks_unattached_reloc (struct bfd_link_info *link_info,
|
|
const char *name, bfd *abfd, asection *section,
|
|
bfd_vma address)
|
|
{
|
|
warning (_("Compiled module \"%s\" section \"%s\": unattached "
|
|
"relocation: %s\n"),
|
|
bfd_get_filename (abfd), bfd_get_section_name (abfd, section),
|
|
name);
|
|
return FALSE;
|
|
}
|
|
|
|
/* Helper for link_callbacks callbacks vector. */
|
|
|
|
static void link_callbacks_einfo (const char *fmt, ...)
|
|
ATTRIBUTE_PRINTF (1, 2);
|
|
|
|
static void
|
|
link_callbacks_einfo (const char *fmt, ...)
|
|
{
|
|
struct cleanup *cleanups;
|
|
va_list ap;
|
|
char *str;
|
|
|
|
va_start (ap, fmt);
|
|
str = xstrvprintf (fmt, ap);
|
|
va_end (ap);
|
|
cleanups = make_cleanup (xfree, str);
|
|
|
|
warning (_("Compile module: warning: %s"), str);
|
|
|
|
do_cleanups (cleanups);
|
|
}
|
|
|
|
/* Helper for bfd_get_relocated_section_contents.
|
|
Only these symbols are set by bfd_simple_get_relocated_section_contents
|
|
but bfd/ seems to use even the NULL ones without checking them first. */
|
|
|
|
static const struct bfd_link_callbacks link_callbacks =
|
|
{
|
|
NULL, /* add_archive_element */
|
|
link_callbacks_multiple_definition, /* multiple_definition */
|
|
NULL, /* multiple_common */
|
|
NULL, /* add_to_set */
|
|
NULL, /* constructor */
|
|
link_callbacks_warning, /* warning */
|
|
link_callbacks_undefined_symbol, /* undefined_symbol */
|
|
link_callbacks_reloc_overflow, /* reloc_overflow */
|
|
link_callbacks_reloc_dangerous, /* reloc_dangerous */
|
|
link_callbacks_unattached_reloc, /* unattached_reloc */
|
|
NULL, /* notice */
|
|
link_callbacks_einfo, /* einfo */
|
|
NULL, /* info */
|
|
NULL, /* minfo */
|
|
NULL, /* override_segment_assignment */
|
|
};
|
|
|
|
struct link_hash_table_cleanup_data
|
|
{
|
|
bfd *abfd;
|
|
bfd *link_next;
|
|
};
|
|
|
|
/* Cleanup callback for struct bfd_link_info. */
|
|
|
|
static void
|
|
link_hash_table_free (void *d)
|
|
{
|
|
struct link_hash_table_cleanup_data *data
|
|
= (struct link_hash_table_cleanup_data *) d;
|
|
|
|
if (data->abfd->is_linker_output)
|
|
(*data->abfd->link.hash->hash_table_free) (data->abfd);
|
|
data->abfd->link.next = data->link_next;
|
|
}
|
|
|
|
/* Relocate and store into inferior memory each section SECT of ABFD. */
|
|
|
|
static void
|
|
copy_sections (bfd *abfd, asection *sect, void *data)
|
|
{
|
|
asymbol **symbol_table = (asymbol **) data;
|
|
bfd_byte *sect_data, *sect_data_got;
|
|
struct cleanup *cleanups;
|
|
struct bfd_link_info link_info;
|
|
struct bfd_link_order link_order;
|
|
CORE_ADDR inferior_addr;
|
|
struct link_hash_table_cleanup_data cleanup_data;
|
|
|
|
if ((bfd_get_section_flags (abfd, sect) & (SEC_ALLOC | SEC_LOAD))
|
|
!= (SEC_ALLOC | SEC_LOAD))
|
|
return;
|
|
|
|
if (bfd_get_section_size (sect) == 0)
|
|
return;
|
|
|
|
/* Mostly a copy of bfd_simple_get_relocated_section_contents which GDB
|
|
cannot use as it does not report relocations to undefined symbols. */
|
|
memset (&link_info, 0, sizeof (link_info));
|
|
link_info.output_bfd = abfd;
|
|
link_info.input_bfds = abfd;
|
|
link_info.input_bfds_tail = &abfd->link.next;
|
|
|
|
cleanup_data.abfd = abfd;
|
|
cleanup_data.link_next = abfd->link.next;
|
|
|
|
abfd->link.next = NULL;
|
|
link_info.hash = bfd_link_hash_table_create (abfd);
|
|
|
|
cleanups = make_cleanup (link_hash_table_free, &cleanup_data);
|
|
link_info.callbacks = &link_callbacks;
|
|
|
|
memset (&link_order, 0, sizeof (link_order));
|
|
link_order.next = NULL;
|
|
link_order.type = bfd_indirect_link_order;
|
|
link_order.offset = 0;
|
|
link_order.size = bfd_get_section_size (sect);
|
|
link_order.u.indirect.section = sect;
|
|
|
|
sect_data = (bfd_byte *) xmalloc (bfd_get_section_size (sect));
|
|
make_cleanup (xfree, sect_data);
|
|
|
|
sect_data_got = bfd_get_relocated_section_contents (abfd, &link_info,
|
|
&link_order, sect_data,
|
|
FALSE, symbol_table);
|
|
|
|
if (sect_data_got == NULL)
|
|
error (_("Cannot map compiled module \"%s\" section \"%s\": %s"),
|
|
bfd_get_filename (abfd), bfd_get_section_name (abfd, sect),
|
|
bfd_errmsg (bfd_get_error ()));
|
|
gdb_assert (sect_data_got == sect_data);
|
|
|
|
inferior_addr = bfd_get_section_vma (abfd, sect);
|
|
if (0 != target_write_memory (inferior_addr, sect_data,
|
|
bfd_get_section_size (sect)))
|
|
error (_("Cannot write compiled module \"%s\" section \"%s\" "
|
|
"to inferior memory range %s-%s."),
|
|
bfd_get_filename (abfd), bfd_get_section_name (abfd, sect),
|
|
paddress (target_gdbarch (), inferior_addr),
|
|
paddress (target_gdbarch (),
|
|
inferior_addr + bfd_get_section_size (sect)));
|
|
|
|
do_cleanups (cleanups);
|
|
}
|
|
|
|
/* Fetch the type of COMPILE_I_EXPR_PTR_TYPE and COMPILE_I_EXPR_VAL
|
|
symbols in OBJFILE so we can calculate how much memory to allocate
|
|
for the out parameter. This avoids needing a malloc in the generated
|
|
code. Throw an error if anything fails.
|
|
GDB first tries to compile the code with COMPILE_I_PRINT_ADDRESS_SCOPE.
|
|
If it finds user tries to print an array type this function returns
|
|
NULL. Caller will then regenerate the code with
|
|
COMPILE_I_PRINT_VALUE_SCOPE, recompiles it again and finally runs it.
|
|
This is because __auto_type array-to-pointer type conversion of
|
|
COMPILE_I_EXPR_VAL which gets detected by COMPILE_I_EXPR_PTR_TYPE
|
|
preserving the array type. */
|
|
|
|
static struct type *
|
|
get_out_value_type (struct symbol *func_sym, struct objfile *objfile,
|
|
enum compile_i_scope_types scope)
|
|
{
|
|
struct symbol *gdb_ptr_type_sym;
|
|
/* Initialize it just to avoid a GCC false warning. */
|
|
struct symbol *gdb_val_sym = NULL;
|
|
struct type *gdb_ptr_type, *gdb_type_from_ptr, *gdb_type, *retval;
|
|
/* Initialize it just to avoid a GCC false warning. */
|
|
const struct block *block = NULL;
|
|
const struct blockvector *bv;
|
|
int nblocks = 0;
|
|
int block_loop = 0;
|
|
|
|
bv = SYMTAB_BLOCKVECTOR (func_sym->owner.symtab);
|
|
nblocks = BLOCKVECTOR_NBLOCKS (bv);
|
|
|
|
gdb_ptr_type_sym = NULL;
|
|
for (block_loop = 0; block_loop < nblocks; block_loop++)
|
|
{
|
|
struct symbol *function = NULL;
|
|
const struct block *function_block;
|
|
|
|
block = BLOCKVECTOR_BLOCK (bv, block_loop);
|
|
if (BLOCK_FUNCTION (block) != NULL)
|
|
continue;
|
|
gdb_val_sym = block_lookup_symbol (block, COMPILE_I_EXPR_VAL, VAR_DOMAIN);
|
|
if (gdb_val_sym == NULL)
|
|
continue;
|
|
|
|
function_block = block;
|
|
while (function_block != BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK)
|
|
&& function_block != BLOCKVECTOR_BLOCK (bv, GLOBAL_BLOCK))
|
|
{
|
|
function_block = BLOCK_SUPERBLOCK (function_block);
|
|
function = BLOCK_FUNCTION (function_block);
|
|
if (function != NULL)
|
|
break;
|
|
}
|
|
if (function != NULL
|
|
&& (BLOCK_SUPERBLOCK (function_block)
|
|
== BLOCKVECTOR_BLOCK (bv, STATIC_BLOCK))
|
|
&& (strcmp (SYMBOL_LINKAGE_NAME (function), GCC_FE_WRAPPER_FUNCTION)
|
|
== 0))
|
|
break;
|
|
}
|
|
if (block_loop == nblocks)
|
|
error (_("No \"%s\" symbol found"), COMPILE_I_EXPR_PTR_TYPE);
|
|
|
|
gdb_type = SYMBOL_TYPE (gdb_val_sym);
|
|
gdb_type = check_typedef (gdb_type);
|
|
|
|
gdb_ptr_type_sym = block_lookup_symbol (block, COMPILE_I_EXPR_PTR_TYPE,
|
|
VAR_DOMAIN);
|
|
if (gdb_ptr_type_sym == NULL)
|
|
error (_("No \"%s\" symbol found"), COMPILE_I_EXPR_PTR_TYPE);
|
|
gdb_ptr_type = SYMBOL_TYPE (gdb_ptr_type_sym);
|
|
gdb_ptr_type = check_typedef (gdb_ptr_type);
|
|
if (TYPE_CODE (gdb_ptr_type) != TYPE_CODE_PTR)
|
|
error (_("Type of \"%s\" is not a pointer"), COMPILE_I_EXPR_PTR_TYPE);
|
|
gdb_type_from_ptr = TYPE_TARGET_TYPE (gdb_ptr_type);
|
|
|
|
if (types_deeply_equal (gdb_type, gdb_type_from_ptr))
|
|
{
|
|
if (scope != COMPILE_I_PRINT_ADDRESS_SCOPE)
|
|
error (_("Expected address scope in compiled module \"%s\"."),
|
|
objfile_name (objfile));
|
|
return gdb_type;
|
|
}
|
|
|
|
if (TYPE_CODE (gdb_type) != TYPE_CODE_PTR)
|
|
error (_("Invalid type code %d of symbol \"%s\" "
|
|
"in compiled module \"%s\"."),
|
|
TYPE_CODE (gdb_type_from_ptr), COMPILE_I_EXPR_VAL,
|
|
objfile_name (objfile));
|
|
|
|
retval = gdb_type_from_ptr;
|
|
switch (TYPE_CODE (gdb_type_from_ptr))
|
|
{
|
|
case TYPE_CODE_ARRAY:
|
|
gdb_type_from_ptr = TYPE_TARGET_TYPE (gdb_type_from_ptr);
|
|
break;
|
|
case TYPE_CODE_FUNC:
|
|
break;
|
|
default:
|
|
error (_("Invalid type code %d of symbol \"%s\" "
|
|
"in compiled module \"%s\"."),
|
|
TYPE_CODE (gdb_type_from_ptr), COMPILE_I_EXPR_PTR_TYPE,
|
|
objfile_name (objfile));
|
|
}
|
|
if (!types_deeply_equal (gdb_type_from_ptr,
|
|
TYPE_TARGET_TYPE (gdb_type)))
|
|
error (_("Referenced types do not match for symbols \"%s\" and \"%s\" "
|
|
"in compiled module \"%s\"."),
|
|
COMPILE_I_EXPR_PTR_TYPE, COMPILE_I_EXPR_VAL,
|
|
objfile_name (objfile));
|
|
if (scope == COMPILE_I_PRINT_ADDRESS_SCOPE)
|
|
return NULL;
|
|
return retval;
|
|
}
|
|
|
|
/* Fetch the type of first parameter of FUNC_SYM.
|
|
Return NULL if FUNC_SYM has no parameters. Throw an error otherwise. */
|
|
|
|
static struct type *
|
|
get_regs_type (struct symbol *func_sym, struct objfile *objfile)
|
|
{
|
|
struct type *func_type = SYMBOL_TYPE (func_sym);
|
|
struct type *regsp_type, *regs_type;
|
|
|
|
/* No register parameter present. */
|
|
if (TYPE_NFIELDS (func_type) == 0)
|
|
return NULL;
|
|
|
|
regsp_type = check_typedef (TYPE_FIELD_TYPE (func_type, 0));
|
|
if (TYPE_CODE (regsp_type) != TYPE_CODE_PTR)
|
|
error (_("Invalid type code %d of first parameter of function \"%s\" "
|
|
"in compiled module \"%s\"."),
|
|
TYPE_CODE (regsp_type), GCC_FE_WRAPPER_FUNCTION,
|
|
objfile_name (objfile));
|
|
|
|
regs_type = check_typedef (TYPE_TARGET_TYPE (regsp_type));
|
|
if (TYPE_CODE (regs_type) != TYPE_CODE_STRUCT)
|
|
error (_("Invalid type code %d of dereferenced first parameter "
|
|
"of function \"%s\" in compiled module \"%s\"."),
|
|
TYPE_CODE (regs_type), GCC_FE_WRAPPER_FUNCTION,
|
|
objfile_name (objfile));
|
|
|
|
return regs_type;
|
|
}
|
|
|
|
/* Store all inferior registers required by REGS_TYPE to inferior memory
|
|
starting at inferior address REGS_BASE. */
|
|
|
|
static void
|
|
store_regs (struct type *regs_type, CORE_ADDR regs_base)
|
|
{
|
|
struct gdbarch *gdbarch = target_gdbarch ();
|
|
struct regcache *regcache = get_thread_regcache (inferior_ptid);
|
|
int fieldno;
|
|
|
|
for (fieldno = 0; fieldno < TYPE_NFIELDS (regs_type); fieldno++)
|
|
{
|
|
const char *reg_name = TYPE_FIELD_NAME (regs_type, fieldno);
|
|
ULONGEST reg_bitpos = TYPE_FIELD_BITPOS (regs_type, fieldno);
|
|
ULONGEST reg_bitsize = TYPE_FIELD_BITSIZE (regs_type, fieldno);
|
|
ULONGEST reg_offset;
|
|
struct type *reg_type = check_typedef (TYPE_FIELD_TYPE (regs_type,
|
|
fieldno));
|
|
ULONGEST reg_size = TYPE_LENGTH (reg_type);
|
|
int regnum;
|
|
struct value *regval;
|
|
CORE_ADDR inferior_addr;
|
|
|
|
if (strcmp (reg_name, COMPILE_I_SIMPLE_REGISTER_DUMMY) == 0)
|
|
continue;
|
|
|
|
if ((reg_bitpos % 8) != 0 || reg_bitsize != 0)
|
|
error (_("Invalid register \"%s\" position %s bits or size %s bits"),
|
|
reg_name, pulongest (reg_bitpos), pulongest (reg_bitsize));
|
|
reg_offset = reg_bitpos / 8;
|
|
|
|
if (TYPE_CODE (reg_type) != TYPE_CODE_INT
|
|
&& TYPE_CODE (reg_type) != TYPE_CODE_PTR)
|
|
error (_("Invalid register \"%s\" type code %d"), reg_name,
|
|
TYPE_CODE (reg_type));
|
|
|
|
regnum = compile_register_name_demangle (gdbarch, reg_name);
|
|
|
|
regval = value_from_register (reg_type, regnum, get_current_frame ());
|
|
if (value_optimized_out (regval))
|
|
error (_("Register \"%s\" is optimized out."), reg_name);
|
|
if (!value_entirely_available (regval))
|
|
error (_("Register \"%s\" is not available."), reg_name);
|
|
|
|
inferior_addr = regs_base + reg_offset;
|
|
if (0 != target_write_memory (inferior_addr, value_contents (regval),
|
|
reg_size))
|
|
error (_("Cannot write register \"%s\" to inferior memory at %s."),
|
|
reg_name, paddress (gdbarch, inferior_addr));
|
|
}
|
|
}
|
|
|
|
/* Load OBJECT_FILE into inferior memory. Throw an error otherwise.
|
|
Caller must fully dispose the return value by calling compile_object_run.
|
|
SOURCE_FILE's copy is stored into the returned object.
|
|
Caller should free both OBJECT_FILE and SOURCE_FILE immediatelly after this
|
|
function returns.
|
|
Function returns NULL only for COMPILE_I_PRINT_ADDRESS_SCOPE when
|
|
COMPILE_I_PRINT_VALUE_SCOPE should have been used instead. */
|
|
|
|
struct compile_module *
|
|
compile_object_load (const char *object_file, const char *source_file,
|
|
enum compile_i_scope_types scope, void *scope_data)
|
|
{
|
|
struct cleanup *cleanups, *cleanups_free_objfile;
|
|
bfd *abfd;
|
|
struct setup_sections_data setup_sections_data;
|
|
CORE_ADDR addr, regs_addr, out_value_addr = 0;
|
|
struct symbol *func_sym;
|
|
struct type *func_type;
|
|
struct bound_minimal_symbol bmsym;
|
|
long storage_needed;
|
|
asymbol **symbol_table, **symp;
|
|
long number_of_symbols, missing_symbols;
|
|
struct type *dptr_type = builtin_type (target_gdbarch ())->builtin_data_ptr;
|
|
unsigned dptr_type_len = TYPE_LENGTH (dptr_type);
|
|
struct compile_module *retval;
|
|
struct type *regs_type, *out_value_type = NULL;
|
|
char *filename, **matching;
|
|
struct objfile *objfile;
|
|
int expect_parameters;
|
|
struct type *expect_return_type;
|
|
struct munmap_list *munmap_list_head = NULL;
|
|
|
|
filename = tilde_expand (object_file);
|
|
cleanups = make_cleanup (xfree, filename);
|
|
|
|
abfd = gdb_bfd_open (filename, gnutarget, -1);
|
|
if (abfd == NULL)
|
|
error (_("\"%s\": could not open as compiled module: %s"),
|
|
filename, bfd_errmsg (bfd_get_error ()));
|
|
make_cleanup_bfd_unref (abfd);
|
|
|
|
if (!bfd_check_format_matches (abfd, bfd_object, &matching))
|
|
error (_("\"%s\": not in loadable format: %s"),
|
|
filename, gdb_bfd_errmsg (bfd_get_error (), matching));
|
|
|
|
if ((bfd_get_file_flags (abfd) & (EXEC_P | DYNAMIC)) != 0)
|
|
error (_("\"%s\": not in object format."), filename);
|
|
|
|
setup_sections_data.last_size = 0;
|
|
setup_sections_data.last_section_first = abfd->sections;
|
|
setup_sections_data.last_prot = -1;
|
|
setup_sections_data.last_max_alignment = 1;
|
|
setup_sections_data.munmap_list_headp = &munmap_list_head;
|
|
make_cleanup (munmap_listp_free_cleanup, &munmap_list_head);
|
|
bfd_map_over_sections (abfd, setup_sections, &setup_sections_data);
|
|
setup_sections (abfd, NULL, &setup_sections_data);
|
|
|
|
storage_needed = bfd_get_symtab_upper_bound (abfd);
|
|
if (storage_needed < 0)
|
|
error (_("Cannot read symbols of compiled module \"%s\": %s"),
|
|
filename, bfd_errmsg (bfd_get_error ()));
|
|
|
|
/* SYMFILE_VERBOSE is not passed even if FROM_TTY, user is not interested in
|
|
"Reading symbols from ..." message for automatically generated file. */
|
|
objfile = symbol_file_add_from_bfd (abfd, filename, 0, NULL, 0, NULL);
|
|
cleanups_free_objfile = make_cleanup_free_objfile (objfile);
|
|
|
|
func_sym = lookup_global_symbol_from_objfile (objfile,
|
|
GCC_FE_WRAPPER_FUNCTION,
|
|
VAR_DOMAIN).symbol;
|
|
if (func_sym == NULL)
|
|
error (_("Cannot find function \"%s\" in compiled module \"%s\"."),
|
|
GCC_FE_WRAPPER_FUNCTION, objfile_name (objfile));
|
|
func_type = SYMBOL_TYPE (func_sym);
|
|
if (TYPE_CODE (func_type) != TYPE_CODE_FUNC)
|
|
error (_("Invalid type code %d of function \"%s\" in compiled "
|
|
"module \"%s\"."),
|
|
TYPE_CODE (func_type), GCC_FE_WRAPPER_FUNCTION,
|
|
objfile_name (objfile));
|
|
|
|
switch (scope)
|
|
{
|
|
case COMPILE_I_SIMPLE_SCOPE:
|
|
expect_parameters = 1;
|
|
expect_return_type = builtin_type (target_gdbarch ())->builtin_void;
|
|
break;
|
|
case COMPILE_I_RAW_SCOPE:
|
|
expect_parameters = 0;
|
|
expect_return_type = builtin_type (target_gdbarch ())->builtin_void;
|
|
break;
|
|
case COMPILE_I_PRINT_ADDRESS_SCOPE:
|
|
case COMPILE_I_PRINT_VALUE_SCOPE:
|
|
expect_parameters = 2;
|
|
expect_return_type = builtin_type (target_gdbarch ())->builtin_void;
|
|
break;
|
|
default:
|
|
internal_error (__FILE__, __LINE__, _("invalid scope %d"), scope);
|
|
}
|
|
if (TYPE_NFIELDS (func_type) != expect_parameters)
|
|
error (_("Invalid %d parameters of function \"%s\" in compiled "
|
|
"module \"%s\"."),
|
|
TYPE_NFIELDS (func_type), GCC_FE_WRAPPER_FUNCTION,
|
|
objfile_name (objfile));
|
|
if (!types_deeply_equal (expect_return_type, TYPE_TARGET_TYPE (func_type)))
|
|
error (_("Invalid return type of function \"%s\" in compiled "
|
|
"module \"%s\"."),
|
|
GCC_FE_WRAPPER_FUNCTION, objfile_name (objfile));
|
|
|
|
/* The memory may be later needed
|
|
by bfd_generic_get_relocated_section_contents
|
|
called from default_symfile_relocate. */
|
|
symbol_table = (asymbol **) obstack_alloc (&objfile->objfile_obstack,
|
|
storage_needed);
|
|
number_of_symbols = bfd_canonicalize_symtab (abfd, symbol_table);
|
|
if (number_of_symbols < 0)
|
|
error (_("Cannot parse symbols of compiled module \"%s\": %s"),
|
|
filename, bfd_errmsg (bfd_get_error ()));
|
|
|
|
missing_symbols = 0;
|
|
for (symp = symbol_table; symp < symbol_table + number_of_symbols; symp++)
|
|
{
|
|
asymbol *sym = *symp;
|
|
|
|
if (sym->flags != 0)
|
|
continue;
|
|
sym->flags = BSF_GLOBAL;
|
|
sym->section = bfd_abs_section_ptr;
|
|
if (strcmp (sym->name, "_GLOBAL_OFFSET_TABLE_") == 0)
|
|
{
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"ELF symbol \"%s\" relocated to zero\n",
|
|
sym->name);
|
|
|
|
/* It seems to be a GCC bug, with -mcmodel=large there should be no
|
|
need for _GLOBAL_OFFSET_TABLE_. Together with -fPIE the data
|
|
remain PC-relative even with _GLOBAL_OFFSET_TABLE_ as zero. */
|
|
sym->value = 0;
|
|
continue;
|
|
}
|
|
bmsym = lookup_minimal_symbol (sym->name, NULL, NULL);
|
|
switch (bmsym.minsym == NULL
|
|
? mst_unknown : MSYMBOL_TYPE (bmsym.minsym))
|
|
{
|
|
case mst_text:
|
|
sym->value = BMSYMBOL_VALUE_ADDRESS (bmsym);
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"ELF mst_text symbol \"%s\" relocated to %s\n",
|
|
sym->name,
|
|
paddress (target_gdbarch (), sym->value));
|
|
break;
|
|
case mst_text_gnu_ifunc:
|
|
sym->value = gnu_ifunc_resolve_addr (target_gdbarch (),
|
|
BMSYMBOL_VALUE_ADDRESS (bmsym));
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"ELF mst_text_gnu_ifunc symbol \"%s\" "
|
|
"relocated to %s\n",
|
|
sym->name,
|
|
paddress (target_gdbarch (), sym->value));
|
|
break;
|
|
default:
|
|
warning (_("Could not find symbol \"%s\" "
|
|
"for compiled module \"%s\"."),
|
|
sym->name, filename);
|
|
missing_symbols++;
|
|
}
|
|
}
|
|
if (missing_symbols)
|
|
error (_("%ld symbols were missing, cannot continue."), missing_symbols);
|
|
|
|
bfd_map_over_sections (abfd, copy_sections, symbol_table);
|
|
|
|
regs_type = get_regs_type (func_sym, objfile);
|
|
if (regs_type == NULL)
|
|
regs_addr = 0;
|
|
else
|
|
{
|
|
/* Use read-only non-executable memory protection. */
|
|
regs_addr = gdbarch_infcall_mmap (target_gdbarch (),
|
|
TYPE_LENGTH (regs_type),
|
|
GDB_MMAP_PROT_READ);
|
|
gdb_assert (regs_addr != 0);
|
|
munmap_list_add (&munmap_list_head, regs_addr, TYPE_LENGTH (regs_type));
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"allocated %s bytes at %s for registers\n",
|
|
paddress (target_gdbarch (),
|
|
TYPE_LENGTH (regs_type)),
|
|
paddress (target_gdbarch (), regs_addr));
|
|
store_regs (regs_type, regs_addr);
|
|
}
|
|
|
|
if (scope == COMPILE_I_PRINT_ADDRESS_SCOPE
|
|
|| scope == COMPILE_I_PRINT_VALUE_SCOPE)
|
|
{
|
|
out_value_type = get_out_value_type (func_sym, objfile, scope);
|
|
if (out_value_type == NULL)
|
|
{
|
|
do_cleanups (cleanups);
|
|
return NULL;
|
|
}
|
|
check_typedef (out_value_type);
|
|
out_value_addr = gdbarch_infcall_mmap (target_gdbarch (),
|
|
TYPE_LENGTH (out_value_type),
|
|
(GDB_MMAP_PROT_READ
|
|
| GDB_MMAP_PROT_WRITE));
|
|
gdb_assert (out_value_addr != 0);
|
|
munmap_list_add (&munmap_list_head, out_value_addr,
|
|
TYPE_LENGTH (out_value_type));
|
|
if (compile_debug)
|
|
fprintf_unfiltered (gdb_stdlog,
|
|
"allocated %s bytes at %s for printed value\n",
|
|
paddress (target_gdbarch (),
|
|
TYPE_LENGTH (out_value_type)),
|
|
paddress (target_gdbarch (), out_value_addr));
|
|
}
|
|
|
|
discard_cleanups (cleanups_free_objfile);
|
|
|
|
retval = XNEW (struct compile_module);
|
|
retval->objfile = objfile;
|
|
retval->source_file = xstrdup (source_file);
|
|
retval->func_sym = func_sym;
|
|
retval->regs_addr = regs_addr;
|
|
retval->scope = scope;
|
|
retval->scope_data = scope_data;
|
|
retval->out_value_type = out_value_type;
|
|
retval->out_value_addr = out_value_addr;
|
|
|
|
/* CLEANUPS will free MUNMAP_LIST_HEAD. */
|
|
retval->munmap_list_head = munmap_list_head;
|
|
munmap_list_head = NULL;
|
|
|
|
do_cleanups (cleanups);
|
|
|
|
return retval;
|
|
}
|