224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
542 lines
18 KiB
C
542 lines
18 KiB
C
/* Copyright (C) 2008-2015 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "defs.h"
|
|
#include "windows-tdep.h"
|
|
#include "gdb_obstack.h"
|
|
#include "xml-support.h"
|
|
#include "gdbarch.h"
|
|
#include "target.h"
|
|
#include "value.h"
|
|
#include "inferior.h"
|
|
#include "command.h"
|
|
#include "gdbcmd.h"
|
|
#include "gdbthread.h"
|
|
#include "objfiles.h"
|
|
#include "symfile.h"
|
|
#include "coff-pe-read.h"
|
|
#include "gdb_bfd.h"
|
|
#include "complaints.h"
|
|
#include "solib.h"
|
|
#include "solib-target.h"
|
|
#include "gdbcore.h"
|
|
|
|
struct cmd_list_element *info_w32_cmdlist;
|
|
|
|
typedef struct thread_information_block_32
|
|
{
|
|
uint32_t current_seh; /* %fs:0x0000 */
|
|
uint32_t current_top_of_stack; /* %fs:0x0004 */
|
|
uint32_t current_bottom_of_stack; /* %fs:0x0008 */
|
|
uint32_t sub_system_tib; /* %fs:0x000c */
|
|
uint32_t fiber_data; /* %fs:0x0010 */
|
|
uint32_t arbitrary_data_slot; /* %fs:0x0014 */
|
|
uint32_t linear_address_tib; /* %fs:0x0018 */
|
|
uint32_t environment_pointer; /* %fs:0x001c */
|
|
uint32_t process_id; /* %fs:0x0020 */
|
|
uint32_t current_thread_id; /* %fs:0x0024 */
|
|
uint32_t active_rpc_handle; /* %fs:0x0028 */
|
|
uint32_t thread_local_storage; /* %fs:0x002c */
|
|
uint32_t process_environment_block; /* %fs:0x0030 */
|
|
uint32_t last_error_number; /* %fs:0x0034 */
|
|
}
|
|
thread_information_32;
|
|
|
|
typedef struct thread_information_block_64
|
|
{
|
|
uint64_t current_seh; /* %gs:0x0000 */
|
|
uint64_t current_top_of_stack; /* %gs:0x0008 */
|
|
uint64_t current_bottom_of_stack; /* %gs:0x0010 */
|
|
uint64_t sub_system_tib; /* %gs:0x0018 */
|
|
uint64_t fiber_data; /* %gs:0x0020 */
|
|
uint64_t arbitrary_data_slot; /* %gs:0x0028 */
|
|
uint64_t linear_address_tib; /* %gs:0x0030 */
|
|
uint64_t environment_pointer; /* %gs:0x0038 */
|
|
uint64_t process_id; /* %gs:0x0040 */
|
|
uint64_t current_thread_id; /* %gs:0x0048 */
|
|
uint64_t active_rpc_handle; /* %gs:0x0050 */
|
|
uint64_t thread_local_storage; /* %gs:0x0058 */
|
|
uint64_t process_environment_block; /* %gs:0x0060 */
|
|
uint64_t last_error_number; /* %gs:0x0068 */
|
|
}
|
|
thread_information_64;
|
|
|
|
|
|
static const char* TIB_NAME[] =
|
|
{
|
|
" current_seh ", /* %fs:0x0000 */
|
|
" current_top_of_stack ", /* %fs:0x0004 */
|
|
" current_bottom_of_stack ", /* %fs:0x0008 */
|
|
" sub_system_tib ", /* %fs:0x000c */
|
|
" fiber_data ", /* %fs:0x0010 */
|
|
" arbitrary_data_slot ", /* %fs:0x0014 */
|
|
" linear_address_tib ", /* %fs:0x0018 */
|
|
" environment_pointer ", /* %fs:0x001c */
|
|
" process_id ", /* %fs:0x0020 */
|
|
" current_thread_id ", /* %fs:0x0024 */
|
|
" active_rpc_handle ", /* %fs:0x0028 */
|
|
" thread_local_storage ", /* %fs:0x002c */
|
|
" process_environment_block ", /* %fs:0x0030 */
|
|
" last_error_number " /* %fs:0x0034 */
|
|
};
|
|
|
|
static const int MAX_TIB32 =
|
|
sizeof (thread_information_32) / sizeof (uint32_t);
|
|
static const int MAX_TIB64 =
|
|
sizeof (thread_information_64) / sizeof (uint64_t);
|
|
static const int FULL_TIB_SIZE = 0x1000;
|
|
|
|
static int maint_display_all_tib = 0;
|
|
|
|
/* Define Thread Local Base pointer type. */
|
|
|
|
static struct type *
|
|
windows_get_tlb_type (struct gdbarch *gdbarch)
|
|
{
|
|
static struct gdbarch *last_gdbarch = NULL;
|
|
static struct type *last_tlb_type = NULL;
|
|
struct type *dword_ptr_type, *dword32_type, *void_ptr_type;
|
|
struct type *peb_ldr_type, *peb_ldr_ptr_type;
|
|
struct type *peb_type, *peb_ptr_type, *list_type, *list_ptr_type;
|
|
struct type *module_list_ptr_type;
|
|
struct type *tib_type, *seh_type, *tib_ptr_type, *seh_ptr_type;
|
|
|
|
/* Do not rebuild type if same gdbarch as last time. */
|
|
if (last_tlb_type && last_gdbarch == gdbarch)
|
|
return last_tlb_type;
|
|
|
|
dword_ptr_type = arch_integer_type (gdbarch, gdbarch_ptr_bit (gdbarch),
|
|
1, "DWORD_PTR");
|
|
dword32_type = arch_integer_type (gdbarch, 32,
|
|
1, "DWORD32");
|
|
void_ptr_type = lookup_pointer_type (builtin_type (gdbarch)->builtin_void);
|
|
|
|
/* list entry */
|
|
|
|
list_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
TYPE_NAME (list_type) = xstrdup ("list");
|
|
|
|
list_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
|
|
module_list_ptr_type = void_ptr_type;
|
|
|
|
append_composite_type_field (list_type, "forward_list",
|
|
module_list_ptr_type);
|
|
append_composite_type_field (list_type, "backward_list",
|
|
module_list_ptr_type);
|
|
|
|
/* Structured Exception Handler */
|
|
|
|
seh_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
TYPE_NAME (seh_type) = xstrdup ("seh");
|
|
|
|
seh_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
TYPE_TARGET_TYPE (seh_ptr_type) = seh_type;
|
|
|
|
append_composite_type_field (seh_type, "next_seh", seh_ptr_type);
|
|
append_composite_type_field (seh_type, "handler",
|
|
builtin_type (gdbarch)->builtin_func_ptr);
|
|
|
|
/* struct _PEB_LDR_DATA */
|
|
peb_ldr_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
TYPE_NAME (peb_ldr_type) = xstrdup ("peb_ldr_data");
|
|
|
|
append_composite_type_field (peb_ldr_type, "length", dword32_type);
|
|
append_composite_type_field (peb_ldr_type, "initialized", dword32_type);
|
|
append_composite_type_field (peb_ldr_type, "ss_handle", void_ptr_type);
|
|
append_composite_type_field (peb_ldr_type, "in_load_order", list_type);
|
|
append_composite_type_field (peb_ldr_type, "in_memory_order", list_type);
|
|
append_composite_type_field (peb_ldr_type, "in_init_order", list_type);
|
|
append_composite_type_field (peb_ldr_type, "entry_in_progress",
|
|
void_ptr_type);
|
|
peb_ldr_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
TYPE_TARGET_TYPE (peb_ldr_ptr_type) = peb_ldr_type;
|
|
|
|
|
|
/* struct process environment block */
|
|
peb_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
TYPE_NAME (peb_type) = xstrdup ("peb");
|
|
|
|
/* First bytes contain several flags. */
|
|
append_composite_type_field (peb_type, "flags", dword_ptr_type);
|
|
append_composite_type_field (peb_type, "mutant", void_ptr_type);
|
|
append_composite_type_field (peb_type, "image_base_address", void_ptr_type);
|
|
append_composite_type_field (peb_type, "ldr", peb_ldr_ptr_type);
|
|
append_composite_type_field (peb_type, "process_parameters", void_ptr_type);
|
|
append_composite_type_field (peb_type, "sub_system_data", void_ptr_type);
|
|
append_composite_type_field (peb_type, "process_heap", void_ptr_type);
|
|
append_composite_type_field (peb_type, "fast_peb_lock", void_ptr_type);
|
|
peb_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
TYPE_TARGET_TYPE (peb_ptr_type) = peb_type;
|
|
|
|
|
|
/* struct thread information block */
|
|
tib_type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT);
|
|
TYPE_NAME (tib_type) = xstrdup ("tib");
|
|
|
|
/* uint32_t current_seh; %fs:0x0000 */
|
|
append_composite_type_field (tib_type, "current_seh", seh_ptr_type);
|
|
/* uint32_t current_top_of_stack; %fs:0x0004 */
|
|
append_composite_type_field (tib_type, "current_top_of_stack",
|
|
void_ptr_type);
|
|
/* uint32_t current_bottom_of_stack; %fs:0x0008 */
|
|
append_composite_type_field (tib_type, "current_bottom_of_stack",
|
|
void_ptr_type);
|
|
/* uint32_t sub_system_tib; %fs:0x000c */
|
|
append_composite_type_field (tib_type, "sub_system_tib", void_ptr_type);
|
|
|
|
/* uint32_t fiber_data; %fs:0x0010 */
|
|
append_composite_type_field (tib_type, "fiber_data", void_ptr_type);
|
|
/* uint32_t arbitrary_data_slot; %fs:0x0014 */
|
|
append_composite_type_field (tib_type, "arbitrary_data_slot", void_ptr_type);
|
|
/* uint32_t linear_address_tib; %fs:0x0018 */
|
|
append_composite_type_field (tib_type, "linear_address_tib", void_ptr_type);
|
|
/* uint32_t environment_pointer; %fs:0x001c */
|
|
append_composite_type_field (tib_type, "environment_pointer", void_ptr_type);
|
|
/* uint32_t process_id; %fs:0x0020 */
|
|
append_composite_type_field (tib_type, "process_id", dword_ptr_type);
|
|
/* uint32_t current_thread_id; %fs:0x0024 */
|
|
append_composite_type_field (tib_type, "thread_id", dword_ptr_type);
|
|
/* uint32_t active_rpc_handle; %fs:0x0028 */
|
|
append_composite_type_field (tib_type, "active_rpc_handle", dword_ptr_type);
|
|
/* uint32_t thread_local_storage; %fs:0x002c */
|
|
append_composite_type_field (tib_type, "thread_local_storage",
|
|
void_ptr_type);
|
|
/* uint32_t process_environment_block; %fs:0x0030 */
|
|
append_composite_type_field (tib_type, "process_environment_block",
|
|
peb_ptr_type);
|
|
/* uint32_t last_error_number; %fs:0x0034 */
|
|
append_composite_type_field (tib_type, "last_error_number", dword_ptr_type);
|
|
|
|
tib_ptr_type = arch_type (gdbarch, TYPE_CODE_PTR,
|
|
TYPE_LENGTH (void_ptr_type), NULL);
|
|
TYPE_TARGET_TYPE (tib_ptr_type) = tib_type;
|
|
|
|
last_tlb_type = tib_ptr_type;
|
|
last_gdbarch = gdbarch;
|
|
|
|
return tib_ptr_type;
|
|
}
|
|
|
|
/* The $_tlb convenience variable is a bit special. We don't know
|
|
for sure the type of the value until we actually have a chance to
|
|
fetch the data. The type can change depending on gdbarch, so it is
|
|
also dependent on which thread you have selected. */
|
|
|
|
/* This function implements the lval_computed support for reading a
|
|
$_tlb value. */
|
|
|
|
static void
|
|
tlb_value_read (struct value *val)
|
|
{
|
|
CORE_ADDR tlb;
|
|
struct type *type = check_typedef (value_type (val));
|
|
|
|
if (!target_get_tib_address (inferior_ptid, &tlb))
|
|
error (_("Unable to read tlb"));
|
|
store_typed_address (value_contents_raw (val), type, tlb);
|
|
}
|
|
|
|
/* This function implements the lval_computed support for writing a
|
|
$_tlb value. */
|
|
|
|
static void
|
|
tlb_value_write (struct value *v, struct value *fromval)
|
|
{
|
|
error (_("Impossible to change the Thread Local Base"));
|
|
}
|
|
|
|
static const struct lval_funcs tlb_value_funcs =
|
|
{
|
|
tlb_value_read,
|
|
tlb_value_write
|
|
};
|
|
|
|
|
|
/* Return a new value with the correct type for the tlb object of
|
|
the current thread using architecture GDBARCH. Return a void value
|
|
if there's no object available. */
|
|
|
|
static struct value *
|
|
tlb_make_value (struct gdbarch *gdbarch, struct internalvar *var, void *ignore)
|
|
{
|
|
if (target_has_stack && !ptid_equal (inferior_ptid, null_ptid))
|
|
{
|
|
struct type *type = windows_get_tlb_type (gdbarch);
|
|
return allocate_computed_value (type, &tlb_value_funcs, NULL);
|
|
}
|
|
|
|
return allocate_value (builtin_type (gdbarch)->builtin_void);
|
|
}
|
|
|
|
|
|
/* Display thread information block of a given thread. */
|
|
|
|
static int
|
|
display_one_tib (ptid_t ptid)
|
|
{
|
|
gdb_byte *tib = NULL;
|
|
gdb_byte *index;
|
|
CORE_ADDR thread_local_base;
|
|
ULONGEST i, val, max, max_name, size, tib_size;
|
|
ULONGEST sizeof_ptr = gdbarch_ptr_bit (target_gdbarch ());
|
|
enum bfd_endian byte_order = gdbarch_byte_order (target_gdbarch ());
|
|
|
|
if (sizeof_ptr == 64)
|
|
{
|
|
size = sizeof (uint64_t);
|
|
tib_size = sizeof (thread_information_64);
|
|
max = MAX_TIB64;
|
|
}
|
|
else
|
|
{
|
|
size = sizeof (uint32_t);
|
|
tib_size = sizeof (thread_information_32);
|
|
max = MAX_TIB32;
|
|
}
|
|
|
|
max_name = max;
|
|
|
|
if (maint_display_all_tib)
|
|
{
|
|
tib_size = FULL_TIB_SIZE;
|
|
max = tib_size / size;
|
|
}
|
|
|
|
tib = (gdb_byte *) alloca (tib_size);
|
|
|
|
if (target_get_tib_address (ptid, &thread_local_base) == 0)
|
|
{
|
|
printf_filtered (_("Unable to get thread local base for %s\n"),
|
|
target_pid_to_str (ptid));
|
|
return -1;
|
|
}
|
|
|
|
if (target_read (¤t_target, TARGET_OBJECT_MEMORY,
|
|
NULL, tib, thread_local_base, tib_size) != tib_size)
|
|
{
|
|
printf_filtered (_("Unable to read thread information "
|
|
"block for %s at address %s\n"),
|
|
target_pid_to_str (ptid),
|
|
paddress (target_gdbarch (), thread_local_base));
|
|
return -1;
|
|
}
|
|
|
|
printf_filtered (_("Thread Information Block %s at %s\n"),
|
|
target_pid_to_str (ptid),
|
|
paddress (target_gdbarch (), thread_local_base));
|
|
|
|
index = (gdb_byte *) tib;
|
|
|
|
/* All fields have the size of a pointer, this allows to iterate
|
|
using the same for loop for both layouts. */
|
|
for (i = 0; i < max; i++)
|
|
{
|
|
val = extract_unsigned_integer (index, size, byte_order);
|
|
if (i < max_name)
|
|
printf_filtered (_("%s is 0x%s\n"), TIB_NAME[i], phex (val, size));
|
|
else if (val != 0)
|
|
printf_filtered (_("TIB[0x%s] is 0x%s\n"), phex (i * size, 2),
|
|
phex (val, size));
|
|
index += size;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
/* Display thread information block of a thread specified by ARGS.
|
|
If ARGS is empty, display thread information block of current_thread
|
|
if current_thread is non NULL.
|
|
Otherwise ARGS is parsed and converted to a integer that should
|
|
be the windows ThreadID (not the internal GDB thread ID). */
|
|
|
|
static void
|
|
display_tib (char * args, int from_tty)
|
|
{
|
|
if (args)
|
|
{
|
|
struct thread_info *tp;
|
|
int gdb_id = value_as_long (parse_and_eval (args));
|
|
|
|
tp = find_thread_id (gdb_id);
|
|
|
|
if (!tp)
|
|
error (_("Thread ID %d not known."), gdb_id);
|
|
|
|
if (!target_thread_alive (tp->ptid))
|
|
error (_("Thread ID %d has terminated."), gdb_id);
|
|
|
|
display_one_tib (tp->ptid);
|
|
}
|
|
else if (!ptid_equal (inferior_ptid, null_ptid))
|
|
display_one_tib (inferior_ptid);
|
|
}
|
|
|
|
void
|
|
windows_xfer_shared_library (const char* so_name, CORE_ADDR load_addr,
|
|
struct gdbarch *gdbarch, struct obstack *obstack)
|
|
{
|
|
char *p;
|
|
struct bfd * dll;
|
|
CORE_ADDR text_offset;
|
|
|
|
obstack_grow_str (obstack, "<library name=\"");
|
|
p = xml_escape_text (so_name);
|
|
obstack_grow_str (obstack, p);
|
|
xfree (p);
|
|
obstack_grow_str (obstack, "\"><segment address=\"");
|
|
dll = gdb_bfd_open (so_name, gnutarget, -1);
|
|
/* The following calls are OK even if dll is NULL.
|
|
The default value 0x1000 is returned by pe_text_section_offset
|
|
in that case. */
|
|
text_offset = pe_text_section_offset (dll);
|
|
gdb_bfd_unref (dll);
|
|
obstack_grow_str (obstack, paddress (gdbarch, load_addr + text_offset));
|
|
obstack_grow_str (obstack, "\"/></library>");
|
|
}
|
|
|
|
/* Implement the "iterate_over_objfiles_in_search_order" gdbarch
|
|
method. It searches all objfiles, starting with CURRENT_OBJFILE
|
|
first (if not NULL).
|
|
|
|
On Windows, the system behaves a little differently when two
|
|
objfiles each define a global symbol using the same name, compared
|
|
to other platforms such as GNU/Linux for instance. On GNU/Linux,
|
|
all instances of the symbol effectively get merged into a single
|
|
one, but on Windows, they remain distinct.
|
|
|
|
As a result, it usually makes sense to start global symbol searches
|
|
with the current objfile before expanding it to all other objfiles.
|
|
This helps for instance when a user debugs some code in a DLL that
|
|
refers to a global variable defined inside that DLL. When trying
|
|
to print the value of that global variable, it would be unhelpful
|
|
to print the value of another global variable defined with the same
|
|
name, but in a different DLL. */
|
|
|
|
static void
|
|
windows_iterate_over_objfiles_in_search_order
|
|
(struct gdbarch *gdbarch,
|
|
iterate_over_objfiles_in_search_order_cb_ftype *cb,
|
|
void *cb_data, struct objfile *current_objfile)
|
|
{
|
|
int stop;
|
|
struct objfile *objfile;
|
|
|
|
if (current_objfile)
|
|
{
|
|
stop = cb (current_objfile, cb_data);
|
|
if (stop)
|
|
return;
|
|
}
|
|
|
|
ALL_OBJFILES (objfile)
|
|
{
|
|
if (objfile != current_objfile)
|
|
{
|
|
stop = cb (objfile, cb_data);
|
|
if (stop)
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
|
|
static void
|
|
show_maint_show_all_tib (struct ui_file *file, int from_tty,
|
|
struct cmd_list_element *c, const char *value)
|
|
{
|
|
fprintf_filtered (file, _("Show all non-zero elements of "
|
|
"Thread Information Block is %s.\n"), value);
|
|
}
|
|
|
|
static void
|
|
info_w32_command (char *args, int from_tty)
|
|
{
|
|
help_list (info_w32_cmdlist, "info w32 ", class_info, gdb_stdout);
|
|
}
|
|
|
|
static int w32_prefix_command_valid = 0;
|
|
void
|
|
init_w32_command_list (void)
|
|
{
|
|
if (!w32_prefix_command_valid)
|
|
{
|
|
add_prefix_cmd ("w32", class_info, info_w32_command,
|
|
_("Print information specific to Win32 debugging."),
|
|
&info_w32_cmdlist, "info w32 ", 0, &infolist);
|
|
w32_prefix_command_valid = 1;
|
|
}
|
|
}
|
|
|
|
/* To be called from the various GDB_OSABI_CYGWIN handlers for the
|
|
various Windows architectures and machine types. */
|
|
|
|
void
|
|
windows_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch)
|
|
{
|
|
/* Canonical paths on this target look like
|
|
`c:\Program Files\Foo App\mydll.dll', for example. */
|
|
set_gdbarch_has_dos_based_file_system (gdbarch, 1);
|
|
|
|
set_gdbarch_iterate_over_objfiles_in_search_order
|
|
(gdbarch, windows_iterate_over_objfiles_in_search_order);
|
|
|
|
set_solib_ops (gdbarch, &solib_target_so_ops);
|
|
}
|
|
|
|
/* Provide a prototype to silence -Wmissing-prototypes. */
|
|
extern initialize_file_ftype _initialize_windows_tdep;
|
|
|
|
/* Implementation of `tlb' variable. */
|
|
|
|
static const struct internalvar_funcs tlb_funcs =
|
|
{
|
|
tlb_make_value,
|
|
NULL,
|
|
NULL
|
|
};
|
|
|
|
void
|
|
_initialize_windows_tdep (void)
|
|
{
|
|
init_w32_command_list ();
|
|
add_cmd ("thread-information-block", class_info, display_tib,
|
|
_("Display thread information block."),
|
|
&info_w32_cmdlist);
|
|
add_alias_cmd ("tib", "thread-information-block", class_info, 1,
|
|
&info_w32_cmdlist);
|
|
|
|
add_setshow_boolean_cmd ("show-all-tib", class_maintenance,
|
|
&maint_display_all_tib, _("\
|
|
Set whether to display all non-zero fields of thread information block."), _("\
|
|
Show whether to display all non-zero fields of thread information block."), _("\
|
|
Use \"on\" to enable, \"off\" to disable.\n\
|
|
If enabled, all non-zero fields of thread information block are displayed,\n\
|
|
even if their meaning is unknown."),
|
|
NULL,
|
|
show_maint_show_all_tib,
|
|
&maintenance_set_cmdlist,
|
|
&maintenance_show_cmdlist);
|
|
|
|
/* Explicitly create without lookup, since that tries to create a
|
|
value with a void typed value, and when we get here, gdbarch
|
|
isn't initialized yet. At this point, we're quite sure there
|
|
isn't another convenience variable of the same name. */
|
|
create_internalvar_type_lazy ("_tlb", &tlb_funcs, NULL);
|
|
}
|