0fa7fe506c
This patch improves the handling of out-of-line functions nested
inside functions that have been inlined.
Consider for instance a situation where function Foo_O224_021
has a function Child1 declared in it, which itself has a function
Child2 nested inside Child1. After compiling the program with
optimization on, Child1 gets inlined, but not Child2.
After inserting a breakpoint on Child2, and running the program
until reaching that breakpoint, we get the following backtrace:
% gdb foo_o224_021
(gdb) break foo_o224_021.child1.child2
(gdb) run
[...]
Breakpoint 1, foo_o224_021 () at foo_o224_021.adb:28
28 Child1;
(gdb) bt
#0 0x0000000000402400 in foo_o224_021 () at foo_o224_021.adb:28
#1 0x00000000004027a4 in foo_o224_021.child1 () at foo_o224_021.adb:23
#2 0x00000000004027a4 in foo_o224_021 () at foo_o224_021.adb:28
GDB reports the wrong function name for frame #0. We also get the same
kind of error in the "Breakpoint 1, foo_o224_021 () [...]" message.
In both cases, the function name should be foo_o224_021.child1.child2,
and the parameters should be "s=...".
What happens is that the inlined frame handling does not handle well
the case where an inlined function is calling an out-of-line function
which was declared inside the inlined function's scope.
In particular, looking first at the inlined-frame sniffer when applying
to frame #0:
/* Calculate DEPTH, the number of inlined functions at this
location. */
depth = 0;
cur_block = frame_block;
while (BLOCK_SUPERBLOCK (cur_block))
{
if (block_inlined_p (cur_block))
depth++;
cur_block = BLOCK_SUPERBLOCK (cur_block);
}
What happens is that cur_block starts as the block associated
to child2, which is not inlined. We shoud be stopping here, but
instead, we keep walking the superblock chain, which takes us
all the way to Foo_O224_021's block, via Child2's block. And
since Child1 was inlined, we end up with a depth count of 1,
wrongly making GDB think that frame #0 is an inlined frame.
Same kind of issue inside skip_inline_frames.
The fix is to stop checking for inlined frames as soon as we see
a block corresponding to a function which is not inlined. This is
the behavior we now obtain:
(gdb) run
[...]
Breakpoint 1, foo_o224_021.child1.child2 (s=...) at foo_o224_021.adb:9
9 function Child2 (S : String) return Boolean is
(gdb) bt
#0 0x0000000000402400 in foo_o224_021.child1.child2 (s=...)
at foo_o224_021.adb:9
#1 0x00000000004027a4 in foo_o224_021.child1 () at foo_o224_021.adb:23
#2 0x00000000004027a4 in foo_o224_021 () at foo_o224_021.adb:28
gdb/ChangeLog:
* inline-frame.c (inline_frame_sniffer, skip_inline_frames):
Stop counting inlined frames as soon as an out-of-line function
is found.
gdb/testsuite/ChangeLog:
* gdb.ada/out_of_line_in_inlined.exp: Add run and "bt" tests.
|
||
|---|---|---|
| .. | ||
| addr_arith | ||
| aliased_array | ||
| arr_arr | ||
| array_bounds | ||
| array_char_idx | ||
| array_return | ||
| array_subscript_addr | ||
| arraydim | ||
| arrayidx | ||
| arrayparam | ||
| arrayptr | ||
| atomic_enum | ||
| bad-task-bp-keyword | ||
| bp_enum_homonym | ||
| bp_on_var | ||
| bp_range_type | ||
| bp_reset | ||
| call_pn | ||
| catch_ex | ||
| char_enum | ||
| char_param | ||
| complete | ||
| cond_lang | ||
| disc_arr_bound | ||
| dot_all | ||
| dyn_arrayidx | ||
| dyn_loc | ||
| enum_idx_packed | ||
| exec_changed | ||
| expr_delims | ||
| exprs | ||
| fixed_cmp | ||
| fixed_points | ||
| float_param | ||
| formatted_ref | ||
| frame_args | ||
| fullname_bp | ||
| fun_addr | ||
| fun_in_declare | ||
| funcall_param | ||
| funcall_ref | ||
| homonym | ||
| info_exc | ||
| info_locals_renaming | ||
| int_deref | ||
| interface | ||
| iwide | ||
| lang_switch | ||
| mi_catch_ex | ||
| mi_dyn_arr | ||
| mi_ex_cond | ||
| mi_exc_info | ||
| mi_interface | ||
| mi_task_arg | ||
| mi_task_info | ||
| mi_var_array | ||
| mod_from_name | ||
| n_arr_bound | ||
| nested | ||
| null_array | ||
| null_record | ||
| O2_float_param | ||
| operator_bp | ||
| optim_drec | ||
| out_of_line_in_inlined | ||
| packed_array | ||
| packed_tagged | ||
| pckd_arr_ren | ||
| pkd_arr_elem | ||
| pp-rec-component | ||
| print_chars | ||
| ptr_typedef | ||
| ptype_field | ||
| ptype_tagged_param | ||
| py_range | ||
| rdv_wait | ||
| rec_comp | ||
| rec_return | ||
| ref_param | ||
| ref_tick_size | ||
| same_enum | ||
| set_pckd_arr_elt | ||
| set_wstr | ||
| small_reg_param | ||
| start | ||
| str_ref_cmp | ||
| str_uninit | ||
| sym_print_name | ||
| taft_type | ||
| tagged | ||
| tagged_access | ||
| tagged_not_init | ||
| task_bp | ||
| tasks | ||
| tick_last_segv | ||
| tick_length_array_enum_idx | ||
| type_coercion | ||
| unc_arr_ptr_in_var_rec | ||
| uninitialized_vars | ||
| var_arr_attrs | ||
| var_rec_arr | ||
| variant_record_packed_array | ||
| watch_arg | ||
| whatis_array_val | ||
| widewide | ||
| win_fu_syms | ||
| addr_arith.exp | ||
| aliased_array.exp | ||
| arr_arr.exp | ||
| array_bounds.exp | ||
| array_char_idx.exp | ||
| array_return.exp | ||
| array_subscript_addr.exp | ||
| arraydim.exp | ||
| arrayidx.exp | ||
| arrayparam.exp | ||
| arrayptr.exp | ||
| assign_1.exp | ||
| atomic_enum.exp | ||
| bad-task-bp-keyword.exp | ||
| boolean_expr.exp | ||
| bp_enum_homonym.exp | ||
| bp_on_var.exp | ||
| bp_range_type.exp | ||
| bp_reset.exp | ||
| call_pn.exp | ||
| catch_ex.exp | ||
| char_enum.exp | ||
| char_param.exp | ||
| complete.exp | ||
| cond_lang.exp | ||
| disc_arr_bound.exp | ||
| dot_all.exp | ||
| dyn_arrayidx.exp | ||
| dyn_loc.exp | ||
| enum_idx_packed.exp | ||
| exec_changed.exp | ||
| expr_delims.exp | ||
| exprs.exp | ||
| fixed_cmp.exp | ||
| fixed_points.exp | ||
| float_param.exp | ||
| formatted_ref.exp | ||
| frame_args.exp | ||
| fullname_bp.exp | ||
| fun_addr.exp | ||
| fun_in_declare.exp | ||
| funcall_param.exp | ||
| funcall_ref.exp | ||
| gnat_ada.gpr | ||
| homonym.exp | ||
| info_exc.exp | ||
| info_locals_renaming.exp | ||
| info_types.c | ||
| info_types.exp | ||
| int_deref.exp | ||
| interface.exp | ||
| iwide.exp | ||
| lang_switch.exp | ||
| Makefile.in | ||
| mi_catch_ex.exp | ||
| mi_dyn_arr.exp | ||
| mi_ex_cond.exp | ||
| mi_exc_info.exp | ||
| mi_interface.exp | ||
| mi_task_arg.exp | ||
| mi_task_info.exp | ||
| mi_var_array.exp | ||
| mod_from_name.exp | ||
| n_arr_bound.exp | ||
| nested.exp | ||
| null_array.exp | ||
| null_record.exp | ||
| O2_float_param.exp | ||
| operator_bp.exp | ||
| optim_drec.exp | ||
| out_of_line_in_inlined.exp | ||
| packed_array.exp | ||
| packed_tagged.exp | ||
| pckd_arr_ren.exp | ||
| pkd_arr_elem.exp | ||
| pp-rec-component.exp | ||
| pp-rec-component.py | ||
| print_chars.exp | ||
| print_pc.exp | ||
| ptr_typedef.exp | ||
| ptype_arith_binop.exp | ||
| ptype_field.exp | ||
| ptype_tagged_param.exp | ||
| py_range.exp | ||
| rdv_wait.exp | ||
| rec_comp.exp | ||
| rec_return.exp | ||
| ref_param.exp | ||
| ref_tick_size.exp | ||
| same_enum.exp | ||
| set_pckd_arr_elt.exp | ||
| set_wstr.exp | ||
| small_reg_param.exp | ||
| start.exp | ||
| str_ref_cmp.exp | ||
| str_uninit.exp | ||
| sym_print_name.exp | ||
| taft_type.exp | ||
| tagged.exp | ||
| tagged_access.exp | ||
| tagged_not_init.exp | ||
| task_bp.exp | ||
| tasks.exp | ||
| tick_last_segv.exp | ||
| tick_length_array_enum_idx.exp | ||
| type_coercion.exp | ||
| unc_arr_ptr_in_var_rec.exp | ||
| uninitialized_vars.exp | ||
| var_arr_attrs.exp | ||
| var_rec_arr.exp | ||
| variant_record_packed_array.exp | ||
| watch_arg.exp | ||
| whatis_array_val.exp | ||
| widewide.exp | ||
| win_fu_syms.exp | ||