8d297bbf60
This patch fixes C++ build errors like this:
/home/pedro/gdb/mygit/cxx-convertion/src/gdb/linux-tdep.c:1126:35: error: invalid conversion from ‘int’ to ‘filterflags’ [-fpermissive]
| COREFILTER_HUGETLB_PRIVATE);
^
This is a case of enums used as bit flags. Unlike "regular" enums,
these values are supposed to be or'ed together. However, in C++, the
type of "(ENUM1 | ENUM2)" is int, and you then can't assign an int to
an enum variable without a cast. That means that this:
enum foo_flags flags = 0;
if (...)
flags |= FOO_FLAG1;
if (...)
flags |= FOO_FLAG2;
... would have to be written as:
enum foo_flags flags = (enum foo_flags) 0;
if (...)
flags = (enum foo_flags) (flags | FOO_FLAG1);
if (...)
flags = (enum foo_flags) (flags | FOO_FLAG2);
which is ... ugly. Alternatively, we'd have to use an int for the
variable's type, which isn't ideal either.
This patch instead adds an "enum flags" class. "enum flags" are
exactly the enums where the values are bits that are meant to be ORed
together.
This allows writing code like the below, while with raw enums this
would fail to compile without casts to enum type at the assignments to
'f':
enum some_flag
{
flag_val1 = 1 << 1,
flag_val2 = 1 << 2,
flag_val3 = 1 << 3,
flag_val4 = 1 << 4,
};
DEF_ENUM_FLAGS_TYPE(enum some_flag, some_flags)
some_flags f = flag_val1 | flag_val2;
f |= flag_val3;
It's also possible to assign literal zero to an enum flags variable
(meaning, no flags), dispensing either adding an awkward explicit "no
value" value to the enumeration or the cast to assignments from 0.
For example:
some_flags f = 0;
f |= flag_val3 | flag_val4;
Note that literal integers other than zero do fail to compile:
some_flags f = 1; // error
C is still supported -- DEF_ENUM_FLAGS_TYPE is just a typedef in that
case.
gdb/ChangeLog:
2015-11-17 Pedro Alves <palves@redhat.com>
* btrace.h: Include common/enum-flags.h.
(btrace_insn_flags): Define.
(struct btrace_insn) <flags>: Change type.
(btrace_function_flags): Define.
(struct btrace_function) <flags>: Change type.
(btrace_thread_flags): Define.
(struct btrace_thread_info) <flags>: Change type.
* c-exp.y (token_flags): Rename to ...
(token_flag): ... this.
(token_flags): Define.
(struct token) <flags>: Change type.
* common/enum-flags.h: New file.
* compile/compile-c-types.c (convert_qualified): Change type of
'quals' local.
* compile/compile-internal.h: Include "common/enum-flags.h".
(gcc_qualifiers_flags): Define.
* completer.c (enum reg_completer_targets): Rename to ...
(enum reg_completer_target): ... this.
(reg_completer_targets): Define.
(reg_or_group_completer_1): Change type of 'targets' parameter.
* disasm.c (do_mixed_source_and_assembly_deprecated): Change type
of 'psl_flags' local.
(do_mixed_source_and_assembly): Change type of 'psl_flags' local.
* infrun.c: Include "common/enum-flags.h".
(enum step_over_what): Rename to ...
(enum step_over_what_flag): ... this.
(step_over_what): Change type.
(start_step_over): Change type of 'step_what' local.
(thread_still_needs_step_over): Now returns a step_over_what.
Adjust.
(keep_going_pass_signal): Change type of 'step_what' local.
* linux-tdep.c: Include "common/enum-flags.h".
(enum filterflags): Rename to ...
(enum filter_flag): ... this.
(filter_flags): Define.
(dump_mapping_p): Change type of 'filterflags' parameter.
(linux_find_memory_regions_full): Change type of 'filterflags'
local.
(linux_find_memory_regions_full): Pass the address of an unsigned
int to sscanf instead of the address of an enum.
* record-btrace.c (btrace_print_lines): Change type of local
'psl_flags'.
(btrace_call_history): Replace 'flags' parameter
with 'int_flags' parameter. Adjust.
(record_btrace_call_history, record_btrace_call_history_range)
(record_btrace_call_history_from): Rename 'flags' parameter to
'int_flags'. Use record_print_flags.
* record.h: Include "common/enum-flags.h".
(record_print_flags): Define.
* source.c: Include "common/enum-flags.h".
(print_source_lines_base, print_source_lines): Change type of
flags parameter.
* symtab.h: Include "common/enum-flags.h".
(enum print_source_lines_flags): Rename to ...
(enum print_source_lines_flag): ... this.
(print_source_lines_flags): Define.
(print_source_lines): Change prototype.
155 lines
5 KiB
C
155 lines
5 KiB
C
/* Header file for GDB compile command and supporting functions.
|
|
Copyright (C) 2014-2015 Free Software Foundation, Inc.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#ifndef GDB_COMPILE_INTERNAL_H
|
|
#define GDB_COMPILE_INTERNAL_H
|
|
|
|
#include "hashtab.h"
|
|
#include "gcc-c-interface.h"
|
|
#include "common/enum-flags.h"
|
|
|
|
/* enum-flags wrapper. */
|
|
DEF_ENUM_FLAGS_TYPE (enum gcc_qualifiers, gcc_qualifiers_flags);
|
|
|
|
/* Debugging flag for the "compile" family of commands. */
|
|
|
|
extern int compile_debug;
|
|
|
|
struct block;
|
|
|
|
/* An object of this type holds state associated with a given
|
|
compilation job. */
|
|
|
|
struct compile_instance
|
|
{
|
|
/* The GCC front end. */
|
|
|
|
struct gcc_base_context *fe;
|
|
|
|
/* The "scope" of this compilation. */
|
|
|
|
enum compile_i_scope_types scope;
|
|
|
|
/* The block in which an expression is being parsed. */
|
|
|
|
const struct block *block;
|
|
|
|
/* Specify "-std=gnu11", "-std=gnu++11" or similar. These options are put
|
|
after CU's DW_AT_producer compilation options to override them. */
|
|
|
|
const char *gcc_target_options;
|
|
|
|
/* How to destroy this object. */
|
|
|
|
void (*destroy) (struct compile_instance *);
|
|
};
|
|
|
|
/* A subclass of compile_instance that is specific to the C front
|
|
end. */
|
|
struct compile_c_instance
|
|
{
|
|
/* Base class. Note that the base class vtable actually points to a
|
|
gcc_c_fe_vtable. */
|
|
|
|
struct compile_instance base;
|
|
|
|
/* Map from gdb types to gcc types. */
|
|
|
|
htab_t type_map;
|
|
|
|
/* Map from gdb symbols to gcc error messages to emit. */
|
|
|
|
htab_t symbol_err_map;
|
|
};
|
|
|
|
/* A helper macro that takes a compile_c_instance and returns its
|
|
corresponding gcc_c_context. */
|
|
|
|
#define C_CTX(I) ((struct gcc_c_context *) ((I)->base.fe))
|
|
|
|
/* Define header and footers for different scopes. */
|
|
|
|
/* A simple scope just declares a function named "_gdb_expr", takes no
|
|
arguments and returns no value. */
|
|
|
|
#define COMPILE_I_SIMPLE_REGISTER_STRUCT_TAG "__gdb_regs"
|
|
#define COMPILE_I_SIMPLE_REGISTER_ARG_NAME "__regs"
|
|
#define COMPILE_I_SIMPLE_REGISTER_DUMMY "_dummy"
|
|
#define COMPILE_I_PRINT_OUT_ARG_TYPE "void *"
|
|
#define COMPILE_I_PRINT_OUT_ARG "__gdb_out_param"
|
|
#define COMPILE_I_EXPR_VAL "__gdb_expr_val"
|
|
#define COMPILE_I_EXPR_PTR_TYPE "__gdb_expr_ptr_type"
|
|
|
|
/* Call gdbarch_register_name (GDBARCH, REGNUM) and convert its result
|
|
to a form suitable for the compiler source. The register names
|
|
should not clash with inferior defined macros. Returned pointer is
|
|
never NULL. Returned pointer needs to be deallocated by xfree. */
|
|
|
|
extern char *compile_register_name_mangled (struct gdbarch *gdbarch,
|
|
int regnum);
|
|
|
|
/* Convert compiler source register name to register number of
|
|
GDBARCH. Returned value is always >= 0, function throws an error
|
|
for non-matching REG_NAME. */
|
|
|
|
extern int compile_register_name_demangle (struct gdbarch *gdbarch,
|
|
const char *reg_name);
|
|
|
|
/* Convert a gdb type, TYPE, to a GCC type. CONTEXT is used to do the
|
|
actual conversion. The new GCC type is returned. */
|
|
|
|
struct type;
|
|
extern gcc_type convert_type (struct compile_c_instance *context,
|
|
struct type *type);
|
|
|
|
/* A callback suitable for use as the GCC C symbol oracle. */
|
|
|
|
extern gcc_c_oracle_function gcc_convert_symbol;
|
|
|
|
/* A callback suitable for use as the GCC C address oracle. */
|
|
|
|
extern gcc_c_symbol_address_function gcc_symbol_address;
|
|
|
|
/* Instantiate a GDB object holding state for the GCC context FE. The
|
|
new object is returned. */
|
|
|
|
extern struct compile_instance *new_compile_instance (struct gcc_c_context *fe);
|
|
|
|
/* Emit code to compute the address for all the local variables in
|
|
scope at PC in BLOCK. Returns a malloc'd vector, indexed by gdb
|
|
register number, where each element indicates if the corresponding
|
|
register is needed to compute a local variable. */
|
|
|
|
extern unsigned char *generate_c_for_variable_locations
|
|
(struct compile_c_instance *compiler,
|
|
struct ui_file *stream,
|
|
struct gdbarch *gdbarch,
|
|
const struct block *block,
|
|
CORE_ADDR pc);
|
|
|
|
/* Get the GCC mode attribute value for a given type size. */
|
|
|
|
extern const char *c_get_mode_for_size (int size);
|
|
|
|
/* Given a dynamic property, return an xmallocd name that is used to
|
|
represent its size. The result must be freed by the caller. The
|
|
contents of the resulting string will be the same each time for
|
|
each call with the same argument. */
|
|
|
|
struct dynamic_prop;
|
|
extern char *c_get_range_decl_name (const struct dynamic_prop *prop);
|
|
|
|
#endif /* GDB_COMPILE_INTERNAL_H */
|