old-cross-binutils/gdb/testsuite/gdb.ada
Pierre-Marie de Rodat d0d8478068 gdb/gdbtypes: fix handling of typedef layers between array types
When a dynamic array type contains a typedef-wrapped array, an assertion
failure occurs during type resolution.  This is what happens in the
following Ada case:

    type Rec_Type is record
       I : Integer;
       B : Boolean;
    end record;

    type Vec_Type is array (1 .. 4) of Rec_Type;

    type Array_Type is array (Positive range <>) of Vec_Type;

If users try to print or even pass to an inferior call a variable A of
type Array_Type, GDB will raise an error:

    (gdb) print a
    ../../src/gdb/gdbtypes.c:1807: internal-error:
    resolve_dynamic_array: Assertion `TYPE_CODE (type) ==
    TYPE_CODE_ARRAY' failed.
    A problem internal to GDB has been detected,
    further debugging may prove unreliable.
    Quit this debugging session? (y or n)

What happens is that during dynamic array type resolution, we first peel
TYPE_CODE_TYPEDEF layers wrapping the array element type and check if
its type is itself TYPE_CODE_ARRAY.  If it is, we pass the
typedef-wrapped type to a recursive call to resolve_dynamic_array
whereas this function expects only TYPE_CODE_ARRAY types.

This patch makes it pass the peeled type to the recursive call so that
type resolution can continue smoothly.

gdb/ChangeLog:

	* gdbtypes.c (resolve_dynamic_array): Pass the peeled element
	type to the recursive call instead of the original (maybe
	TYPE_CODE_TYPEDEF) type.

gdb/testsuite/ChangeLog:

	* gdb.ada/var_arr_typedef.exp: New testcase.
	* gdb.ada/var_arr_typedef/pack.adb: New file.
	* gdb.ada/var_arr_typedef/pack.ads: New file.
	* gdb.ada/var_arr_typedef/var_arr_typedef.adb: New file.
2015-07-23 14:59:58 +02:00
..
addr_arith
aliased_array
arr_arr
array_bounds
array_char_idx
array_return
array_subscript_addr
arraydim
arrayidx
arrayparam
arrayptr
atomic_enum
bad-task-bp-keyword
bp_enum_homonym
bp_on_var
bp_range_type
bp_reset
byte_packed_arr Non bit-packed packed arrays as variable-length fields 2015-05-15 14:00:57 -07:00
call_pn
catch_ex
char_enum
char_param
complete
cond_lang
disc_arr_bound
dot_all
dyn_arrayidx
dyn_loc
enum_idx_packed
exec_changed
expr_delims
exprs
fixed_cmp
fixed_points
float_param
formatted_ref
frame_args
fullname_bp
fun_addr
fun_in_declare
funcall_param
funcall_ref Do not consider reference types as dynamic 2015-04-03 15:23:49 +02:00
homonym
info_exc
info_locals_renaming
int_deref
interface
iwide
lang_switch
mi_catch_ex
mi_dyn_arr
mi_ex_cond
mi_exc_info
mi_interface
mi_task_arg
mi_task_info
mi_var_array
mod_from_name
n_arr_bound
nested
null_array
null_record
O2_float_param
operator_bp
optim_drec
out_of_line_in_inlined DWARF: cannot break on out-of-line function nested inside inlined function. 2015-05-05 11:06:09 -07:00
packed_array
packed_tagged
pckd_arr_ren
pckd_neg [Ada] problem printing negative integer values in packed arrays. 2015-05-15 07:37:15 -07:00
pkd_arr_elem
pp-rec-component
print_chars
ptr_typedef
ptype_field
ptype_tagged_param
py_range
rdv_wait
rec_comp [Ada] Preserve typedef layer when getting struct element 2015-04-27 11:04:47 +02:00
rec_return
ref_param
ref_tick_size
same_enum
set_pckd_arr_elt
set_wstr
small_reg_param
start
str_ref_cmp
str_uninit
sym_print_name
taft_type
tagged
tagged_access
tagged_not_init
task_bp
tasks
tick_last_segv
tick_length_array_enum_idx
type_coercion
unc_arr_ptr_in_var_rec
uninitialized_vars
var_arr_attrs
var_arr_typedef gdb/gdbtypes: fix handling of typedef layers between array types 2015-07-23 14:59:58 +02:00
var_rec_arr testsuite/gdb.ada/var_rec_arr: New testcase. 2015-05-05 10:48:21 -07:00
variant_record_packed_array
watch_arg
whatis_array_val
widewide
win_fu_syms
addr_arith.exp
aliased_array.exp
arr_arr.exp
array_bounds.exp
array_char_idx.exp
array_return.exp
array_subscript_addr.exp
arraydim.exp
arrayidx.exp
arrayparam.exp
arrayptr.exp
assign_1.exp
atomic_enum.exp
bad-task-bp-keyword.exp
boolean_expr.exp
bp_enum_homonym.exp
bp_on_var.exp
bp_range_type.exp
bp_reset.exp
byte_packed_arr.exp Non bit-packed packed arrays as variable-length fields 2015-05-15 14:00:57 -07:00
call_pn.exp
catch_ex.exp
char_enum.exp
char_param.exp
complete.exp
cond_lang.exp
disc_arr_bound.exp
dot_all.exp
dyn_arrayidx.exp
dyn_loc.exp
enum_idx_packed.exp
exec_changed.exp
expr_delims.exp
exprs.exp
fixed_cmp.exp
fixed_points.exp
float_param.exp
formatted_ref.exp
frame_args.exp
fullname_bp.exp
fun_addr.exp
fun_in_declare.exp
funcall_param.exp
funcall_ref.exp Do not consider reference types as dynamic 2015-04-03 15:23:49 +02:00
gnat_ada.gpr
homonym.exp
info_exc.exp gdb.ada/info_exc.exp: Adjust expected output in "info exception" test. 2015-07-20 15:18:24 -07:00
info_locals_renaming.exp
info_types.c
info_types.exp
int_deref.exp
interface.exp
iwide.exp
lang_switch.exp
Makefile.in
mi_catch_ex.exp
mi_dyn_arr.exp
mi_ex_cond.exp
mi_exc_info.exp
mi_interface.exp
mi_task_arg.exp
mi_task_info.exp
mi_var_array.exp
mod_from_name.exp
n_arr_bound.exp
nested.exp
null_array.exp
null_record.exp
O2_float_param.exp
operator_bp.exp
optim_drec.exp
out_of_line_in_inlined.exp out of line functions nested inside inline functions. 2015-05-05 11:08:14 -07:00
packed_array.exp
packed_tagged.exp
pckd_arr_ren.exp
pckd_neg.exp [Ada] problem printing negative integer values in packed arrays. 2015-05-15 07:37:15 -07:00
pkd_arr_elem.exp
pp-rec-component.exp
pp-rec-component.py
print_chars.exp
print_pc.exp
ptr_typedef.exp
ptype_arith_binop.exp
ptype_field.exp
ptype_tagged_param.exp
py_range.exp
rdv_wait.exp
rec_comp.exp [Ada] Preserve typedef layer when getting struct element 2015-04-27 11:04:47 +02:00
rec_return.exp
ref_param.exp
ref_tick_size.exp
same_enum.exp
set_pckd_arr_elt.exp
set_wstr.exp
small_reg_param.exp
start.exp
str_ref_cmp.exp
str_uninit.exp
sym_print_name.exp
taft_type.exp
tagged.exp
tagged_access.exp
tagged_not_init.exp
task_bp.exp
tasks.exp
tick_last_segv.exp
tick_length_array_enum_idx.exp
type_coercion.exp
unc_arr_ptr_in_var_rec.exp
uninitialized_vars.exp
var_arr_attrs.exp
var_arr_typedef.exp gdb/gdbtypes: fix handling of typedef layers between array types 2015-07-23 14:59:58 +02:00
var_rec_arr.exp testsuite/gdb.ada/var_rec_arr: New testcase. 2015-05-05 10:48:21 -07:00
variant_record_packed_array.exp
watch_arg.exp
whatis_array_val.exp
widewide.exp
win_fu_syms.exp