a8f077dc25
This patch updates tests for fork and exec events in target remote mode. In the majority of cases this was a simple matter of removing some code that disabled the test for target remote. In a few cases the test needed to be disabled; in those cases the gdb_protocol was checked instead of using the [is_remote target] etc. In a couple of cases we needed to use clean_restart, since target remote doesn't support the run command, and in one case we had to modify an expect expression to allow for a "multiprocess-style" ptid. Tested with the patch that implemented target remote mode fork and exec event support. gdb/testsuite/ChangeLog: * gdb.base/execl-update-breakpoints.exp (main): Enable for target remote. * gdb.base/foll-exec-mode.exp (main): Disable for target remote. * gdb.base/foll-exec.exp (main): Enable for target remote. * gdb.base/foll-fork.exp (main): Likewise. * gdb.base/foll-vfork.exp (main): Likewise. * gdb.base/multi-forks.exp (main): Likewise, and use clean_restart. (proc continue_to_exit_bp_loc): Use clean_restart. * gdb.base/pie-execl.exp (main): Disable for target remote. * gdb.base/watch-vfork.exp (main): Enable for target remote. * gdb.mi/mi-nsthrexec.exp (main): Likewise. * gdb.threads/execl.exp (main): Likewise. * gdb.threads/fork-child-threads.exp (main): Likewise. * gdb.threads/fork-plus-threads.exp (main): Disable for target remote. * gdb.threads/fork-thread-pending.exp (main): Enable for target remote. * gdb.threads/linux-dp.exp (check_philosopher_stack): Allow pid.tid style ptids, instead of just tid. * gdb.threads/thread-execl.exp (main): Enable for target remote. * gdb.threads/watchpoint-fork.exp (main): Likewise. * gdb.trace/report.exp (use_collected_data): Allow pid.tid style ptids, instead of just tid.
112 lines
3.4 KiB
Text
112 lines
3.4 KiB
Text
# Copyright (C) 2015 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# This test verifies that threads created by the child fork are
|
|
# properly handled. Specifically, GDB used to have a bug where it
|
|
# would leave child fork threads stuck stopped, even though "info
|
|
# threads" would show them running.
|
|
#
|
|
# See https://sourceware.org/bugzilla/show_bug.cgi?id=18600
|
|
|
|
# In remote mode, we cannot continue debugging after all
|
|
# inferiors have terminated, and this test requires that.
|
|
if { [target_info exists gdb_protocol]
|
|
&& [target_info gdb_protocol] == "remote" } {
|
|
continue
|
|
}
|
|
|
|
standard_testfile
|
|
|
|
proc do_test { detach_on_fork } {
|
|
global GDBFLAGS
|
|
global srcfile testfile
|
|
global gdb_prompt
|
|
|
|
set saved_gdbflags $GDBFLAGS
|
|
set GDBFLAGS [concat $GDBFLAGS " -ex \"set non-stop on\""]
|
|
|
|
if {[prepare_for_testing "failed to prepare" \
|
|
$testfile $srcfile {debug pthreads}] == -1} {
|
|
set GDBFLAGS $saved_gdbflags
|
|
return -1
|
|
}
|
|
|
|
set GDBFLAGS $saved_gdbflags
|
|
|
|
if ![runto_main] then {
|
|
fail "Can't run to main"
|
|
return 0
|
|
}
|
|
|
|
gdb_test_no_output "set detach-on-fork $detach_on_fork"
|
|
set test "continue &"
|
|
gdb_test_multiple $test $test {
|
|
-re "$gdb_prompt " {
|
|
pass $test
|
|
}
|
|
}
|
|
|
|
# gdbserver had a bug that resulted in reporting the fork child's
|
|
# initial stop to gdb, which gdb does not expect, in turn
|
|
# resulting in a broken session, like:
|
|
#
|
|
# [Thread 31536.31536] #16 stopped. <== BAD
|
|
# [New Thread 31547.31547]
|
|
# [Inferior 10 (process 31536) exited normally]
|
|
# [New Thread 31547.31560]
|
|
#
|
|
# [Thread 31547.31547] #18 stopped. <== BAD
|
|
# Cannot remove breakpoints because program is no longer writable. <== BAD
|
|
# Further execution is probably impossible. <== BAD
|
|
# [Inferior 11 (process 31547) exited normally]
|
|
# [Inferior 1 (process 31454) exited normally]
|
|
#
|
|
# These variables track whether we see such broken behavior.
|
|
set saw_cannot_remove_breakpoints 0
|
|
set saw_thread_stopped 0
|
|
|
|
set test "inferior 1 exited"
|
|
gdb_test_multiple "" $test {
|
|
-re "Cannot remove breakpoints" {
|
|
set saw_cannot_remove_breakpoints 1
|
|
exp_continue
|
|
}
|
|
-re "Thread \[^\r\n\]+ stopped\\." {
|
|
set saw_thread_stopped 1
|
|
exp_continue
|
|
}
|
|
-re "Inferior 1 \(\[^\r\n\]+\) exited normally" {
|
|
pass $test
|
|
}
|
|
}
|
|
|
|
gdb_assert !$saw_cannot_remove_breakpoints \
|
|
"no failure to remove breakpoints"
|
|
gdb_assert !$saw_thread_stopped \
|
|
"no spurious thread stop"
|
|
|
|
gdb_test "info threads" "No threads\." \
|
|
"no threads left"
|
|
|
|
gdb_test "info inferiors" \
|
|
"Num\[ \t\]+Description\[ \t\]+Executable\[ \t\]+\r\n\\* 1 \[^\r\n\]+" \
|
|
"only inferior 1 left"
|
|
}
|
|
|
|
foreach detach_on_fork {"on" "off"} {
|
|
with_test_prefix "detach-on-fork=$detach_on_fork" {
|
|
do_test $detach_on_fork
|
|
}
|
|
}
|