7ae1a6a6cc
On Linux, we need to explicitly ptrace attach to all lwps of a process. Because GDB might not be connected yet when an attach is requested, and thus it may not be possible to activate thread_db, as that requires access to symbols (IOW, gdbserver --attach), a while ago we make linux_attach loop over the lwps as listed by /proc/PID/task to find the lwps to attach to. linux_attach_lwp_1 has: ... if (initial) /* If lwp is the tgid, we handle adding existing threads later. Otherwise we just add lwp without bothering about any other threads. */ ptid = ptid_build (lwpid, lwpid, 0); else { /* Note that extracting the pid from the current inferior is safe, since we're always called in the context of the same process as this new thread. */ int pid = pid_of (current_inferior); ptid = ptid_build (pid, lwpid, 0); } That "safe" comment referred to linux_attach_lwp being called by thread-db.c. But this was clearly missed when a new call to linux_attach_lwp_1 was added to linux_attach. As a result, current_inferior will be set to some random process, and non-initial lwps of the second inferior get assigned the pid of the wrong inferior. E.g., in the case of attaching to two inferiors, for the second inferior (and so on), non-initial lwps of the second inferior get assigned the pid of the first inferior. This doesn't trigger on the first inferior, when current_inferior is NULL, add_thread switches the current inferior to the newly added thread. Rather than making linux_attach switch current_inferior temporarily (thus avoiding further reliance on global state), or making linux_attach_lwp_1 get the tgid from /proc, which add extra syscalls, and will be wrong in case of the user having originally attached directly to a non-tgid lwp, and then that lwp spawning new clones (the ptid.pid field of further new clones should be the same as the original lwp's pid, which is not the tgid), we note that callers of linux_attach_lwp/linux_attach_lwp_1 always have the right pid handy already, so they can pass it down along with the lwpid. The only other reason for the "initial" parameter is to error out instead of warn in case of attach failure, when we're first attaching to a process. There are only three callers of linux_attach_lwp/linux_attach_lwp_1, and each wants to print a different warn/error string, so we can just move the error/warn out of linux_attach_lwp_1 to the callers, thus getting rid of the "initial" parameter. There really nothing gdbserver-specific about attaching to two threaded processes, so this adds a new test under gdb.multi/. The test passes cleanly against the native GNU/Linux target, but fails/triggers the bug against GDBserver (before the patch), with the native-extended-remote board (as plain remote doesn't support multi-process). Tested on x86_64 Fedora 17, with the native-extended-gdbserver board. gdb/gdbserver/ 2014-04-25 Pedro Alves <palves@redhat.com> PR server/16255 * linux-low.c (linux_attach_fail_reason_string): New function. (linux_attach_lwp): Delete. (linux_attach_lwp_1): Rename to ... (linux_attach_lwp): ... this. Take a ptid instead of a pid as argument. Remove "initial" parameter. Return int instead of void. Don't error or warn here. (linux_attach): Adjust to call linux_attach_lwp. Call error on failure to attach to the tgid. Call warning when failing to attach to an lwp. * linux-low.h (linux_attach_lwp): Take a ptid instead of a pid as argument. Remove "initial" parameter. Return int instead of void. Don't error or warn here. (linux_attach_fail_reason_string): New declaration. * thread-db.c (attach_thread): Adjust to linux_attach_lwp's interface change. Use linux_attach_fail_reason_string. gdb/ 2014-04-25 Pedro Alves <palves@redhat.com> PR server/16255 * common/linux-ptrace.c (linux_ptrace_attach_warnings): Rename to ... (linux_ptrace_attach_fail_reason): ... this. Remove "warning: " and newline from built string. * common/linux-ptrace.h (linux_ptrace_attach_warnings): Rename to ... (linux_ptrace_attach_fail_reason): ... this. * linux-nat.c (linux_nat_attach): Adjust to use linux_ptrace_attach_fail_reason. gdb/testsuite/ 2014-04-25 Simon Marchi <simon.marchi@ericsson.com> Pedro Alves <palves@redhat.com> PR server/16255 * gdb.multi/multi-attach.c: New file. * gdb.multi/multi-attach.exp: New file. |
||
---|---|---|
.. | ||
.gitignore | ||
acinclude.m4 | ||
aclocal.m4 | ||
ax.c | ||
ax.h | ||
ChangeLog | ||
config.in | ||
configure | ||
configure.ac | ||
configure.srv | ||
debug.c | ||
debug.h | ||
dll.c | ||
dll.h | ||
event-loop.c | ||
event-loop.h | ||
gdb_proc_service.h | ||
gdbreplay.c | ||
gdbthread.h | ||
hostio-errno.c | ||
hostio.c | ||
hostio.h | ||
i386-low.c | ||
i386-low.h | ||
i387-fp.c | ||
i387-fp.h | ||
inferiors.c | ||
inferiors.h | ||
linux-aarch64-low.c | ||
linux-amd64-ipa.c | ||
linux-arm-low.c | ||
linux-bfin-low.c | ||
linux-cris-low.c | ||
linux-crisv32-low.c | ||
linux-i386-ipa.c | ||
linux-ia64-low.c | ||
linux-low.c | ||
linux-low.h | ||
linux-m32r-low.c | ||
linux-m68k-low.c | ||
linux-mips-low.c | ||
linux-nios2-low.c | ||
linux-ppc-low.c | ||
linux-s390-low.c | ||
linux-sh-low.c | ||
linux-sparc-low.c | ||
linux-tic6x-low.c | ||
linux-tile-low.c | ||
linux-x86-low.c | ||
linux-xtensa-low.c | ||
lynx-i386-low.c | ||
lynx-low.c | ||
lynx-low.h | ||
lynx-ppc-low.c | ||
Makefile.in | ||
mem-break.c | ||
mem-break.h | ||
notif.c | ||
notif.h | ||
nto-low.c | ||
nto-low.h | ||
nto-x86-low.c | ||
proc-service.c | ||
proc-service.list | ||
README | ||
regcache.c | ||
regcache.h | ||
remote-utils.c | ||
remote-utils.h | ||
server.c | ||
server.h | ||
spu-low.c | ||
target.c | ||
target.h | ||
tdesc.c | ||
tdesc.h | ||
terminal.h | ||
thread-db.c | ||
tracepoint.c | ||
tracepoint.h | ||
utils.c | ||
utils.h | ||
win32-arm-low.c | ||
win32-i386-low.c | ||
win32-low.c | ||
win32-low.h | ||
wincecompat.c | ||
wincecompat.h | ||
xtensa-xtregs.c |
README for GDBserver & GDBreplay by Stu Grossman and Fred Fish Introduction: This is GDBserver, a remote server for Un*x-like systems. It can be used to control the execution of a program on a target system from a GDB on a different host. GDB and GDBserver communicate using the standard remote serial protocol implemented in remote.c, and various *-stub.c files. They communicate via either a serial line or a TCP connection. For more information about GDBserver, see the GDB manual. Usage (server (target) side): First, you need to have a copy of the program you want to debug put onto the target system. The program can be stripped to save space if needed, as GDBserver doesn't care about symbols. All symbol handling is taken care of by the GDB running on the host system. To use the server, you log on to the target system, and run the `gdbserver' program. You must tell it (a) how to communicate with GDB, (b) the name of your program, and (c) its arguments. The general syntax is: target> gdbserver COMM PROGRAM [ARGS ...] For example, using a serial port, you might say: target> gdbserver /dev/com1 emacs foo.txt This tells GDBserver to debug emacs with an argument of foo.txt, and to communicate with GDB via /dev/com1. GDBserver now waits patiently for the host GDB to communicate with it. To use a TCP connection, you could say: target> gdbserver host:2345 emacs foo.txt This says pretty much the same thing as the last example, except that we are going to communicate with the host GDB via TCP. The `host:2345' argument means that we are expecting to see a TCP connection from `host' to local TCP port 2345. (Currently, the `host' part is ignored.) You can choose any number you want for the port number as long as it does not conflict with any existing TCP ports on the target system. This same port number must be used in the host GDBs `target remote' command, which will be described shortly. Note that if you chose a port number that conflicts with another service, GDBserver will print an error message and exit. On some targets, GDBserver can also attach to running programs. This is accomplished via the --attach argument. The syntax is: target> gdbserver --attach COMM PID PID is the process ID of a currently running process. It isn't necessary to point GDBserver at a binary for the running process. Usage (host side): You need an unstripped copy of the target program on your host system, since GDB needs to examine it's symbol tables and such. Start up GDB as you normally would, with the target program as the first argument. (You may need to use the --baud option if the serial line is running at anything except 9600 baud.) Ie: `gdb TARGET-PROG', or `gdb --baud BAUD TARGET-PROG'. After that, the only new command you need to know about is `target remote'. It's argument is either a device name (usually a serial device, like `/dev/ttyb'), or a HOST:PORT descriptor. For example: (gdb) target remote /dev/ttyb communicates with the server via serial line /dev/ttyb, and: (gdb) target remote the-target:2345 communicates via a TCP connection to port 2345 on host `the-target', where you previously started up GDBserver with the same port number. Note that for TCP connections, you must start up GDBserver prior to using the `target remote' command, otherwise you may get an error that looks something like `Connection refused'. Building GDBserver: The supported targets as of November 2006 are: arm-*-linux* bfin-*-uclinux bfin-*-linux-uclibc crisv32-*-linux* cris-*-linux* i[34567]86-*-cygwin* i[34567]86-*-linux* i[34567]86-*-mingw* ia64-*-linux* m32r*-*-linux* m68*-*-linux* m68*-*-uclinux* mips*64*-*-linux* mips*-*-linux* powerpc[64]-*-linux* s390[x]-*-linux* sh-*-linux* spu*-*-* x86_64-*-linux* Configuring GDBserver you should specify the same machine for host and target (which are the machine that GDBserver is going to run on. This is not the same as the machine that GDB is going to run on; building GDBserver automatically as part of building a whole tree of tools does not currently work if cross-compilation is involved (we don't get the right CC in the Makefile, to start with)). Building GDBserver for your target is very straightforward. If you build GDB natively on a target which GDBserver supports, it will be built automatically when you build GDB. You can also build just GDBserver: % mkdir obj % cd obj % path-to-gdbserver-sources/configure % make If you prefer to cross-compile to your target, then you can also build GDBserver that way. In a Bourne shell, for example: % export CC=your-cross-compiler % path-to-gdbserver-sources/configure your-target-name % make Using GDBreplay: A special hacked down version of GDBserver can be used to replay remote debug log files created by GDB. Before using the GDB "target" command to initiate a remote debug session, use "set remotelogfile <filename>" to tell GDB that you want to make a recording of the serial or tcp session. Note that when replaying the session, GDB communicates with GDBreplay via tcp, regardless of whether the original session was via a serial link or tcp. Once you are done with the remote debug session, start GDBreplay and tell it the name of the log file and the host and port number that GDB should connect to (typically the same as the host running GDB): $ gdbreplay logfile host:port Then start GDB (preferably in a different screen or window) and use the "target" command to connect to GDBreplay: (gdb) target remote host:port Repeat the same sequence of user commands to GDB that you gave in the original debug session. GDB should not be able to tell that it is talking to GDBreplay rather than a real target, all other things being equal. Note that GDBreplay echos the command lines to stderr, as well as the contents of the packets it sends and receives. The last command echoed by GDBreplay is the next command that needs to be typed to GDB to continue the session in sync with the original session.