6f937416b9
This is sort of a continuation of Keith's parse_exp_1 constification patch. It started out by undoing these bits: @@ -754,9 +754,12 @@ validate_actionline (char **line, struct tmp_p = p; for (loc = t->base.loc; loc; loc = loc->next) { - p = tmp_p; - exp = parse_exp_1 (&p, loc->address, + const char *q; + + q = tmp_p; + exp = parse_exp_1 (&q, loc->address, block_for_pc (loc->address), 1); + p = (char *) q; and progressively making more things const upwards, fixing fallout, rinse repeat, until GDB built again (--enable-targets=all). That ended up constifying lookup_cmd/add_cmd and (lots of) friends, and the completers. I didn't try to constify the command hooks themselves, because I know upfront there are commands that write to the command string argument, and I think I managed to stop at a nice non-hacky split point already. I think the only non-really-super-obvious changes are tracepoint.c:validate_actionline, and tracepoint.c:trace_dump_actions. The rest is just mostly about 'char *' => 'const char *', 'char **'=> 'const char **', and the occasional (e.g., deprecated_cmd_warning) case of 'char **'=> 'const char *', where/when I noticed that nothing actually cares about the pointer to pointer output. Tested on x86_64 Fedora 17, native and gdbserver. gdb/ 2013-03-13 Pedro Alves <palves@redhat.com> * ada-lang.c (struct add_partial_datum) <text, text0, word>: Make fields const. (ada_make_symbol_completion_list): Make "text0" parameter const. * ax-gdb.c (agent_eval_command_one): Make "exp" parameter const. * breakpoint.c (condition_completer): Make "text" and "word" parameters const. Adjust. (check_tracepoint_command): Adjust to validate_actionline prototype change. (catch_syscall_completer): Make "text" and "word" parameters const. * cli/cli-cmds.c (show_user): Make "comname" local const. (valid_command_p): Make "command" parameter const. (alias_command): Make "alias_prefix" and "command_prefix" locals const. * cli/cli-decode.c (add_cmd): Make "name" parameter const. (add_alias_cmd): Make "name" and "oldname" parameters const. Adjust. No longer make copy of OLDNAME. (add_prefix_cmd, add_abbrev_prefix_cmd, add_set_or_show_cmd) (add_setshow_cmd_full, add_setshow_enum_cmd) (add_setshow_auto_boolean_cmd, add_setshow_boolean_cmd) (add_setshow_filename_cmd, add_setshow_string_cmd) (add_setshow_string_noescape_cmd) (add_setshow_optional_filename_cmd, add_setshow_integer_cmd) (add_setshow_uinteger_cmd, add_setshow_zinteger_cmd) (add_setshow_zuinteger_unlimited_cmd, add_setshow_zuinteger_cmd) (delete_cmd, add_info, add_info_alias, add_com, add_com_alias): Make "name" parameter const. (help_cmd): Rename "command" parameter to "arg". New const local "command". (find_cmd): Make "command" parameter const. (lookup_cmd_1): Make "text" parameter pointer to const. Adjust to deprecated_cmd_warning prototype change. (undef_cmd_error): Make "cmdtype" parameter const. (lookup_cmd): Make "line" parameter const. (deprecated_cmd_warning): Change type of "text" parameter to pointer to const char, from pointer to pointer to char. Adjust. (lookup_cmd_composition): Make "text" parameter const. (complete_on_cmdlist, complete_on_enum): Make "text" and "word" parameters const. * cli/cli-decode.h (struct cmd_list_element) <name>: Make field const. * cli/cli-script.c (validate_comname): Make "tem" local const. (define_command): New const local "tem_c". Use it in calls to lookup_cmd. (document_command): Make "tem" and "comfull" locals const. (show_user_1): Make "prefix" and "name" parameters const. * cli-script.h (show_user_1): Make "prefix" and "name" parameters const. * command.h (add_cmd, add_alias_cmd, add_prefix_cmd) (add_abbrev_prefix_cmd, completer_ftype, lookup_cmd, lookup_cmd_1) (deprecated_cmd_warning, lookup_cmd_composition, add_com) (add_com_alias, add_info, add_info_alias, complete_on_cmdlist) (complete_on_enum, add_setshow_enum_cmd) (add_setshow_auto_boolean_cmd, add_setshow_boolean_cmd) (add_setshow_filename_cmd, add_setshow_string_cmd) (add_setshow_string_noescape_cmd) (add_setshow_optional_filename_cmd, add_setshow_integer_cmd) (add_setshow_uinteger_cmd, add_setshow_zinteger_cmd) (add_setshow_zuinteger_cmd, add_setshow_zuinteger_unlimited_cmd): Change prototypes, constifying strings. * completer.c (noop_completer, filename_completer): Make "text" and "prefix" parameters const. (location_completer, expression_completer) (complete_line_internal): Make "text" and "prefix" parameters const and adjust. (command_completer, signal_completer): Make "text" and "prefix" parameters const. * completer.h (noop_completer, filename_completer) (expression_completer, location_completer, command_completer) (signal_completer): Change prototypes. * corefile.c (complete_set_gnutarget): Make "text" and "word" parameters const. * cp-abi.c (cp_abi_completer): Likewise. * expression.h (parse_expression_for_completion): Change prototype. * f-lang.c (f_make_symbol_completion_list): Make "text" and "word" parameters const. * infcmd.c (_initialize_infcmd): Make "cmd_name" local const. * infrun.c (handle_completer): Make "text" and "word" parameters const. * interps.c (interpreter_completer): Make "text" and "word" parameters const. * language.h (struct language_defn) <la_make_symbol_completion_list>: Make "text" and "word" parameters const. * parse.c (parse_exp_1): Move const hack to parse_exp_in_context. (parse_exp_in_context): Rename to ... (parse_exp_in_context_1): ... this. (parse_exp_in_context): Reimplement, with const hack from parse_exp_1. (parse_expression_for_completion): Make "string" parameter const. * printcmd.c (decode_format): Make "string_ptr" parameter pointer to pointer to const char. Adjust. (print_command_1): Make "exp" parameter const. (output_command): Rename to ... (output_command_const): ... this. Make "exp" parameter const. (output_command): Reimplement. (x_command): Adjust. (display_command): Rename "exp" parameter to "arg". New "exp" local, const version of "arg". * python/py-auto-load.c (gdbpy_initialize_auto_load): Make "cmd_name" local const. * python/py-cmd.c (cmdpy_destroyer): Cast const away in xfree call. (cmdpy_completer): Make "text" and "word" parameters const. (gdbpy_parse_command_name): Make "prefix_text2" local const. * python/py-param.c (add_setshow_generic): Make "tmp_name" local const. * remote.c (_initialize_remote): Make "cmd_name" local const. * symtab.c (language_search_unquoted_string): Make "text" and "p" parameters const. Adjust. (completion_list_add_fields): Make "sym_text", "text" and "word" parameters const. (struct add_name_data) <sym_text, text, word>: Make fields const. (default_make_symbol_completion_list_break_on): Make "text" and "word" parameters const. Adjust locals. (default_make_symbol_completion_list) (make_symbol_completion_list, make_symbol_completion_type) (make_symbol_completion_list_fn): Make "text" and "word" parameters const. (make_file_symbol_completion_list): Make "text", "word" and "srcfile" parameters const. Adjust locals. (add_filename_to_list): Make "text" and "word" parameters const. (struct add_partial_filename_data) <text, word>: Make fields const. (make_source_files_completion_list): Make "text" and "word" parameters const. * symtab.h (default_make_symbol_completion_list_break_on) (default_make_symbol_completion_list, make_symbol_completion_list) (make_symbol_completion_type enum type_code) (make_symbol_completion_list_fn make_file_symbol_completion_list) (make_source_files_completion_list): Change prototype. * top.c (execute_command): Adjust to pass pointer to pointer to const char to lookup_cmd, and to deprecated_cmd_warning prototype change. (set_verbose): Make "cmdname" local const. * tracepoint.c (decode_agent_options): Make "exp" parameter const, and adjust. (validate_actionline): Make "line" parameter a pointer to const char, and adjust. (encode_actions_1): Make "action_exp" local const, and adjust. (encode_actions): Adjust. (replace_comma): Delete. (trace_dump_actions): Make "action_exp" and "next_comma" locals const, and adjust. Don't frob the action string while splitting it at commas. Instead, make a copy of each split substring in turn. (trace_dump_command): Adjust to validate_actionline prototype change. * tracepoint.h (decode_agent_options, decode_agent_options) (encode_actions, validate_actionline): Change prototypes. * valprint.h (output_command): Delete declaration. (output_command_const): Declare. * value.c (function_destroyer): Cast const away in xfree call.
291 lines
8.7 KiB
C
291 lines
8.7 KiB
C
/* Data structures associated with tracepoints in GDB.
|
|
Copyright (C) 1997-2013 Free Software Foundation, Inc.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#if !defined (TRACEPOINT_H)
|
|
#define TRACEPOINT_H 1
|
|
|
|
#include "breakpoint.h"
|
|
#include "target.h"
|
|
#include "memrange.h"
|
|
#include "gdb_vecs.h"
|
|
|
|
/* A trace state variable is a value managed by a target being
|
|
traced. A trace state variable (or tsv for short) can be accessed
|
|
and assigned to by tracepoint actions and conditionals, but is not
|
|
part of the program being traced, and it doesn't have to be
|
|
collected. Effectively the variables are scratch space for
|
|
tracepoints. */
|
|
|
|
struct trace_state_variable
|
|
{
|
|
/* The variable's name. The user has to prefix with a dollar sign,
|
|
but we don't store that internally. */
|
|
const char *name;
|
|
|
|
/* An id number assigned by GDB, and transmitted to targets. */
|
|
int number;
|
|
|
|
/* The initial value of a variable is a 64-bit signed integer. */
|
|
LONGEST initial_value;
|
|
|
|
/* 1 if the value is known, else 0. The value is known during a
|
|
trace run, or in tfind mode if the variable was collected into
|
|
the current trace frame. */
|
|
int value_known;
|
|
|
|
/* The value of a variable is a 64-bit signed integer. */
|
|
LONGEST value;
|
|
|
|
/* This is true for variables that are predefined and built into
|
|
the target. */
|
|
int builtin;
|
|
};
|
|
|
|
/* The trace status encompasses various info about the general state
|
|
of the tracing run. */
|
|
|
|
enum trace_stop_reason
|
|
{
|
|
trace_stop_reason_unknown,
|
|
trace_never_run,
|
|
tstop_command,
|
|
trace_buffer_full,
|
|
trace_disconnected,
|
|
tracepoint_passcount,
|
|
tracepoint_error
|
|
};
|
|
|
|
struct trace_status
|
|
{
|
|
/* If the status is coming from a file rather than a live target,
|
|
this points at the file's filename. Otherwise, this is NULL. */
|
|
const char *filename;
|
|
|
|
/* This is true if the value of the running field is known. */
|
|
int running_known;
|
|
|
|
/* This is true when the trace experiment is actually running. */
|
|
int running;
|
|
|
|
enum trace_stop_reason stop_reason;
|
|
|
|
/* If stop_reason is tracepoint_passcount or tracepoint_error, this
|
|
is the (on-target) number of the tracepoint which caused the
|
|
stop. */
|
|
int stopping_tracepoint;
|
|
|
|
/* If stop_reason is tstop_command or tracepoint_error, this is an
|
|
arbitrary string that may describe the reason for the stop in
|
|
more detail. */
|
|
|
|
char *stop_desc;
|
|
|
|
/* Number of traceframes currently in the buffer. */
|
|
|
|
int traceframe_count;
|
|
|
|
/* Number of traceframes created since start of run. */
|
|
|
|
int traceframes_created;
|
|
|
|
/* Total size of the target's trace buffer. */
|
|
|
|
int buffer_size;
|
|
|
|
/* Unused bytes left in the target's trace buffer. */
|
|
|
|
int buffer_free;
|
|
|
|
/* 1 if the target will continue tracing after disconnection, else
|
|
0. If the target does not report a value, assume 0. */
|
|
|
|
int disconnected_tracing;
|
|
|
|
/* 1 if the target is using a circular trace buffer, else 0. If the
|
|
target does not report a value, assume 0. */
|
|
|
|
int circular_buffer;
|
|
|
|
/* The "name" of the person running the trace. This is an
|
|
arbitrary string. */
|
|
|
|
char *user_name;
|
|
|
|
/* "Notes" about the trace. This is an arbitrary string not
|
|
interpreted by GDBserver in any special way. */
|
|
|
|
char *notes;
|
|
|
|
/* The calendar times at which the trace run started and stopped,
|
|
both expressed in microseconds of Unix time. */
|
|
|
|
LONGEST start_time;
|
|
LONGEST stop_time;
|
|
};
|
|
|
|
struct trace_status *current_trace_status (void);
|
|
|
|
extern char *default_collect;
|
|
|
|
/* Struct to collect random info about tracepoints on the target. */
|
|
|
|
struct uploaded_tp
|
|
{
|
|
int number;
|
|
enum bptype type;
|
|
ULONGEST addr;
|
|
int enabled;
|
|
int step;
|
|
int pass;
|
|
int orig_size;
|
|
|
|
/* String that is the encoded form of the tracepoint's condition. */
|
|
char *cond;
|
|
|
|
/* Vectors of strings that are the encoded forms of a tracepoint's
|
|
actions. */
|
|
VEC(char_ptr) *actions;
|
|
VEC(char_ptr) *step_actions;
|
|
|
|
/* The original string defining the location of the tracepoint. */
|
|
char *at_string;
|
|
|
|
/* The original string defining the tracepoint's condition. */
|
|
char *cond_string;
|
|
|
|
/* List of original strings defining the tracepoint's actions. */
|
|
VEC(char_ptr) *cmd_strings;
|
|
|
|
/* The tracepoint's current hit count. */
|
|
int hit_count;
|
|
|
|
/* The tracepoint's current traceframe usage. */
|
|
ULONGEST traceframe_usage;
|
|
|
|
struct uploaded_tp *next;
|
|
};
|
|
|
|
/* Struct recording info about trace state variables on the target. */
|
|
|
|
struct uploaded_tsv
|
|
{
|
|
const char *name;
|
|
int number;
|
|
LONGEST initial_value;
|
|
int builtin;
|
|
struct uploaded_tsv *next;
|
|
};
|
|
|
|
/* Struct recording info about a target static tracepoint marker. */
|
|
|
|
struct static_tracepoint_marker
|
|
{
|
|
struct gdbarch *gdbarch;
|
|
CORE_ADDR address;
|
|
|
|
/* The string ID of the marker. */
|
|
char *str_id;
|
|
|
|
/* Extra target reported info associated with the marker. */
|
|
char *extra;
|
|
};
|
|
|
|
extern void parse_static_tracepoint_marker_definition
|
|
(char *line, char **pp,
|
|
struct static_tracepoint_marker *marker);
|
|
extern void release_static_tracepoint_marker (struct static_tracepoint_marker *);
|
|
extern void free_current_marker (void *arg);
|
|
|
|
/* A hook used to notify the UI of tracepoint operations. */
|
|
|
|
extern void (*deprecated_trace_find_hook) (char *arg, int from_tty);
|
|
extern void (*deprecated_trace_start_stop_hook) (int start, int from_tty);
|
|
|
|
/* Returns the current traceframe number. */
|
|
extern int get_traceframe_number (void);
|
|
|
|
/* Make the traceframe NUM be the current GDB trace frame number, and
|
|
do nothing more. In particular, this does not flush the
|
|
register/frame caches or notify the target about the trace frame
|
|
change, so that is can be used when we need to momentarily access
|
|
live memory. Targets lazily switch their current traceframe to
|
|
match GDB's traceframe number, at the appropriate times. */
|
|
extern void set_traceframe_number (int);
|
|
|
|
/* Make the traceframe NUM be the current trace frame, all the way to
|
|
the target, and flushes all global state (register/frame caches,
|
|
etc.). */
|
|
extern void set_current_traceframe (int num);
|
|
|
|
struct cleanup *make_cleanup_restore_current_traceframe (void);
|
|
struct cleanup *make_cleanup_restore_traceframe_number (void);
|
|
|
|
void free_actions (struct breakpoint *);
|
|
|
|
extern const char *decode_agent_options (const char *exp);
|
|
|
|
extern void encode_actions (struct breakpoint *t, struct bp_location *tloc,
|
|
char ***tdp_actions, char ***stepping_actions);
|
|
|
|
extern void validate_actionline (const char *, struct breakpoint *);
|
|
extern void validate_trace_state_variable_name (const char *name);
|
|
|
|
extern struct trace_state_variable *find_trace_state_variable (const char *name);
|
|
extern struct trace_state_variable *create_trace_state_variable (const char *name);
|
|
|
|
extern int encode_source_string (int num, ULONGEST addr,
|
|
char *srctype, char *src,
|
|
char *buf, int buf_size);
|
|
|
|
extern void parse_trace_status (char *line, struct trace_status *ts);
|
|
|
|
extern void parse_tracepoint_status (char *p, struct breakpoint *tp,
|
|
struct uploaded_tp *utp);
|
|
|
|
extern void parse_tracepoint_definition (char *line,
|
|
struct uploaded_tp **utpp);
|
|
extern void parse_tsv_definition (char *line, struct uploaded_tsv **utsvp);
|
|
|
|
extern struct uploaded_tp *get_uploaded_tp (int num, ULONGEST addr,
|
|
struct uploaded_tp **utpp);
|
|
extern struct tracepoint *create_tracepoint_from_upload (struct uploaded_tp *utp);
|
|
extern void merge_uploaded_tracepoints (struct uploaded_tp **utpp);
|
|
extern void merge_uploaded_trace_state_variables (struct uploaded_tsv **utsvp);
|
|
|
|
extern void disconnect_tracing (int from_tty);
|
|
|
|
extern void start_tracing (char *notes);
|
|
extern void stop_tracing (char *notes);
|
|
|
|
extern void trace_status_mi (int on_stop);
|
|
|
|
extern void tvariables_info_1 (void);
|
|
extern void save_trace_state_variables (struct ui_file *fp);
|
|
|
|
extern void tfind_1 (enum trace_find_type type, int num,
|
|
ULONGEST addr1, ULONGEST addr2,
|
|
int from_tty);
|
|
|
|
extern void trace_save (const char *filename, int target_does_save);
|
|
|
|
extern struct traceframe_info *parse_traceframe_info (const char *tframe_info);
|
|
|
|
extern int traceframe_available_memory (VEC(mem_range_s) **result,
|
|
CORE_ADDR memaddr, ULONGEST len);
|
|
|
|
#endif /* TRACEPOINT_H */
|