old-cross-binutils/gdb/testsuite/gdb.base/source.exp
Joel Brobecker 7c647d6155 warn if "source" fails to open the file when from_tty == 0
Consider the following example:

    % gdb -q -batch -ex 'source nonexistant-file'
    [nothing]

One would have at least expected the debugger to warn about
not finding the file, similar to the error shown when using
a more interactive mode. Eg:

    (gdb) source nonexistant-file
    nonexistant-file: No such file or directory.

Not raising an error appears to be intentional, presumably in order
to prevent this situation from stoping the execution of a GDB script.
But the lack of at least a warning makes it harder for a user to
diagnose any issue, if the file was expected to be there and readable.

This patch adds a warning in that case:

    % gdb -q -batch -ex 'source nonexistant-file'
    warning: nonexistant-file: No such file or directory.

gdb/ChangeLog:

        * utils.h (perror_warning_with_name): Add declaration.
        * utils.c (perror_warning_with_name): New function.
        * cli/cli-cmds.c (source_script_with_search): Add call to
        perror_warning_with_name if from_tty is nul.

gdb/testsuite/ChangeLog:

        * gdb.base/source-nofile.gdb: New file.
        * gdb.base/source.exp: Add two tests verifying the behavior when
        the "source" command is given a non-existant filename.
2013-10-11 08:23:11 +00:00

69 lines
2.3 KiB
Text

# This testcase is part of GDB, the GNU debugger.
# Copyright 2005-2013 Free Software Foundation, Inc.
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# Test GDB's "source" command - reads in a GDB script.
standard_testfile structs.c
gdb_start
gdb_test "source ${srcdir}/${subdir}/source-error.gdb" \
"source-error.gdb:21: Error in sourced command file:\[\r\n\]*Cannot access memory at address 0x0.*" \
"script contains error"
gdb_test "source -v ${srcdir}/${subdir}/source-test.gdb" \
"echo test source options.*" \
"source -v"
# There was a bug where -v got stuck in the "on" position.
# Verify "source script", without the -v, is not verbose.
set test "source after -v"
gdb_test_multiple "source ${srcdir}/${subdir}/source-test.gdb" $test {
-re "echo test source options.*$gdb_prompt $" {
fail "$test"
}
-re "test source options.*$gdb_prompt $" {
pass "$test"
}
}
gdb_test "dir ${srcdir}/${subdir}" "Source directories searched: .*" \
"set search directories"
gdb_test "source -s ./source-test.gdb" \
"test source options" \
"source -s"
# Test -v and -s in either order.
gdb_test "source -s -v ./source-test.gdb" \
"echo test source options.*" \
"source -s -v"
gdb_test "source -v -s ./source-test.gdb" \
"echo test source options.*" \
"source -v -s"
# Test sourcing a non-existant file, both when the source command
# comes from the a command entered at the GDB prompt, and when
# it comes from a script being sourced.
gdb_test "source for-sure-nonexistant-file" \
"for-sure-nonexistant-file: No such file or directory\."
gdb_test "source source-nofile.gdb" \
"warning: for-sure-nonexistant-file: No such file or directory\.\[\r\n\]*source error not fatal"
gdb_exit