a8454a7c5a
Checking whether the gcore command is included in the GDB build as
proxy for checking whether core dumping is supported by the target is
useless, as gcore.o has been in COMMON_OBS since git 9b4eba8e:
2009-10-26 Michael Snyder <msnyder@vmware.com>
Hui Zhu <teawater@gmail.com>
* Makefile.in (SFILES): Add gcore.c.
(COMMON_OBS): Add gcore.o.
* config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
* config/alpha/fbsd.mh (NATDEPFILES): Ditto.
...
IOW, the command is always included in the build.
Instead, nowadays, tests bail out if actually trying to generate a
core fails with an indication the target doesn't support it. See
gdb_gcore_cmd and callers.
Tested on x86_64 Fedora 20.
gdb/testsuite/ChangeLog:
* gdb.base/gcore-buffer-overflow.exp: Remove "help gcore" test.
* gdb.base/gcore-relro-pie.exp: Likewise.
* gdb.base/gcore-relro.exp: Likewise.
* gdb.base/gcore.exp: Likewise.
* gdb.base/print-symbol-loading.exp: Likewise.
* gdb.threads/gcore-thread.exp: Likewise.
* lib/gdb.exp (gdb_gcore_cmd): Don't expect "Undefined command".
43 lines
1.5 KiB
Text
43 lines
1.5 KiB
Text
# Copyright 2007-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test GDB's internal buffers safety for the GCORE command.
|
|
|
|
|
|
standard_testfile .c
|
|
# The ${binfile} basename needs to exceed 80 characters (`sizeof (psargs)')
|
|
# plus some additional data to overwrite the stack frame.
|
|
set pattern 01234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789
|
|
append binfile -${pattern}
|
|
|
|
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
|
|
untested ${testfile}.exp
|
|
return -1
|
|
}
|
|
|
|
# Start with a fresh gdb.
|
|
|
|
clean_restart ${binfile}
|
|
|
|
gdb_test_no_output "set args ${pattern}" \
|
|
"Set buffer exceeding arguments"
|
|
|
|
if { ! [ runto_main ] } then {
|
|
untested gcore-buffer-overflow.exp
|
|
return -1
|
|
}
|
|
|
|
gdb_gcore_cmd [standard_output_file gcore-buffer-overflow.test] \
|
|
"save a corefile"
|