d7b30f6729
This is the continuation of what Joel proposed on: <https://sourceware.org/ml/gdb-patches/2013-12/msg00977.html> Now that I have already submitted and pushed the patch to split i386_stap_parse_special_token into two smaller functions, it is indeed simpler to understand this patch. It occurs because, on x86, triplet displacement operands are allowed (like "-4+8-20(%rbp)"), and the current parser for this expression is buggy. It does not correctly extract the register name from the expression, which leads to incorrect evaluation. The parser was also being very "generous" with the expression, so I included a few more checks to ensure that we're indeed dealing with a triplet displacement operand. This patch also includes testcases for the two different kind of expressions that can be encountered on x86: the triplet displacement (explained above) and the three-argument displacement (as in "(%rbx,%ebx,-8)"). The tests are obviously arch-dependent and are placed under gdb.arch/. Message-ID: <m3mwj1j12v.fsf@redhat.com> URL: <https://sourceware.org/ml/gdb-patches/2014-01/msg00310.html> gdb/ 2014-02-20 Sergio Durigan Junior <sergiodj@redhat.com> PR tdep/16397 * i386-tdep.c (i386_stap_parse_special_token_triplet): Check if a number comes after the + or - signs. Adjust length of register name to be extracted. gdb/testsuite/ 2014-02-20 Sergio Durigan Junior <sergiodj@redhat.com> PR tdep/16397 * gdb.arch/amd64-stap-special-operands.exp: New file. * gdb.arch/amd64-stap-three-arg-disp.S: Likewise. * gdb.arch/amd64-stap-three-arg-disp.c: Likewise. * gdb.arch/amd64-stap-triplet.S: Likewise. * gdb.arch/amd64-stap-triplet.c: Likewise.
47 lines
1.4 KiB
Text
47 lines
1.4 KiB
Text
# Copyright 2013 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if { ![istarget "x86_64-*-*"] && ![istarget "i?86-*-*"] } {
|
|
verbose "Skipping amd64-stap-special-operands.exp"
|
|
return
|
|
}
|
|
|
|
proc test_probe { probe_name } {
|
|
if { ![runto "-pstap $probe_name"] } {
|
|
fail "run to probe $probe_name"
|
|
return
|
|
}
|
|
|
|
gdb_test "print \$_probe_argc" " = 1"
|
|
gdb_test "print \$_probe_arg0" " = 10"
|
|
}
|
|
|
|
standard_testfile amd64-stap-triplet.S
|
|
|
|
if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
|
|
untested amd64-stap-special-operands.exp
|
|
return -1
|
|
}
|
|
|
|
test_probe "triplet"
|
|
|
|
standard_testfile amd64-stap-three-arg-disp.S
|
|
|
|
if { [prepare_for_testing $testfile.exp $testfile $srcfile] } {
|
|
untested amd64-stap-special-operands.exp
|
|
return -1
|
|
}
|
|
|
|
test_probe "three_arg"
|