906d60cf46
Running break-interp.exp with the target always in non-stop mode trips on PR13858, as enabling non-stop also enables displaced stepping. The problem is that when GDB doesn't know where the entry point is, it doesn't know where to put the displaced stepping scratch pad. The test added by this commit exercises this. Without the fix, we get: (gdb) PASS: gdb.base/step-over-no-symbols.exp: displaced=on: break *$pc set displaced-stepping on (gdb) PASS: gdb.base/step-over-no-symbols.exp: displaced=on: set displaced-stepping on stepi 0x00000000004005be in ?? () Entry point address is not known. (gdb) PASS: gdb.base/step-over-no-symbols.exp: displaced=on: stepi p /x $pc $2 = 0x4005be (gdb) PASS: gdb.base/step-over-no-symbols.exp: displaced=on: get after PC FAIL: gdb.base/step-over-no-symbols.exp: displaced=on: advanced The fix switches all GNU/Linux ports to get the entry point from AT_ENTRY in the target auxiliary vector instead of from symbols. This is currently only done by PPC when Cell debugging is enabled, but I think all archs should be able to do the same. Note that ppc_linux_displaced_step_location cached the result, I'm guessing to avoid constantly re-fetching the auxv out of remote targets, but that's no longer necessary nowadays, as the auxv blob is itself cached in the inferior object. The ppc_linux_entry_point_addr global is obviously bad for multi-process too nowadays. Tested on x86-64 (-m64/-m32), PPC64 (-m64/-m32) and S/390 GNU/Linux. Yao tested the new test on ARM as well. gdb/ChangeLog: 2015-04-10 Pedro Alves <palves@redhat.com> PR gdb/13858 * amd64-linux-tdep.c (amd64_linux_init_abi_common): Install linux_displaced_step_location as gdbarch_displaced_step_location hook. * arm-linux-tdep.c (arm_linux_init_abi): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * linux-tdep.c (linux_displaced_step_location): New function, based on ppc_linux_displaced_step_location. * linux-tdep.h (linux_displaced_step_location): New declaration. * ppc-linux-tdep.c (ppc_linux_entry_point_addr): Delete. (ppc_linux_inferior_created, ppc_linux_displaced_step_location): Delete. (ppc_linux_init_abi): Install linux_displaced_step_location as gdbarch_displaced_step_location hook, even without Cell/B.E.. (_initialize_ppc_linux_tdep): Don't install ppc_linux_inferior_created as inferior_created observer. * s390-linux-tdep.c (s390_gdbarch_init): Install linux_displaced_step_location as gdbarch_displaced_step_location hook. gdb/testsuite/ 2015-04-10 Pedro Alves <palves@redhat.com> PR gdb/13858 * gdb.base/step-over-no-symbols.exp: New file.
92 lines
2.4 KiB
Text
92 lines
2.4 KiB
Text
# Copyright (C) 2015 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test that GDB can step past a breakpoint even if GDB doesn't have
|
|
# symbols for the main binary. PR gdb/13858.
|
|
|
|
standard_testfile start.c
|
|
|
|
if { [build_executable "failed to build" ${testfile} $srcfile] } {
|
|
return -1
|
|
}
|
|
|
|
# Get the current PC. MSG is used as test message.
|
|
|
|
proc get_pc { msg } {
|
|
global hex gdb_prompt
|
|
|
|
set addr ""
|
|
gdb_test_multiple "p /x \$pc" "$msg" {
|
|
-re " = ($hex).*$gdb_prompt $" {
|
|
set addr $expect_out(1,string)
|
|
pass "$msg"
|
|
}
|
|
}
|
|
|
|
return $addr
|
|
}
|
|
|
|
# Test stepping past a breakpoint with no symbols. DISPLACED is one
|
|
# of the "set displaced-stepping" options. If GDB can't find where to
|
|
# put the scratch pad, GDB should be able to fall back to stepping
|
|
# past the breakpoint using an in-line step-over.
|
|
|
|
proc test_step_over { displaced } {
|
|
global hex
|
|
global binfile
|
|
|
|
clean_restart $binfile
|
|
|
|
if ![runto_main] {
|
|
fail "couldn't run to main"
|
|
untested "stepping over breakpoint with displaced=$displaced"
|
|
return -1
|
|
}
|
|
|
|
delete_breakpoints
|
|
|
|
set msg "purging symbols"
|
|
gdb_test_multiple "file" "$msg" {
|
|
-re "Are you sure you want to change the file.*y or n. $" {
|
|
send_gdb "y\n"
|
|
exp_continue
|
|
}
|
|
-re "Discard symbol table.*y or n. $" {
|
|
gdb_test "y" "No symbol file now." "$msg"
|
|
}
|
|
}
|
|
|
|
set before_addr [get_pc "get before PC"]
|
|
|
|
gdb_test "break *\$pc" "Breakpoint .* at $hex"
|
|
|
|
gdb_test_no_output "set displaced-stepping $displaced"
|
|
|
|
gdb_test "stepi" "$hex in \?\? .*"
|
|
|
|
set after_addr [get_pc "get after PC"]
|
|
|
|
gdb_assert {$before_addr != $after_addr} "advanced"
|
|
}
|
|
|
|
foreach displaced { "off" "on" "auto" } {
|
|
if { $displaced != "off" && ![support_displaced_stepping] } {
|
|
continue
|
|
}
|
|
|
|
with_test_prefix "displaced=$displaced" {
|
|
test_step_over $displaced
|
|
}
|
|
}
|