4ec7020176
A few months ago semicolons after "return" were removed throughout the testsuite. However, as I pointed out in review, they're unnecessary not just after "return", but pretty much after any tcl command. ';' is the command separator, and you only need it if there's another command on the same line afterwards. This patch was written by running: $ find . -name "*.exp" | xargs grep -l ";\s*$" | xargs sed -i 's/\([^#][^\s*;]*\)\s*;\s*$/\1/' and then undoing changes to comments, and lib/future.exp. Tested on x86_64 Fedora 17. gdb/testsuite/ 2013-06-07 Pedro Alves <palves@redhat.com> * boards/native-extended-gdbserver.exp: Remove semicolon. * config/arm-ice.exp: Likewise. * config/bfin.exp: Likewise. * config/cygmon.exp: Likewise. * config/h8300.exp: Likewise. * config/monitor.exp: Likewise. * config/sid.exp: Likewise. * config/sim.exp: Likewise. * config/slite.exp: Likewise. * config/vx.exp: Likewise. * gdb.arch/i386-bp_permanent.exp: Likewise. * gdb.asm/asm-source.exp: Likewise. * gdb.base/args.exp: Likewise. * gdb.base/attach-pie-misread.exp: Likewise. * gdb.base/auxv.exp: Likewise. * gdb.base/bigcore.exp: Likewise. * gdb.base/bitfields2.exp: Likewise. * gdb.base/bitfields.exp: Likewise. * gdb.base/break.exp: Likewise. * gdb.base/break-interp.exp: Likewise. * gdb.base/callfuncs.exp: Likewise. * gdb.base/call-sc.exp: Likewise. * gdb.base/commands.exp: Likewise. * gdb.base/corefile.exp: Likewise. * gdb.base/dbx.exp: Likewise. * gdb.base/ending-run.exp: Likewise. * gdb.base/exprs.exp: Likewise. * gdb.base/funcargs.exp: Likewise. * gdb.base/hbreak2.exp: Likewise. * gdb.base/huge.exp: Likewise. * gdb.base/list.exp: Likewise. * gdb.base/memattr.exp: Likewise. * gdb.base/overlays.exp: Likewise. * gdb.base/printcmds.exp: Likewise. * gdb.base/recurse.exp: Likewise. * gdb.base/remotetimeout.exp: Likewise. * gdb.base/reread.exp: Likewise. * gdb.base/savedregs.exp: Likewise. * gdb.base/scope.exp: Likewise. * gdb.base/sepdebug.exp: Likewise. * gdb.base/setshow.exp: Likewise. * gdb.base/setvar.exp: Likewise. * gdb.base/sigaltstack.exp: Likewise. * gdb.base/siginfo-addr.exp: Likewise. * gdb.base/siginfo.exp: Likewise. * gdb.base/siginfo-obj.exp: Likewise. * gdb.base/sigrepeat.exp: Likewise. * gdb.base/sigstep.exp: Likewise. * gdb.base/structs.exp: Likewise. * gdb.base/testenv.exp: Likewise. * gdb.base/twice.exp: Likewise. * gdb.base/valgrind-db-attach.exp: Likewise. * gdb.base/valgrind-infcall.exp: Likewise. * gdb.base/varargs.exp: Likewise. * gdb.base/watchpoint.exp: Likewise. * gdb.cp/gdb1355.exp: Likewise. * gdb.cp/misc.exp: Likewise. * gdb.disasm/hppa.exp: Likewise. * gdb.disasm/t01_mov.exp: Likewise. * gdb.disasm/t02_mova.exp: Likewise. * gdb.disasm/t03_add.exp: Likewise. * gdb.disasm/t04_sub.exp: Likewise. * gdb.disasm/t05_cmp.exp: Likewise. * gdb.disasm/t06_ari2.exp: Likewise. * gdb.disasm/t07_ari3.exp: Likewise. * gdb.disasm/t08_or.exp: Likewise. * gdb.disasm/t09_xor.exp: Likewise. * gdb.disasm/t10_and.exp: Likewise. * gdb.disasm/t11_logs.exp: Likewise. * gdb.disasm/t12_bit.exp: Likewise. * gdb.disasm/t13_otr.exp: Likewise. * gdb.gdb/selftest.exp: Likewise. * gdb.hp/gdb.base-hp/callfwmall.exp: Likewise. * gdb.mi/mi-reverse.exp: Likewise. * gdb.pascal/floats.exp: Likewise. * gdb.python/py-inferior.exp: Likewise. * gdb.threads/attach-into-signal.exp: Likewise. * gdb.threads/pthreads.exp: Likewise. * gdb.threads/thread_events.exp: Likewise. * gdb.threads/watchthreads.exp: Likewise. * gdb.trace/actions-changed.exp: Likewise. * gdb.trace/actions.exp: Likewise. * gdb.trace/ax.exp: Likewise. * gdb.trace/backtrace.exp: Likewise. * gdb.trace/change-loc.exp: Likewise. * gdb.trace/deltrace.exp: Likewise. * gdb.trace/disconnected-tracing.exp: Likewise. * gdb.trace/ftrace.exp: Likewise. * gdb.trace/infotrace.exp: Likewise. * gdb.trace/passc-dyn.exp: Likewise. * gdb.trace/passcount.exp: Likewise. * gdb.trace/pending.exp: Likewise. * gdb.trace/qtro.exp: Likewise. * gdb.trace/range-stepping.exp: Likewise. * gdb.trace/report.exp: Likewise. * gdb.trace/save-trace.exp: Likewise. * gdb.trace/status-stop.exp: Likewise. * gdb.trace/strace.exp: Likewise. * gdb.trace/tfile.exp: Likewise. * gdb.trace/tfind.exp: Likewise. * gdb.trace/trace-break.exp: Likewise. * gdb.trace/tracecmd.exp: Likewise. * gdb.trace/trace-mt.exp: Likewise. * gdb.trace/tspeed.exp: Likewise. * gdb.trace/tsv.exp: Likewise. * gdb.trace/while-stepping.exp: Likewise. * lib/gdb.exp: Likewise. * lib/gdbserver-support.exp: Likewise. * lib/java.exp: Likewise. * lib/mi-support.exp: Likewise. * lib/pascal.exp: Likewise. * lib/prompt.exp: Likewise. * lib/trace-support.exp: Likewise.
147 lines
4.3 KiB
Text
147 lines
4.3 KiB
Text
# Copyright 2004-2013 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
|
|
# The program siginfo-obj.c arranges for a signal handler registered
|
|
# using sigaction's sa_sigaction / SA_SIGINFO to be called with
|
|
# si_addr filled in.
|
|
|
|
# This test confirms that we can inspect signal info using the
|
|
# $_siginfo convenience variable.
|
|
|
|
if [target_info exists gdb,nosignals] {
|
|
verbose "Skipping siginfo-obj.exp because of nosignals."
|
|
continue
|
|
}
|
|
|
|
if { ! [istarget "i?86-*-linux*"]
|
|
&& ! [istarget "x86_64-*-linux*"]
|
|
&& ! [istarget "arm*-*-linux*"] } {
|
|
verbose "Skipping siginfo-obj.exp because of lack of support."
|
|
return
|
|
}
|
|
|
|
|
|
set testfile siginfo-obj
|
|
set srcfile ${testfile}.c
|
|
set binfile ${objdir}/${subdir}/${testfile}
|
|
if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" executable {debug}] != "" } {
|
|
untested "Couldn't compile ${srcfile}.c"
|
|
return -1
|
|
}
|
|
|
|
# get things started
|
|
gdb_exit
|
|
gdb_start
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
gdb_load ${binfile}
|
|
|
|
# Advance to main
|
|
if { ![runto_main] } then {
|
|
gdb_suppress_tests
|
|
}
|
|
|
|
# Run to the signal.
|
|
gdb_test "continue" ".*Program received signal SIGSEGV.*" "continue to signal"
|
|
|
|
# Try to generate a core file, for a later test.
|
|
set gcorefile [standard_output_file $testfile.gcore]
|
|
set gcore_created [gdb_gcore_cmd $gcorefile "save a core file"]
|
|
|
|
set ssi_addr ""
|
|
set test "Extract si_addr"
|
|
gdb_test_multiple "p \$_siginfo" "$test" {
|
|
-re "si_addr = ($hex).*$gdb_prompt $" {
|
|
set ssi_addr $expect_out(1,string)
|
|
pass "$test"
|
|
}
|
|
}
|
|
|
|
set test "Extract si_errno"
|
|
gdb_test_multiple "p \$_siginfo" "$test" {
|
|
-re "si_errno = (\[0-9\]\+).*$gdb_prompt $" {
|
|
set ssi_errno $expect_out(1,string)
|
|
pass "$test"
|
|
}
|
|
}
|
|
|
|
set test "Extract si_code"
|
|
gdb_test_multiple "p \$_siginfo" "$test" {
|
|
-re "si_code = (\[0-9\]\+).*$gdb_prompt $" {
|
|
set ssi_code $expect_out(1,string)
|
|
pass "$test"
|
|
}
|
|
}
|
|
|
|
set test "Extract si_signo"
|
|
gdb_test_multiple "p \$_siginfo" "$test" {
|
|
-re "si_signo = (\[0-9\]\+).*$gdb_prompt $" {
|
|
set ssi_signo $expect_out(1,string)
|
|
pass "$test"
|
|
}
|
|
}
|
|
|
|
set bp_location [gdb_get_line_number "set breakpoint here"]
|
|
|
|
gdb_test "break $bp_location"
|
|
gdb_test "continue" ".* handler .*" "continue to handler"
|
|
|
|
gdb_test "p ssi_addr" " = \\(void \\*\\) $ssi_addr"
|
|
gdb_test "p ssi_errno" " = $ssi_errno"
|
|
gdb_test "p ssi_code" " = $ssi_code"
|
|
gdb_test "p ssi_signo" " = $ssi_signo"
|
|
|
|
# Again, but this time, patch si_addr and check that the inferior sees
|
|
# the changed value.
|
|
|
|
# Advance to main
|
|
if { ![runto_main] } then {
|
|
gdb_suppress_tests
|
|
}
|
|
|
|
# Run to the signal.
|
|
gdb_test "continue" ".*Program received signal SIGSEGV.*" "continue to signal"
|
|
|
|
set test "Set si_addr"
|
|
gdb_test "p \$_siginfo._sifields._sigfault.si_addr = 0x666" " = \\(void \\*\\) 0x666"
|
|
gdb_test "p \$_siginfo.si_errno = 666" " = 666"
|
|
gdb_test "p \$_siginfo.si_code = 999" " = 999"
|
|
gdb_test "p \$_siginfo.si_signo = 11" " = 11"
|
|
|
|
gdb_test "break $bp_location"
|
|
gdb_test "continue" ".* handler .*" "continue to handler"
|
|
|
|
gdb_test "p ssi_addr" " = \\(void \\*\\) 0x666"
|
|
gdb_test "p ssi_errno" " = 666"
|
|
gdb_test "p ssi_code" " = 999"
|
|
gdb_test "p ssi_signo" " = 11"
|
|
|
|
# Test siginfo preservation in core files.
|
|
if {$gcore_created} {
|
|
clean_restart $binfile
|
|
|
|
gdb_test "core $gcorefile" "Core was generated by.*" \
|
|
"core [file tail $gcorefile]"
|
|
|
|
gdb_test "p \$_siginfo.si_signo" " = $ssi_signo" \
|
|
"p \$_siginfo.si_signo from core file"
|
|
gdb_test "p \$_siginfo.si_errno" " = $ssi_errno" \
|
|
"p \$_siginfo.si_errno from core file"
|
|
gdb_test "p \$_siginfo.si_code" " = $ssi_code" \
|
|
"p \$_siginfo.si_code from core file"
|
|
gdb_test "p \$_siginfo._sifields._sigfault.si_addr" \
|
|
" = \\(void \\*\\) $ssi_addr" \
|
|
"p \$_siginfo._sifields._sigfault.si_addr from core file"
|
|
}
|