9a3c826307
Note: I needed to split this patch in two, otherwise it's too big for the mailing list. This patch adds explicit casts to situations where a void pointer is assigned to a pointer to the "real" type. Building in C++ mode requires those assignments to use an explicit cast. This includes, for example: - callback arguments (cleanups, comparison functions, ...) - data attached to some object (objfile, program space, etc) in the form of a void pointer - "user data" passed to some function This patch comes from the commit "(mostly) auto-generated patch to insert casts needed for C++", taken from Pedro's C++ branch. Only files built on x86 with --enable-targets=all are modified, so the native files for other arches will need to be dealt with separately. I built-tested this with --enable-targets=all and reg-tested. To my surprise, a test case (selftest.exp) had to be adjusted. Here's the ChangeLog entry. Again, this was relatively quick to make despite the length, thanks to David Malcom's script, although I don't believe it's very useful information in that particular case... gdb/ChangeLog: * aarch64-tdep.c (aarch64_make_prologue_cache): Add cast(s). (aarch64_make_stub_cache): Likewise. (value_of_aarch64_user_reg): Likewise. * ada-lang.c (ada_inferior_data_cleanup): Likewise. (get_ada_inferior_data): Likewise. (get_ada_pspace_data): Likewise. (ada_pspace_data_cleanup): Likewise. (ada_complete_symbol_matcher): Likewise. (ada_exc_search_name_matches): Likewise. * ada-tasks.c (get_ada_tasks_pspace_data): Likewise. (get_ada_tasks_inferior_data): Likewise. * addrmap.c (addrmap_mutable_foreach_worker): Likewise. (splay_obstack_alloc): Likewise. (splay_obstack_free): Likewise. * alpha-linux-tdep.c (alpha_linux_supply_gregset): Likewise. (alpha_linux_collect_gregset): Likewise. (alpha_linux_supply_fpregset): Likewise. (alpha_linux_collect_fpregset): Likewise. * alpha-mdebug-tdep.c (alpha_mdebug_frame_unwind_cache): Likewise. * alpha-tdep.c (alpha_lds): Likewise. (alpha_sts): Likewise. (alpha_sigtramp_frame_unwind_cache): Likewise. (alpha_heuristic_frame_unwind_cache): Likewise. (alpha_supply_int_regs): Likewise. (alpha_fill_int_regs): Likewise. (alpha_supply_fp_regs): Likewise. (alpha_fill_fp_regs): Likewise. * alphanbsd-tdep.c (alphanbsd_supply_fpregset): Likewise. (alphanbsd_aout_supply_gregset): Likewise. (alphanbsd_supply_gregset): Likewise. * amd64-linux-tdep.c (amd64_linux_init_abi): Likewise. (amd64_x32_linux_init_abi): Likewise. * amd64-nat.c (amd64_supply_native_gregset): Likewise. (amd64_collect_native_gregset): Likewise. * amd64-tdep.c (amd64_frame_cache): Likewise. (amd64_sigtramp_frame_cache): Likewise. (amd64_epilogue_frame_cache): Likewise. (amd64_supply_fxsave): Likewise. (amd64_supply_xsave): Likewise. (amd64_collect_fxsave): Likewise. (amd64_collect_xsave): Likewise. * amd64-windows-tdep.c (amd64_windows_frame_cache): Likewise. * amd64obsd-tdep.c (amd64obsd_trapframe_cache): Likewise. * arm-linux-tdep.c (arm_linux_supply_gregset): Likewise. (arm_linux_collect_gregset): Likewise. (arm_linux_supply_nwfpe): Likewise. (arm_linux_collect_nwfpe): Likewise. (arm_linux_supply_vfp): Likewise. (arm_linux_collect_vfp): Likewise. * arm-tdep.c (arm_find_mapping_symbol): Likewise. (arm_prologue_unwind_stop_reason): Likewise. (arm_prologue_this_id): Likewise. (arm_prologue_prev_register): Likewise. (arm_exidx_data_free): Likewise. (arm_find_exidx_entry): Likewise. (arm_stub_this_id): Likewise. (arm_m_exception_this_id): Likewise. (arm_m_exception_prev_register): Likewise. (arm_normal_frame_base): Likewise. (gdb_print_insn_arm): Likewise. (arm_objfile_data_free): Likewise. (arm_record_special_symbol): Likewise. (value_of_arm_user_reg): Likewise. * armbsd-tdep.c (armbsd_supply_fpregset): Likewise. (armbsd_supply_gregset): Likewise. * auto-load.c (auto_load_pspace_data_cleanup): Likewise. (get_auto_load_pspace_data): Likewise. (hash_loaded_script_entry): Likewise. (eq_loaded_script_entry): Likewise. (clear_section_scripts): Likewise. (collect_matching_scripts): Likewise. * auxv.c (auxv_inferior_data_cleanup): Likewise. (get_auxv_inferior_data): Likewise. * avr-tdep.c (avr_frame_unwind_cache): Likewise. * ax-general.c (do_free_agent_expr_cleanup): Likewise. * bfd-target.c (target_bfd_xfer_partial): Likewise. (target_bfd_xclose): Likewise. (target_bfd_get_section_table): Likewise. * bfin-tdep.c (bfin_frame_cache): Likewise. * block.c (find_block_in_blockvector): Likewise. (call_site_for_pc): Likewise. (block_find_non_opaque_type_preferred): Likewise. * break-catch-sig.c (signal_catchpoint_insert_location): Likewise. (signal_catchpoint_remove_location): Likewise. (signal_catchpoint_breakpoint_hit): Likewise. (signal_catchpoint_print_one): Likewise. (signal_catchpoint_print_mention): Likewise. (signal_catchpoint_print_recreate): Likewise. * break-catch-syscall.c (get_catch_syscall_inferior_data): Likewise. * breakpoint.c (do_cleanup_counted_command_line): Likewise. (bp_location_compare_addrs): Likewise. (get_first_locp_gte_addr): Likewise. (check_tracepoint_command): Likewise. (do_map_commands_command): Likewise. (get_breakpoint_objfile_data): Likewise. (free_breakpoint_probes): Likewise. (do_captured_breakpoint_query): Likewise. (compare_breakpoints): Likewise. (bp_location_compare): Likewise. (bpstat_remove_breakpoint_callback): Likewise. (do_delete_breakpoint_cleanup): Likewise. * bsd-uthread.c (bsd_uthread_set_supply_uthread): Likewise. (bsd_uthread_set_collect_uthread): Likewise. (bsd_uthread_activate): Likewise. (bsd_uthread_fetch_registers): Likewise. (bsd_uthread_store_registers): Likewise. * btrace.c (check_xml_btrace_version): Likewise. (parse_xml_btrace_block): Likewise. (parse_xml_btrace_pt_config_cpu): Likewise. (parse_xml_btrace_pt_raw): Likewise. (parse_xml_btrace_pt): Likewise. (parse_xml_btrace_conf_bts): Likewise. (parse_xml_btrace_conf_pt): Likewise. (do_btrace_data_cleanup): Likewise. * c-typeprint.c (find_typedef_for_canonicalize): Likewise. * charset.c (cleanup_iconv): Likewise. (do_cleanup_iterator): Likewise. * cli-out.c (cli_uiout_dtor): Likewise. (cli_table_begin): Likewise. (cli_table_body): Likewise. (cli_table_end): Likewise. (cli_table_header): Likewise. (cli_begin): Likewise. (cli_end): Likewise. (cli_field_int): Likewise. (cli_field_skip): Likewise. (cli_field_string): Likewise. (cli_field_fmt): Likewise. (cli_spaces): Likewise. (cli_text): Likewise. (cli_message): Likewise. (cli_wrap_hint): Likewise. (cli_flush): Likewise. (cli_redirect): Likewise. (out_field_fmt): Likewise. (field_separator): Likewise. (cli_out_set_stream): Likewise. * cli/cli-cmds.c (compare_symtabs): Likewise. * cli/cli-dump.c (call_dump_func): Likewise. (restore_section_callback): Likewise. * cli/cli-script.c (clear_hook_in_cleanup): Likewise. (do_restore_user_call_depth): Likewise. (do_free_command_lines_cleanup): Likewise. * coff-pe-read.c (get_section_vmas): Likewise. (pe_as16): Likewise. (pe_as32): Likewise. * coffread.c (coff_symfile_read): Likewise. * common/agent.c (agent_look_up_symbols): Likewise. * common/filestuff.c (do_close_cleanup): Likewise. * common/format.c (free_format_pieces_cleanup): Likewise. * common/vec.c (vec_o_reserve): Likewise. * compile/compile-c-support.c (print_one_macro): Likewise. * compile/compile-c-symbols.c (hash_symbol_error): Likewise. (eq_symbol_error): Likewise. (del_symbol_error): Likewise. (error_symbol_once): Likewise. (gcc_convert_symbol): Likewise. (gcc_symbol_address): Likewise. (hash_symname): Likewise. (eq_symname): Likewise. * compile/compile-c-types.c (hash_type_map_instance): Likewise. (eq_type_map_instance): Likewise. (insert_type): Likewise. (convert_type): Likewise. * compile/compile-object-load.c (munmap_listp_free_cleanup): Likewise. (setup_sections): Likewise. (link_hash_table_free): Likewise. (copy_sections): Likewise. * compile/compile-object-run.c (do_module_cleanup): Likewise. * compile/compile.c (compile_print_value): Likewise. (do_rmdir): Likewise. (cleanup_compile_instance): Likewise. (cleanup_unlink_file): Likewise. * completer.c (free_completion_tracker): Likewise. * corelow.c (add_to_spuid_list): Likewise. * cp-namespace.c (reset_directive_searched): Likewise. * cp-support.c (reset_directive_searched): Likewise. * cris-tdep.c (cris_sigtramp_frame_unwind_cache): Likewise. (cris_frame_unwind_cache): Likewise. * d-lang.c (builtin_d_type): Likewise. * d-namespace.c (reset_directive_searched): Likewise. * dbxread.c (dbx_free_symfile_info): Likewise. (do_free_bincl_list_cleanup): Likewise. * disasm.c (hash_dis_line_entry): Likewise. (eq_dis_line_entry): Likewise. (dis_asm_print_address): Likewise. (fprintf_disasm): Likewise. (do_ui_file_delete): Likewise. * doublest.c (convert_floatformat_to_doublest): Likewise. * dummy-frame.c (pop_dummy_frame_bpt): Likewise. (dummy_frame_prev_register): Likewise. (dummy_frame_this_id): Likewise. * dwarf2-frame-tailcall.c (cache_hash): Likewise. (cache_eq): Likewise. (cache_find): Likewise. (tailcall_frame_this_id): Likewise. (dwarf2_tailcall_prev_register_first): Likewise. (tailcall_frame_prev_register): Likewise. (tailcall_frame_dealloc_cache): Likewise. (tailcall_frame_prev_arch): Likewise. * dwarf2-frame.c (dwarf2_frame_state_free): Likewise. (dwarf2_frame_set_init_reg): Likewise. (dwarf2_frame_init_reg): Likewise. (dwarf2_frame_set_signal_frame_p): Likewise. (dwarf2_frame_signal_frame_p): Likewise. (dwarf2_frame_set_adjust_regnum): Likewise. (dwarf2_frame_adjust_regnum): Likewise. (clear_pointer_cleanup): Likewise. (dwarf2_frame_cache): Likewise. (find_cie): Likewise. (dwarf2_frame_find_fde): Likewise. * dwarf2expr.c (dwarf_expr_address_type): Likewise. (free_dwarf_expr_context_cleanup): Likewise. * dwarf2loc.c (locexpr_find_frame_base_location): Likewise. (locexpr_get_frame_base): Likewise. (loclist_find_frame_base_location): Likewise. (loclist_get_frame_base): Likewise. (dwarf_expr_dwarf_call): Likewise. (dwarf_expr_get_base_type): Likewise. (dwarf_expr_push_dwarf_reg_entry_value): Likewise. (dwarf_expr_get_obj_addr): Likewise. (entry_data_value_coerce_ref): Likewise. (entry_data_value_copy_closure): Likewise. (entry_data_value_free_closure): Likewise. (get_frame_address_in_block_wrapper): Likewise. (dwarf2_evaluate_property): Likewise. (dwarf2_compile_property_to_c): Likewise. (needs_frame_read_addr_from_reg): Likewise. (needs_frame_get_reg_value): Likewise. (needs_frame_frame_base): Likewise. (needs_frame_frame_cfa): Likewise. (needs_frame_tls_address): Likewise. (needs_frame_dwarf_call): Likewise. (needs_dwarf_reg_entry_value): Likewise. (get_ax_pc): Likewise. (locexpr_read_variable): Likewise. (locexpr_read_variable_at_entry): Likewise. (locexpr_read_needs_frame): Likewise. (locexpr_describe_location): Likewise. (locexpr_tracepoint_var_ref): Likewise. (locexpr_generate_c_location): Likewise. (loclist_read_variable): Likewise. (loclist_read_variable_at_entry): Likewise. (loclist_describe_location): Likewise. (loclist_tracepoint_var_ref): Likewise. (loclist_generate_c_location): Likewise. * dwarf2read.c (line_header_hash_voidp): Likewise. (line_header_eq_voidp): Likewise. (dwarf2_has_info): Likewise. (dwarf2_get_section_info): Likewise. (locate_dwz_sections): Likewise. (hash_file_name_entry): Likewise. (eq_file_name_entry): Likewise. (delete_file_name_entry): Likewise. (dw2_setup): Likewise. (dw2_get_file_names_reader): Likewise. (dw2_find_pc_sect_compunit_symtab): Likewise. (hash_signatured_type): Likewise. (eq_signatured_type): Likewise. (add_signatured_type_cu_to_table): Likewise. (create_debug_types_hash_table): Likewise. (lookup_dwo_signatured_type): Likewise. (lookup_dwp_signatured_type): Likewise. (lookup_signatured_type): Likewise. (hash_type_unit_group): Likewise. (eq_type_unit_group): Likewise. (get_type_unit_group): Likewise. (process_psymtab_comp_unit_reader): Likewise. (sort_tu_by_abbrev_offset): Likewise. (process_skeletonless_type_unit): Likewise. (psymtabs_addrmap_cleanup): Likewise. (dwarf2_read_symtab): Likewise. (psymtab_to_symtab_1): Likewise. (die_hash): Likewise. (die_eq): Likewise. (load_full_comp_unit_reader): Likewise. (reset_die_in_process): Likewise. (free_cu_line_header): Likewise. (handle_DW_AT_stmt_list): Likewise. (hash_dwo_file): Likewise. (eq_dwo_file): Likewise. (hash_dwo_unit): Likewise. (eq_dwo_unit): Likewise. (create_dwo_cu_reader): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (lookup_dwo_unit_in_dwp): Likewise. (dwarf2_locate_dwo_sections): Likewise. (dwarf2_locate_common_dwp_sections): Likewise. (dwarf2_locate_v2_dwp_sections): Likewise. (hash_dwp_loaded_cutus): Likewise. (eq_dwp_loaded_cutus): Likewise. (lookup_dwo_cutu): Likewise. (abbrev_table_free_cleanup): Likewise. (dwarf2_free_abbrev_table): Likewise. (find_partial_die_in_comp_unit): Likewise. (free_line_header_voidp): Likewise. (follow_die_offset): Likewise. (follow_die_sig_1): Likewise. (free_heap_comp_unit): Likewise. (free_stack_comp_unit): Likewise. (dwarf2_free_objfile): Likewise. (per_cu_offset_and_type_hash): Likewise. (per_cu_offset_and_type_eq): Likewise. (get_die_type_at_offset): Likewise. (partial_die_hash): Likewise. (partial_die_eq): Likewise. (dwarf2_per_objfile_free): Likewise. (hash_strtab_entry): Likewise. (eq_strtab_entry): Likewise. (add_string): Likewise. (hash_symtab_entry): Likewise. (eq_symtab_entry): Likewise. (delete_symtab_entry): Likewise. (cleanup_mapped_symtab): Likewise. (add_indices_to_cpool): Likewise. (hash_psymtab_cu_index): Likewise. (eq_psymtab_cu_index): Likewise. (add_address_entry_worker): Likewise. (unlink_if_set): Likewise. (write_one_signatured_type): Likewise. (save_gdb_index_command): Likewise. * elfread.c (elf_symtab_read): Likewise. (elf_gnu_ifunc_cache_hash): Likewise. (elf_gnu_ifunc_cache_eq): Likewise. (elf_gnu_ifunc_record_cache): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_get_probes): Likewise. (probe_key_free): Likewise. * f-lang.c (builtin_f_type): Likewise. * frame-base.c (frame_base_append_sniffer): Likewise. (frame_base_set_default): Likewise. (frame_base_find_by_frame): Likewise. * frame-unwind.c (frame_unwind_prepend_unwinder): Likewise. (frame_unwind_append_unwinder): Likewise. (frame_unwind_find_by_frame): Likewise. * frame.c (frame_addr_hash): Likewise. (frame_addr_hash_eq): Likewise. (frame_stash_find): Likewise. (do_frame_register_read): Likewise. (unwind_to_current_frame): Likewise. (frame_cleanup_after_sniffer): Likewise. * frv-linux-tdep.c (frv_linux_sigtramp_frame_cache): Likewise. * frv-tdep.c (frv_frame_unwind_cache): Likewise. * ft32-tdep.c (ft32_frame_cache): Likewise. * gcore.c (do_bfd_delete_cleanup): Likewise. (gcore_create_callback): Likewise. * gdb_bfd.c (hash_bfd): Likewise. (eq_bfd): Likewise. (gdb_bfd_open): Likewise. (free_one_bfd_section): Likewise. (gdb_bfd_ref): Likewise. (gdb_bfd_unref): Likewise. (get_section_descriptor): Likewise. (gdb_bfd_map_section): Likewise. (gdb_bfd_crc): Likewise. (gdb_bfd_mark_parent): Likewise. (gdb_bfd_record_inclusion): Likewise. (gdb_bfd_requires_relocations): Likewise. (print_one_bfd): Likewise. * gdbtypes.c (type_pair_hash): Likewise. (type_pair_eq): Likewise. (builtin_type): Likewise. (objfile_type): Likewise. * gnu-v3-abi.c (vtable_ptrdiff_type): Likewise. (vtable_address_point_offset): Likewise. (gnuv3_get_vtable): Likewise. (hash_value_and_voffset): Likewise. (eq_value_and_voffset): Likewise. (compare_value_and_voffset): Likewise. (compute_vtable_size): Likewise. (gnuv3_get_typeid_type): Likewise. * go-lang.c (builtin_go_type): Likewise. * guile/scm-block.c (bkscm_hash_block_smob): Likewise. (bkscm_eq_block_smob): Likewise. (bkscm_objfile_block_map): Likewise. (bkscm_del_objfile_blocks): Likewise. * guile/scm-breakpoint.c (bpscm_build_bp_list): Likewise. * guile/scm-disasm.c (gdbscm_disasm_read_memory_worker): Likewise. (gdbscm_disasm_print_address): Likewise. * guile/scm-frame.c (frscm_hash_frame_smob): Likewise. (frscm_eq_frame_smob): Likewise. (frscm_inferior_frame_map): Likewise. (frscm_del_inferior_frames): Likewise. * guile/scm-gsmob.c (gdbscm_add_objfile_ref): Likewise. * guile/scm-objfile.c (ofscm_handle_objfile_deleted): Likewise. (ofscm_objfile_smob_from_objfile): Likewise. * guile/scm-ports.c (ioscm_write): Likewise. (ioscm_file_port_delete): Likewise. (ioscm_file_port_rewind): Likewise. (ioscm_file_port_put): Likewise. (ioscm_file_port_write): Likewise. * guile/scm-progspace.c (psscm_handle_pspace_deleted): Likewise. (psscm_pspace_smob_from_pspace): Likewise. * guile/scm-safe-call.c (scscm_recording_pre_unwind_handler): Likewise. (scscm_recording_unwind_handler): Likewise. (gdbscm_with_catch): Likewise. (scscm_call_0_body): Likewise. (scscm_call_1_body): Likewise. (scscm_call_2_body): Likewise. (scscm_call_3_body): Likewise. (scscm_call_4_body): Likewise. (scscm_apply_1_body): Likewise. (scscm_eval_scheme_string): Likewise. (gdbscm_safe_eval_string): Likewise. (scscm_source_scheme_script): Likewise. (gdbscm_safe_source_script): Likewise. * guile/scm-string.c (gdbscm_call_scm_to_stringn): Likewise. (gdbscm_call_scm_from_stringn): Likewise. * guile/scm-symbol.c (syscm_hash_symbol_smob): Likewise. (syscm_eq_symbol_smob): Likewise. (syscm_get_symbol_map): Likewise. (syscm_del_objfile_symbols): Likewise. * guile/scm-symtab.c (stscm_hash_symtab_smob): Likewise. (stscm_eq_symtab_smob): Likewise. (stscm_objfile_symtab_map): Likewise. (stscm_del_objfile_symtabs): Likewise. * guile/scm-type.c (tyscm_hash_type_smob): Likewise. (tyscm_eq_type_smob): Likewise. (tyscm_type_map): Likewise. (tyscm_copy_type_recursive): Likewise. (save_objfile_types): Likewise. * guile/scm-utils.c (extract_arg): Likewise. * h8300-tdep.c (h8300_frame_cache): Likewise. * hppa-linux-tdep.c (hppa_linux_sigtramp_frame_unwind_cache): Likewise. * hppa-tdep.c (compare_unwind_entries): Likewise. (find_unwind_entry): Likewise. (hppa_frame_cache): Likewise. (hppa_stub_frame_unwind_cache): Likewise. * hppanbsd-tdep.c (hppanbsd_supply_gregset): Likewise. * hppaobsd-tdep.c (hppaobsd_supply_gregset): Likewise. (hppaobsd_supply_fpregset): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. * i386-linux-tdep.c (i386_linux_init_abi): Likewise. * i386-tdep.c (i386_frame_cache): Likewise. (i386_epilogue_frame_cache): Likewise. (i386_sigtramp_frame_cache): Likewise. (i386_supply_gregset): Likewise. (i386_collect_gregset): Likewise. (i386_gdbarch_init): Likewise. * i386obsd-tdep.c (i386obsd_aout_supply_regset): Likewise. (i386obsd_trapframe_cache): Likewise. * i387-tdep.c (i387_supply_fsave): Likewise. (i387_collect_fsave): Likewise. (i387_supply_fxsave): Likewise. (i387_collect_fxsave): Likewise. (i387_supply_xsave): Likewise. (i387_collect_xsave): Likewise. * ia64-tdep.c (ia64_frame_cache): Likewise. (ia64_sigtramp_frame_cache): Likewise. * infcmd.c (attach_command_continuation): Likewise. (attach_command_continuation_free_args): Likewise. * inferior.c (restore_inferior): Likewise. (delete_thread_of_inferior): Likewise. * inflow.c (inflow_inferior_data_cleanup): Likewise. (get_inflow_inferior_data): Likewise. (inflow_inferior_exit): Likewise. * infrun.c (displaced_step_clear_cleanup): Likewise. (restore_current_uiout_cleanup): Likewise. (release_stop_context_cleanup): Likewise. (do_restore_infcall_suspend_state_cleanup): Likewise. (do_restore_infcall_control_state_cleanup): Likewise. (restore_inferior_ptid): Likewise. * inline-frame.c (block_starting_point_at): Likewise. * iq2000-tdep.c (iq2000_frame_cache): Likewise. * jit.c (get_jit_objfile_data): Likewise. (get_jit_program_space_data): Likewise. (jit_object_close_impl): Likewise. (jit_find_objf_with_entry_addr): Likewise. (jit_breakpoint_deleted): Likewise. (jit_unwind_reg_set_impl): Likewise. (jit_unwind_reg_get_impl): Likewise. (jit_dealloc_cache): Likewise. (jit_frame_sniffer): Likewise. (jit_frame_prev_register): Likewise. (jit_prepend_unwinder): Likewise. (jit_inferior_exit_hook): Likewise. (free_objfile_data): Likewise. * jv-lang.c (jv_per_objfile_free): Likewise. (get_dynamics_objfile): Likewise. (get_java_class_symtab): Likewise. (builtin_java_type): Likewise. * language.c (language_string_char_type): Likewise. (language_bool_type): Likewise. (language_lookup_primitive_type): Likewise. (language_lookup_primitive_type_as_symbol): Likewise. * linespec.c (hash_address_entry): Likewise. (eq_address_entry): Likewise. (iterate_inline_only): Likewise. (iterate_name_matcher): Likewise. (decode_line_2_compare_items): Likewise. (collect_one_symbol): Likewise. (compare_symbols): Likewise. (compare_msymbols): Likewise. (add_symtabs_to_list): Likewise. (collect_symbols): Likewise. (compare_msyms): Likewise. (add_minsym): Likewise. (cleanup_linespec_result): Likewise. * linux-fork.c (inferior_call_waitpid_cleanup): Likewise. * linux-nat.c (delete_lwp_cleanup): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (resume_stopped_resumed_lwps): Likewise. * linux-tdep.c (get_linux_gdbarch_data): Likewise. (invalidate_linux_cache_inf): Likewise. (get_linux_inferior_data): Likewise. (linux_find_memory_regions_thunk): Likewise. (linux_make_mappings_callback): Likewise. (linux_corefile_thread_callback): Likewise. (find_mapping_size): Likewise. * linux-thread-db.c (find_new_threads_callback): Likewise. * lm32-tdep.c (lm32_frame_cache): Likewise. * m2-lang.c (builtin_m2_type): Likewise. * m32c-tdep.c (m32c_analyze_frame_prologue): Likewise. * m32r-linux-tdep.c (m32r_linux_sigtramp_frame_cache): Likewise. (m32r_linux_supply_gregset): Likewise. (m32r_linux_collect_gregset): Likewise. * m32r-tdep.c (m32r_frame_unwind_cache): Likewise. * m68hc11-tdep.c (m68hc11_frame_unwind_cache): Likewise. * m68k-tdep.c (m68k_frame_cache): Likewise. * m68kbsd-tdep.c (m68kbsd_supply_fpregset): Likewise. (m68kbsd_supply_gregset): Likewise. * m68klinux-tdep.c (m68k_linux_sigtramp_frame_cache): Likewise. * m88k-tdep.c (m88k_frame_cache): Likewise. (m88k_supply_gregset): Likewise. gdb/gdbserver/ChangeLog: * dll.c (match_dll): Add cast(s). (unloaded_dll): Likewise. * linux-low.c (second_thread_of_pid_p): Likewise. (delete_lwp_callback): Likewise. (count_events_callback): Likewise. (select_event_lwp_callback): Likewise. (linux_set_resume_request): Likewise. * server.c (accumulate_file_name_length): Likewise. (emit_dll_description): Likewise. (handle_qxfer_threads_worker): Likewise. (visit_actioned_threads): Likewise. * thread-db.c (any_thread_of): Likewise. * tracepoint.c (same_process_p): Likewise. (match_blocktype): Likewise. (build_traceframe_info_xml): Likewise. gdb/testsuite/ChangeLog: * gdb.gdb/selftest.exp (do_steps_and_nexts): Adjust expected source line.
1023 lines
27 KiB
C
1023 lines
27 KiB
C
/* Thread management interface, for the remote server for GDB.
|
|
Copyright (C) 2002-2015 Free Software Foundation, Inc.
|
|
|
|
Contributed by MontaVista Software.
|
|
|
|
This file is part of GDB.
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; either version 3 of the License, or
|
|
(at your option) any later version.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
|
|
|
#include "server.h"
|
|
|
|
#include "linux-low.h"
|
|
|
|
extern int debug_threads;
|
|
|
|
static int thread_db_use_events;
|
|
|
|
#include "gdb_proc_service.h"
|
|
#include "nat/gdb_thread_db.h"
|
|
#include "gdb_vecs.h"
|
|
#include "nat/linux-procfs.h"
|
|
|
|
#ifndef USE_LIBTHREAD_DB_DIRECTLY
|
|
#include <dlfcn.h>
|
|
#endif
|
|
#include <limits.h>
|
|
#include <ctype.h>
|
|
|
|
struct thread_db
|
|
{
|
|
/* Structure that identifies the child process for the
|
|
<proc_service.h> interface. */
|
|
struct ps_prochandle proc_handle;
|
|
|
|
/* Connection to the libthread_db library. */
|
|
td_thragent_t *thread_agent;
|
|
|
|
/* If this flag has been set, we've already asked GDB for all
|
|
symbols we might need; assume symbol cache misses are
|
|
failures. */
|
|
int all_symbols_looked_up;
|
|
|
|
#ifndef USE_LIBTHREAD_DB_DIRECTLY
|
|
/* Handle of the libthread_db from dlopen. */
|
|
void *handle;
|
|
#endif
|
|
|
|
/* Thread creation event breakpoint. The code at this location in
|
|
the child process will be called by the pthread library whenever
|
|
a new thread is created. By setting a special breakpoint at this
|
|
location, GDB can detect when a new thread is created. We obtain
|
|
this location via the td_ta_event_addr call. Note that if the
|
|
running kernel supports tracing clones, then we don't need to use
|
|
(and in fact don't use) this magic thread event breakpoint to
|
|
learn about threads. */
|
|
struct breakpoint *td_create_bp;
|
|
|
|
/* Addresses of libthread_db functions. */
|
|
td_ta_new_ftype *td_ta_new_p;
|
|
td_ta_event_getmsg_ftype * td_ta_event_getmsg_p;
|
|
td_ta_set_event_ftype *td_ta_set_event_p;
|
|
td_ta_event_addr_ftype *td_ta_event_addr_p;
|
|
td_ta_map_lwp2thr_ftype *td_ta_map_lwp2thr_p;
|
|
td_thr_get_info_ftype *td_thr_get_info_p;
|
|
td_thr_event_enable_ftype *td_thr_event_enable_p;
|
|
td_ta_thr_iter_ftype *td_ta_thr_iter_p;
|
|
td_thr_tls_get_addr_ftype *td_thr_tls_get_addr_p;
|
|
td_thr_tlsbase_ftype *td_thr_tlsbase_p;
|
|
td_symbol_list_ftype *td_symbol_list_p;
|
|
};
|
|
|
|
static char *libthread_db_search_path;
|
|
|
|
static int find_one_thread (ptid_t);
|
|
static int find_new_threads_callback (const td_thrhandle_t *th_p, void *data);
|
|
|
|
static const char *
|
|
thread_db_err_str (td_err_e err)
|
|
{
|
|
static char buf[64];
|
|
|
|
switch (err)
|
|
{
|
|
case TD_OK:
|
|
return "generic 'call succeeded'";
|
|
case TD_ERR:
|
|
return "generic error";
|
|
case TD_NOTHR:
|
|
return "no thread to satisfy query";
|
|
case TD_NOSV:
|
|
return "no sync handle to satisfy query";
|
|
case TD_NOLWP:
|
|
return "no LWP to satisfy query";
|
|
case TD_BADPH:
|
|
return "invalid process handle";
|
|
case TD_BADTH:
|
|
return "invalid thread handle";
|
|
case TD_BADSH:
|
|
return "invalid synchronization handle";
|
|
case TD_BADTA:
|
|
return "invalid thread agent";
|
|
case TD_BADKEY:
|
|
return "invalid key";
|
|
case TD_NOMSG:
|
|
return "no event message for getmsg";
|
|
case TD_NOFPREGS:
|
|
return "FPU register set not available";
|
|
case TD_NOLIBTHREAD:
|
|
return "application not linked with libthread";
|
|
case TD_NOEVENT:
|
|
return "requested event is not supported";
|
|
case TD_NOCAPAB:
|
|
return "capability not available";
|
|
case TD_DBERR:
|
|
return "debugger service failed";
|
|
case TD_NOAPLIC:
|
|
return "operation not applicable to";
|
|
case TD_NOTSD:
|
|
return "no thread-specific data for this thread";
|
|
case TD_MALLOC:
|
|
return "malloc failed";
|
|
case TD_PARTIALREG:
|
|
return "only part of register set was written/read";
|
|
case TD_NOXREGS:
|
|
return "X register set not available for this thread";
|
|
#ifdef HAVE_TD_VERSION
|
|
case TD_VERSION:
|
|
return "version mismatch between libthread_db and libpthread";
|
|
#endif
|
|
default:
|
|
xsnprintf (buf, sizeof (buf), "unknown thread_db error '%d'", err);
|
|
return buf;
|
|
}
|
|
}
|
|
|
|
#if 0
|
|
static char *
|
|
thread_db_state_str (td_thr_state_e state)
|
|
{
|
|
static char buf[64];
|
|
|
|
switch (state)
|
|
{
|
|
case TD_THR_STOPPED:
|
|
return "stopped by debugger";
|
|
case TD_THR_RUN:
|
|
return "runnable";
|
|
case TD_THR_ACTIVE:
|
|
return "active";
|
|
case TD_THR_ZOMBIE:
|
|
return "zombie";
|
|
case TD_THR_SLEEP:
|
|
return "sleeping";
|
|
case TD_THR_STOPPED_ASLEEP:
|
|
return "stopped by debugger AND blocked";
|
|
default:
|
|
xsnprintf (buf, sizeof (buf), "unknown thread_db state %d", state);
|
|
return buf;
|
|
}
|
|
}
|
|
#endif
|
|
|
|
static int
|
|
thread_db_create_event (CORE_ADDR where)
|
|
{
|
|
td_event_msg_t msg;
|
|
td_err_e err;
|
|
struct lwp_info *lwp;
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
|
|
gdb_assert (thread_db->td_ta_event_getmsg_p != NULL);
|
|
|
|
if (debug_threads)
|
|
debug_printf ("Thread creation event.\n");
|
|
|
|
/* FIXME: This assumes we don't get another event.
|
|
In the LinuxThreads implementation, this is safe,
|
|
because all events come from the manager thread
|
|
(except for its own creation, of course). */
|
|
err = thread_db->td_ta_event_getmsg_p (thread_db->thread_agent, &msg);
|
|
if (err != TD_OK)
|
|
fprintf (stderr, "thread getmsg err: %s\n",
|
|
thread_db_err_str (err));
|
|
|
|
/* If we do not know about the main thread yet, this would be a good time to
|
|
find it. We need to do this to pick up the main thread before any newly
|
|
created threads. */
|
|
lwp = get_thread_lwp (current_thread);
|
|
if (lwp->thread_known == 0)
|
|
find_one_thread (current_thread->entry.id);
|
|
|
|
/* msg.event == TD_EVENT_CREATE */
|
|
|
|
find_new_threads_callback (msg.th_p, NULL);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
thread_db_enable_reporting (void)
|
|
{
|
|
td_thr_events_t events;
|
|
td_notify_t notify;
|
|
td_err_e err;
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
|
|
if (thread_db->td_ta_set_event_p == NULL
|
|
|| thread_db->td_ta_event_addr_p == NULL
|
|
|| thread_db->td_ta_event_getmsg_p == NULL)
|
|
/* This libthread_db is missing required support. */
|
|
return 0;
|
|
|
|
/* Set the process wide mask saying which events we're interested in. */
|
|
td_event_emptyset (&events);
|
|
td_event_addset (&events, TD_CREATE);
|
|
|
|
err = thread_db->td_ta_set_event_p (thread_db->thread_agent, &events);
|
|
if (err != TD_OK)
|
|
{
|
|
warning ("Unable to set global thread event mask: %s",
|
|
thread_db_err_str (err));
|
|
return 0;
|
|
}
|
|
|
|
/* Get address for thread creation breakpoint. */
|
|
err = thread_db->td_ta_event_addr_p (thread_db->thread_agent, TD_CREATE,
|
|
¬ify);
|
|
if (err != TD_OK)
|
|
{
|
|
warning ("Unable to get location for thread creation breakpoint: %s",
|
|
thread_db_err_str (err));
|
|
return 0;
|
|
}
|
|
thread_db->td_create_bp
|
|
= set_breakpoint_at ((CORE_ADDR) (unsigned long) notify.u.bptaddr,
|
|
thread_db_create_event);
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
find_one_thread (ptid_t ptid)
|
|
{
|
|
td_thrhandle_t th;
|
|
td_thrinfo_t ti;
|
|
td_err_e err;
|
|
struct thread_info *inferior;
|
|
struct lwp_info *lwp;
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
int lwpid = ptid_get_lwp (ptid);
|
|
|
|
inferior = (struct thread_info *) find_inferior_id (&all_threads, ptid);
|
|
lwp = get_thread_lwp (inferior);
|
|
if (lwp->thread_known)
|
|
return 1;
|
|
|
|
/* Get information about this thread. */
|
|
err = thread_db->td_ta_map_lwp2thr_p (thread_db->thread_agent, lwpid, &th);
|
|
if (err != TD_OK)
|
|
error ("Cannot get thread handle for LWP %d: %s",
|
|
lwpid, thread_db_err_str (err));
|
|
|
|
err = thread_db->td_thr_get_info_p (&th, &ti);
|
|
if (err != TD_OK)
|
|
error ("Cannot get thread info for LWP %d: %s",
|
|
lwpid, thread_db_err_str (err));
|
|
|
|
if (debug_threads)
|
|
debug_printf ("Found thread %ld (LWP %d)\n",
|
|
ti.ti_tid, ti.ti_lid);
|
|
|
|
if (lwpid != ti.ti_lid)
|
|
{
|
|
warning ("PID mismatch! Expected %ld, got %ld",
|
|
(long) lwpid, (long) ti.ti_lid);
|
|
return 0;
|
|
}
|
|
|
|
if (thread_db_use_events)
|
|
{
|
|
err = thread_db->td_thr_event_enable_p (&th, 1);
|
|
if (err != TD_OK)
|
|
error ("Cannot enable thread event reporting for %d: %s",
|
|
ti.ti_lid, thread_db_err_str (err));
|
|
}
|
|
|
|
/* If the new thread ID is zero, a final thread ID will be available
|
|
later. Do not enable thread debugging yet. */
|
|
if (ti.ti_tid == 0)
|
|
return 0;
|
|
|
|
lwp->thread_known = 1;
|
|
lwp->th = th;
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Attach a thread. Return true on success. */
|
|
|
|
static int
|
|
attach_thread (const td_thrhandle_t *th_p, td_thrinfo_t *ti_p)
|
|
{
|
|
struct process_info *proc = current_process ();
|
|
int pid = pid_of (proc);
|
|
ptid_t ptid = ptid_build (pid, ti_p->ti_lid, 0);
|
|
struct lwp_info *lwp;
|
|
int err;
|
|
|
|
if (debug_threads)
|
|
debug_printf ("Attaching to thread %ld (LWP %d)\n",
|
|
ti_p->ti_tid, ti_p->ti_lid);
|
|
err = linux_attach_lwp (ptid);
|
|
if (err != 0)
|
|
{
|
|
warning ("Could not attach to thread %ld (LWP %d): %s\n",
|
|
ti_p->ti_tid, ti_p->ti_lid,
|
|
linux_ptrace_attach_fail_reason_string (ptid, err));
|
|
return 0;
|
|
}
|
|
|
|
lwp = find_lwp_pid (ptid);
|
|
gdb_assert (lwp != NULL);
|
|
lwp->thread_known = 1;
|
|
lwp->th = *th_p;
|
|
|
|
if (thread_db_use_events)
|
|
{
|
|
td_err_e err;
|
|
struct thread_db *thread_db = proc->priv->thread_db;
|
|
|
|
err = thread_db->td_thr_event_enable_p (th_p, 1);
|
|
if (err != TD_OK)
|
|
error ("Cannot enable thread event reporting for %d: %s",
|
|
ti_p->ti_lid, thread_db_err_str (err));
|
|
}
|
|
|
|
return 1;
|
|
}
|
|
|
|
/* Attach thread if we haven't seen it yet.
|
|
Increment *COUNTER if we have attached a new thread.
|
|
Return false on failure. */
|
|
|
|
static int
|
|
maybe_attach_thread (const td_thrhandle_t *th_p, td_thrinfo_t *ti_p,
|
|
int *counter)
|
|
{
|
|
struct lwp_info *lwp;
|
|
|
|
lwp = find_lwp_pid (pid_to_ptid (ti_p->ti_lid));
|
|
if (lwp != NULL)
|
|
return 1;
|
|
|
|
if (!attach_thread (th_p, ti_p))
|
|
return 0;
|
|
|
|
if (counter != NULL)
|
|
*counter += 1;
|
|
|
|
return 1;
|
|
}
|
|
|
|
static int
|
|
find_new_threads_callback (const td_thrhandle_t *th_p, void *data)
|
|
{
|
|
td_thrinfo_t ti;
|
|
td_err_e err;
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
|
|
err = thread_db->td_thr_get_info_p (th_p, &ti);
|
|
if (err != TD_OK)
|
|
error ("Cannot get thread info: %s", thread_db_err_str (err));
|
|
|
|
if (ti.ti_lid == -1)
|
|
{
|
|
/* A thread with kernel thread ID -1 is either a thread that
|
|
exited and was joined, or a thread that is being created but
|
|
hasn't started yet, and that is reusing the tcb/stack of a
|
|
thread that previously exited and was joined. (glibc marks
|
|
terminated and joined threads with kernel thread ID -1. See
|
|
glibc PR17707. */
|
|
if (debug_threads)
|
|
debug_printf ("thread_db: skipping exited and "
|
|
"joined thread (0x%lx)\n", ti.ti_tid);
|
|
return 0;
|
|
}
|
|
|
|
/* Check for zombies. */
|
|
if (ti.ti_state == TD_THR_UNKNOWN || ti.ti_state == TD_THR_ZOMBIE)
|
|
return 0;
|
|
|
|
if (!maybe_attach_thread (th_p, &ti, (int *) data))
|
|
{
|
|
/* Terminate iteration early: we might be looking at stale data in
|
|
the inferior. The thread_db_find_new_threads will retry. */
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
thread_db_find_new_threads (void)
|
|
{
|
|
td_err_e err;
|
|
ptid_t ptid = current_ptid;
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
int loop, iteration;
|
|
|
|
/* This function is only called when we first initialize thread_db.
|
|
First locate the initial thread. If it is not ready for
|
|
debugging yet, then stop. */
|
|
if (find_one_thread (ptid) == 0)
|
|
return;
|
|
|
|
/* Require 4 successive iterations which do not find any new threads.
|
|
The 4 is a heuristic: there is an inherent race here, and I have
|
|
seen that 2 iterations in a row are not always sufficient to
|
|
"capture" all threads. */
|
|
for (loop = 0, iteration = 0; loop < 4; ++loop, ++iteration)
|
|
{
|
|
int new_thread_count = 0;
|
|
|
|
/* Iterate over all user-space threads to discover new threads. */
|
|
err = thread_db->td_ta_thr_iter_p (thread_db->thread_agent,
|
|
find_new_threads_callback,
|
|
&new_thread_count,
|
|
TD_THR_ANY_STATE,
|
|
TD_THR_LOWEST_PRIORITY,
|
|
TD_SIGNO_MASK, TD_THR_ANY_USER_FLAGS);
|
|
if (debug_threads)
|
|
debug_printf ("Found %d threads in iteration %d.\n",
|
|
new_thread_count, iteration);
|
|
|
|
if (new_thread_count != 0)
|
|
{
|
|
/* Found new threads. Restart iteration from beginning. */
|
|
loop = -1;
|
|
}
|
|
}
|
|
if (err != TD_OK)
|
|
error ("Cannot find new threads: %s", thread_db_err_str (err));
|
|
}
|
|
|
|
/* Cache all future symbols that thread_db might request. We can not
|
|
request symbols at arbitrary states in the remote protocol, only
|
|
when the client tells us that new symbols are available. So when
|
|
we load the thread library, make sure to check the entire list. */
|
|
|
|
static void
|
|
thread_db_look_up_symbols (void)
|
|
{
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
const char **sym_list;
|
|
CORE_ADDR unused;
|
|
|
|
for (sym_list = thread_db->td_symbol_list_p (); *sym_list; sym_list++)
|
|
look_up_one_symbol (*sym_list, &unused, 1);
|
|
|
|
/* We're not interested in any other libraries loaded after this
|
|
point, only in symbols in libpthread.so. */
|
|
thread_db->all_symbols_looked_up = 1;
|
|
}
|
|
|
|
int
|
|
thread_db_look_up_one_symbol (const char *name, CORE_ADDR *addrp)
|
|
{
|
|
struct thread_db *thread_db = current_process ()->priv->thread_db;
|
|
int may_ask_gdb = !thread_db->all_symbols_looked_up;
|
|
|
|
/* If we've passed the call to thread_db_look_up_symbols, then
|
|
anything not in the cache must not exist; we're not interested
|
|
in any libraries loaded after that point, only in symbols in
|
|
libpthread.so. It might not be an appropriate time to look
|
|
up a symbol, e.g. while we're trying to fetch registers. */
|
|
return look_up_one_symbol (name, addrp, may_ask_gdb);
|
|
}
|
|
|
|
int
|
|
thread_db_get_tls_address (struct thread_info *thread, CORE_ADDR offset,
|
|
CORE_ADDR load_module, CORE_ADDR *address)
|
|
{
|
|
psaddr_t addr;
|
|
td_err_e err;
|
|
struct lwp_info *lwp;
|
|
struct thread_info *saved_thread;
|
|
struct process_info *proc;
|
|
struct thread_db *thread_db;
|
|
|
|
proc = get_thread_process (thread);
|
|
thread_db = proc->priv->thread_db;
|
|
|
|
/* If the thread layer is not (yet) initialized, fail. */
|
|
if (thread_db == NULL || !thread_db->all_symbols_looked_up)
|
|
return TD_ERR;
|
|
|
|
/* If td_thr_tls_get_addr is missing rather do not expect td_thr_tlsbase
|
|
could work. */
|
|
if (thread_db->td_thr_tls_get_addr_p == NULL
|
|
|| (load_module == 0 && thread_db->td_thr_tlsbase_p == NULL))
|
|
return -1;
|
|
|
|
lwp = get_thread_lwp (thread);
|
|
if (!lwp->thread_known)
|
|
find_one_thread (thread->entry.id);
|
|
if (!lwp->thread_known)
|
|
return TD_NOTHR;
|
|
|
|
saved_thread = current_thread;
|
|
current_thread = thread;
|
|
|
|
if (load_module != 0)
|
|
{
|
|
/* Note the cast through uintptr_t: this interface only works if
|
|
a target address fits in a psaddr_t, which is a host pointer.
|
|
So a 32-bit debugger can not access 64-bit TLS through this. */
|
|
err = thread_db->td_thr_tls_get_addr_p (&lwp->th,
|
|
(psaddr_t) (uintptr_t) load_module,
|
|
offset, &addr);
|
|
}
|
|
else
|
|
{
|
|
/* This code path handles the case of -static -pthread executables:
|
|
https://sourceware.org/ml/libc-help/2014-03/msg00024.html
|
|
For older GNU libc r_debug.r_map is NULL. For GNU libc after
|
|
PR libc/16831 due to GDB PR threads/16954 LOAD_MODULE is also NULL.
|
|
The constant number 1 depends on GNU __libc_setup_tls
|
|
initialization of l_tls_modid to 1. */
|
|
err = thread_db->td_thr_tlsbase_p (&lwp->th, 1, &addr);
|
|
addr = (char *) addr + offset;
|
|
}
|
|
|
|
current_thread = saved_thread;
|
|
if (err == TD_OK)
|
|
{
|
|
*address = (CORE_ADDR) (uintptr_t) addr;
|
|
return 0;
|
|
}
|
|
else
|
|
return err;
|
|
}
|
|
|
|
#ifdef USE_LIBTHREAD_DB_DIRECTLY
|
|
|
|
static int
|
|
thread_db_load_search (void)
|
|
{
|
|
td_err_e err;
|
|
struct thread_db *tdb;
|
|
struct process_info *proc = current_process ();
|
|
|
|
gdb_assert (proc->priv->thread_db == NULL);
|
|
|
|
tdb = XCNEW (struct thread_db);
|
|
proc->priv->thread_db = tdb;
|
|
|
|
tdb->td_ta_new_p = &td_ta_new;
|
|
|
|
/* Attempt to open a connection to the thread library. */
|
|
err = tdb->td_ta_new_p (&tdb->proc_handle, &tdb->thread_agent);
|
|
if (err != TD_OK)
|
|
{
|
|
if (debug_threads)
|
|
debug_printf ("td_ta_new(): %s\n", thread_db_err_str (err));
|
|
free (tdb);
|
|
proc->priv->thread_db = NULL;
|
|
return 0;
|
|
}
|
|
|
|
tdb->td_ta_map_lwp2thr_p = &td_ta_map_lwp2thr;
|
|
tdb->td_thr_get_info_p = &td_thr_get_info;
|
|
tdb->td_ta_thr_iter_p = &td_ta_thr_iter;
|
|
tdb->td_symbol_list_p = &td_symbol_list;
|
|
|
|
/* This is required only when thread_db_use_events is on. */
|
|
tdb->td_thr_event_enable_p = &td_thr_event_enable;
|
|
|
|
/* These are not essential. */
|
|
tdb->td_ta_event_addr_p = &td_ta_event_addr;
|
|
tdb->td_ta_set_event_p = &td_ta_set_event;
|
|
tdb->td_ta_event_getmsg_p = &td_ta_event_getmsg;
|
|
tdb->td_thr_tls_get_addr_p = &td_thr_tls_get_addr;
|
|
tdb->td_thr_tlsbase_p = &td_thr_tlsbase;
|
|
|
|
return 1;
|
|
}
|
|
|
|
#else
|
|
|
|
static int
|
|
try_thread_db_load_1 (void *handle)
|
|
{
|
|
td_err_e err;
|
|
struct thread_db *tdb;
|
|
struct process_info *proc = current_process ();
|
|
|
|
gdb_assert (proc->priv->thread_db == NULL);
|
|
|
|
tdb = XCNEW (struct thread_db);
|
|
proc->priv->thread_db = tdb;
|
|
|
|
tdb->handle = handle;
|
|
|
|
/* Initialize pointers to the dynamic library functions we will use.
|
|
Essential functions first. */
|
|
|
|
#define CHK(required, a) \
|
|
do \
|
|
{ \
|
|
if ((a) == NULL) \
|
|
{ \
|
|
if (debug_threads) \
|
|
debug_printf ("dlsym: %s\n", dlerror ()); \
|
|
if (required) \
|
|
{ \
|
|
free (tdb); \
|
|
proc->priv->thread_db = NULL; \
|
|
return 0; \
|
|
} \
|
|
} \
|
|
} \
|
|
while (0)
|
|
|
|
#define TDB_DLSYM(tdb, func) \
|
|
tdb->func ## _p = (func ## _ftype *) dlsym (tdb->handle, #func)
|
|
|
|
CHK (1, TDB_DLSYM (tdb, td_ta_new));
|
|
|
|
/* Attempt to open a connection to the thread library. */
|
|
err = tdb->td_ta_new_p (&tdb->proc_handle, &tdb->thread_agent);
|
|
if (err != TD_OK)
|
|
{
|
|
if (debug_threads)
|
|
debug_printf ("td_ta_new(): %s\n", thread_db_err_str (err));
|
|
free (tdb);
|
|
proc->priv->thread_db = NULL;
|
|
return 0;
|
|
}
|
|
|
|
CHK (1, TDB_DLSYM (tdb, td_ta_map_lwp2thr));
|
|
CHK (1, TDB_DLSYM (tdb, td_thr_get_info));
|
|
CHK (1, TDB_DLSYM (tdb, td_ta_thr_iter));
|
|
CHK (1, TDB_DLSYM (tdb, td_symbol_list));
|
|
|
|
/* This is required only when thread_db_use_events is on. */
|
|
CHK (thread_db_use_events, TDB_DLSYM (tdb, td_thr_event_enable));
|
|
|
|
/* These are not essential. */
|
|
CHK (0, TDB_DLSYM (tdb, td_ta_event_addr));
|
|
CHK (0, TDB_DLSYM (tdb, td_ta_set_event));
|
|
CHK (0, TDB_DLSYM (tdb, td_ta_event_getmsg));
|
|
CHK (0, TDB_DLSYM (tdb, td_thr_tls_get_addr));
|
|
CHK (0, TDB_DLSYM (tdb, td_thr_tlsbase));
|
|
|
|
#undef CHK
|
|
#undef TDB_DLSYM
|
|
|
|
return 1;
|
|
}
|
|
|
|
#ifdef HAVE_DLADDR
|
|
|
|
/* Lookup a library in which given symbol resides.
|
|
Note: this is looking in the GDBSERVER process, not in the inferior.
|
|
Returns library name, or NULL. */
|
|
|
|
static const char *
|
|
dladdr_to_soname (const void *addr)
|
|
{
|
|
Dl_info info;
|
|
|
|
if (dladdr (addr, &info) != 0)
|
|
return info.dli_fname;
|
|
return NULL;
|
|
}
|
|
|
|
#endif
|
|
|
|
static int
|
|
try_thread_db_load (const char *library)
|
|
{
|
|
void *handle;
|
|
|
|
if (debug_threads)
|
|
debug_printf ("Trying host libthread_db library: %s.\n",
|
|
library);
|
|
handle = dlopen (library, RTLD_NOW);
|
|
if (handle == NULL)
|
|
{
|
|
if (debug_threads)
|
|
debug_printf ("dlopen failed: %s.\n", dlerror ());
|
|
return 0;
|
|
}
|
|
|
|
#ifdef HAVE_DLADDR
|
|
if (debug_threads && strchr (library, '/') == NULL)
|
|
{
|
|
void *td_init;
|
|
|
|
td_init = dlsym (handle, "td_init");
|
|
if (td_init != NULL)
|
|
{
|
|
const char *const libpath = dladdr_to_soname (td_init);
|
|
|
|
if (libpath != NULL)
|
|
fprintf (stderr, "Host %s resolved to: %s.\n",
|
|
library, libpath);
|
|
}
|
|
}
|
|
#endif
|
|
|
|
if (try_thread_db_load_1 (handle))
|
|
return 1;
|
|
|
|
/* This library "refused" to work on current inferior. */
|
|
dlclose (handle);
|
|
return 0;
|
|
}
|
|
|
|
/* Handle $sdir in libthread-db-search-path.
|
|
Look for libthread_db in the system dirs, or wherever a plain
|
|
dlopen(file_without_path) will look.
|
|
The result is true for success. */
|
|
|
|
static int
|
|
try_thread_db_load_from_sdir (void)
|
|
{
|
|
return try_thread_db_load (LIBTHREAD_DB_SO);
|
|
}
|
|
|
|
/* Try to load libthread_db from directory DIR of length DIR_LEN.
|
|
The result is true for success. */
|
|
|
|
static int
|
|
try_thread_db_load_from_dir (const char *dir, size_t dir_len)
|
|
{
|
|
char path[PATH_MAX];
|
|
|
|
if (dir_len + 1 + strlen (LIBTHREAD_DB_SO) + 1 > sizeof (path))
|
|
{
|
|
char *cp = (char *) xmalloc (dir_len + 1);
|
|
|
|
memcpy (cp, dir, dir_len);
|
|
cp[dir_len] = '\0';
|
|
warning (_("libthread-db-search-path component too long,"
|
|
" ignored: %s."), cp);
|
|
free (cp);
|
|
return 0;
|
|
}
|
|
|
|
memcpy (path, dir, dir_len);
|
|
path[dir_len] = '/';
|
|
strcpy (path + dir_len + 1, LIBTHREAD_DB_SO);
|
|
return try_thread_db_load (path);
|
|
}
|
|
|
|
/* Search libthread_db_search_path for libthread_db which "agrees"
|
|
to work on current inferior.
|
|
The result is true for success. */
|
|
|
|
static int
|
|
thread_db_load_search (void)
|
|
{
|
|
VEC (char_ptr) *dir_vec;
|
|
char *this_dir;
|
|
int i, rc = 0;
|
|
|
|
if (libthread_db_search_path == NULL)
|
|
libthread_db_search_path = xstrdup (LIBTHREAD_DB_SEARCH_PATH);
|
|
|
|
dir_vec = dirnames_to_char_ptr_vec (libthread_db_search_path);
|
|
|
|
for (i = 0; VEC_iterate (char_ptr, dir_vec, i, this_dir); ++i)
|
|
{
|
|
const int pdir_len = sizeof ("$pdir") - 1;
|
|
size_t this_dir_len;
|
|
|
|
this_dir_len = strlen (this_dir);
|
|
|
|
if (strncmp (this_dir, "$pdir", pdir_len) == 0
|
|
&& (this_dir[pdir_len] == '\0'
|
|
|| this_dir[pdir_len] == '/'))
|
|
{
|
|
/* We don't maintain a list of loaded libraries so we don't know
|
|
where libpthread lives. We *could* fetch the info, but we don't
|
|
do that yet. Ignore it. */
|
|
}
|
|
else if (strcmp (this_dir, "$sdir") == 0)
|
|
{
|
|
if (try_thread_db_load_from_sdir ())
|
|
{
|
|
rc = 1;
|
|
break;
|
|
}
|
|
}
|
|
else
|
|
{
|
|
if (try_thread_db_load_from_dir (this_dir, this_dir_len))
|
|
{
|
|
rc = 1;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
free_char_ptr_vec (dir_vec);
|
|
if (debug_threads)
|
|
debug_printf ("thread_db_load_search returning %d\n", rc);
|
|
return rc;
|
|
}
|
|
|
|
#endif /* USE_LIBTHREAD_DB_DIRECTLY */
|
|
|
|
int
|
|
thread_db_init (int use_events)
|
|
{
|
|
struct process_info *proc = current_process ();
|
|
|
|
/* FIXME drow/2004-10-16: This is the "overall process ID", which
|
|
GNU/Linux calls tgid, "thread group ID". When we support
|
|
attaching to threads, the original thread may not be the correct
|
|
thread. We would have to get the process ID from /proc for NPTL.
|
|
For LinuxThreads we could do something similar: follow the chain
|
|
of parent processes until we find the highest one we're attached
|
|
to, and use its tgid.
|
|
|
|
This isn't the only place in gdbserver that assumes that the first
|
|
process in the list is the thread group leader. */
|
|
|
|
thread_db_use_events = use_events;
|
|
|
|
if (thread_db_load_search ())
|
|
{
|
|
if (use_events && thread_db_enable_reporting () == 0)
|
|
{
|
|
/* Keep trying; maybe event reporting will work later. */
|
|
thread_db_mourn (proc);
|
|
return 0;
|
|
}
|
|
|
|
/* It's best to avoid td_ta_thr_iter if possible. That walks
|
|
data structures in the inferior's address space that may be
|
|
corrupted, or, if the target is running, the list may change
|
|
while we walk it. In the latter case, it's possible that a
|
|
thread exits just at the exact time that causes GDBserver to
|
|
get stuck in an infinite loop. If the kernel supports clone
|
|
events, and /proc/PID/task/ exits, then we already know about
|
|
all threads in the process. When we need info out of
|
|
thread_db on a given thread (e.g., for TLS), we'll use
|
|
find_one_thread then. That uses thread_db entry points that
|
|
do not walk libpthread's thread list, so should be safe, as
|
|
well as more efficient. */
|
|
if (use_events
|
|
|| !linux_proc_task_list_dir_exists (pid_of (proc)))
|
|
thread_db_find_new_threads ();
|
|
thread_db_look_up_symbols ();
|
|
return 1;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
any_thread_of (struct inferior_list_entry *entry, void *args)
|
|
{
|
|
int *pid_p = (int *) args;
|
|
|
|
if (ptid_get_pid (entry->id) == *pid_p)
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void
|
|
switch_to_process (struct process_info *proc)
|
|
{
|
|
int pid = pid_of (proc);
|
|
|
|
current_thread =
|
|
(struct thread_info *) find_inferior (&all_threads,
|
|
any_thread_of, &pid);
|
|
}
|
|
|
|
/* Disconnect from libthread_db and free resources. */
|
|
|
|
static void
|
|
disable_thread_event_reporting (struct process_info *proc)
|
|
{
|
|
struct thread_db *thread_db = proc->priv->thread_db;
|
|
if (thread_db)
|
|
{
|
|
td_err_e (*td_ta_clear_event_p) (const td_thragent_t *ta,
|
|
td_thr_events_t *event);
|
|
|
|
#ifndef USE_LIBTHREAD_DB_DIRECTLY
|
|
td_ta_clear_event_p
|
|
= (td_ta_clear_event_ftype *) dlsym (thread_db->handle,
|
|
"td_ta_clear_event");
|
|
#else
|
|
td_ta_clear_event_p = &td_ta_clear_event;
|
|
#endif
|
|
|
|
if (td_ta_clear_event_p != NULL)
|
|
{
|
|
struct thread_info *saved_thread = current_thread;
|
|
td_thr_events_t events;
|
|
|
|
switch_to_process (proc);
|
|
|
|
/* Set the process wide mask saying we aren't interested
|
|
in any events anymore. */
|
|
td_event_fillset (&events);
|
|
(*td_ta_clear_event_p) (thread_db->thread_agent, &events);
|
|
|
|
current_thread = saved_thread;
|
|
}
|
|
}
|
|
}
|
|
|
|
static void
|
|
remove_thread_event_breakpoints (struct process_info *proc)
|
|
{
|
|
struct thread_db *thread_db = proc->priv->thread_db;
|
|
|
|
if (thread_db->td_create_bp != NULL)
|
|
{
|
|
struct thread_info *saved_thread = current_thread;
|
|
|
|
switch_to_process (proc);
|
|
|
|
delete_breakpoint (thread_db->td_create_bp);
|
|
thread_db->td_create_bp = NULL;
|
|
|
|
current_thread = saved_thread;
|
|
}
|
|
}
|
|
|
|
void
|
|
thread_db_detach (struct process_info *proc)
|
|
{
|
|
struct thread_db *thread_db = proc->priv->thread_db;
|
|
|
|
if (thread_db)
|
|
{
|
|
disable_thread_event_reporting (proc);
|
|
remove_thread_event_breakpoints (proc);
|
|
}
|
|
}
|
|
|
|
/* Disconnect from libthread_db and free resources. */
|
|
|
|
void
|
|
thread_db_mourn (struct process_info *proc)
|
|
{
|
|
struct thread_db *thread_db = proc->priv->thread_db;
|
|
if (thread_db)
|
|
{
|
|
td_ta_delete_ftype *td_ta_delete_p;
|
|
|
|
#ifndef USE_LIBTHREAD_DB_DIRECTLY
|
|
td_ta_delete_p = (td_ta_delete_ftype *) dlsym (thread_db->handle, "td_ta_delete");
|
|
#else
|
|
td_ta_delete_p = &td_ta_delete;
|
|
#endif
|
|
|
|
if (td_ta_delete_p != NULL)
|
|
(*td_ta_delete_p) (thread_db->thread_agent);
|
|
|
|
#ifndef USE_LIBTHREAD_DB_DIRECTLY
|
|
dlclose (thread_db->handle);
|
|
#endif /* USE_LIBTHREAD_DB_DIRECTLY */
|
|
|
|
free (thread_db);
|
|
proc->priv->thread_db = NULL;
|
|
}
|
|
}
|
|
|
|
/* Handle "set libthread-db-search-path" monitor command and return 1.
|
|
For any other command, return 0. */
|
|
|
|
int
|
|
thread_db_handle_monitor_command (char *mon)
|
|
{
|
|
const char *cmd = "set libthread-db-search-path";
|
|
size_t cmd_len = strlen (cmd);
|
|
|
|
if (strncmp (mon, cmd, cmd_len) == 0
|
|
&& (mon[cmd_len] == '\0'
|
|
|| mon[cmd_len] == ' '))
|
|
{
|
|
const char *cp = mon + cmd_len;
|
|
|
|
if (libthread_db_search_path != NULL)
|
|
free (libthread_db_search_path);
|
|
|
|
/* Skip leading space (if any). */
|
|
while (isspace (*cp))
|
|
++cp;
|
|
|
|
if (*cp == '\0')
|
|
cp = LIBTHREAD_DB_SEARCH_PATH;
|
|
libthread_db_search_path = xstrdup (cp);
|
|
|
|
monitor_output ("libthread-db-search-path set to `");
|
|
monitor_output (libthread_db_search_path);
|
|
monitor_output ("'\n");
|
|
return 1;
|
|
}
|
|
|
|
/* Tell server.c to perform default processing. */
|
|
return 0;
|
|
}
|