224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
529 lines
13 KiB
C
529 lines
13 KiB
C
/* Core dump and executable file functions above target vector, for GDB.
|
||
|
||
Copyright (C) 1986-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include <signal.h>
|
||
#include <fcntl.h>
|
||
#include "inferior.h"
|
||
#include "symtab.h"
|
||
#include "command.h"
|
||
#include "gdbcmd.h"
|
||
#include "bfd.h"
|
||
#include "target.h"
|
||
#include "gdbcore.h"
|
||
#include "dis-asm.h"
|
||
#include <sys/stat.h>
|
||
#include "completer.h"
|
||
#include "observer.h"
|
||
#include "cli/cli-utils.h"
|
||
|
||
/* Local function declarations. */
|
||
|
||
extern void _initialize_core (void);
|
||
|
||
/* You can have any number of hooks for `exec_file_command' command to
|
||
call. If there's only one hook, it is set in exec_file_display
|
||
hook. If there are two or more hooks, they are set in
|
||
exec_file_extra_hooks[], and deprecated_exec_file_display_hook is
|
||
set to a function that calls all of them. This extra complexity is
|
||
needed to preserve compatibility with old code that assumed that
|
||
only one hook could be set, and which called
|
||
deprecated_exec_file_display_hook directly. */
|
||
|
||
typedef void (*hook_type) (const char *);
|
||
|
||
hook_type deprecated_exec_file_display_hook; /* The original hook. */
|
||
static hook_type *exec_file_extra_hooks; /* Array of additional
|
||
hooks. */
|
||
static int exec_file_hook_count = 0; /* Size of array. */
|
||
|
||
/* Binary file diddling handle for the core file. */
|
||
|
||
bfd *core_bfd = NULL;
|
||
|
||
/* corelow.c target. It is never NULL after GDB initialization. */
|
||
|
||
struct target_ops *core_target;
|
||
|
||
|
||
/* Backward compatability with old way of specifying core files. */
|
||
|
||
void
|
||
core_file_command (char *filename, int from_tty)
|
||
{
|
||
dont_repeat (); /* Either way, seems bogus. */
|
||
|
||
gdb_assert (core_target != NULL);
|
||
|
||
if (!filename)
|
||
(core_target->to_detach) (core_target, filename, from_tty);
|
||
else
|
||
(core_target->to_open) (filename, from_tty);
|
||
}
|
||
|
||
|
||
/* If there are two or more functions that wish to hook into
|
||
exec_file_command, this function will call all of the hook
|
||
functions. */
|
||
|
||
static void
|
||
call_extra_exec_file_hooks (const char *filename)
|
||
{
|
||
int i;
|
||
|
||
for (i = 0; i < exec_file_hook_count; i++)
|
||
(*exec_file_extra_hooks[i]) (filename);
|
||
}
|
||
|
||
/* Call this to specify the hook for exec_file_command to call back.
|
||
This is called from the x-window display code. */
|
||
|
||
void
|
||
specify_exec_file_hook (void (*hook) (const char *))
|
||
{
|
||
hook_type *new_array;
|
||
|
||
if (deprecated_exec_file_display_hook != NULL)
|
||
{
|
||
/* There's already a hook installed. Arrange to have both it
|
||
and the subsequent hooks called. */
|
||
if (exec_file_hook_count == 0)
|
||
{
|
||
/* If this is the first extra hook, initialize the hook
|
||
array. */
|
||
exec_file_extra_hooks = XNEW (hook_type);
|
||
exec_file_extra_hooks[0] = deprecated_exec_file_display_hook;
|
||
deprecated_exec_file_display_hook = call_extra_exec_file_hooks;
|
||
exec_file_hook_count = 1;
|
||
}
|
||
|
||
/* Grow the hook array by one and add the new hook to the end.
|
||
Yes, it's inefficient to grow it by one each time but since
|
||
this is hardly ever called it's not a big deal. */
|
||
exec_file_hook_count++;
|
||
new_array = (hook_type *)
|
||
xrealloc (exec_file_extra_hooks,
|
||
exec_file_hook_count * sizeof (hook_type));
|
||
exec_file_extra_hooks = new_array;
|
||
exec_file_extra_hooks[exec_file_hook_count - 1] = hook;
|
||
}
|
||
else
|
||
deprecated_exec_file_display_hook = hook;
|
||
}
|
||
|
||
void
|
||
reopen_exec_file (void)
|
||
{
|
||
char *filename;
|
||
int res;
|
||
struct stat st;
|
||
struct cleanup *cleanups;
|
||
|
||
/* Don't do anything if there isn't an exec file. */
|
||
if (exec_bfd == NULL)
|
||
return;
|
||
|
||
/* If the timestamp of the exec file has changed, reopen it. */
|
||
filename = xstrdup (bfd_get_filename (exec_bfd));
|
||
cleanups = make_cleanup (xfree, filename);
|
||
res = stat (filename, &st);
|
||
|
||
if (exec_bfd_mtime && exec_bfd_mtime != st.st_mtime)
|
||
exec_file_attach (filename, 0);
|
||
else
|
||
/* If we accessed the file since last opening it, close it now;
|
||
this stops GDB from holding the executable open after it
|
||
exits. */
|
||
bfd_cache_close_all ();
|
||
|
||
do_cleanups (cleanups);
|
||
}
|
||
|
||
/* If we have both a core file and an exec file,
|
||
print a warning if they don't go together. */
|
||
|
||
void
|
||
validate_files (void)
|
||
{
|
||
if (exec_bfd && core_bfd)
|
||
{
|
||
if (!core_file_matches_executable_p (core_bfd, exec_bfd))
|
||
warning (_("core file may not match specified executable file."));
|
||
else if (bfd_get_mtime (exec_bfd) > bfd_get_mtime (core_bfd))
|
||
warning (_("exec file is newer than core file."));
|
||
}
|
||
}
|
||
|
||
/* Return the name of the executable file as a string.
|
||
ERR nonzero means get error if there is none specified;
|
||
otherwise return 0 in that case. */
|
||
|
||
char *
|
||
get_exec_file (int err)
|
||
{
|
||
if (exec_filename)
|
||
return exec_filename;
|
||
if (!err)
|
||
return NULL;
|
||
|
||
error (_("No executable file specified.\n\
|
||
Use the \"file\" or \"exec-file\" command."));
|
||
return NULL;
|
||
}
|
||
|
||
|
||
char *
|
||
memory_error_message (enum target_xfer_status err,
|
||
struct gdbarch *gdbarch, CORE_ADDR memaddr)
|
||
{
|
||
switch (err)
|
||
{
|
||
case TARGET_XFER_E_IO:
|
||
/* Actually, address between memaddr and memaddr + len was out of
|
||
bounds. */
|
||
return xstrprintf (_("Cannot access memory at address %s"),
|
||
paddress (gdbarch, memaddr));
|
||
case TARGET_XFER_UNAVAILABLE:
|
||
return xstrprintf (_("Memory at address %s unavailable."),
|
||
paddress (gdbarch, memaddr));
|
||
default:
|
||
internal_error (__FILE__, __LINE__,
|
||
"unhandled target_xfer_status: %s (%s)",
|
||
target_xfer_status_to_string (err),
|
||
plongest (err));
|
||
}
|
||
}
|
||
|
||
/* Report a memory error by throwing a suitable exception. */
|
||
|
||
void
|
||
memory_error (enum target_xfer_status err, CORE_ADDR memaddr)
|
||
{
|
||
char *str;
|
||
enum errors exception = GDB_NO_ERROR;
|
||
|
||
/* Build error string. */
|
||
str = memory_error_message (err, target_gdbarch (), memaddr);
|
||
make_cleanup (xfree, str);
|
||
|
||
/* Choose the right error to throw. */
|
||
switch (err)
|
||
{
|
||
case TARGET_XFER_E_IO:
|
||
exception = MEMORY_ERROR;
|
||
break;
|
||
case TARGET_XFER_UNAVAILABLE:
|
||
exception = NOT_AVAILABLE_ERROR;
|
||
break;
|
||
}
|
||
|
||
/* Throw it. */
|
||
throw_error (exception, ("%s"), str);
|
||
}
|
||
|
||
/* Same as target_read_memory, but report an error if can't read. */
|
||
|
||
void
|
||
read_memory (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len)
|
||
{
|
||
ULONGEST xfered = 0;
|
||
|
||
while (xfered < len)
|
||
{
|
||
enum target_xfer_status status;
|
||
ULONGEST xfered_len;
|
||
|
||
status = target_xfer_partial (current_target.beneath,
|
||
TARGET_OBJECT_MEMORY, NULL,
|
||
myaddr + xfered, NULL,
|
||
memaddr + xfered, len - xfered,
|
||
&xfered_len);
|
||
|
||
if (status != TARGET_XFER_OK)
|
||
memory_error (status == TARGET_XFER_EOF ? TARGET_XFER_E_IO : status,
|
||
memaddr + xfered);
|
||
|
||
xfered += xfered_len;
|
||
QUIT;
|
||
}
|
||
}
|
||
|
||
/* Same as target_read_stack, but report an error if can't read. */
|
||
|
||
void
|
||
read_stack (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len)
|
||
{
|
||
int status;
|
||
|
||
status = target_read_stack (memaddr, myaddr, len);
|
||
if (status != 0)
|
||
memory_error (status, memaddr);
|
||
}
|
||
|
||
/* Same as target_read_code, but report an error if can't read. */
|
||
|
||
void
|
||
read_code (CORE_ADDR memaddr, gdb_byte *myaddr, ssize_t len)
|
||
{
|
||
int status;
|
||
|
||
status = target_read_code (memaddr, myaddr, len);
|
||
if (status != 0)
|
||
memory_error (status, memaddr);
|
||
}
|
||
|
||
/* Read memory at MEMADDR of length LEN and put the contents in
|
||
RETURN_VALUE. Return 0 if MEMADDR couldn't be read and non-zero
|
||
if successful. */
|
||
|
||
int
|
||
safe_read_memory_integer (CORE_ADDR memaddr, int len,
|
||
enum bfd_endian byte_order,
|
||
LONGEST *return_value)
|
||
{
|
||
gdb_byte buf[sizeof (LONGEST)];
|
||
|
||
if (target_read_memory (memaddr, buf, len))
|
||
return 0;
|
||
|
||
*return_value = extract_signed_integer (buf, len, byte_order);
|
||
return 1;
|
||
}
|
||
|
||
LONGEST
|
||
read_memory_integer (CORE_ADDR memaddr, int len,
|
||
enum bfd_endian byte_order)
|
||
{
|
||
gdb_byte buf[sizeof (LONGEST)];
|
||
|
||
read_memory (memaddr, buf, len);
|
||
return extract_signed_integer (buf, len, byte_order);
|
||
}
|
||
|
||
ULONGEST
|
||
read_memory_unsigned_integer (CORE_ADDR memaddr, int len,
|
||
enum bfd_endian byte_order)
|
||
{
|
||
gdb_byte buf[sizeof (ULONGEST)];
|
||
|
||
read_memory (memaddr, buf, len);
|
||
return extract_unsigned_integer (buf, len, byte_order);
|
||
}
|
||
|
||
LONGEST
|
||
read_code_integer (CORE_ADDR memaddr, int len,
|
||
enum bfd_endian byte_order)
|
||
{
|
||
gdb_byte buf[sizeof (LONGEST)];
|
||
|
||
read_code (memaddr, buf, len);
|
||
return extract_signed_integer (buf, len, byte_order);
|
||
}
|
||
|
||
ULONGEST
|
||
read_code_unsigned_integer (CORE_ADDR memaddr, int len,
|
||
enum bfd_endian byte_order)
|
||
{
|
||
gdb_byte buf[sizeof (ULONGEST)];
|
||
|
||
read_code (memaddr, buf, len);
|
||
return extract_unsigned_integer (buf, len, byte_order);
|
||
}
|
||
|
||
void
|
||
read_memory_string (CORE_ADDR memaddr, char *buffer, int max_len)
|
||
{
|
||
char *cp;
|
||
int i;
|
||
int cnt;
|
||
|
||
cp = buffer;
|
||
while (1)
|
||
{
|
||
if (cp - buffer >= max_len)
|
||
{
|
||
buffer[max_len - 1] = '\0';
|
||
break;
|
||
}
|
||
cnt = max_len - (cp - buffer);
|
||
if (cnt > 8)
|
||
cnt = 8;
|
||
read_memory (memaddr + (int) (cp - buffer), (gdb_byte *) cp, cnt);
|
||
for (i = 0; i < cnt && *cp; i++, cp++)
|
||
; /* null body */
|
||
|
||
if (i < cnt && !*cp)
|
||
break;
|
||
}
|
||
}
|
||
|
||
CORE_ADDR
|
||
read_memory_typed_address (CORE_ADDR addr, struct type *type)
|
||
{
|
||
gdb_byte *buf = (gdb_byte *) alloca (TYPE_LENGTH (type));
|
||
|
||
read_memory (addr, buf, TYPE_LENGTH (type));
|
||
return extract_typed_address (buf, type);
|
||
}
|
||
|
||
/* See gdbcore.h. */
|
||
|
||
void
|
||
write_memory (CORE_ADDR memaddr,
|
||
const bfd_byte *myaddr, ssize_t len)
|
||
{
|
||
int status;
|
||
|
||
status = target_write_memory (memaddr, myaddr, len);
|
||
if (status != 0)
|
||
memory_error (status, memaddr);
|
||
}
|
||
|
||
/* Same as write_memory, but notify 'memory_changed' observers. */
|
||
|
||
void
|
||
write_memory_with_notification (CORE_ADDR memaddr, const bfd_byte *myaddr,
|
||
ssize_t len)
|
||
{
|
||
write_memory (memaddr, myaddr, len);
|
||
observer_notify_memory_changed (current_inferior (), memaddr, len, myaddr);
|
||
}
|
||
|
||
/* Store VALUE at ADDR in the inferior as a LEN-byte unsigned
|
||
integer. */
|
||
void
|
||
write_memory_unsigned_integer (CORE_ADDR addr, int len,
|
||
enum bfd_endian byte_order,
|
||
ULONGEST value)
|
||
{
|
||
gdb_byte *buf = (gdb_byte *) alloca (len);
|
||
|
||
store_unsigned_integer (buf, len, byte_order, value);
|
||
write_memory (addr, buf, len);
|
||
}
|
||
|
||
/* Store VALUE at ADDR in the inferior as a LEN-byte signed
|
||
integer. */
|
||
void
|
||
write_memory_signed_integer (CORE_ADDR addr, int len,
|
||
enum bfd_endian byte_order,
|
||
LONGEST value)
|
||
{
|
||
gdb_byte *buf = (gdb_byte *) alloca (len);
|
||
|
||
store_signed_integer (buf, len, byte_order, value);
|
||
write_memory (addr, buf, len);
|
||
}
|
||
|
||
/* The current default bfd target. Points to storage allocated for
|
||
gnutarget_string. */
|
||
char *gnutarget;
|
||
|
||
/* Same thing, except it is "auto" not NULL for the default case. */
|
||
static char *gnutarget_string;
|
||
static void
|
||
show_gnutarget_string (struct ui_file *file, int from_tty,
|
||
struct cmd_list_element *c,
|
||
const char *value)
|
||
{
|
||
fprintf_filtered (file,
|
||
_("The current BFD target is \"%s\".\n"), value);
|
||
}
|
||
|
||
static void set_gnutarget_command (char *, int,
|
||
struct cmd_list_element *);
|
||
|
||
static void
|
||
set_gnutarget_command (char *ignore, int from_tty,
|
||
struct cmd_list_element *c)
|
||
{
|
||
char *gend = gnutarget_string + strlen (gnutarget_string);
|
||
|
||
gend = remove_trailing_whitespace (gnutarget_string, gend);
|
||
*gend = '\0';
|
||
|
||
if (strcmp (gnutarget_string, "auto") == 0)
|
||
gnutarget = NULL;
|
||
else
|
||
gnutarget = gnutarget_string;
|
||
}
|
||
|
||
/* A completion function for "set gnutarget". */
|
||
|
||
static VEC (char_ptr) *
|
||
complete_set_gnutarget (struct cmd_list_element *cmd,
|
||
const char *text, const char *word)
|
||
{
|
||
static const char **bfd_targets;
|
||
|
||
if (bfd_targets == NULL)
|
||
{
|
||
int last;
|
||
|
||
bfd_targets = bfd_target_list ();
|
||
for (last = 0; bfd_targets[last] != NULL; ++last)
|
||
;
|
||
|
||
bfd_targets = XRESIZEVEC (const char *, bfd_targets, last + 2);
|
||
bfd_targets[last] = "auto";
|
||
bfd_targets[last + 1] = NULL;
|
||
}
|
||
|
||
return complete_on_enum (bfd_targets, text, word);
|
||
}
|
||
|
||
/* Set the gnutarget. */
|
||
void
|
||
set_gnutarget (char *newtarget)
|
||
{
|
||
if (gnutarget_string != NULL)
|
||
xfree (gnutarget_string);
|
||
gnutarget_string = xstrdup (newtarget);
|
||
set_gnutarget_command (NULL, 0, NULL);
|
||
}
|
||
|
||
void
|
||
_initialize_core (void)
|
||
{
|
||
struct cmd_list_element *c;
|
||
|
||
c = add_cmd ("core-file", class_files, core_file_command, _("\
|
||
Use FILE as core dump for examining memory and registers.\n\
|
||
No arg means have no core file. This command has been superseded by the\n\
|
||
`target core' and `detach' commands."), &cmdlist);
|
||
set_cmd_completer (c, filename_completer);
|
||
|
||
|
||
c = add_setshow_string_noescape_cmd ("gnutarget", class_files,
|
||
&gnutarget_string, _("\
|
||
Set the current BFD target."), _("\
|
||
Show the current BFD target."), _("\
|
||
Use `set gnutarget auto' to specify automatic detection."),
|
||
set_gnutarget_command,
|
||
show_gnutarget_string,
|
||
&setlist, &showlist);
|
||
set_cmd_completer (c, complete_set_gnutarget);
|
||
|
||
add_alias_cmd ("g", "gnutarget", class_files, 1, &setlist);
|
||
|
||
if (getenv ("GNUTARGET"))
|
||
set_gnutarget (getenv ("GNUTARGET"));
|
||
else
|
||
set_gnutarget ("auto");
|
||
}
|