9ef9e6a6a0
One of the last checks update_breakpoints_after_exec does while looping over the list of breakpoints is check that the breakpoint has a valid location spec. It uses event_location_empty_p to check if the location spec is "empty", and if it is, the breakpoint is deleted. momentary_breakpoint types rely on setting the breakpoint structure's location spec to NULL, thereby causing an update to delete the breakpoint. However, event_location_empty_p assumed that locations were never NULL. As a result, GDB would crash dereferencing a NULL pointer whenever update_breakpoints_after_exec would encounter a momentary_breakpoint. This patch creates a new wrapper/helper function which tests that the given breakpoint's location spec is non-NULL and if it is not "empty" or "unspecified." gdb/ChangeLog PR breakpoints/19546 * breakpoint.c (breakpoint_event_location_empty_p): New function. (update_breakpoints_after_exec, bkpt_re_set): Use this new function instead of event_location_empty_p. gdb/testsuite/ChangeLog PR breakpoints/19546 * gdb.base/infcall-exec.c: New file. * gdb.base/infcall-exec2.c: New file. * gdb.base/infcall-exec.exp: New file.
48 lines
1.6 KiB
Text
48 lines
1.6 KiB
Text
# Copyright 2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test an inferior function call which execs a new program.
|
|
# This is a test for breakpoints/19546.
|
|
|
|
standard_testfile
|
|
|
|
set testfile2 "infcall-exec2"
|
|
set srcfile2 "${testfile2}.c"
|
|
set binfile2 [standard_output_file $testfile2]
|
|
|
|
# Build the two executables for the test.
|
|
if {[gdb_compile $srcdir/$subdir/$srcfile $binfile executable debug] != ""} {
|
|
untested "could not build $binfile"
|
|
return -1
|
|
}
|
|
if {[gdb_compile $srcdir/$subdir/$srcfile2 $binfile2 executable debug] != ""} {
|
|
untested "could not build $binfile2"
|
|
return -1
|
|
}
|
|
|
|
clean_restart $binfile
|
|
|
|
if {![runto_main]} {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
set expected_result "process $decimal is executing new program: $binfile2"
|
|
append expected_result "\[\r\n\]+.*"
|
|
append expected_result "Breakpoint 1, main .*at .*$srcfile2:$decimal"
|
|
append expected_result ".*"
|
|
|
|
gdb_test "call execlp \(\"$binfile2\", \"$binfile2\", \(char \*\)0\)" \
|
|
$expected_result "call execlp"
|