f01dcfd9a7
Some of the source code for the test cases in the GDB testsuite reside in .S files containing assembly code. These files typically define a symbol - such as main - which may, depending on the target, require a prefix such as underscore. For example, gdb.dwarf2/dw-compdir-oldgcc.S defines the symbol main: main: .globl main Some targets, such as rx-elf, require main to have an underscore prefix. (If it doesn't, a linker error results due to not being able to find _main required by crt0.o.) So, instead, the above should look like this for rx-elf and other targets with this same requirement: _main: .globl _main This patch defines a new tcl proc in lib/gdb named gdb_target_symbol_prefix_flags_asm. This proc returns a string which will - assuming everything else is wired up correctly - cause -DSYMBOL_PREFIX=_ to be passed on the command line to the compiler. The test cases are augmented with a macro definition for SYMBOL as follows: #define CONCAT1(a, b) CONCAT2(a, b) #define CONCAT2(a, b) a ## b #ifdef SYMBOL_PREFIX # define SYMBOL(str) CONCAT1(SYMBOL_PREFIX, str) #else # define SYMBOL(str) str #endif Symbols, such as main shown in the example earlier are then wrapped with SYMBOL like this: SYMBOL(main): .globl SYMBOL(main) The net effect will be to add a prefix for those targets which need it and add no prefix for those targets which do not. It should be noted that there was already a proc in lib/gdb.exp called gdb_target_symbol_prefix_flags. It still exists, but has been significantly rewritten. (There is only one small difference between the two versions.) That proc used to explicitly list targets which were known to require an underscore prefix. This is no longer done; the recently added proc, gdb_target_symbol_prefix, is now invoked to dynamically discover whether or not a prefix is required for that particular target. The difference between gdb_target_symbol_prefix_flags_asm and gdb_target_symbol_prefix_flags is that the former returns a bare prefix while the latter returns the prefix enclosed in double quotes. I.e. assuming that the discovered prefix is underscore, gdb_target_symbol_prefix_flags_asm returns: additional_flags=-DSYMBOL_PREFIX=_ while gdb_target_symbol_prefix_flags returns: additional_flags=-DSYMBOL_PREFIX="_" The double-quoted version is not suitable for using with .S files containing assembly code; there is no way to strip the double quotes using C preprocessor constructs. It would be possible to use the bare (non double quoted) version in C source code. However, the supporting macros become more complicated and therefore more difficult to maintain. gdb/testsuite/ChangeLog: * lib/gdb (gdb_target_symbol_prefix_flags_asm): New proc. (gdb_target_symbol_prefix_flags): Define in terms of _asm version. * gdb.arch/i386-float.exp, gdb.arch/i386-permbkpt.exp, gdb.dwarf2/dw2-canonicalize-type.exp, gdb.dwarf2/dw2-compdir-oldgcc.exp, gdb.dwarf2/dw2-minsym-in-cu.exp, gdb.dwarf2/dw2-op-stack-value.exp, gdb.dwarf2/dw2-unresolved.exp, gdb.dwarf2/fission-reread.exp, gdb.dwarf2/pr13961.exp: Use flags provided by gdb_target_symbol_prefix_flags_asm. * gdb.dwarf2/dw2-canonicalize-type.S, gdb.dwarf2/dw2-compdir-oldgcc.S, testsuite/gdb.dwarf2/dw2-minsym-in-cu.S, testsuite/gdb.dwarf2/dw2-unresolved-main.c, testsuite/gdb.dwarf2/dw2-unresolved.S, gdb.dwarf2/fission-reread.S, gdb.dwarf2/pr13961.S: Define and use SYMBOL macro (and supporting macros where needed). Use this macro for symbols which require the prefix provided by SYMBOL_PREFIX. |
||
---|---|---|
.. | ||
aarch64-atomic-inst.c | ||
aarch64-atomic-inst.exp | ||
aarch64-fp.c | ||
aarch64-fp.exp | ||
alpha-step.c | ||
alpha-step.exp | ||
altivec-abi.c | ||
altivec-abi.exp | ||
altivec-regs.c | ||
altivec-regs.exp | ||
amd64-byte.exp | ||
amd64-disp-step.exp | ||
amd64-disp-step.S | ||
amd64-dword.exp | ||
amd64-entry-value-inline.c | ||
amd64-entry-value-inline.exp | ||
amd64-entry-value-inline.S | ||
amd64-entry-value-param.c | ||
amd64-entry-value-param.exp | ||
amd64-entry-value-param.S | ||
amd64-entry-value-paramref.cc | ||
amd64-entry-value-paramref.exp | ||
amd64-entry-value-paramref.S | ||
amd64-entry-value.cc | ||
amd64-entry-value.exp | ||
amd64-entry-value.s | ||
amd64-i386-address.exp | ||
amd64-i386-address.S | ||
amd64-invalid-stack-middle.c | ||
amd64-invalid-stack-middle.exp | ||
amd64-invalid-stack-middle.S | ||
amd64-invalid-stack-top.c | ||
amd64-invalid-stack-top.exp | ||
amd64-optimout-repeat.c | ||
amd64-optimout-repeat.exp | ||
amd64-optimout-repeat.S | ||
amd64-prologue-skip.exp | ||
amd64-prologue-skip.S | ||
amd64-prologue-xmm.c | ||
amd64-prologue-xmm.exp | ||
amd64-prologue-xmm.s | ||
amd64-pseudo.c | ||
amd64-stap-optional-prefix.exp | ||
amd64-stap-optional-prefix.S | ||
amd64-stap-special-operands.exp | ||
amd64-stap-three-arg-disp.c | ||
amd64-stap-three-arg-disp.S | ||
amd64-stap-triplet.c | ||
amd64-stap-triplet.S | ||
amd64-stap-wrong-subexp.exp | ||
amd64-stap-wrong-subexp.S | ||
amd64-tailcall-cxx.exp | ||
amd64-tailcall-cxx1.cc | ||
amd64-tailcall-cxx1.S | ||
amd64-tailcall-cxx2.cc | ||
amd64-tailcall-cxx2.S | ||
amd64-tailcall-noret.c | ||
amd64-tailcall-noret.exp | ||
amd64-tailcall-noret.S | ||
amd64-tailcall-ret.c | ||
amd64-tailcall-ret.exp | ||
amd64-tailcall-ret.S | ||
amd64-tailcall-self.c | ||
amd64-tailcall-self.exp | ||
amd64-tailcall-self.S | ||
amd64-word.exp | ||
arm-bl-branch-dest.c | ||
arm-bl-branch-dest.exp | ||
arm-disp-step.exp | ||
arm-disp-step.S | ||
avr-flash-qualifier.c | ||
avr-flash-qualifier.exp | ||
cordic.ko.bz2 | ||
cordic.ko.debug.bz2 | ||
disp-step-insn-reloc.exp | ||
e500-abi.c | ||
e500-abi.exp | ||
e500-prologue.c | ||
e500-prologue.exp | ||
e500-regs.c | ||
e500-regs.exp | ||
ftrace-insn-reloc.exp | ||
gdb1291.exp | ||
gdb1291.s | ||
gdb1431.exp | ||
gdb1431.s | ||
gdb1558.c | ||
gdb1558.exp | ||
i386-avx.c | ||
i386-avx.exp | ||
i386-avx512.c | ||
i386-avx512.exp | ||
i386-biarch-core.core.bz2 | ||
i386-biarch-core.exp | ||
i386-bp_permanent.c | ||
i386-bp_permanent.exp | ||
i386-byte.exp | ||
i386-cfi-notcurrent.exp | ||
i386-cfi-notcurrent.S | ||
i386-disp-step.exp | ||
i386-disp-step.S | ||
i386-dr3-watch.c | ||
i386-dr3-watch.exp | ||
i386-float.exp | ||
i386-float.S | ||
i386-gnu-cfi-asm.S | ||
i386-gnu-cfi.c | ||
i386-gnu-cfi.exp | ||
i386-mpx-map.c | ||
i386-mpx-map.exp | ||
i386-mpx.c | ||
i386-mpx.exp | ||
i386-permbkpt.exp | ||
i386-permbkpt.S | ||
i386-prologue.c | ||
i386-prologue.exp | ||
i386-pseudo.c | ||
i386-signal.c | ||
i386-signal.exp | ||
i386-size-overlap.c | ||
i386-size-overlap.exp | ||
i386-size.c | ||
i386-size.exp | ||
i386-sse-stack-align.c | ||
i386-sse-stack-align.exp | ||
i386-sse-stack-align.S | ||
i386-sse.c | ||
i386-sse.exp | ||
i386-stap-eval-lang-ada.c | ||
i386-stap-eval-lang-ada.exp | ||
i386-stap-eval-lang-ada.S | ||
i386-unwind.c | ||
i386-unwind.exp | ||
i386-word.exp | ||
ia64-breakpoint-shadow.exp | ||
ia64-breakpoint-shadow.S | ||
insn-reloc.c | ||
iwmmxt-regs.c | ||
iwmmxt-regs.exp | ||
Makefile.in | ||
mips-octeon-bbit.c | ||
mips-octeon-bbit.exp | ||
mips16-thunks-inmain.c | ||
mips16-thunks-main.c | ||
mips16-thunks-sin.c | ||
mips16-thunks-sinfrob.c | ||
mips16-thunks-sinfrob16.c | ||
mips16-thunks-sinmain.c | ||
mips16-thunks-sinmips16.c | ||
mips16-thunks.exp | ||
pa-nullify.exp | ||
pa-nullify.s | ||
pa64-nullify.s | ||
powerpc-aix-prologue.c | ||
powerpc-aix-prologue.exp | ||
powerpc-d128-regs.c | ||
powerpc-d128-regs.exp | ||
powerpc-power.exp | ||
powerpc-power.s | ||
powerpc-prologue.c | ||
powerpc-prologue.exp | ||
powerpc-stackless.exp | ||
powerpc-stackless.S | ||
ppc-dfp.c | ||
ppc-dfp.exp | ||
ppc-fp.c | ||
ppc-fp.exp | ||
ppc64-atomic-inst.exp | ||
ppc64-atomic-inst.S | ||
ppc64-symtab-cordic.exp | ||
s390-multiarch.c | ||
s390-multiarch.exp | ||
s390-tdbregs.c | ||
s390-tdbregs.exp | ||
s390-vregs.exp | ||
s390-vregs.S | ||
sparc-sysstep.c | ||
sparc-sysstep.exp | ||
spu-info.c | ||
spu-info.exp | ||
spu-ls.c | ||
spu-ls.exp | ||
thumb-bx-pc.exp | ||
thumb-bx-pc.S | ||
thumb-prologue.c | ||
thumb-prologue.exp | ||
thumb-singlestep.exp | ||
thumb-singlestep.S | ||
thumb2-it.exp | ||
thumb2-it.S | ||
vsx-regs.c | ||
vsx-regs.exp |