a8454a7c5a
Checking whether the gcore command is included in the GDB build as
proxy for checking whether core dumping is supported by the target is
useless, as gcore.o has been in COMMON_OBS since git 9b4eba8e:
2009-10-26 Michael Snyder <msnyder@vmware.com>
Hui Zhu <teawater@gmail.com>
* Makefile.in (SFILES): Add gcore.c.
(COMMON_OBS): Add gcore.o.
* config/alpha/alpha-linux.mh (NATDEPFILES): Delete gcore.o.
* config/alpha/fbsd.mh (NATDEPFILES): Ditto.
...
IOW, the command is always included in the build.
Instead, nowadays, tests bail out if actually trying to generate a
core fails with an indication the target doesn't support it. See
gdb_gcore_cmd and callers.
Tested on x86_64 Fedora 20.
gdb/testsuite/ChangeLog:
* gdb.base/gcore-buffer-overflow.exp: Remove "help gcore" test.
* gdb.base/gcore-relro-pie.exp: Likewise.
* gdb.base/gcore-relro.exp: Likewise.
* gdb.base/gcore.exp: Likewise.
* gdb.base/print-symbol-loading.exp: Likewise.
* gdb.threads/gcore-thread.exp: Likewise.
* lib/gdb.exp (gdb_gcore_cmd): Don't expect "Undefined command".
56 lines
1.8 KiB
Text
56 lines
1.8 KiB
Text
# Copyright 2012-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if {[skip_shlib_tests]} {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile gcore-relro-main.c
|
|
set libfile gcore-relro-lib
|
|
set srcfile_lib ${libfile}.c
|
|
set binfile_lib [standard_output_file ${libfile}.so]
|
|
set gcorefile ${binfile}.gcore
|
|
set objfile [standard_output_file ${testfile}.o]
|
|
|
|
if { [gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} {debug}] != ""
|
|
|| [gdb_compile ${srcdir}/${subdir}/${srcfile} ${objfile} object {debug}] != "" } {
|
|
untested ${testfile}.exp
|
|
return -1
|
|
}
|
|
set opts [list debug shlib=${binfile_lib} additional_flags=-Wl,-z,relro]
|
|
if { [gdb_compile ${objfile} ${binfile} executable $opts] != "" } {
|
|
unsupported "-Wl,-z,relro compilation failed"
|
|
return -1
|
|
}
|
|
|
|
clean_restart ${binfile}
|
|
gdb_load_shlibs ${binfile_lib}
|
|
|
|
if ![runto lib] {
|
|
return -1
|
|
}
|
|
|
|
if {![gdb_gcore_cmd $gcorefile "save a corefile"]} {
|
|
return -1
|
|
}
|
|
|
|
# Now restart gdb and load the corefile.
|
|
|
|
clean_restart ${binfile}
|
|
gdb_load_shlibs ${binfile_lib}
|
|
|
|
gdb_test "core ${gcorefile}" "Core was generated by .*" "re-load generated corefile"
|
|
|
|
gdb_test "frame" "#0 \[^\r\n\]* lib .*" "library got loaded"
|