673dc4a054
I see the following two fails on arm-none-eabi target, because argv[0] isn't available. print argv[0]^M $1 = 0x1f78 "/dev/null"^M (gdb) FAIL: gdb.base/argv0-symlink.exp: kept file symbolic link name print argv[0]^M $1 = 0x1f78 "/dev/null"^M (gdb) FAIL: gdb.base/argv0-symlink.exp: kept directory symbolic link name My first thought is to check [target_info exists noargs], and skip the test if it returns true. However, noargs is set in gdbserver board files, so argv0-symlink.exp will be skipped on gdbserver board file. The change is too aggressive. When the program is running with gdbserver, argv[1] to argv[N] aren't available, but argv[0] is. Fortunately, argv0-symlink.exp only requires argv[0]. argv0-symlink.exp can be run with gdbserver board file, as what we do now. What we need to check is whether argv[0] is available, so I add a new proc gdb_has_argv0 to do so by starting a program, and check argc/argv[0] to see whether argv[0] is available. Dan fixed the similar problem by checking noargs, which is too strong. https://sourceware.org/ml/gdb-patches/2010-02/msg00398.html as a result, the test is skipped on gdbserver. This patch fixed it too. gdb/testsuite: 2014-10-18 Yao Qi <yao@codesourcery.com> * gdb.base/argv0-symlink.exp: Check argv[0] value if gdb_has_argv0 return true. * gdb.guile/scm-value.exp (test_value_in_inferior): Don't check [target_info exists noargs], check [gdb_has_argv0] instead. * gdb.python/py-value.exp (test_value_in_inferior): Likewise. * lib/gdb.exp (gdb_has_argv0, gdb_has_argv0_1): New procedures.
92 lines
2.7 KiB
Text
92 lines
2.7 KiB
Text
# Copyright 2013-2014 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
standard_testfile
|
|
|
|
set has_argv0 [gdb_has_argv0]
|
|
|
|
if { [build_executable ${testfile}.exp ${testfile} ${srcfile}] == -1 } {
|
|
return -1
|
|
}
|
|
|
|
set test "kept file symbolic link name"
|
|
set filelink "${testfile}-filelink"
|
|
|
|
remote_file host delete [standard_output_file $filelink]
|
|
set status [remote_exec host "ln -sf ${testfile} [standard_output_file $filelink]"]
|
|
if {[lindex $status 0] != 0} {
|
|
unsupported "$test (host does not support symbolic links)"
|
|
return 0
|
|
}
|
|
|
|
clean_restart "$filelink"
|
|
|
|
if ![runto_main] {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test_no_output "set print repeats 10000"
|
|
gdb_test_no_output "set print elements 10000"
|
|
|
|
if { $has_argv0 } {
|
|
gdb_test {print argv[0]} "/$filelink\"" $test
|
|
} else {
|
|
unsupported $test
|
|
}
|
|
|
|
# For a link named /PATH/TO/DIR/LINK, we want to check the output
|
|
# against "/DIR/LINK", but computed in a way that doesn't make
|
|
# assumptions about the test directory layout.
|
|
set full_filelink [standard_output_file $filelink]
|
|
set lastdir [file tail [file dirname $full_filelink]]
|
|
|
|
gdb_test "info inferiors" "/$lastdir/$filelink *" "$test for info inferiors"
|
|
|
|
|
|
set test "kept directory symbolic link name"
|
|
set dirlink "${testfile}-dirlink"
|
|
|
|
# 'ln -sf' does not overwrite symbol link to a directory.
|
|
# 'remote_file host delete' uses stat (not lstat), therefore it refuses to
|
|
# delete a directory.
|
|
remote_exec host "rm -f [standard_output_file $dirlink]"
|
|
set status [remote_exec host "ln -sf . [standard_output_file $dirlink]"]
|
|
if {[lindex $status 0] != 0} {
|
|
unsupported "$test (host does not support symbolic links)"
|
|
return 0
|
|
}
|
|
|
|
clean_restart "$dirlink/$filelink"
|
|
|
|
if ![runto_main] {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test_no_output "set print repeats 10000"
|
|
gdb_test_no_output "set print elements 10000"
|
|
|
|
if { $has_argv0 } {
|
|
# gdbserver does not have this issue.
|
|
if ![is_remote target] {
|
|
setup_kfail "*-*-*" gdb/15934
|
|
}
|
|
gdb_test {print argv[0]} "/$dirlink/$filelink\"" $test
|
|
} else {
|
|
unsupported $test
|
|
}
|
|
|
|
gdb_test "info inferiors" "/$lastdir/$filelink *" "$test for info inferiors"
|