4ec7020176
A few months ago semicolons after "return" were removed throughout the testsuite. However, as I pointed out in review, they're unnecessary not just after "return", but pretty much after any tcl command. ';' is the command separator, and you only need it if there's another command on the same line afterwards. This patch was written by running: $ find . -name "*.exp" | xargs grep -l ";\s*$" | xargs sed -i 's/\([^#][^\s*;]*\)\s*;\s*$/\1/' and then undoing changes to comments, and lib/future.exp. Tested on x86_64 Fedora 17. gdb/testsuite/ 2013-06-07 Pedro Alves <palves@redhat.com> * boards/native-extended-gdbserver.exp: Remove semicolon. * config/arm-ice.exp: Likewise. * config/bfin.exp: Likewise. * config/cygmon.exp: Likewise. * config/h8300.exp: Likewise. * config/monitor.exp: Likewise. * config/sid.exp: Likewise. * config/sim.exp: Likewise. * config/slite.exp: Likewise. * config/vx.exp: Likewise. * gdb.arch/i386-bp_permanent.exp: Likewise. * gdb.asm/asm-source.exp: Likewise. * gdb.base/args.exp: Likewise. * gdb.base/attach-pie-misread.exp: Likewise. * gdb.base/auxv.exp: Likewise. * gdb.base/bigcore.exp: Likewise. * gdb.base/bitfields2.exp: Likewise. * gdb.base/bitfields.exp: Likewise. * gdb.base/break.exp: Likewise. * gdb.base/break-interp.exp: Likewise. * gdb.base/callfuncs.exp: Likewise. * gdb.base/call-sc.exp: Likewise. * gdb.base/commands.exp: Likewise. * gdb.base/corefile.exp: Likewise. * gdb.base/dbx.exp: Likewise. * gdb.base/ending-run.exp: Likewise. * gdb.base/exprs.exp: Likewise. * gdb.base/funcargs.exp: Likewise. * gdb.base/hbreak2.exp: Likewise. * gdb.base/huge.exp: Likewise. * gdb.base/list.exp: Likewise. * gdb.base/memattr.exp: Likewise. * gdb.base/overlays.exp: Likewise. * gdb.base/printcmds.exp: Likewise. * gdb.base/recurse.exp: Likewise. * gdb.base/remotetimeout.exp: Likewise. * gdb.base/reread.exp: Likewise. * gdb.base/savedregs.exp: Likewise. * gdb.base/scope.exp: Likewise. * gdb.base/sepdebug.exp: Likewise. * gdb.base/setshow.exp: Likewise. * gdb.base/setvar.exp: Likewise. * gdb.base/sigaltstack.exp: Likewise. * gdb.base/siginfo-addr.exp: Likewise. * gdb.base/siginfo.exp: Likewise. * gdb.base/siginfo-obj.exp: Likewise. * gdb.base/sigrepeat.exp: Likewise. * gdb.base/sigstep.exp: Likewise. * gdb.base/structs.exp: Likewise. * gdb.base/testenv.exp: Likewise. * gdb.base/twice.exp: Likewise. * gdb.base/valgrind-db-attach.exp: Likewise. * gdb.base/valgrind-infcall.exp: Likewise. * gdb.base/varargs.exp: Likewise. * gdb.base/watchpoint.exp: Likewise. * gdb.cp/gdb1355.exp: Likewise. * gdb.cp/misc.exp: Likewise. * gdb.disasm/hppa.exp: Likewise. * gdb.disasm/t01_mov.exp: Likewise. * gdb.disasm/t02_mova.exp: Likewise. * gdb.disasm/t03_add.exp: Likewise. * gdb.disasm/t04_sub.exp: Likewise. * gdb.disasm/t05_cmp.exp: Likewise. * gdb.disasm/t06_ari2.exp: Likewise. * gdb.disasm/t07_ari3.exp: Likewise. * gdb.disasm/t08_or.exp: Likewise. * gdb.disasm/t09_xor.exp: Likewise. * gdb.disasm/t10_and.exp: Likewise. * gdb.disasm/t11_logs.exp: Likewise. * gdb.disasm/t12_bit.exp: Likewise. * gdb.disasm/t13_otr.exp: Likewise. * gdb.gdb/selftest.exp: Likewise. * gdb.hp/gdb.base-hp/callfwmall.exp: Likewise. * gdb.mi/mi-reverse.exp: Likewise. * gdb.pascal/floats.exp: Likewise. * gdb.python/py-inferior.exp: Likewise. * gdb.threads/attach-into-signal.exp: Likewise. * gdb.threads/pthreads.exp: Likewise. * gdb.threads/thread_events.exp: Likewise. * gdb.threads/watchthreads.exp: Likewise. * gdb.trace/actions-changed.exp: Likewise. * gdb.trace/actions.exp: Likewise. * gdb.trace/ax.exp: Likewise. * gdb.trace/backtrace.exp: Likewise. * gdb.trace/change-loc.exp: Likewise. * gdb.trace/deltrace.exp: Likewise. * gdb.trace/disconnected-tracing.exp: Likewise. * gdb.trace/ftrace.exp: Likewise. * gdb.trace/infotrace.exp: Likewise. * gdb.trace/passc-dyn.exp: Likewise. * gdb.trace/passcount.exp: Likewise. * gdb.trace/pending.exp: Likewise. * gdb.trace/qtro.exp: Likewise. * gdb.trace/range-stepping.exp: Likewise. * gdb.trace/report.exp: Likewise. * gdb.trace/save-trace.exp: Likewise. * gdb.trace/status-stop.exp: Likewise. * gdb.trace/strace.exp: Likewise. * gdb.trace/tfile.exp: Likewise. * gdb.trace/tfind.exp: Likewise. * gdb.trace/trace-break.exp: Likewise. * gdb.trace/tracecmd.exp: Likewise. * gdb.trace/trace-mt.exp: Likewise. * gdb.trace/tspeed.exp: Likewise. * gdb.trace/tsv.exp: Likewise. * gdb.trace/while-stepping.exp: Likewise. * lib/gdb.exp: Likewise. * lib/gdbserver-support.exp: Likewise. * lib/java.exp: Likewise. * lib/mi-support.exp: Likewise. * lib/pascal.exp: Likewise. * lib/prompt.exp: Likewise. * lib/trace-support.exp: Likewise.
137 lines
4.8 KiB
Text
137 lines
4.8 KiB
Text
# Copyright 2010-2013 Free Software Foundation, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# Test of trace file support.
|
|
|
|
# Note that unlike most of the tracing tests, this can be run on
|
|
# targets lacking tracepoint support; the program tfile.c has the
|
|
# ability to generate synthetic trace files directly, and the tfile
|
|
# target is available to all GDB configs.
|
|
|
|
load_lib "trace-support.exp"
|
|
|
|
gdb_exit
|
|
gdb_start
|
|
standard_testfile
|
|
if { [gdb_compile "$srcdir/$subdir/$srcfile" $binfile \
|
|
executable {debug nowarnings}] != "" } {
|
|
untested ${testfile}.exp
|
|
return -1
|
|
}
|
|
gdb_reinitialize_dir $srcdir/$subdir
|
|
|
|
# Make sure we are starting fresh.
|
|
remote_file host delete tfile-basic.tf
|
|
remote_file host delete tfile-error.tf
|
|
remote_file target delete tfile-basic.tf
|
|
remote_file target delete tfile-error.tf
|
|
|
|
remote_exec target "$binfile"
|
|
# Copy tracefile from target to host through build.
|
|
remote_download host [remote_upload target tfile-basic.tf] tfile-basic.tf
|
|
remote_download host [remote_upload target tfile-error.tf] tfile-error.tf
|
|
|
|
gdb_load $binfile
|
|
|
|
# Program has presumably exited, now target a trace file it created.
|
|
|
|
gdb_test "target tfile tfile-basic.tf" "Created tracepoint.*" \
|
|
"target tfile"
|
|
|
|
gdb_test "info trace" ".*tracepoint.*in write_basic_trace_file.*" \
|
|
"info tracepoints on trace file"
|
|
|
|
gdb_test "tfind 0" \
|
|
"Found trace frame 0, tracepoint \[0-9\]+.
|
|
\#0 write_basic_trace_file ().*" \
|
|
"tfind 0 on trace file"
|
|
|
|
# Note that there is no tracepoint collecting these globals, we
|
|
# just happen to know they are covered by the trace frame.
|
|
|
|
gdb_test "print testglob" " = 31415" "print testglob on trace file"
|
|
|
|
gdb_test "print testglob2" " = 271828" "print testglob2 on trace file"
|
|
|
|
# This global is not covered by the trace frame, but since it's const,
|
|
# we should be able to read it from the executable.
|
|
|
|
gdb_test "print constglob" " = 10000" "print constglob on trace file"
|
|
|
|
# Similarly, disassembly should find the read-only pieces in the executable.
|
|
gdb_test "disassemble main" \
|
|
"Dump of assembler code for function main:.* $hex <\\+0\\>:.*End of assembler dump\."
|
|
|
|
# This global is also not covered by the trace frame, and since it's
|
|
# non-const, we should _not_ read it from the executable, as that
|
|
# would show the variable's initial value, not the current at time the
|
|
# trace frame was created.
|
|
|
|
gdb_test "print nonconstglob" \
|
|
" = <unavailable>" "print nonconstglob on trace file"
|
|
|
|
gdb_test "tfind" "Target failed to find requested trace frame." \
|
|
"tfind does not find a second frame in trace file"
|
|
|
|
gdb_test "tstatus" \
|
|
"Using a trace file.*
|
|
Trace stopped by a tstop command.*
|
|
Collected 1 trace frame.*
|
|
Trace buffer has 256 bytes of 4096 bytes free \\(93% full\\).*
|
|
Looking at trace frame 0, tracepoint .*" \
|
|
"tstatus on trace file"
|
|
|
|
gdb_test "tfind end" "No longer looking at any trace frame" "leave tfind mode"
|
|
|
|
gdb_test "backtrace" "No stack\." \
|
|
"no stack if no traceframe selected"
|
|
|
|
gdb_test "info registers" "The program has no registers now\." \
|
|
"no registers if no traceframe selected"
|
|
|
|
# Now start afresh, using only a trace file.
|
|
|
|
gdb_exit
|
|
gdb_start
|
|
|
|
gdb_load $binfile
|
|
|
|
gdb_test "target tfile tfile-error.tf" "Created tracepoint.*" \
|
|
"target tfile"
|
|
|
|
gdb_test "tstatus" \
|
|
"Using a trace file.*
|
|
Trace stopped by an error \\(made-up error, tracepoint 1\\).*
|
|
Collected 0 trace frame.*
|
|
Trace buffer has 256 bytes of 4096 bytes free \\(93% full\\).*
|
|
Not looking at any trace frame.*" \
|
|
"tstatus on error trace file"
|
|
|
|
gdb_test "info threads" "No threads\..*"
|
|
gdb_test "info inferiors" "\\* 1 <null>\[ \t\]+${binfile}.*"
|
|
|
|
# Make sure we can reopen without error.
|
|
gdb_test \
|
|
"interpreter-exec mi \"-target-select tfile tfile-basic.tf\"" \
|
|
"\\^connected.*"
|
|
|
|
gdb_test "interpreter-exec mi \"-trace-status\"" \
|
|
"\\^done,supported=\"file\",trace-file=\".*tfile-basic.tf\",running=\"0\",stop-reason=\"request\",frames=\"${decimal}\",frames-created=\"${decimal}\",buffer-size=\"${decimal}\",buffer-free=\"${decimal}\",disconnected=\".*\",circular=\".*\",user-name=\"\",notes=\"\",start-time=\".*\",stop-time=\".*\"" \
|
|
"-trace-status"
|
|
|
|
# Test completion works well.
|
|
|
|
gdb_test "target tfile tfile-basic\t" "Assuming tracepoint.*" \
|
|
"complete-command 'target tfile'"
|