4819b3f897
I happened to notice a bug with ptype &Ref, and found out userdef.exp
actually exercises the bug. With:
class Container
{
public:
Member m;
Member& operator* ();
};
Member& Container::operator* ()
{
return this->m;
}
And 'c' is of type Container:
(gdb) p c
$1 = {m = {z = -9192}}
(gdb) p *c
$2 = (Member &) @0x7fffffffda20: {z = -9192}
(gdb) ptype *c
type = class Member {
public:
int z;
} &
(gdb) p &*c
$3 = (Member *) 0x7fffffffda20
(gdb) ptype &*c
type = class Member {
public:
int z;
} &*
(gdb)
Notice that last print (&*c) on says the type is a pointer - that's
how you get the address behind a reference. But notice the last ptype
instead says the type of the same expression is a pointer _reference_.
This looks like a bug to me.
This patch fixes it. The issue is that we're entering the VALUE_LVAL
(x) == lval_memory branch by mistake for references. The fix is just
to swap the tests so references are checked first, like value_addr
also handles references first.
Tested on x86_64 Fedora 17.
2013-02-14 Pedro Alves <palves@redhat.com>
* eval.c (evaluate_subexp_for_address) <default_case_after_eval,
EVAL_AVOID_SIDE_EFFECTS>: Swap and handle TYPE_CODE_REF before
lval_memory.
2013-02-14 Pedro Alves <palves@redhat.com>
* gdb.cp/userdef.exp (ptype &*c): Don't expect an &.
142 lines
4.6 KiB
Text
142 lines
4.6 KiB
Text
# Tests of overloaded operators resolution.
|
|
# Copyright 1998-2013 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# written by Elena Zannoni (ezannoni@cygnus.com)
|
|
#
|
|
# source file "userdef.cc"
|
|
#
|
|
|
|
if { [skip_stl_tests] } { continue }
|
|
|
|
# On SPU this test fails because the executable exceeds local storage size.
|
|
if { [istarget "spu*-*-*"] } {
|
|
return 0
|
|
}
|
|
|
|
standard_testfile .cc
|
|
|
|
if {[prepare_for_testing $testfile.exp $testfile $srcfile {debug c++}]} {
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] then {
|
|
perror "couldn't run to breakpoint"
|
|
continue
|
|
}
|
|
|
|
gdb_test "break marker1" \
|
|
"Breakpoint .*${srcfile}.*"
|
|
|
|
gdb_test "cont" \
|
|
"Break.* marker1(\\(\\)|) \\(\\) at .*:$decimal.*" \
|
|
"continue to marker1"
|
|
|
|
gdb_test "up" " in main .*" "up from marker1"
|
|
|
|
gdb_test "print one + two" "\\\$\[0-9\]* = {x = 6, y = 8}"
|
|
|
|
# If GDB fails to restore the selected frame properly after the
|
|
# inferior function call above (see GDB PR 1155 for an explanation of
|
|
# why this might happen), all the subsequent tests will fail. We
|
|
# should detect report that failure, but let the marker call finish so
|
|
# that the rest of the tests can run undisturbed.
|
|
gdb_test_multiple "frame" "re-selected 'main' frame after inferior call" {
|
|
-re "#0 marker1.*$gdb_prompt $" {
|
|
setup_kfail "gdb/1155" s390-*-linux-gnu
|
|
fail "re-selected 'main' frame after inferior call"
|
|
gdb_test "finish" ".*main.*at .*userdef.cc:.*// marker1-returns-here.*" \
|
|
"finish call to marker1"
|
|
}
|
|
-re "#1 ($hex in )?main.*$gdb_prompt $" {
|
|
pass "re-selected 'main' frame after inferior call"
|
|
}
|
|
}
|
|
|
|
gdb_test "print one - two" "\\\$\[0-9\]* = {x = -2, y = -2}"
|
|
|
|
gdb_test "print one * two" "\\\$\[0-9\]* = {x = 8, y = 15}"
|
|
|
|
gdb_test "print one / two" "\\\$\[0-9\]* = {x = 0, y = 0}"
|
|
|
|
gdb_test "print one % two" "\\\$\[0-9\]* = {x = 2, y = 3}"
|
|
|
|
gdb_test "print one && two" "\\\$\[0-9\]* = 1\[\r\n\]"
|
|
|
|
gdb_test "print one || two" "\\\$\[0-9\]* = 1\[\r\n\]"
|
|
|
|
gdb_test "print one & two" "\\\$\[0-9\]* = {x = 0, y = 1}"
|
|
|
|
gdb_test "print one | two" "\\\$\[0-9\]* = {x = 6, y = 7}"
|
|
|
|
gdb_test "print one ^ two" "\\\$\[0-9\]* = {x = 6, y = 6}"
|
|
|
|
gdb_test "print one < two" "\\\$\[0-9\]* = 1\[\r\n\]"
|
|
|
|
gdb_test "print one <= two" "\\\$\[0-9\]* = 1\[\r\n\]"
|
|
|
|
gdb_test "print one > two" "\\\$\[0-9\]* = 0\[\r\n\]"
|
|
|
|
gdb_test "print one >= two" "\\\$\[0-9\]* = 0\[\r\n\]"
|
|
|
|
gdb_test "print one == two" "\\\$\[0-9\]* = 0\[\r\n\]"
|
|
gdb_test "print one.operator== (two)" "\\\$\[0-9\]* = 0\[\r\n\]"
|
|
|
|
gdb_test "print one != two" "\\\$\[0-9\]* = 1\[\r\n\]"
|
|
|
|
# Can't really check the output of this one without knowing
|
|
# target integer width. Make sure we don't try to call
|
|
# the iostreams operator instead, though.
|
|
gdb_test "print one << 31" "\\\$\[0-9\]* = {x = -?\[0-9\]*, y = -?\[0-9\]*}"
|
|
|
|
# Should be fine even on < 32-bit targets.
|
|
gdb_test "print one >> 31" "\\\$\[0-9\]* = {x = 0, y = 0}"
|
|
|
|
gdb_test "print !one" "\\\$\[0-9\]* = 0\[\r\n\]"
|
|
|
|
# Assumes 2's complement. So does everything...
|
|
gdb_test "print +one" "\\\$\[0-9\]* = {x = 2, y = 3}"
|
|
|
|
gdb_test "print ~one" "\\\$\[0-9\]* = {x = -3, y = -4}"
|
|
|
|
gdb_test "print -one" "\\\$\[0-9\]* = {x = -2, y = -3}"
|
|
|
|
gdb_test "print one++" "\\\$\[0-9\]* = {x = 2, y = 4}"
|
|
|
|
gdb_test "print ++one" "\\\$\[0-9\]* = {x = 3, y = 4}"
|
|
|
|
gdb_test "print one--" "\\\$\[0-9\]* = {x = 3, y = 3}"
|
|
|
|
gdb_test "print --one" "\\\$\[0-9\]* = {x = 2, y = 3}"
|
|
|
|
gdb_test "print one += 7" "\\\$\[0-9\]* = {x = 9, y = 10}"
|
|
|
|
gdb_test "print two = one" "\\\$\[0-9\]* = {x = 9, y = 10}"
|
|
|
|
# Check that GDB tolerates whitespace in operator names.
|
|
gdb_test "break A2::operator+" ".*Breakpoint $decimal at.*"
|
|
gdb_test "break A2::operator +" ".*Breakpoint $decimal at.*"
|
|
|
|
# Check that GDB handles operator* correctly.
|
|
gdb_test "print c" "\\\$\[0-9\]* = {m = {z = .*}}"
|
|
gdb_test "print *c" "\\\$\[0-9\]* = \\(Member &\\) @$hex: {z = .*}"
|
|
gdb_test "print &*c" "\\\$\[0-9\]* = \\(Member \\*\\) $hex"
|
|
gdb_test "ptype &*c" "type = (struct|class) Member {(\[\r\n \]+public:)?\[\r\n \]+int z;\[\r\n\].*} \\*"
|
|
|
|
gdb_test "print operator== (mem1, mem2)" " = false"
|
|
gdb_test "print operator== (mem1, mem1)" " = true"
|
|
|
|
gdb_exit
|
|
return 0
|