224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
1449 lines
46 KiB
C
1449 lines
46 KiB
C
/* Read ELF (Executable and Linking Format) object files for GDB.
|
||
|
||
Copyright (C) 1991-2015 Free Software Foundation, Inc.
|
||
|
||
Written by Fred Fish at Cygnus Support.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
#include "defs.h"
|
||
#include "bfd.h"
|
||
#include "elf-bfd.h"
|
||
#include "elf/common.h"
|
||
#include "elf/internal.h"
|
||
#include "elf/mips.h"
|
||
#include "symtab.h"
|
||
#include "symfile.h"
|
||
#include "objfiles.h"
|
||
#include "buildsym.h"
|
||
#include "stabsread.h"
|
||
#include "gdb-stabs.h"
|
||
#include "complaints.h"
|
||
#include "demangle.h"
|
||
#include "psympriv.h"
|
||
#include "filenames.h"
|
||
#include "probe.h"
|
||
#include "arch-utils.h"
|
||
#include "gdbtypes.h"
|
||
#include "value.h"
|
||
#include "infcall.h"
|
||
#include "gdbthread.h"
|
||
#include "regcache.h"
|
||
#include "bcache.h"
|
||
#include "gdb_bfd.h"
|
||
#include "build-id.h"
|
||
#include "location.h"
|
||
|
||
extern void _initialize_elfread (void);
|
||
|
||
/* Forward declarations. */
|
||
extern const struct sym_fns elf_sym_fns_gdb_index;
|
||
extern const struct sym_fns elf_sym_fns_lazy_psyms;
|
||
|
||
/* The struct elfinfo is available only during ELF symbol table and
|
||
psymtab reading. It is destroyed at the completion of psymtab-reading.
|
||
It's local to elf_symfile_read. */
|
||
|
||
struct elfinfo
|
||
{
|
||
asection *stabsect; /* Section pointer for .stab section */
|
||
asection *mdebugsect; /* Section pointer for .mdebug section */
|
||
};
|
||
|
||
/* Per-BFD data for probe info. */
|
||
|
||
static const struct bfd_data *probe_key = NULL;
|
||
|
||
/* Minimal symbols located at the GOT entries for .plt - that is the real
|
||
pointer where the given entry will jump to. It gets updated by the real
|
||
function address during lazy ld.so resolving in the inferior. These
|
||
minimal symbols are indexed for <tab>-completion. */
|
||
|
||
#define SYMBOL_GOT_PLT_SUFFIX "@got.plt"
|
||
|
||
/* Locate the segments in ABFD. */
|
||
|
||
static struct symfile_segment_data *
|
||
elf_symfile_segments (bfd *abfd)
|
||
{
|
||
Elf_Internal_Phdr *phdrs, **segments;
|
||
long phdrs_size;
|
||
int num_phdrs, num_segments, num_sections, i;
|
||
asection *sect;
|
||
struct symfile_segment_data *data;
|
||
|
||
phdrs_size = bfd_get_elf_phdr_upper_bound (abfd);
|
||
if (phdrs_size == -1)
|
||
return NULL;
|
||
|
||
phdrs = (Elf_Internal_Phdr *) alloca (phdrs_size);
|
||
num_phdrs = bfd_get_elf_phdrs (abfd, phdrs);
|
||
if (num_phdrs == -1)
|
||
return NULL;
|
||
|
||
num_segments = 0;
|
||
segments = XALLOCAVEC (Elf_Internal_Phdr *, num_phdrs);
|
||
for (i = 0; i < num_phdrs; i++)
|
||
if (phdrs[i].p_type == PT_LOAD)
|
||
segments[num_segments++] = &phdrs[i];
|
||
|
||
if (num_segments == 0)
|
||
return NULL;
|
||
|
||
data = XCNEW (struct symfile_segment_data);
|
||
data->num_segments = num_segments;
|
||
data->segment_bases = XCNEWVEC (CORE_ADDR, num_segments);
|
||
data->segment_sizes = XCNEWVEC (CORE_ADDR, num_segments);
|
||
|
||
for (i = 0; i < num_segments; i++)
|
||
{
|
||
data->segment_bases[i] = segments[i]->p_vaddr;
|
||
data->segment_sizes[i] = segments[i]->p_memsz;
|
||
}
|
||
|
||
num_sections = bfd_count_sections (abfd);
|
||
data->segment_info = XCNEWVEC (int, num_sections);
|
||
|
||
for (i = 0, sect = abfd->sections; sect != NULL; i++, sect = sect->next)
|
||
{
|
||
int j;
|
||
CORE_ADDR vma;
|
||
|
||
if ((bfd_get_section_flags (abfd, sect) & SEC_ALLOC) == 0)
|
||
continue;
|
||
|
||
vma = bfd_get_section_vma (abfd, sect);
|
||
|
||
for (j = 0; j < num_segments; j++)
|
||
if (segments[j]->p_memsz > 0
|
||
&& vma >= segments[j]->p_vaddr
|
||
&& (vma - segments[j]->p_vaddr) < segments[j]->p_memsz)
|
||
{
|
||
data->segment_info[i] = j + 1;
|
||
break;
|
||
}
|
||
|
||
/* We should have found a segment for every non-empty section.
|
||
If we haven't, we will not relocate this section by any
|
||
offsets we apply to the segments. As an exception, do not
|
||
warn about SHT_NOBITS sections; in normal ELF execution
|
||
environments, SHT_NOBITS means zero-initialized and belongs
|
||
in a segment, but in no-OS environments some tools (e.g. ARM
|
||
RealView) use SHT_NOBITS for uninitialized data. Since it is
|
||
uninitialized, it doesn't need a program header. Such
|
||
binaries are not relocatable. */
|
||
if (bfd_get_section_size (sect) > 0 && j == num_segments
|
||
&& (bfd_get_section_flags (abfd, sect) & SEC_LOAD) != 0)
|
||
warning (_("Loadable section \"%s\" outside of ELF segments"),
|
||
bfd_section_name (abfd, sect));
|
||
}
|
||
|
||
return data;
|
||
}
|
||
|
||
/* We are called once per section from elf_symfile_read. We
|
||
need to examine each section we are passed, check to see
|
||
if it is something we are interested in processing, and
|
||
if so, stash away some access information for the section.
|
||
|
||
For now we recognize the dwarf debug information sections and
|
||
line number sections from matching their section names. The
|
||
ELF definition is no real help here since it has no direct
|
||
knowledge of DWARF (by design, so any debugging format can be
|
||
used).
|
||
|
||
We also recognize the ".stab" sections used by the Sun compilers
|
||
released with Solaris 2.
|
||
|
||
FIXME: The section names should not be hardwired strings (what
|
||
should they be? I don't think most object file formats have enough
|
||
section flags to specify what kind of debug section it is.
|
||
-kingdon). */
|
||
|
||
static void
|
||
elf_locate_sections (bfd *ignore_abfd, asection *sectp, void *eip)
|
||
{
|
||
struct elfinfo *ei;
|
||
|
||
ei = (struct elfinfo *) eip;
|
||
if (strcmp (sectp->name, ".stab") == 0)
|
||
{
|
||
ei->stabsect = sectp;
|
||
}
|
||
else if (strcmp (sectp->name, ".mdebug") == 0)
|
||
{
|
||
ei->mdebugsect = sectp;
|
||
}
|
||
}
|
||
|
||
static struct minimal_symbol *
|
||
record_minimal_symbol (const char *name, int name_len, int copy_name,
|
||
CORE_ADDR address,
|
||
enum minimal_symbol_type ms_type,
|
||
asection *bfd_section, struct objfile *objfile)
|
||
{
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
|
||
if (ms_type == mst_text || ms_type == mst_file_text
|
||
|| ms_type == mst_text_gnu_ifunc)
|
||
address = gdbarch_addr_bits_remove (gdbarch, address);
|
||
|
||
return prim_record_minimal_symbol_full (name, name_len, copy_name, address,
|
||
ms_type,
|
||
gdb_bfd_section_index (objfile->obfd,
|
||
bfd_section),
|
||
objfile);
|
||
}
|
||
|
||
/* Read the symbol table of an ELF file.
|
||
|
||
Given an objfile, a symbol table, and a flag indicating whether the
|
||
symbol table contains regular, dynamic, or synthetic symbols, add all
|
||
the global function and data symbols to the minimal symbol table.
|
||
|
||
In stabs-in-ELF, as implemented by Sun, there are some local symbols
|
||
defined in the ELF symbol table, which can be used to locate
|
||
the beginnings of sections from each ".o" file that was linked to
|
||
form the executable objfile. We gather any such info and record it
|
||
in data structures hung off the objfile's private data. */
|
||
|
||
#define ST_REGULAR 0
|
||
#define ST_DYNAMIC 1
|
||
#define ST_SYNTHETIC 2
|
||
|
||
static void
|
||
elf_symtab_read (struct objfile *objfile, int type,
|
||
long number_of_symbols, asymbol **symbol_table,
|
||
int copy_names)
|
||
{
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
asymbol *sym;
|
||
long i;
|
||
CORE_ADDR symaddr;
|
||
CORE_ADDR offset;
|
||
enum minimal_symbol_type ms_type;
|
||
/* Name of the last file symbol. This is either a constant string or is
|
||
saved on the objfile's filename cache. */
|
||
const char *filesymname = "";
|
||
struct dbx_symfile_info *dbx = DBX_SYMFILE_INFO (objfile);
|
||
int stripped = (bfd_get_symcount (objfile->obfd) == 0);
|
||
int elf_make_msymbol_special_p
|
||
= gdbarch_elf_make_msymbol_special_p (gdbarch);
|
||
|
||
for (i = 0; i < number_of_symbols; i++)
|
||
{
|
||
sym = symbol_table[i];
|
||
if (sym->name == NULL || *sym->name == '\0')
|
||
{
|
||
/* Skip names that don't exist (shouldn't happen), or names
|
||
that are null strings (may happen). */
|
||
continue;
|
||
}
|
||
|
||
/* Skip "special" symbols, e.g. ARM mapping symbols. These are
|
||
symbols which do not correspond to objects in the symbol table,
|
||
but have some other target-specific meaning. */
|
||
if (bfd_is_target_special_symbol (objfile->obfd, sym))
|
||
{
|
||
if (gdbarch_record_special_symbol_p (gdbarch))
|
||
gdbarch_record_special_symbol (gdbarch, objfile, sym);
|
||
continue;
|
||
}
|
||
|
||
offset = ANOFFSET (objfile->section_offsets,
|
||
gdb_bfd_section_index (objfile->obfd, sym->section));
|
||
if (type == ST_DYNAMIC
|
||
&& sym->section == bfd_und_section_ptr
|
||
&& (sym->flags & BSF_FUNCTION))
|
||
{
|
||
struct minimal_symbol *msym;
|
||
bfd *abfd = objfile->obfd;
|
||
asection *sect;
|
||
|
||
/* Symbol is a reference to a function defined in
|
||
a shared library.
|
||
If its value is non zero then it is usually the address
|
||
of the corresponding entry in the procedure linkage table,
|
||
plus the desired section offset.
|
||
If its value is zero then the dynamic linker has to resolve
|
||
the symbol. We are unable to find any meaningful address
|
||
for this symbol in the executable file, so we skip it. */
|
||
symaddr = sym->value;
|
||
if (symaddr == 0)
|
||
continue;
|
||
|
||
/* sym->section is the undefined section. However, we want to
|
||
record the section where the PLT stub resides with the
|
||
minimal symbol. Search the section table for the one that
|
||
covers the stub's address. */
|
||
for (sect = abfd->sections; sect != NULL; sect = sect->next)
|
||
{
|
||
if ((bfd_get_section_flags (abfd, sect) & SEC_ALLOC) == 0)
|
||
continue;
|
||
|
||
if (symaddr >= bfd_get_section_vma (abfd, sect)
|
||
&& symaddr < bfd_get_section_vma (abfd, sect)
|
||
+ bfd_get_section_size (sect))
|
||
break;
|
||
}
|
||
if (!sect)
|
||
continue;
|
||
|
||
/* On ia64-hpux, we have discovered that the system linker
|
||
adds undefined symbols with nonzero addresses that cannot
|
||
be right (their address points inside the code of another
|
||
function in the .text section). This creates problems
|
||
when trying to determine which symbol corresponds to
|
||
a given address.
|
||
|
||
We try to detect those buggy symbols by checking which
|
||
section we think they correspond to. Normally, PLT symbols
|
||
are stored inside their own section, and the typical name
|
||
for that section is ".plt". So, if there is a ".plt"
|
||
section, and yet the section name of our symbol does not
|
||
start with ".plt", we ignore that symbol. */
|
||
if (!startswith (sect->name, ".plt")
|
||
&& bfd_get_section_by_name (abfd, ".plt") != NULL)
|
||
continue;
|
||
|
||
msym = record_minimal_symbol
|
||
(sym->name, strlen (sym->name), copy_names,
|
||
symaddr, mst_solib_trampoline, sect, objfile);
|
||
if (msym != NULL)
|
||
{
|
||
msym->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch, sym, msym);
|
||
}
|
||
continue;
|
||
}
|
||
|
||
/* If it is a nonstripped executable, do not enter dynamic
|
||
symbols, as the dynamic symbol table is usually a subset
|
||
of the main symbol table. */
|
||
if (type == ST_DYNAMIC && !stripped)
|
||
continue;
|
||
if (sym->flags & BSF_FILE)
|
||
{
|
||
filesymname = bcache (sym->name, strlen (sym->name) + 1,
|
||
objfile->per_bfd->filename_cache);
|
||
}
|
||
else if (sym->flags & BSF_SECTION_SYM)
|
||
continue;
|
||
else if (sym->flags & (BSF_GLOBAL | BSF_LOCAL | BSF_WEAK
|
||
| BSF_GNU_UNIQUE))
|
||
{
|
||
struct minimal_symbol *msym;
|
||
|
||
/* Select global/local/weak symbols. Note that bfd puts abs
|
||
symbols in their own section, so all symbols we are
|
||
interested in will have a section. */
|
||
/* Bfd symbols are section relative. */
|
||
symaddr = sym->value + sym->section->vma;
|
||
/* For non-absolute symbols, use the type of the section
|
||
they are relative to, to intuit text/data. Bfd provides
|
||
no way of figuring this out for absolute symbols. */
|
||
if (sym->section == bfd_abs_section_ptr)
|
||
{
|
||
/* This is a hack to get the minimal symbol type
|
||
right for Irix 5, which has absolute addresses
|
||
with special section indices for dynamic symbols.
|
||
|
||
NOTE: uweigand-20071112: Synthetic symbols do not
|
||
have an ELF-private part, so do not touch those. */
|
||
unsigned int shndx = type == ST_SYNTHETIC ? 0 :
|
||
((elf_symbol_type *) sym)->internal_elf_sym.st_shndx;
|
||
|
||
switch (shndx)
|
||
{
|
||
case SHN_MIPS_TEXT:
|
||
ms_type = mst_text;
|
||
break;
|
||
case SHN_MIPS_DATA:
|
||
ms_type = mst_data;
|
||
break;
|
||
case SHN_MIPS_ACOMMON:
|
||
ms_type = mst_bss;
|
||
break;
|
||
default:
|
||
ms_type = mst_abs;
|
||
}
|
||
|
||
/* If it is an Irix dynamic symbol, skip section name
|
||
symbols, relocate all others by section offset. */
|
||
if (ms_type != mst_abs)
|
||
{
|
||
if (sym->name[0] == '.')
|
||
continue;
|
||
}
|
||
}
|
||
else if (sym->section->flags & SEC_CODE)
|
||
{
|
||
if (sym->flags & (BSF_GLOBAL | BSF_WEAK | BSF_GNU_UNIQUE))
|
||
{
|
||
if (sym->flags & BSF_GNU_INDIRECT_FUNCTION)
|
||
ms_type = mst_text_gnu_ifunc;
|
||
else
|
||
ms_type = mst_text;
|
||
}
|
||
/* The BSF_SYNTHETIC check is there to omit ppc64 function
|
||
descriptors mistaken for static functions starting with 'L'.
|
||
*/
|
||
else if ((sym->name[0] == '.' && sym->name[1] == 'L'
|
||
&& (sym->flags & BSF_SYNTHETIC) == 0)
|
||
|| ((sym->flags & BSF_LOCAL)
|
||
&& sym->name[0] == '$'
|
||
&& sym->name[1] == 'L'))
|
||
/* Looks like a compiler-generated label. Skip
|
||
it. The assembler should be skipping these (to
|
||
keep executables small), but apparently with
|
||
gcc on the (deleted) delta m88k SVR4, it loses.
|
||
So to have us check too should be harmless (but
|
||
I encourage people to fix this in the assembler
|
||
instead of adding checks here). */
|
||
continue;
|
||
else
|
||
{
|
||
ms_type = mst_file_text;
|
||
}
|
||
}
|
||
else if (sym->section->flags & SEC_ALLOC)
|
||
{
|
||
if (sym->flags & (BSF_GLOBAL | BSF_WEAK | BSF_GNU_UNIQUE))
|
||
{
|
||
if (sym->section->flags & SEC_LOAD)
|
||
{
|
||
ms_type = mst_data;
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_bss;
|
||
}
|
||
}
|
||
else if (sym->flags & BSF_LOCAL)
|
||
{
|
||
if (sym->section->flags & SEC_LOAD)
|
||
{
|
||
ms_type = mst_file_data;
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_file_bss;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
ms_type = mst_unknown;
|
||
}
|
||
}
|
||
else
|
||
{
|
||
/* FIXME: Solaris2 shared libraries include lots of
|
||
odd "absolute" and "undefined" symbols, that play
|
||
hob with actions like finding what function the PC
|
||
is in. Ignore them if they aren't text, data, or bss. */
|
||
/* ms_type = mst_unknown; */
|
||
continue; /* Skip this symbol. */
|
||
}
|
||
msym = record_minimal_symbol
|
||
(sym->name, strlen (sym->name), copy_names, symaddr,
|
||
ms_type, sym->section, objfile);
|
||
|
||
if (msym)
|
||
{
|
||
/* NOTE: uweigand-20071112: A synthetic symbol does not have an
|
||
ELF-private part. */
|
||
if (type != ST_SYNTHETIC)
|
||
{
|
||
/* Pass symbol size field in via BFD. FIXME!!! */
|
||
elf_symbol_type *elf_sym = (elf_symbol_type *) sym;
|
||
SET_MSYMBOL_SIZE (msym, elf_sym->internal_elf_sym.st_size);
|
||
}
|
||
|
||
msym->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch, sym, msym);
|
||
}
|
||
|
||
/* If we see a default versioned symbol, install it under
|
||
its version-less name. */
|
||
if (msym != NULL)
|
||
{
|
||
const char *atsign = strchr (sym->name, '@');
|
||
|
||
if (atsign != NULL && atsign[1] == '@' && atsign > sym->name)
|
||
{
|
||
int len = atsign - sym->name;
|
||
|
||
record_minimal_symbol (sym->name, len, 1, symaddr,
|
||
ms_type, sym->section, objfile);
|
||
}
|
||
}
|
||
|
||
/* For @plt symbols, also record a trampoline to the
|
||
destination symbol. The @plt symbol will be used in
|
||
disassembly, and the trampoline will be used when we are
|
||
trying to find the target. */
|
||
if (msym && ms_type == mst_text && type == ST_SYNTHETIC)
|
||
{
|
||
int len = strlen (sym->name);
|
||
|
||
if (len > 4 && strcmp (sym->name + len - 4, "@plt") == 0)
|
||
{
|
||
struct minimal_symbol *mtramp;
|
||
|
||
mtramp = record_minimal_symbol (sym->name, len - 4, 1,
|
||
symaddr,
|
||
mst_solib_trampoline,
|
||
sym->section, objfile);
|
||
if (mtramp)
|
||
{
|
||
SET_MSYMBOL_SIZE (mtramp, MSYMBOL_SIZE (msym));
|
||
mtramp->created_by_gdb = 1;
|
||
mtramp->filename = filesymname;
|
||
if (elf_make_msymbol_special_p)
|
||
gdbarch_elf_make_msymbol_special (gdbarch,
|
||
sym, mtramp);
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Build minimal symbols named `function@got.plt' (see SYMBOL_GOT_PLT_SUFFIX)
|
||
for later look ups of which function to call when user requests
|
||
a STT_GNU_IFUNC function. As the STT_GNU_IFUNC type is found at the target
|
||
library defining `function' we cannot yet know while reading OBJFILE which
|
||
of the SYMBOL_GOT_PLT_SUFFIX entries will be needed and later
|
||
DYN_SYMBOL_TABLE is no longer easily available for OBJFILE. */
|
||
|
||
static void
|
||
elf_rel_plt_read (struct objfile *objfile, asymbol **dyn_symbol_table)
|
||
{
|
||
bfd *obfd = objfile->obfd;
|
||
const struct elf_backend_data *bed = get_elf_backend_data (obfd);
|
||
asection *plt, *relplt, *got_plt;
|
||
int plt_elf_idx;
|
||
bfd_size_type reloc_count, reloc;
|
||
char *string_buffer = NULL;
|
||
size_t string_buffer_size = 0;
|
||
struct cleanup *back_to;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
||
size_t ptr_size = TYPE_LENGTH (ptr_type);
|
||
|
||
if (objfile->separate_debug_objfile_backlink)
|
||
return;
|
||
|
||
plt = bfd_get_section_by_name (obfd, ".plt");
|
||
if (plt == NULL)
|
||
return;
|
||
plt_elf_idx = elf_section_data (plt)->this_idx;
|
||
|
||
got_plt = bfd_get_section_by_name (obfd, ".got.plt");
|
||
if (got_plt == NULL)
|
||
{
|
||
/* For platforms where there is no separate .got.plt. */
|
||
got_plt = bfd_get_section_by_name (obfd, ".got");
|
||
if (got_plt == NULL)
|
||
return;
|
||
}
|
||
|
||
/* This search algorithm is from _bfd_elf_canonicalize_dynamic_reloc. */
|
||
for (relplt = obfd->sections; relplt != NULL; relplt = relplt->next)
|
||
if (elf_section_data (relplt)->this_hdr.sh_info == plt_elf_idx
|
||
&& (elf_section_data (relplt)->this_hdr.sh_type == SHT_REL
|
||
|| elf_section_data (relplt)->this_hdr.sh_type == SHT_RELA))
|
||
break;
|
||
if (relplt == NULL)
|
||
return;
|
||
|
||
if (! bed->s->slurp_reloc_table (obfd, relplt, dyn_symbol_table, TRUE))
|
||
return;
|
||
|
||
back_to = make_cleanup (free_current_contents, &string_buffer);
|
||
|
||
reloc_count = relplt->size / elf_section_data (relplt)->this_hdr.sh_entsize;
|
||
for (reloc = 0; reloc < reloc_count; reloc++)
|
||
{
|
||
const char *name;
|
||
struct minimal_symbol *msym;
|
||
CORE_ADDR address;
|
||
const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX);
|
||
size_t name_len;
|
||
|
||
name = bfd_asymbol_name (*relplt->relocation[reloc].sym_ptr_ptr);
|
||
name_len = strlen (name);
|
||
address = relplt->relocation[reloc].address;
|
||
|
||
/* Does the pointer reside in the .got.plt section? */
|
||
if (!(bfd_get_section_vma (obfd, got_plt) <= address
|
||
&& address < bfd_get_section_vma (obfd, got_plt)
|
||
+ bfd_get_section_size (got_plt)))
|
||
continue;
|
||
|
||
/* We cannot check if NAME is a reference to mst_text_gnu_ifunc as in
|
||
OBJFILE the symbol is undefined and the objfile having NAME defined
|
||
may not yet have been loaded. */
|
||
|
||
if (string_buffer_size < name_len + got_suffix_len + 1)
|
||
{
|
||
string_buffer_size = 2 * (name_len + got_suffix_len);
|
||
string_buffer = (char *) xrealloc (string_buffer, string_buffer_size);
|
||
}
|
||
memcpy (string_buffer, name, name_len);
|
||
memcpy (&string_buffer[name_len], SYMBOL_GOT_PLT_SUFFIX,
|
||
got_suffix_len + 1);
|
||
|
||
msym = record_minimal_symbol (string_buffer, name_len + got_suffix_len,
|
||
1, address, mst_slot_got_plt, got_plt,
|
||
objfile);
|
||
if (msym)
|
||
SET_MSYMBOL_SIZE (msym, ptr_size);
|
||
}
|
||
|
||
do_cleanups (back_to);
|
||
}
|
||
|
||
/* The data pointer is htab_t for gnu_ifunc_record_cache_unchecked. */
|
||
|
||
static const struct objfile_data *elf_objfile_gnu_ifunc_cache_data;
|
||
|
||
/* Map function names to CORE_ADDR in elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
struct elf_gnu_ifunc_cache
|
||
{
|
||
/* This is always a function entry address, not a function descriptor. */
|
||
CORE_ADDR addr;
|
||
|
||
char name[1];
|
||
};
|
||
|
||
/* htab_hash for elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
static hashval_t
|
||
elf_gnu_ifunc_cache_hash (const void *a_voidp)
|
||
{
|
||
const struct elf_gnu_ifunc_cache *a = a_voidp;
|
||
|
||
return htab_hash_string (a->name);
|
||
}
|
||
|
||
/* htab_eq for elf_objfile_gnu_ifunc_cache_data. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_cache_eq (const void *a_voidp, const void *b_voidp)
|
||
{
|
||
const struct elf_gnu_ifunc_cache *a = a_voidp;
|
||
const struct elf_gnu_ifunc_cache *b = b_voidp;
|
||
|
||
return strcmp (a->name, b->name) == 0;
|
||
}
|
||
|
||
/* Record the target function address of a STT_GNU_IFUNC function NAME is the
|
||
function entry address ADDR. Return 1 if NAME and ADDR are considered as
|
||
valid and therefore they were successfully recorded, return 0 otherwise.
|
||
|
||
Function does not expect a duplicate entry. Use
|
||
elf_gnu_ifunc_resolve_by_cache first to check if the entry for NAME already
|
||
exists. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_record_cache (const char *name, CORE_ADDR addr)
|
||
{
|
||
struct bound_minimal_symbol msym;
|
||
asection *sect;
|
||
struct objfile *objfile;
|
||
htab_t htab;
|
||
struct elf_gnu_ifunc_cache entry_local, *entry_p;
|
||
void **slot;
|
||
|
||
msym = lookup_minimal_symbol_by_pc (addr);
|
||
if (msym.minsym == NULL)
|
||
return 0;
|
||
if (BMSYMBOL_VALUE_ADDRESS (msym) != addr)
|
||
return 0;
|
||
/* minimal symbols have always SYMBOL_OBJ_SECTION non-NULL. */
|
||
sect = MSYMBOL_OBJ_SECTION (msym.objfile, msym.minsym)->the_bfd_section;
|
||
objfile = msym.objfile;
|
||
|
||
/* If .plt jumps back to .plt the symbol is still deferred for later
|
||
resolution and it has no use for GDB. Besides ".text" this symbol can
|
||
reside also in ".opd" for ppc64 function descriptor. */
|
||
if (strcmp (bfd_get_section_name (objfile->obfd, sect), ".plt") == 0)
|
||
return 0;
|
||
|
||
htab = objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data);
|
||
if (htab == NULL)
|
||
{
|
||
htab = htab_create_alloc_ex (1, elf_gnu_ifunc_cache_hash,
|
||
elf_gnu_ifunc_cache_eq,
|
||
NULL, &objfile->objfile_obstack,
|
||
hashtab_obstack_allocate,
|
||
dummy_obstack_deallocate);
|
||
set_objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data, htab);
|
||
}
|
||
|
||
entry_local.addr = addr;
|
||
obstack_grow (&objfile->objfile_obstack, &entry_local,
|
||
offsetof (struct elf_gnu_ifunc_cache, name));
|
||
obstack_grow_str0 (&objfile->objfile_obstack, name);
|
||
entry_p
|
||
= (struct elf_gnu_ifunc_cache *) obstack_finish (&objfile->objfile_obstack);
|
||
|
||
slot = htab_find_slot (htab, entry_p, INSERT);
|
||
if (*slot != NULL)
|
||
{
|
||
struct elf_gnu_ifunc_cache *entry_found_p = *slot;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
|
||
if (entry_found_p->addr != addr)
|
||
{
|
||
/* This case indicates buggy inferior program, the resolved address
|
||
should never change. */
|
||
|
||
warning (_("gnu-indirect-function \"%s\" has changed its resolved "
|
||
"function_address from %s to %s"),
|
||
name, paddress (gdbarch, entry_found_p->addr),
|
||
paddress (gdbarch, addr));
|
||
}
|
||
|
||
/* New ENTRY_P is here leaked/duplicate in the OBJFILE obstack. */
|
||
}
|
||
*slot = entry_p;
|
||
|
||
return 1;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Only the elf_objfile_gnu_ifunc_cache_data hash table is searched by this
|
||
function. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_by_cache (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
struct objfile *objfile;
|
||
|
||
ALL_PSPACE_OBJFILES (current_program_space, objfile)
|
||
{
|
||
htab_t htab;
|
||
struct elf_gnu_ifunc_cache *entry_p;
|
||
void **slot;
|
||
|
||
htab = objfile_data (objfile, elf_objfile_gnu_ifunc_cache_data);
|
||
if (htab == NULL)
|
||
continue;
|
||
|
||
entry_p = ((struct elf_gnu_ifunc_cache *)
|
||
alloca (sizeof (*entry_p) + strlen (name)));
|
||
strcpy (entry_p->name, name);
|
||
|
||
slot = htab_find_slot (htab, entry_p, NO_INSERT);
|
||
if (slot == NULL)
|
||
continue;
|
||
entry_p = *slot;
|
||
gdb_assert (entry_p != NULL);
|
||
|
||
if (addr_p)
|
||
*addr_p = entry_p->addr;
|
||
return 1;
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Only the SYMBOL_GOT_PLT_SUFFIX locations are searched by this function.
|
||
elf_gnu_ifunc_resolve_by_cache must have been already called for NAME to
|
||
prevent cache entries duplicates. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_by_got (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
char *name_got_plt;
|
||
struct objfile *objfile;
|
||
const size_t got_suffix_len = strlen (SYMBOL_GOT_PLT_SUFFIX);
|
||
|
||
name_got_plt = (char *) alloca (strlen (name) + got_suffix_len + 1);
|
||
sprintf (name_got_plt, "%s" SYMBOL_GOT_PLT_SUFFIX, name);
|
||
|
||
ALL_PSPACE_OBJFILES (current_program_space, objfile)
|
||
{
|
||
bfd *obfd = objfile->obfd;
|
||
struct gdbarch *gdbarch = get_objfile_arch (objfile);
|
||
struct type *ptr_type = builtin_type (gdbarch)->builtin_data_ptr;
|
||
size_t ptr_size = TYPE_LENGTH (ptr_type);
|
||
CORE_ADDR pointer_address, addr;
|
||
asection *plt;
|
||
gdb_byte *buf = (gdb_byte *) alloca (ptr_size);
|
||
struct bound_minimal_symbol msym;
|
||
|
||
msym = lookup_minimal_symbol (name_got_plt, NULL, objfile);
|
||
if (msym.minsym == NULL)
|
||
continue;
|
||
if (MSYMBOL_TYPE (msym.minsym) != mst_slot_got_plt)
|
||
continue;
|
||
pointer_address = BMSYMBOL_VALUE_ADDRESS (msym);
|
||
|
||
plt = bfd_get_section_by_name (obfd, ".plt");
|
||
if (plt == NULL)
|
||
continue;
|
||
|
||
if (MSYMBOL_SIZE (msym.minsym) != ptr_size)
|
||
continue;
|
||
if (target_read_memory (pointer_address, buf, ptr_size) != 0)
|
||
continue;
|
||
addr = extract_typed_address (buf, ptr_type);
|
||
addr = gdbarch_convert_from_func_ptr_addr (gdbarch, addr,
|
||
¤t_target);
|
||
addr = gdbarch_addr_bits_remove (gdbarch, addr);
|
||
|
||
if (addr_p)
|
||
*addr_p = addr;
|
||
if (elf_gnu_ifunc_record_cache (name, addr))
|
||
return 1;
|
||
}
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Try to find the target resolved function entry address of a STT_GNU_IFUNC
|
||
function NAME. If the address is found it is stored to *ADDR_P (if ADDR_P
|
||
is not NULL) and the function returns 1. It returns 0 otherwise.
|
||
|
||
Both the elf_objfile_gnu_ifunc_cache_data hash table and
|
||
SYMBOL_GOT_PLT_SUFFIX locations are searched by this function. */
|
||
|
||
static int
|
||
elf_gnu_ifunc_resolve_name (const char *name, CORE_ADDR *addr_p)
|
||
{
|
||
if (elf_gnu_ifunc_resolve_by_cache (name, addr_p))
|
||
return 1;
|
||
|
||
if (elf_gnu_ifunc_resolve_by_got (name, addr_p))
|
||
return 1;
|
||
|
||
return 0;
|
||
}
|
||
|
||
/* Call STT_GNU_IFUNC - a function returning addresss of a real function to
|
||
call. PC is theSTT_GNU_IFUNC resolving function entry. The value returned
|
||
is the entry point of the resolved STT_GNU_IFUNC target function to call.
|
||
*/
|
||
|
||
static CORE_ADDR
|
||
elf_gnu_ifunc_resolve_addr (struct gdbarch *gdbarch, CORE_ADDR pc)
|
||
{
|
||
const char *name_at_pc;
|
||
CORE_ADDR start_at_pc, address;
|
||
struct type *func_func_type = builtin_type (gdbarch)->builtin_func_func;
|
||
struct value *function, *address_val;
|
||
|
||
/* Try first any non-intrusive methods without an inferior call. */
|
||
|
||
if (find_pc_partial_function (pc, &name_at_pc, &start_at_pc, NULL)
|
||
&& start_at_pc == pc)
|
||
{
|
||
if (elf_gnu_ifunc_resolve_name (name_at_pc, &address))
|
||
return address;
|
||
}
|
||
else
|
||
name_at_pc = NULL;
|
||
|
||
function = allocate_value (func_func_type);
|
||
set_value_address (function, pc);
|
||
|
||
/* STT_GNU_IFUNC resolver functions have no parameters. FUNCTION is the
|
||
function entry address. ADDRESS may be a function descriptor. */
|
||
|
||
address_val = call_function_by_hand (function, 0, NULL);
|
||
address = value_as_address (address_val);
|
||
address = gdbarch_convert_from_func_ptr_addr (gdbarch, address,
|
||
¤t_target);
|
||
address = gdbarch_addr_bits_remove (gdbarch, address);
|
||
|
||
if (name_at_pc)
|
||
elf_gnu_ifunc_record_cache (name_at_pc, address);
|
||
|
||
return address;
|
||
}
|
||
|
||
/* Handle inferior hit of bp_gnu_ifunc_resolver, see its definition. */
|
||
|
||
static void
|
||
elf_gnu_ifunc_resolver_stop (struct breakpoint *b)
|
||
{
|
||
struct breakpoint *b_return;
|
||
struct frame_info *prev_frame = get_prev_frame (get_current_frame ());
|
||
struct frame_id prev_frame_id = get_stack_frame_id (prev_frame);
|
||
CORE_ADDR prev_pc = get_frame_pc (prev_frame);
|
||
int thread_id = pid_to_thread_id (inferior_ptid);
|
||
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver);
|
||
|
||
for (b_return = b->related_breakpoint; b_return != b;
|
||
b_return = b_return->related_breakpoint)
|
||
{
|
||
gdb_assert (b_return->type == bp_gnu_ifunc_resolver_return);
|
||
gdb_assert (b_return->loc != NULL && b_return->loc->next == NULL);
|
||
gdb_assert (frame_id_p (b_return->frame_id));
|
||
|
||
if (b_return->thread == thread_id
|
||
&& b_return->loc->requested_address == prev_pc
|
||
&& frame_id_eq (b_return->frame_id, prev_frame_id))
|
||
break;
|
||
}
|
||
|
||
if (b_return == b)
|
||
{
|
||
struct symtab_and_line sal;
|
||
|
||
/* No need to call find_pc_line for symbols resolving as this is only
|
||
a helper breakpointer never shown to the user. */
|
||
|
||
init_sal (&sal);
|
||
sal.pspace = current_inferior ()->pspace;
|
||
sal.pc = prev_pc;
|
||
sal.section = find_pc_overlay (sal.pc);
|
||
sal.explicit_pc = 1;
|
||
b_return = set_momentary_breakpoint (get_frame_arch (prev_frame), sal,
|
||
prev_frame_id,
|
||
bp_gnu_ifunc_resolver_return);
|
||
|
||
/* set_momentary_breakpoint invalidates PREV_FRAME. */
|
||
prev_frame = NULL;
|
||
|
||
/* Add new b_return to the ring list b->related_breakpoint. */
|
||
gdb_assert (b_return->related_breakpoint == b_return);
|
||
b_return->related_breakpoint = b->related_breakpoint;
|
||
b->related_breakpoint = b_return;
|
||
}
|
||
}
|
||
|
||
/* Handle inferior hit of bp_gnu_ifunc_resolver_return, see its definition. */
|
||
|
||
static void
|
||
elf_gnu_ifunc_resolver_return_stop (struct breakpoint *b)
|
||
{
|
||
struct gdbarch *gdbarch = get_frame_arch (get_current_frame ());
|
||
struct type *func_func_type = builtin_type (gdbarch)->builtin_func_func;
|
||
struct type *value_type = TYPE_TARGET_TYPE (func_func_type);
|
||
struct regcache *regcache = get_thread_regcache (inferior_ptid);
|
||
struct value *func_func;
|
||
struct value *value;
|
||
CORE_ADDR resolved_address, resolved_pc;
|
||
struct symtab_and_line sal;
|
||
struct symtabs_and_lines sals, sals_end;
|
||
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver_return);
|
||
|
||
while (b->related_breakpoint != b)
|
||
{
|
||
struct breakpoint *b_next = b->related_breakpoint;
|
||
|
||
switch (b->type)
|
||
{
|
||
case bp_gnu_ifunc_resolver:
|
||
break;
|
||
case bp_gnu_ifunc_resolver_return:
|
||
delete_breakpoint (b);
|
||
break;
|
||
default:
|
||
internal_error (__FILE__, __LINE__,
|
||
_("handle_inferior_event: Invalid "
|
||
"gnu-indirect-function breakpoint type %d"),
|
||
(int) b->type);
|
||
}
|
||
b = b_next;
|
||
}
|
||
gdb_assert (b->type == bp_gnu_ifunc_resolver);
|
||
gdb_assert (b->loc->next == NULL);
|
||
|
||
func_func = allocate_value (func_func_type);
|
||
set_value_address (func_func, b->loc->related_address);
|
||
|
||
value = allocate_value (value_type);
|
||
gdbarch_return_value (gdbarch, func_func, value_type, regcache,
|
||
value_contents_raw (value), NULL);
|
||
resolved_address = value_as_address (value);
|
||
resolved_pc = gdbarch_convert_from_func_ptr_addr (gdbarch,
|
||
resolved_address,
|
||
¤t_target);
|
||
resolved_pc = gdbarch_addr_bits_remove (gdbarch, resolved_pc);
|
||
|
||
gdb_assert (current_program_space == b->pspace || b->pspace == NULL);
|
||
elf_gnu_ifunc_record_cache (event_location_to_string (b->location),
|
||
resolved_pc);
|
||
|
||
sal = find_pc_line (resolved_pc, 0);
|
||
sals.nelts = 1;
|
||
sals.sals = &sal;
|
||
sals_end.nelts = 0;
|
||
|
||
b->type = bp_breakpoint;
|
||
update_breakpoint_locations (b, sals, sals_end);
|
||
}
|
||
|
||
/* A helper function for elf_symfile_read that reads the minimal
|
||
symbols. */
|
||
|
||
static void
|
||
elf_read_minimal_symbols (struct objfile *objfile, int symfile_flags,
|
||
const struct elfinfo *ei)
|
||
{
|
||
bfd *synth_abfd, *abfd = objfile->obfd;
|
||
struct cleanup *back_to;
|
||
long symcount = 0, dynsymcount = 0, synthcount, storage_needed;
|
||
asymbol **symbol_table = NULL, **dyn_symbol_table = NULL;
|
||
asymbol *synthsyms;
|
||
struct dbx_symfile_info *dbx;
|
||
|
||
if (symtab_create_debug)
|
||
{
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"Reading minimal symbols of objfile %s ...\n",
|
||
objfile_name (objfile));
|
||
}
|
||
|
||
/* If we already have minsyms, then we can skip some work here.
|
||
However, if there were stabs or mdebug sections, we go ahead and
|
||
redo all the work anyway, because the psym readers for those
|
||
kinds of debuginfo need extra information found here. This can
|
||
go away once all types of symbols are in the per-BFD object. */
|
||
if (objfile->per_bfd->minsyms_read
|
||
&& ei->stabsect == NULL
|
||
&& ei->mdebugsect == NULL)
|
||
{
|
||
if (symtab_create_debug)
|
||
fprintf_unfiltered (gdb_stdlog,
|
||
"... minimal symbols previously read\n");
|
||
return;
|
||
}
|
||
|
||
init_minimal_symbol_collection ();
|
||
back_to = make_cleanup_discard_minimal_symbols ();
|
||
|
||
/* Allocate struct to keep track of the symfile. */
|
||
dbx = XCNEW (struct dbx_symfile_info);
|
||
set_objfile_data (objfile, dbx_objfile_data_key, dbx);
|
||
|
||
/* Process the normal ELF symbol table first. */
|
||
|
||
storage_needed = bfd_get_symtab_upper_bound (objfile->obfd);
|
||
if (storage_needed < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
if (storage_needed > 0)
|
||
{
|
||
/* Memory gets permanently referenced from ABFD after
|
||
bfd_canonicalize_symtab so it must not get freed before ABFD gets. */
|
||
|
||
symbol_table = (asymbol **) bfd_alloc (abfd, storage_needed);
|
||
symcount = bfd_canonicalize_symtab (objfile->obfd, symbol_table);
|
||
|
||
if (symcount < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
elf_symtab_read (objfile, ST_REGULAR, symcount, symbol_table, 0);
|
||
}
|
||
|
||
/* Add the dynamic symbols. */
|
||
|
||
storage_needed = bfd_get_dynamic_symtab_upper_bound (objfile->obfd);
|
||
|
||
if (storage_needed > 0)
|
||
{
|
||
/* Memory gets permanently referenced from ABFD after
|
||
bfd_get_synthetic_symtab so it must not get freed before ABFD gets.
|
||
It happens only in the case when elf_slurp_reloc_table sees
|
||
asection->relocation NULL. Determining which section is asection is
|
||
done by _bfd_elf_get_synthetic_symtab which is all a bfd
|
||
implementation detail, though. */
|
||
|
||
dyn_symbol_table = (asymbol **) bfd_alloc (abfd, storage_needed);
|
||
dynsymcount = bfd_canonicalize_dynamic_symtab (objfile->obfd,
|
||
dyn_symbol_table);
|
||
|
||
if (dynsymcount < 0)
|
||
error (_("Can't read symbols from %s: %s"),
|
||
bfd_get_filename (objfile->obfd),
|
||
bfd_errmsg (bfd_get_error ()));
|
||
|
||
elf_symtab_read (objfile, ST_DYNAMIC, dynsymcount, dyn_symbol_table, 0);
|
||
|
||
elf_rel_plt_read (objfile, dyn_symbol_table);
|
||
}
|
||
|
||
/* Contrary to binutils --strip-debug/--only-keep-debug the strip command from
|
||
elfutils (eu-strip) moves even the .symtab section into the .debug file.
|
||
|
||
bfd_get_synthetic_symtab on ppc64 for each function descriptor ELF symbol
|
||
'name' creates a new BSF_SYNTHETIC ELF symbol '.name' with its code
|
||
address. But with eu-strip files bfd_get_synthetic_symtab would fail to
|
||
read the code address from .opd while it reads the .symtab section from
|
||
a separate debug info file as the .opd section is SHT_NOBITS there.
|
||
|
||
With SYNTH_ABFD the .opd section will be read from the original
|
||
backlinked binary where it is valid. */
|
||
|
||
if (objfile->separate_debug_objfile_backlink)
|
||
synth_abfd = objfile->separate_debug_objfile_backlink->obfd;
|
||
else
|
||
synth_abfd = abfd;
|
||
|
||
/* Add synthetic symbols - for instance, names for any PLT entries. */
|
||
|
||
synthcount = bfd_get_synthetic_symtab (synth_abfd, symcount, symbol_table,
|
||
dynsymcount, dyn_symbol_table,
|
||
&synthsyms);
|
||
if (synthcount > 0)
|
||
{
|
||
asymbol **synth_symbol_table;
|
||
long i;
|
||
|
||
make_cleanup (xfree, synthsyms);
|
||
synth_symbol_table = XNEWVEC (asymbol *, synthcount);
|
||
for (i = 0; i < synthcount; i++)
|
||
synth_symbol_table[i] = synthsyms + i;
|
||
make_cleanup (xfree, synth_symbol_table);
|
||
elf_symtab_read (objfile, ST_SYNTHETIC, synthcount,
|
||
synth_symbol_table, 1);
|
||
}
|
||
|
||
/* Install any minimal symbols that have been collected as the current
|
||
minimal symbols for this objfile. The debug readers below this point
|
||
should not generate new minimal symbols; if they do it's their
|
||
responsibility to install them. "mdebug" appears to be the only one
|
||
which will do this. */
|
||
|
||
install_minimal_symbols (objfile);
|
||
do_cleanups (back_to);
|
||
|
||
if (symtab_create_debug)
|
||
fprintf_unfiltered (gdb_stdlog, "Done reading minimal symbols.\n");
|
||
}
|
||
|
||
/* Scan and build partial symbols for a symbol file.
|
||
We have been initialized by a call to elf_symfile_init, which
|
||
currently does nothing.
|
||
|
||
This function only does the minimum work necessary for letting the
|
||
user "name" things symbolically; it does not read the entire symtab.
|
||
Instead, it reads the external and static symbols and puts them in partial
|
||
symbol tables. When more extensive information is requested of a
|
||
file, the corresponding partial symbol table is mutated into a full
|
||
fledged symbol table by going back and reading the symbols
|
||
for real.
|
||
|
||
We look for sections with specific names, to tell us what debug
|
||
format to look for: FIXME!!!
|
||
|
||
elfstab_build_psymtabs() handles STABS symbols;
|
||
mdebug_build_psymtabs() handles ECOFF debugging information.
|
||
|
||
Note that ELF files have a "minimal" symbol table, which looks a lot
|
||
like a COFF symbol table, but has only the minimal information necessary
|
||
for linking. We process this also, and use the information to
|
||
build gdb's minimal symbol table. This gives us some minimal debugging
|
||
capability even for files compiled without -g. */
|
||
|
||
static void
|
||
elf_symfile_read (struct objfile *objfile, int symfile_flags)
|
||
{
|
||
bfd *abfd = objfile->obfd;
|
||
struct elfinfo ei;
|
||
|
||
memset ((char *) &ei, 0, sizeof (ei));
|
||
bfd_map_over_sections (abfd, elf_locate_sections, (void *) & ei);
|
||
|
||
elf_read_minimal_symbols (objfile, symfile_flags, &ei);
|
||
|
||
/* ELF debugging information is inserted into the psymtab in the
|
||
order of least informative first - most informative last. Since
|
||
the psymtab table is searched `most recent insertion first' this
|
||
increases the probability that more detailed debug information
|
||
for a section is found.
|
||
|
||
For instance, an object file might contain both .mdebug (XCOFF)
|
||
and .debug_info (DWARF2) sections then .mdebug is inserted first
|
||
(searched last) and DWARF2 is inserted last (searched first). If
|
||
we don't do this then the XCOFF info is found first - for code in
|
||
an included file XCOFF info is useless. */
|
||
|
||
if (ei.mdebugsect)
|
||
{
|
||
const struct ecoff_debug_swap *swap;
|
||
|
||
/* .mdebug section, presumably holding ECOFF debugging
|
||
information. */
|
||
swap = get_elf_backend_data (abfd)->elf_backend_ecoff_debug_swap;
|
||
if (swap)
|
||
elfmdebug_build_psymtabs (objfile, swap, ei.mdebugsect);
|
||
}
|
||
if (ei.stabsect)
|
||
{
|
||
asection *str_sect;
|
||
|
||
/* Stab sections have an associated string table that looks like
|
||
a separate section. */
|
||
str_sect = bfd_get_section_by_name (abfd, ".stabstr");
|
||
|
||
/* FIXME should probably warn about a stab section without a stabstr. */
|
||
if (str_sect)
|
||
elfstab_build_psymtabs (objfile,
|
||
ei.stabsect,
|
||
str_sect->filepos,
|
||
bfd_section_size (abfd, str_sect));
|
||
}
|
||
|
||
if (dwarf2_has_info (objfile, NULL))
|
||
{
|
||
/* elf_sym_fns_gdb_index cannot handle simultaneous non-DWARF debug
|
||
information present in OBJFILE. If there is such debug info present
|
||
never use .gdb_index. */
|
||
|
||
if (!objfile_has_partial_symbols (objfile)
|
||
&& dwarf2_initialize_objfile (objfile))
|
||
objfile_set_sym_fns (objfile, &elf_sym_fns_gdb_index);
|
||
else
|
||
{
|
||
/* It is ok to do this even if the stabs reader made some
|
||
partial symbols, because OBJF_PSYMTABS_READ has not been
|
||
set, and so our lazy reader function will still be called
|
||
when needed. */
|
||
objfile_set_sym_fns (objfile, &elf_sym_fns_lazy_psyms);
|
||
}
|
||
}
|
||
/* If the file has its own symbol tables it has no separate debug
|
||
info. `.dynsym'/`.symtab' go to MSYMBOLS, `.debug_info' goes to
|
||
SYMTABS/PSYMTABS. `.gnu_debuglink' may no longer be present with
|
||
`.note.gnu.build-id'.
|
||
|
||
.gnu_debugdata is !objfile_has_partial_symbols because it contains only
|
||
.symtab, not .debug_* section. But if we already added .gnu_debugdata as
|
||
an objfile via find_separate_debug_file_in_section there was no separate
|
||
debug info available. Therefore do not attempt to search for another one,
|
||
objfile->separate_debug_objfile->separate_debug_objfile GDB guarantees to
|
||
be NULL and we would possibly violate it. */
|
||
|
||
else if (!objfile_has_partial_symbols (objfile)
|
||
&& objfile->separate_debug_objfile == NULL
|
||
&& objfile->separate_debug_objfile_backlink == NULL)
|
||
{
|
||
char *debugfile;
|
||
|
||
debugfile = find_separate_debug_file_by_buildid (objfile);
|
||
|
||
if (debugfile == NULL)
|
||
debugfile = find_separate_debug_file_by_debuglink (objfile);
|
||
|
||
if (debugfile)
|
||
{
|
||
struct cleanup *cleanup = make_cleanup (xfree, debugfile);
|
||
bfd *abfd = symfile_bfd_open (debugfile);
|
||
|
||
make_cleanup_bfd_unref (abfd);
|
||
symbol_file_add_separate (abfd, debugfile, symfile_flags, objfile);
|
||
do_cleanups (cleanup);
|
||
}
|
||
}
|
||
}
|
||
|
||
/* Callback to lazily read psymtabs. */
|
||
|
||
static void
|
||
read_psyms (struct objfile *objfile)
|
||
{
|
||
if (dwarf2_has_info (objfile, NULL))
|
||
dwarf2_build_psymtabs (objfile);
|
||
}
|
||
|
||
/* Initialize anything that needs initializing when a completely new symbol
|
||
file is specified (not just adding some symbols from another file, e.g. a
|
||
shared library).
|
||
|
||
We reinitialize buildsym, since we may be reading stabs from an ELF
|
||
file. */
|
||
|
||
static void
|
||
elf_new_init (struct objfile *ignore)
|
||
{
|
||
stabsread_new_init ();
|
||
buildsym_new_init ();
|
||
}
|
||
|
||
/* Perform any local cleanups required when we are done with a particular
|
||
objfile. I.E, we are in the process of discarding all symbol information
|
||
for an objfile, freeing up all memory held for it, and unlinking the
|
||
objfile struct from the global list of known objfiles. */
|
||
|
||
static void
|
||
elf_symfile_finish (struct objfile *objfile)
|
||
{
|
||
dwarf2_free_objfile (objfile);
|
||
}
|
||
|
||
/* ELF specific initialization routine for reading symbols. */
|
||
|
||
static void
|
||
elf_symfile_init (struct objfile *objfile)
|
||
{
|
||
/* ELF objects may be reordered, so set OBJF_REORDERED. If we
|
||
find this causes a significant slowdown in gdb then we could
|
||
set it in the debug symbol readers only when necessary. */
|
||
objfile->flags |= OBJF_REORDERED;
|
||
}
|
||
|
||
/* Implementation of `sym_get_probes', as documented in symfile.h. */
|
||
|
||
static VEC (probe_p) *
|
||
elf_get_probes (struct objfile *objfile)
|
||
{
|
||
VEC (probe_p) *probes_per_bfd;
|
||
|
||
/* Have we parsed this objfile's probes already? */
|
||
probes_per_bfd = bfd_data (objfile->obfd, probe_key);
|
||
|
||
if (!probes_per_bfd)
|
||
{
|
||
int ix;
|
||
const struct probe_ops *probe_ops;
|
||
|
||
/* Here we try to gather information about all types of probes from the
|
||
objfile. */
|
||
for (ix = 0; VEC_iterate (probe_ops_cp, all_probe_ops, ix, probe_ops);
|
||
ix++)
|
||
probe_ops->get_probes (&probes_per_bfd, objfile);
|
||
|
||
if (probes_per_bfd == NULL)
|
||
{
|
||
VEC_reserve (probe_p, probes_per_bfd, 1);
|
||
gdb_assert (probes_per_bfd != NULL);
|
||
}
|
||
|
||
set_bfd_data (objfile->obfd, probe_key, probes_per_bfd);
|
||
}
|
||
|
||
return probes_per_bfd;
|
||
}
|
||
|
||
/* Helper function used to free the space allocated for storing SystemTap
|
||
probe information. */
|
||
|
||
static void
|
||
probe_key_free (bfd *abfd, void *d)
|
||
{
|
||
int ix;
|
||
VEC (probe_p) *probes = d;
|
||
struct probe *probe;
|
||
|
||
for (ix = 0; VEC_iterate (probe_p, probes, ix, probe); ix++)
|
||
probe->pops->destroy (probe);
|
||
|
||
VEC_free (probe_p, probes);
|
||
}
|
||
|
||
|
||
|
||
/* Implementation `sym_probe_fns', as documented in symfile.h. */
|
||
|
||
static const struct sym_probe_fns elf_probe_fns =
|
||
{
|
||
elf_get_probes, /* sym_get_probes */
|
||
};
|
||
|
||
/* Register that we are able to handle ELF object file formats. */
|
||
|
||
static const struct sym_fns elf_sym_fns =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symtab */
|
||
elf_symfile_init, /* read initial info, setup for sym_read() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
NULL, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocation */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&psym_functions
|
||
};
|
||
|
||
/* The same as elf_sym_fns, but not registered and lazily reads
|
||
psymbols. */
|
||
|
||
const struct sym_fns elf_sym_fns_lazy_psyms =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symtab */
|
||
elf_symfile_init, /* read initial info, setup for sym_read() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
read_psyms, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocation */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&psym_functions
|
||
};
|
||
|
||
/* The same as elf_sym_fns, but not registered and uses the
|
||
DWARF-specific GNU index rather than psymtab. */
|
||
const struct sym_fns elf_sym_fns_gdb_index =
|
||
{
|
||
elf_new_init, /* init anything gbl to entire symab */
|
||
elf_symfile_init, /* read initial info, setup for sym_red() */
|
||
elf_symfile_read, /* read a symbol file into symtab */
|
||
NULL, /* sym_read_psymbols */
|
||
elf_symfile_finish, /* finished with file, cleanup */
|
||
default_symfile_offsets, /* Translate ext. to int. relocatin */
|
||
elf_symfile_segments, /* Get segment information from a file. */
|
||
NULL,
|
||
default_symfile_relocate, /* Relocate a debug section. */
|
||
&elf_probe_fns, /* sym_probe_fns */
|
||
&dwarf2_gdb_index_functions
|
||
};
|
||
|
||
/* STT_GNU_IFUNC resolver vector to be installed to gnu_ifunc_fns_p. */
|
||
|
||
static const struct gnu_ifunc_fns elf_gnu_ifunc_fns =
|
||
{
|
||
elf_gnu_ifunc_resolve_addr,
|
||
elf_gnu_ifunc_resolve_name,
|
||
elf_gnu_ifunc_resolver_stop,
|
||
elf_gnu_ifunc_resolver_return_stop
|
||
};
|
||
|
||
void
|
||
_initialize_elfread (void)
|
||
{
|
||
probe_key = register_bfd_data_with_cleanup (NULL, probe_key_free);
|
||
add_symtab_fns (bfd_target_elf_flavour, &elf_sym_fns);
|
||
|
||
elf_objfile_gnu_ifunc_cache_data = register_objfile_data ();
|
||
gnu_ifunc_fns_p = &elf_gnu_ifunc_fns;
|
||
}
|