224c3ddb89
Most allocation functions (if not all) return a void* pointing to the allocated memory. In C++, we need to add an explicit cast when assigning the result to a pointer to another type (which is the case more often than not). The content of this patch is taken from Pedro's branch, from commit "(mostly) auto-generated patch to insert casts needed for C++". I validated that the changes make sense and manually reflowed the code to make it respect the coding style. I also found multiple places where I could use XNEW/XNEWVEC/XRESIZEVEC/etc. Thanks a lot to whoever did that automated script to insert casts, doing it completely by hand would have taken a ridiculous amount of time. Only files built on x86 with --enable-targets=all are modified. This means that all other -nat.c files are untouched and will have to be dealt with later by using appropiate compilers. Or maybe we can try to build them with a regular g++ just to know where to add casts, I don't know. I built-tested this with --enable-targets=all and reg-tested. Here's the changelog entry, which was not too bad to make despite the size, thanks to David Malcom's script. I fixed some bits by hand, but there might be some wrong parts left (hopefully not). gdb/ChangeLog: * aarch64-linux-tdep.c (aarch64_stap_parse_special_token): Add cast to allocation result assignment. * ada-exp.y (write_object_renaming): Likewise. (write_ambiguous_var): Likewise. (ada_nget_field_index): Likewise. (write_var_or_type): Likewise. * ada-lang.c (ada_decode_symbol): Likewise. (ada_value_assign): Likewise. (value_pointer): Likewise. (cache_symbol): Likewise. (add_nonlocal_symbols): Likewise. (ada_name_for_lookup): Likewise. (symbol_completion_add): Likewise. (ada_to_fixed_type_1): Likewise. (ada_get_next_arg): Likewise. (defns_collected): Likewise. * ada-lex.l (processId): Likewise. (processString): Likewise. * ada-tasks.c (read_known_tasks_array): Likewise. (read_known_tasks_list): Likewise. * ada-typeprint.c (decoded_type_name): Likewise. * addrmap.c (addrmap_mutable_create_fixed): Likewise. * amd64-tdep.c (amd64_push_arguments): Likewise. (amd64_displaced_step_copy_insn): Likewise. (amd64_classify_insn_at): Likewise. (amd64_relocate_instruction): Likewise. * amd64obsd-tdep.c (amd64obsd_sigtramp_p): Likewise. * arch-utils.c (simple_displaced_step_copy_insn): Likewise. (initialize_current_architecture): Likewise. * arm-linux-tdep.c (arm_stap_parse_special_token): Likewise. * arm-symbian-tdep.c (arm_symbian_osabi_sniffer): Likewise. * arm-tdep.c (arm_exidx_new_objfile): Likewise. (arm_push_dummy_call): Likewise. (extend_buffer_earlier): Likewise. (arm_adjust_breakpoint_address): Likewise. (arm_skip_stub): Likewise. * auto-load.c (filename_is_in_pattern): Likewise. (maybe_add_script_file): Likewise. (maybe_add_script_text): Likewise. (auto_load_objfile_script_1): Likewise. * auxv.c (ld_so_xfer_auxv): Likewise. * ax-general.c (new_agent_expr): Likewise. (grow_expr): Likewise. (ax_reg_mask): Likewise. * bcache.c (bcache_full): Likewise. * breakpoint.c (program_breakpoint_here_p): Likewise. * btrace.c (parse_xml_raw): Likewise. * build-id.c (build_id_to_debug_bfd): Likewise. * buildsym.c (end_symtab_with_blockvector): Likewise. * c-exp.y (string_exp): Likewise. (qualified_name): Likewise. (write_destructor_name): Likewise. (operator_stoken): Likewise. (parse_number): Likewise. (scan_macro_expansion): Likewise. (yylex): Likewise. (c_print_token): Likewise. * c-lang.c (c_get_string): Likewise. (emit_numeric_character): Likewise. * charset.c (wchar_iterate): Likewise. * cli/cli-cmds.c (complete_command): Likewise. (make_command): Likewise. * cli/cli-dump.c (restore_section_callback): Likewise. (restore_binary_file): Likewise. * cli/cli-interp.c (cli_interpreter_exec): Likewise. * cli/cli-script.c (execute_control_command): Likewise. * cli/cli-setshow.c (do_set_command): Likewise. * coff-pe-read.c (add_pe_forwarded_sym): Likewise. (read_pe_exported_syms): Likewise. * coffread.c (coff_read_struct_type): Likewise. (coff_read_enum_type): Likewise. * common/btrace-common.c (btrace_data_append): Likewise. * common/buffer.c (buffer_grow): Likewise. * common/filestuff.c (gdb_fopen_cloexec): Likewise. * common/format.c (parse_format_string): Likewise. * common/gdb_vecs.c (delim_string_to_char_ptr_vec_append): Likewise. * common/xml-utils.c (xml_escape_text): Likewise. * compile/compile-object-load.c (copy_sections): Likewise. (compile_object_load): Likewise. * compile/compile-object-run.c (compile_object_run): Likewise. * completer.c (filename_completer): Likewise. * corefile.c (read_memory_typed_address): Likewise. (write_memory_unsigned_integer): Likewise. (write_memory_signed_integer): Likewise. (complete_set_gnutarget): Likewise. * corelow.c (get_core_register_section): Likewise. * cp-name-parser.y (d_grab): Likewise. (allocate_info): Likewise. (cp_new_demangle_parse_info): Likewise. * cp-namespace.c (cp_scan_for_anonymous_namespaces): Likewise. (cp_lookup_symbol_in_namespace): Likewise. (lookup_namespace_scope): Likewise. (find_symbol_in_baseclass): Likewise. (cp_lookup_nested_symbol): Likewise. (cp_lookup_transparent_type_loop): Likewise. * cp-support.c (copy_string_to_obstack): Likewise. (make_symbol_overload_list): Likewise. (make_symbol_overload_list_namespace): Likewise. (make_symbol_overload_list_adl_namespace): Likewise. (first_component_command): Likewise. * cp-valprint.c (cp_print_value): Likewise. * ctf.c (ctf_xfer_partial): Likewise. * d-exp.y (StringExp): Likewise. * d-namespace.c (d_lookup_symbol_in_module): Likewise. (lookup_module_scope): Likewise. (find_symbol_in_baseclass): Likewise. (d_lookup_nested_symbol): Likewise. * dbxread.c (find_stab_function_addr): Likewise. (read_dbx_symtab): Likewise. (dbx_end_psymtab): Likewise. (cp_set_block_scope): Likewise. * dcache.c (dcache_alloc): Likewise. * demangle.c (_initialize_demangler): Likewise. * dicos-tdep.c (dicos_load_module_p): Likewise. * dictionary.c (dict_create_hashed_expandable): Likewise. (dict_create_linear_expandable): Likewise. (expand_hashtable): Likewise. (add_symbol_linear_expandable): Likewise. * dwarf2-frame.c (add_cie): Likewise. (add_fde): Likewise. (dwarf2_build_frame_info): Likewise. * dwarf2expr.c (dwarf_expr_grow_stack): Likewise. (dwarf_expr_fetch_address): Likewise. (add_piece): Likewise. (execute_stack_op): Likewise. * dwarf2loc.c (chain_candidate): Likewise. (dwarf_entry_parameter_to_value): Likewise. (read_pieced_value): Likewise. (write_pieced_value): Likewise. * dwarf2read.c (dwarf2_read_section): Likewise. (add_type_unit): Likewise. (read_comp_units_from_section): Likewise. (fixup_go_packaging): Likewise. (dwarf2_compute_name): Likewise. (dwarf2_physname): Likewise. (create_dwo_unit_in_dwp_v1): Likewise. (create_dwo_unit_in_dwp_v2): Likewise. (read_func_scope): Likewise. (read_call_site_scope): Likewise. (dwarf2_attach_fields_to_type): Likewise. (process_structure_scope): Likewise. (mark_common_block_symbol_computed): Likewise. (read_common_block): Likewise. (abbrev_table_read_table): Likewise. (guess_partial_die_structure_name): Likewise. (fixup_partial_die): Likewise. (add_file_name): Likewise. (dwarf2_const_value_data): Likewise. (dwarf2_const_value_attr): Likewise. (build_error_marker_type): Likewise. (guess_full_die_structure_name): Likewise. (anonymous_struct_prefix): Likewise. (typename_concat): Likewise. (dwarf2_canonicalize_name): Likewise. (dwarf2_name): Likewise. (write_constant_as_bytes): Likewise. (dwarf2_fetch_constant_bytes): Likewise. (copy_string): Likewise. (parse_macro_definition): Likewise. * elfread.c (elf_symfile_segments): Likewise. (elf_rel_plt_read): Likewise. (elf_gnu_ifunc_resolve_by_cache): Likewise. (elf_gnu_ifunc_resolve_by_got): Likewise. (elf_read_minimal_symbols): Likewise. (elf_gnu_ifunc_record_cache): Likewise. * event-top.c (top_level_prompt): Likewise. (command_line_handler): Likewise. * exec.c (resize_section_table): Likewise. * expprint.c (print_subexp_standard): Likewise. * fbsd-tdep.c (fbsd_collect_regset_section_cb): Likewise. * findcmd.c (parse_find_args): Likewise. * findvar.c (address_from_register): Likewise. * frame.c (get_prev_frame_always): Likewise. * gdb_bfd.c (gdb_bfd_ref): Likewise. (get_section_descriptor): Likewise. * gdb_obstack.c (obconcat): Likewise. (obstack_strdup): Likewise. * gdbtypes.c (lookup_function_type_with_arguments): Likewise. (create_set_type): Likewise. (lookup_unsigned_typename): Likewise. (lookup_signed_typename): Likewise. (resolve_dynamic_union): Likewise. (resolve_dynamic_struct): Likewise. (add_dyn_prop): Likewise. (copy_dynamic_prop_list): Likewise. (arch_flags_type): Likewise. (append_composite_type_field_raw): Likewise. * gdbtypes.h (INIT_FUNC_SPECIFIC): Likewise. * gnu-v3-abi.c (gnuv3_rtti_type): Likewise. * go-exp.y (string_exp): Likewise. * go-lang.c (go_demangle): Likewise. * guile/guile.c (compute_scheme_string): Likewise. * guile/scm-cmd.c (gdbscm_parse_command_name): Likewise. (gdbscm_canonicalize_command_name): Likewise. * guile/scm-ports.c (ioscm_init_stdio_buffers): Likewise. (ioscm_init_memory_port): Likewise. (ioscm_reinit_memory_port): Likewise. * guile/scm-utils.c (gdbscm_gc_xstrdup): Likewise. (gdbscm_gc_dup_argv): Likewise. * h8300-tdep.c (h8300_push_dummy_call): Likewise. * hppa-tdep.c (internalize_unwinds): Likewise. (read_unwind_info): Likewise. * i386-cygwin-tdep.c (core_process_module_section): Likewise. (windows_core_xfer_shared_libraries): Likewise. * i386-tdep.c (i386_displaced_step_copy_insn): Likewise. (i386_stap_parse_special_token_triplet): Likewise. (i386_stap_parse_special_token_three_arg_disp): Likewise. * i386obsd-tdep.c (i386obsd_sigtramp_p): Likewise. * inf-child.c (inf_child_fileio_readlink): Likewise. * inf-ptrace.c (inf_ptrace_fetch_register): Likewise. (inf_ptrace_store_register): Likewise. * infrun.c (follow_exec): Likewise. (displaced_step_prepare_throw): Likewise. (save_stop_context): Likewise. (save_infcall_suspend_state): Likewise. * jit.c (jit_read_descriptor): Likewise. (jit_read_code_entry): Likewise. (jit_symtab_line_mapping_add_impl): Likewise. (finalize_symtab): Likewise. (jit_unwind_reg_get_impl): Likewise. * jv-exp.y (QualifiedName): Likewise. * jv-lang.c (get_java_utf8_name): Likewise. (type_from_class): Likewise. (java_demangle_type_signature): Likewise. (java_class_name_from_physname): Likewise. * jv-typeprint.c (java_type_print_base): Likewise. * jv-valprint.c (java_value_print): Likewise. * language.c (add_language): Likewise. * linespec.c (add_sal_to_sals_basic): Likewise. (add_sal_to_sals): Likewise. (decode_objc): Likewise. (find_linespec_symbols): Likewise. * linux-fork.c (fork_save_infrun_state): Likewise. * linux-nat.c (linux_nat_detach): Likewise. (linux_nat_fileio_readlink): Likewise. * linux-record.c (record_linux_sockaddr): Likewise. (record_linux_msghdr): Likewise. (Do): Likewise. * linux-tdep.c (linux_core_info_proc_mappings): Likewise. (linux_collect_regset_section_cb): Likewise. (linux_get_siginfo_data): Likewise. * linux-thread-db.c (try_thread_db_load_from_pdir_1): Likewise. (try_thread_db_load_from_dir): Likewise. (thread_db_load_search): Likewise. (info_auto_load_libthread_db): Likewise. * m32c-tdep.c (m32c_m16c_address_to_pointer): Likewise. (m32c_m16c_pointer_to_address): Likewise. * m68hc11-tdep.c (m68hc11_pseudo_register_write): Likewise. * m68k-tdep.c (m68k_get_longjmp_target): Likewise. * machoread.c (macho_check_dsym): Likewise. * macroexp.c (resize_buffer): Likewise. (gather_arguments): Likewise. (maybe_expand): Likewise. * macrotab.c (new_macro_key): Likewise. (new_source_file): Likewise. (new_macro_definition): Likewise. * mdebugread.c (parse_symbol): Likewise. (parse_type): Likewise. (parse_partial_symbols): Likewise. (psymtab_to_symtab_1): Likewise. * mem-break.c (default_memory_insert_breakpoint): Likewise. * mi/mi-cmd-break.c (mi_argv_to_format): Likewise. * mi/mi-main.c (mi_cmd_data_read_memory): Likewise. (mi_cmd_data_read_memory_bytes): Likewise. (mi_cmd_data_write_memory_bytes): Likewise. (mi_cmd_trace_frame_collected): Likewise. * mi/mi-parse.c (mi_parse_argv): Likewise. (mi_parse): Likewise. * minidebug.c (lzma_open): Likewise. (lzma_pread): Likewise. * mips-tdep.c (mips_read_fp_register_single): Likewise. (mips_print_fp_register): Likewise. * mipsnbsd-tdep.c (mipsnbsd_get_longjmp_target): Likewise. * mipsread.c (read_alphacoff_dynamic_symtab): Likewise. * mt-tdep.c (mt_register_name): Likewise. (mt_registers_info): Likewise. (mt_push_dummy_call): Likewise. * namespace.c (add_using_directive): Likewise. * nat/linux-btrace.c (perf_event_read): Likewise. (linux_enable_bts): Likewise. * nat/linux-osdata.c (linux_common_core_of_thread): Likewise. * nat/linux-ptrace.c (linux_ptrace_test_ret_to_nx): Likewise. * nto-tdep.c (nto_find_and_open_solib): Likewise. (nto_parse_redirection): Likewise. * objc-lang.c (objc_demangle): Likewise. (find_methods): Likewise. * objfiles.c (get_objfile_bfd_data): Likewise. (set_objfile_main_name): Likewise. (allocate_objfile): Likewise. (objfile_relocate): Likewise. (update_section_map): Likewise. * osabi.c (generic_elf_osabi_sniff_abi_tag_sections): Likewise. * p-exp.y (exp): Likewise. (yylex): Likewise. * p-valprint.c (pascal_object_print_value): Likewise. * parse.c (initialize_expout): Likewise. (mark_completion_tag): Likewise. (copy_name): Likewise. (parse_float): Likewise. (type_stack_reserve): Likewise. * ppc-linux-tdep.c (ppc_stap_parse_special_token): Likewise. (ppu2spu_prev_register): Likewise. * ppc-ravenscar-thread.c (supply_register_at_address): Likewise. * printcmd.c (printf_wide_c_string): Likewise. (printf_pointer): Likewise. * probe.c (parse_probes): Likewise. * python/py-cmd.c (gdbpy_parse_command_name): Likewise. (cmdpy_init): Likewise. * python/py-gdb-readline.c (gdbpy_readline_wrapper): Likewise. * python/py-symtab.c (set_sal): Likewise. * python/py-unwind.c (pyuw_sniffer): Likewise. * python/python.c (python_interactive_command): Likewise. (compute_python_string): Likewise. * ravenscar-thread.c (get_running_thread_id): Likewise. * record-full.c (record_full_exec_insn): Likewise. (record_full_core_open_1): Likewise. * regcache.c (regcache_raw_read_signed): Likewise. (regcache_raw_read_unsigned): Likewise. (regcache_cooked_read_signed): Likewise. (regcache_cooked_read_unsigned): Likewise. * remote-fileio.c (remote_fileio_func_open): Likewise. (remote_fileio_func_rename): Likewise. (remote_fileio_func_unlink): Likewise. (remote_fileio_func_stat): Likewise. (remote_fileio_func_system): Likewise. * remote-mips.c (mips_xfer_memory): Likewise. (mips_load_srec): Likewise. (pmon_end_download): Likewise. * remote.c (new_remote_state): Likewise. (map_regcache_remote_table): Likewise. (remote_register_number_and_offset): Likewise. (init_remote_state): Likewise. (get_memory_packet_size): Likewise. (remote_pass_signals): Likewise. (remote_program_signals): Likewise. (remote_start_remote): Likewise. (remote_check_symbols): Likewise. (remote_query_supported): Likewise. (extended_remote_attach): Likewise. (process_g_packet): Likewise. (store_registers_using_G): Likewise. (putpkt_binary): Likewise. (read_frame): Likewise. (compare_sections_command): Likewise. (remote_hostio_pread): Likewise. (remote_hostio_readlink): Likewise. (remote_file_put): Likewise. (remote_file_get): Likewise. (remote_pid_to_exec_file): Likewise. (_initialize_remote): Likewise. * rs6000-aix-tdep.c (rs6000_aix_ld_info_to_xml): Likewise. (rs6000_aix_core_xfer_shared_libraries_aix): Likewise. * rs6000-tdep.c (ppc_displaced_step_copy_insn): Likewise. (bfd_uses_spe_extensions): Likewise. * s390-linux-tdep.c (s390_displaced_step_copy_insn): Likewise. * score-tdep.c (score7_malloc_and_get_memblock): Likewise. * solib-dsbt.c (decode_loadmap): Likewise. (fetch_loadmap): Likewise. (scan_dyntag): Likewise. (enable_break): Likewise. (dsbt_relocate_main_executable): Likewise. * solib-frv.c (fetch_loadmap): Likewise. (enable_break2): Likewise. (frv_relocate_main_executable): Likewise. * solib-spu.c (spu_relocate_main_executable): Likewise. (spu_bfd_open): Likewise. * solib-svr4.c (lm_info_read): Likewise. (read_program_header): Likewise. (find_program_interpreter): Likewise. (scan_dyntag): Likewise. (elf_locate_base): Likewise. (open_symbol_file_object): Likewise. (read_program_headers_from_bfd): Likewise. (svr4_relocate_main_executable): Likewise. * solib-target.c (solib_target_relocate_section_addresses): Likewise. * solib.c (solib_find_1): Likewise. (exec_file_find): Likewise. (solib_find): Likewise. * source.c (openp): Likewise. (print_source_lines_base): Likewise. (forward_search_command): Likewise. * sparc-ravenscar-thread.c (supply_register_at_address): Likewise. * spu-tdep.c (spu2ppu_prev_register): Likewise. (spu_get_overlay_table): Likewise. * stabsread.c (patch_block_stabs): Likewise. (define_symbol): Likewise. (again:): Likewise. (read_member_functions): Likewise. (read_one_struct_field): Likewise. (read_enum_type): Likewise. (common_block_start): Likewise. * stack.c (read_frame_arg): Likewise. (backtrace_command): Likewise. * stap-probe.c (stap_parse_register_operand): Likewise. * symfile.c (syms_from_objfile_1): Likewise. (find_separate_debug_file): Likewise. (load_command): Likewise. (load_progress): Likewise. (load_section_callback): Likewise. (reread_symbols): Likewise. (add_filename_language): Likewise. (allocate_compunit_symtab): Likewise. (read_target_long_array): Likewise. (simple_read_overlay_table): Likewise. * symtab.c (symbol_set_names): Likewise. (resize_symbol_cache): Likewise. (rbreak_command): Likewise. (completion_list_add_name): Likewise. (completion_list_objc_symbol): Likewise. (add_filename_to_list): Likewise. * target-descriptions.c (maint_print_c_tdesc_cmd): Likewise. * target-memory.c (target_write_memory_blocks): Likewise. * target.c (target_read_string): Likewise. (read_whatever_is_readable): Likewise. (target_read_alloc_1): Likewise. (simple_search_memory): Likewise. (target_fileio_read_alloc_1): Likewise. * tilegx-tdep.c (tilegx_push_dummy_call): Likewise. * top.c (command_line_input): Likewise. * tracefile-tfile.c (tfile_fetch_registers): Likewise. * tracefile.c (tracefile_fetch_registers): Likewise. * tracepoint.c (add_memrange): Likewise. (init_collection_list): Likewise. (add_aexpr): Likewise. (trace_dump_actions): Likewise. (parse_trace_status): Likewise. (parse_tracepoint_definition): Likewise. (parse_tsv_definition): Likewise. (parse_static_tracepoint_marker_definition): Likewise. * tui/tui-file.c (tui_sfileopen): Likewise. (tui_file_adjust_strbuf): Likewise. * tui/tui-io.c (tui_expand_tabs): Likewise. * tui/tui-source.c (tui_set_source_content): Likewise. * typeprint.c (find_global_typedef): Likewise. * ui-file.c (do_ui_file_xstrdup): Likewise. (ui_file_obsavestring): Likewise. (mem_file_write): Likewise. * utils.c (make_hex_string): Likewise. (get_regcomp_error): Likewise. (puts_filtered_tabular): Likewise. (gdb_realpath_keepfile): Likewise. (ldirname): Likewise. (gdb_bfd_errmsg): Likewise. (substitute_path_component): Likewise. * valops.c (search_struct_method): Likewise. (find_oload_champ_namespace_loop): Likewise. * valprint.c (print_decimal_chars): Likewise. (read_string): Likewise. (generic_emit_char): Likewise. * varobj.c (varobj_delete): Likewise. (varobj_value_get_print_value): Likewise. * vaxobsd-tdep.c (vaxobsd_sigtramp_sniffer): Likewise. * windows-tdep.c (display_one_tib): Likewise. * xcoffread.c (read_xcoff_symtab): Likewise. (process_xcoff_symbol): Likewise. (swap_sym): Likewise. (scan_xcoff_symtab): Likewise. (xcoff_initial_scan): Likewise. * xml-support.c (gdb_xml_end_element): Likewise. (xml_process_xincludes): Likewise. (xml_fetch_content_from_file): Likewise. * xml-syscall.c (xml_list_of_syscalls): Likewise. * xstormy16-tdep.c (xstormy16_push_dummy_call): Likewise. gdb/gdbserver/ChangeLog: * ax.c (gdb_parse_agent_expr): Add cast to allocation result assignment. (gdb_unparse_agent_expr): Likewise. * hostio.c (require_data): Likewise. (handle_pread): Likewise. * linux-low.c (disable_regset): Likewise. (fetch_register): Likewise. (store_register): Likewise. (get_dynamic): Likewise. (linux_qxfer_libraries_svr4): Likewise. * mem-break.c (delete_fast_tracepoint_jump): Likewise. (set_fast_tracepoint_jump): Likewise. (uninsert_fast_tracepoint_jumps_at): Likewise. (reinsert_fast_tracepoint_jumps_at): Likewise. (validate_inserted_breakpoint): Likewise. (clone_agent_expr): Likewise. * regcache.c (init_register_cache): Likewise. * remote-utils.c (putpkt_binary_1): Likewise. (decode_M_packet): Likewise. (decode_X_packet): Likewise. (look_up_one_symbol): Likewise. (relocate_instruction): Likewise. (monitor_output): Likewise. * server.c (handle_search_memory): Likewise. (handle_qxfer_exec_file): Likewise. (handle_qxfer_libraries): Likewise. (handle_qxfer): Likewise. (handle_query): Likewise. (handle_v_cont): Likewise. (handle_v_run): Likewise. (captured_main): Likewise. * target.c (write_inferior_memory): Likewise. * thread-db.c (try_thread_db_load_from_dir): Likewise. * tracepoint.c (init_trace_buffer): Likewise. (add_tracepoint_action): Likewise. (add_traceframe): Likewise. (add_traceframe_block): Likewise. (cmd_qtdpsrc): Likewise. (cmd_qtdv): Likewise. (cmd_qtstatus): Likewise. (response_source): Likewise. (response_tsv): Likewise. (cmd_qtnotes): Likewise. (gdb_collect): Likewise. (initialize_tracepoint): Likewise.
609 lines
16 KiB
C
609 lines
16 KiB
C
/* Functions for manipulating expressions designed to be executed on the agent
|
||
Copyright (C) 1998-2015 Free Software Foundation, Inc.
|
||
|
||
This file is part of GDB.
|
||
|
||
This program is free software; you can redistribute it and/or modify
|
||
it under the terms of the GNU General Public License as published by
|
||
the Free Software Foundation; either version 3 of the License, or
|
||
(at your option) any later version.
|
||
|
||
This program is distributed in the hope that it will be useful,
|
||
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||
GNU General Public License for more details.
|
||
|
||
You should have received a copy of the GNU General Public License
|
||
along with this program. If not, see <http://www.gnu.org/licenses/>. */
|
||
|
||
/* Despite what the above comment says about this file being part of
|
||
GDB, we would like to keep these functions free of GDB
|
||
dependencies, since we want to be able to use them in contexts
|
||
outside of GDB (test suites, the stub, etc.) */
|
||
|
||
#include "defs.h"
|
||
#include "ax.h"
|
||
|
||
#include "value.h"
|
||
#include "user-regs.h"
|
||
|
||
static void grow_expr (struct agent_expr *x, int n);
|
||
|
||
static void append_const (struct agent_expr *x, LONGEST val, int n);
|
||
|
||
static LONGEST read_const (struct agent_expr *x, int o, int n);
|
||
|
||
static void generic_ext (struct agent_expr *x, enum agent_op op, int n);
|
||
|
||
/* Functions for building expressions. */
|
||
|
||
/* Allocate a new, empty agent expression. */
|
||
struct agent_expr *
|
||
new_agent_expr (struct gdbarch *gdbarch, CORE_ADDR scope)
|
||
{
|
||
struct agent_expr *x = XNEW (struct agent_expr);
|
||
|
||
x->len = 0;
|
||
x->size = 1; /* Change this to a larger value once
|
||
reallocation code is tested. */
|
||
x->buf = (unsigned char *) xmalloc (x->size);
|
||
|
||
x->gdbarch = gdbarch;
|
||
x->scope = scope;
|
||
|
||
/* Bit vector for registers used. */
|
||
x->reg_mask_len = 1;
|
||
x->reg_mask = XCNEWVEC (unsigned char, x->reg_mask_len);
|
||
|
||
x->tracing = 0;
|
||
x->trace_string = 0;
|
||
|
||
return x;
|
||
}
|
||
|
||
/* Free a agent expression. */
|
||
void
|
||
free_agent_expr (struct agent_expr *x)
|
||
{
|
||
xfree (x->buf);
|
||
xfree (x->reg_mask);
|
||
xfree (x);
|
||
}
|
||
|
||
static void
|
||
do_free_agent_expr_cleanup (void *x)
|
||
{
|
||
free_agent_expr (x);
|
||
}
|
||
|
||
struct cleanup *
|
||
make_cleanup_free_agent_expr (struct agent_expr *x)
|
||
{
|
||
return make_cleanup (do_free_agent_expr_cleanup, x);
|
||
}
|
||
|
||
|
||
/* Make sure that X has room for at least N more bytes. This doesn't
|
||
affect the length, just the allocated size. */
|
||
static void
|
||
grow_expr (struct agent_expr *x, int n)
|
||
{
|
||
if (x->len + n > x->size)
|
||
{
|
||
x->size *= 2;
|
||
if (x->size < x->len + n)
|
||
x->size = x->len + n + 10;
|
||
x->buf = (unsigned char *) xrealloc (x->buf, x->size);
|
||
}
|
||
}
|
||
|
||
|
||
/* Append the low N bytes of VAL as an N-byte integer to the
|
||
expression X, in big-endian order. */
|
||
static void
|
||
append_const (struct agent_expr *x, LONGEST val, int n)
|
||
{
|
||
int i;
|
||
|
||
grow_expr (x, n);
|
||
for (i = n - 1; i >= 0; i--)
|
||
{
|
||
x->buf[x->len + i] = val & 0xff;
|
||
val >>= 8;
|
||
}
|
||
x->len += n;
|
||
}
|
||
|
||
|
||
/* Extract an N-byte big-endian unsigned integer from expression X at
|
||
offset O. */
|
||
static LONGEST
|
||
read_const (struct agent_expr *x, int o, int n)
|
||
{
|
||
int i;
|
||
LONGEST accum = 0;
|
||
|
||
/* Make sure we're not reading off the end of the expression. */
|
||
if (o + n > x->len)
|
||
error (_("GDB bug: ax-general.c (read_const): incomplete constant"));
|
||
|
||
for (i = 0; i < n; i++)
|
||
accum = (accum << 8) | x->buf[o + i];
|
||
|
||
return accum;
|
||
}
|
||
|
||
|
||
/* Append a simple operator OP to EXPR. */
|
||
void
|
||
ax_simple (struct agent_expr *x, enum agent_op op)
|
||
{
|
||
grow_expr (x, 1);
|
||
x->buf[x->len++] = op;
|
||
}
|
||
|
||
/* Append a pick operator to EXPR. DEPTH is the stack item to pick,
|
||
with 0 being top of stack. */
|
||
|
||
void
|
||
ax_pick (struct agent_expr *x, int depth)
|
||
{
|
||
if (depth < 0 || depth > 255)
|
||
error (_("GDB bug: ax-general.c (ax_pick): stack depth out of range"));
|
||
ax_simple (x, aop_pick);
|
||
append_const (x, 1, depth);
|
||
}
|
||
|
||
|
||
/* Append a sign-extension or zero-extension instruction to EXPR, to
|
||
extend an N-bit value. */
|
||
static void
|
||
generic_ext (struct agent_expr *x, enum agent_op op, int n)
|
||
{
|
||
/* N must fit in a byte. */
|
||
if (n < 0 || n > 255)
|
||
error (_("GDB bug: ax-general.c (generic_ext): bit count out of range"));
|
||
/* That had better be enough range. */
|
||
if (sizeof (LONGEST) * 8 > 255)
|
||
error (_("GDB bug: ax-general.c (generic_ext): "
|
||
"opcode has inadequate range"));
|
||
|
||
grow_expr (x, 2);
|
||
x->buf[x->len++] = op;
|
||
x->buf[x->len++] = n;
|
||
}
|
||
|
||
|
||
/* Append a sign-extension instruction to EXPR, to extend an N-bit value. */
|
||
void
|
||
ax_ext (struct agent_expr *x, int n)
|
||
{
|
||
generic_ext (x, aop_ext, n);
|
||
}
|
||
|
||
|
||
/* Append a zero-extension instruction to EXPR, to extend an N-bit value. */
|
||
void
|
||
ax_zero_ext (struct agent_expr *x, int n)
|
||
{
|
||
generic_ext (x, aop_zero_ext, n);
|
||
}
|
||
|
||
|
||
/* Append a trace_quick instruction to EXPR, to record N bytes. */
|
||
void
|
||
ax_trace_quick (struct agent_expr *x, int n)
|
||
{
|
||
/* N must fit in a byte. */
|
||
if (n < 0 || n > 255)
|
||
error (_("GDB bug: ax-general.c (ax_trace_quick): "
|
||
"size out of range for trace_quick"));
|
||
|
||
grow_expr (x, 2);
|
||
x->buf[x->len++] = aop_trace_quick;
|
||
x->buf[x->len++] = n;
|
||
}
|
||
|
||
|
||
/* Append a goto op to EXPR. OP is the actual op (must be aop_goto or
|
||
aop_if_goto). We assume we don't know the target offset yet,
|
||
because it's probably a forward branch, so we leave space in EXPR
|
||
for the target, and return the offset in EXPR of that space, so we
|
||
can backpatch it once we do know the target offset. Use ax_label
|
||
to do the backpatching. */
|
||
int
|
||
ax_goto (struct agent_expr *x, enum agent_op op)
|
||
{
|
||
grow_expr (x, 3);
|
||
x->buf[x->len + 0] = op;
|
||
x->buf[x->len + 1] = 0xff;
|
||
x->buf[x->len + 2] = 0xff;
|
||
x->len += 3;
|
||
return x->len - 2;
|
||
}
|
||
|
||
/* Suppose a given call to ax_goto returns some value PATCH. When you
|
||
know the offset TARGET that goto should jump to, call
|
||
ax_label (EXPR, PATCH, TARGET)
|
||
to patch TARGET into the ax_goto instruction. */
|
||
void
|
||
ax_label (struct agent_expr *x, int patch, int target)
|
||
{
|
||
/* Make sure the value is in range. Don't accept 0xffff as an
|
||
offset; that's our magic sentinel value for unpatched branches. */
|
||
if (target < 0 || target >= 0xffff)
|
||
error (_("GDB bug: ax-general.c (ax_label): label target out of range"));
|
||
|
||
x->buf[patch] = (target >> 8) & 0xff;
|
||
x->buf[patch + 1] = target & 0xff;
|
||
}
|
||
|
||
|
||
/* Assemble code to push a constant on the stack. */
|
||
void
|
||
ax_const_l (struct agent_expr *x, LONGEST l)
|
||
{
|
||
static enum agent_op ops[]
|
||
=
|
||
{aop_const8, aop_const16, aop_const32, aop_const64};
|
||
int size;
|
||
int op;
|
||
|
||
/* How big is the number? 'op' keeps track of which opcode to use.
|
||
Notice that we don't really care whether the original number was
|
||
signed or unsigned; we always reproduce the value exactly, and
|
||
use the shortest representation. */
|
||
for (op = 0, size = 8; size < 64; size *= 2, op++)
|
||
{
|
||
LONGEST lim = ((LONGEST) 1) << (size - 1);
|
||
|
||
if (-lim <= l && l <= lim - 1)
|
||
break;
|
||
}
|
||
|
||
/* Emit the right opcode... */
|
||
ax_simple (x, ops[op]);
|
||
|
||
/* Emit the low SIZE bytes as an unsigned number. We know that
|
||
sign-extending this will yield l. */
|
||
append_const (x, l, size / 8);
|
||
|
||
/* Now, if it was negative, and not full-sized, sign-extend it. */
|
||
if (l < 0 && size < 64)
|
||
ax_ext (x, size);
|
||
}
|
||
|
||
|
||
void
|
||
ax_const_d (struct agent_expr *x, LONGEST d)
|
||
{
|
||
/* FIXME: floating-point support not present yet. */
|
||
error (_("GDB bug: ax-general.c (ax_const_d): "
|
||
"floating point not supported yet"));
|
||
}
|
||
|
||
|
||
/* Assemble code to push the value of register number REG on the
|
||
stack. */
|
||
void
|
||
ax_reg (struct agent_expr *x, int reg)
|
||
{
|
||
if (reg >= gdbarch_num_regs (x->gdbarch))
|
||
{
|
||
/* This is a pseudo-register. */
|
||
if (!gdbarch_ax_pseudo_register_push_stack_p (x->gdbarch))
|
||
error (_("'%s' is a pseudo-register; "
|
||
"GDB cannot yet trace its contents."),
|
||
user_reg_map_regnum_to_name (x->gdbarch, reg));
|
||
if (gdbarch_ax_pseudo_register_push_stack (x->gdbarch, x, reg))
|
||
error (_("Trace '%s' failed."),
|
||
user_reg_map_regnum_to_name (x->gdbarch, reg));
|
||
}
|
||
else
|
||
{
|
||
/* Make sure the register number is in range. */
|
||
if (reg < 0 || reg > 0xffff)
|
||
error (_("GDB bug: ax-general.c (ax_reg): "
|
||
"register number out of range"));
|
||
grow_expr (x, 3);
|
||
x->buf[x->len] = aop_reg;
|
||
x->buf[x->len + 1] = (reg >> 8) & 0xff;
|
||
x->buf[x->len + 2] = (reg) & 0xff;
|
||
x->len += 3;
|
||
}
|
||
}
|
||
|
||
/* Assemble code to operate on a trace state variable. */
|
||
|
||
void
|
||
ax_tsv (struct agent_expr *x, enum agent_op op, int num)
|
||
{
|
||
/* Make sure the tsv number is in range. */
|
||
if (num < 0 || num > 0xffff)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("ax-general.c (ax_tsv): variable "
|
||
"number is %d, out of range"), num);
|
||
|
||
grow_expr (x, 3);
|
||
x->buf[x->len] = op;
|
||
x->buf[x->len + 1] = (num >> 8) & 0xff;
|
||
x->buf[x->len + 2] = (num) & 0xff;
|
||
x->len += 3;
|
||
}
|
||
|
||
/* Append a string to the expression. Note that the string is going
|
||
into the bytecodes directly, not on the stack. As a precaution,
|
||
include both length as prefix, and terminate with a NUL. (The NUL
|
||
is counted in the length.) */
|
||
|
||
void
|
||
ax_string (struct agent_expr *x, const char *str, int slen)
|
||
{
|
||
int i;
|
||
|
||
/* Make sure the string length is reasonable. */
|
||
if (slen < 0 || slen > 0xffff)
|
||
internal_error (__FILE__, __LINE__,
|
||
_("ax-general.c (ax_string): string "
|
||
"length is %d, out of allowed range"), slen);
|
||
|
||
grow_expr (x, 2 + slen + 1);
|
||
x->buf[x->len++] = ((slen + 1) >> 8) & 0xff;
|
||
x->buf[x->len++] = (slen + 1) & 0xff;
|
||
for (i = 0; i < slen; ++i)
|
||
x->buf[x->len++] = str[i];
|
||
x->buf[x->len++] = '\0';
|
||
}
|
||
|
||
|
||
|
||
/* Functions for disassembling agent expressions, and otherwise
|
||
debugging the expression compiler. */
|
||
|
||
struct aop_map aop_map[] =
|
||
{
|
||
{0, 0, 0, 0, 0}
|
||
#define DEFOP(NAME, SIZE, DATA_SIZE, CONSUMED, PRODUCED, VALUE) \
|
||
, { # NAME, SIZE, DATA_SIZE, CONSUMED, PRODUCED }
|
||
#include "ax.def"
|
||
#undef DEFOP
|
||
};
|
||
|
||
|
||
/* Disassemble the expression EXPR, writing to F. */
|
||
void
|
||
ax_print (struct ui_file *f, struct agent_expr *x)
|
||
{
|
||
int i;
|
||
|
||
fprintf_filtered (f, _("Scope: %s\n"), paddress (x->gdbarch, x->scope));
|
||
fprintf_filtered (f, _("Reg mask:"));
|
||
for (i = 0; i < x->reg_mask_len; ++i)
|
||
fprintf_filtered (f, _(" %02x"), x->reg_mask[i]);
|
||
fprintf_filtered (f, _("\n"));
|
||
|
||
/* Check the size of the name array against the number of entries in
|
||
the enum, to catch additions that people didn't sync. */
|
||
if ((sizeof (aop_map) / sizeof (aop_map[0]))
|
||
!= aop_last)
|
||
error (_("GDB bug: ax-general.c (ax_print): opcode map out of sync"));
|
||
|
||
for (i = 0; i < x->len;)
|
||
{
|
||
enum agent_op op = (enum agent_op) x->buf[i];
|
||
|
||
if (op >= (sizeof (aop_map) / sizeof (aop_map[0]))
|
||
|| !aop_map[op].name)
|
||
{
|
||
fprintf_filtered (f, _("%3d <bad opcode %02x>\n"), i, op);
|
||
i++;
|
||
continue;
|
||
}
|
||
if (i + 1 + aop_map[op].op_size > x->len)
|
||
{
|
||
fprintf_filtered (f, _("%3d <incomplete opcode %s>\n"),
|
||
i, aop_map[op].name);
|
||
break;
|
||
}
|
||
|
||
fprintf_filtered (f, "%3d %s", i, aop_map[op].name);
|
||
if (aop_map[op].op_size > 0)
|
||
{
|
||
fputs_filtered (" ", f);
|
||
|
||
print_longest (f, 'd', 0,
|
||
read_const (x, i + 1, aop_map[op].op_size));
|
||
}
|
||
/* Handle the complicated printf arguments specially. */
|
||
else if (op == aop_printf)
|
||
{
|
||
int slen, nargs;
|
||
|
||
i++;
|
||
nargs = x->buf[i++];
|
||
slen = x->buf[i++];
|
||
slen = slen * 256 + x->buf[i++];
|
||
fprintf_filtered (f, _(" \"%s\", %d args"),
|
||
&(x->buf[i]), nargs);
|
||
i += slen - 1;
|
||
}
|
||
fprintf_filtered (f, "\n");
|
||
i += 1 + aop_map[op].op_size;
|
||
}
|
||
}
|
||
|
||
/* Add register REG to the register mask for expression AX. */
|
||
void
|
||
ax_reg_mask (struct agent_expr *ax, int reg)
|
||
{
|
||
if (reg >= gdbarch_num_regs (ax->gdbarch))
|
||
{
|
||
/* This is a pseudo-register. */
|
||
if (!gdbarch_ax_pseudo_register_collect_p (ax->gdbarch))
|
||
error (_("'%s' is a pseudo-register; "
|
||
"GDB cannot yet trace its contents."),
|
||
user_reg_map_regnum_to_name (ax->gdbarch, reg));
|
||
if (gdbarch_ax_pseudo_register_collect (ax->gdbarch, ax, reg))
|
||
error (_("Trace '%s' failed."),
|
||
user_reg_map_regnum_to_name (ax->gdbarch, reg));
|
||
}
|
||
else
|
||
{
|
||
int byte = reg / 8;
|
||
|
||
/* Grow the bit mask if necessary. */
|
||
if (byte >= ax->reg_mask_len)
|
||
{
|
||
/* It's not appropriate to double here. This isn't a
|
||
string buffer. */
|
||
int new_len = byte + 1;
|
||
unsigned char *new_reg_mask
|
||
= XRESIZEVEC (unsigned char, ax->reg_mask, new_len);
|
||
|
||
memset (new_reg_mask + ax->reg_mask_len, 0,
|
||
(new_len - ax->reg_mask_len) * sizeof (ax->reg_mask[0]));
|
||
ax->reg_mask_len = new_len;
|
||
ax->reg_mask = new_reg_mask;
|
||
}
|
||
|
||
ax->reg_mask[byte] |= 1 << (reg % 8);
|
||
}
|
||
}
|
||
|
||
/* Given an agent expression AX, fill in requirements and other descriptive
|
||
bits. */
|
||
void
|
||
ax_reqs (struct agent_expr *ax)
|
||
{
|
||
int i;
|
||
int height;
|
||
|
||
/* Jump target table. targets[i] is non-zero iff we have found a
|
||
jump to offset i. */
|
||
char *targets = (char *) alloca (ax->len * sizeof (targets[0]));
|
||
|
||
/* Instruction boundary table. boundary[i] is non-zero iff our scan
|
||
has reached an instruction starting at offset i. */
|
||
char *boundary = (char *) alloca (ax->len * sizeof (boundary[0]));
|
||
|
||
/* Stack height record. If either targets[i] or boundary[i] is
|
||
non-zero, heights[i] is the height the stack should have before
|
||
executing the bytecode at that point. */
|
||
int *heights = (int *) alloca (ax->len * sizeof (heights[0]));
|
||
|
||
/* Pointer to a description of the present op. */
|
||
struct aop_map *op;
|
||
|
||
memset (targets, 0, ax->len * sizeof (targets[0]));
|
||
memset (boundary, 0, ax->len * sizeof (boundary[0]));
|
||
|
||
ax->max_height = ax->min_height = height = 0;
|
||
ax->flaw = agent_flaw_none;
|
||
ax->max_data_size = 0;
|
||
|
||
for (i = 0; i < ax->len; i += 1 + op->op_size)
|
||
{
|
||
if (ax->buf[i] > (sizeof (aop_map) / sizeof (aop_map[0])))
|
||
{
|
||
ax->flaw = agent_flaw_bad_instruction;
|
||
return;
|
||
}
|
||
|
||
op = &aop_map[ax->buf[i]];
|
||
|
||
if (!op->name)
|
||
{
|
||
ax->flaw = agent_flaw_bad_instruction;
|
||
return;
|
||
}
|
||
|
||
if (i + 1 + op->op_size > ax->len)
|
||
{
|
||
ax->flaw = agent_flaw_incomplete_instruction;
|
||
return;
|
||
}
|
||
|
||
/* If this instruction is a forward jump target, does the
|
||
current stack height match the stack height at the jump
|
||
source? */
|
||
if (targets[i] && (heights[i] != height))
|
||
{
|
||
ax->flaw = agent_flaw_height_mismatch;
|
||
return;
|
||
}
|
||
|
||
boundary[i] = 1;
|
||
heights[i] = height;
|
||
|
||
height -= op->consumed;
|
||
if (height < ax->min_height)
|
||
ax->min_height = height;
|
||
height += op->produced;
|
||
if (height > ax->max_height)
|
||
ax->max_height = height;
|
||
|
||
if (op->data_size > ax->max_data_size)
|
||
ax->max_data_size = op->data_size;
|
||
|
||
/* For jump instructions, check that the target is a valid
|
||
offset. If it is, record the fact that that location is a
|
||
jump target, and record the height we expect there. */
|
||
if (aop_goto == op - aop_map
|
||
|| aop_if_goto == op - aop_map)
|
||
{
|
||
int target = read_const (ax, i + 1, 2);
|
||
if (target < 0 || target >= ax->len)
|
||
{
|
||
ax->flaw = agent_flaw_bad_jump;
|
||
return;
|
||
}
|
||
|
||
/* Do we have any information about what the stack height
|
||
should be at the target? */
|
||
if (targets[target] || boundary[target])
|
||
{
|
||
if (heights[target] != height)
|
||
{
|
||
ax->flaw = agent_flaw_height_mismatch;
|
||
return;
|
||
}
|
||
}
|
||
|
||
/* Record the target, along with the stack height we expect. */
|
||
targets[target] = 1;
|
||
heights[target] = height;
|
||
}
|
||
|
||
/* For unconditional jumps with a successor, check that the
|
||
successor is a target, and pick up its stack height. */
|
||
if (aop_goto == op - aop_map
|
||
&& i + 3 < ax->len)
|
||
{
|
||
if (!targets[i + 3])
|
||
{
|
||
ax->flaw = agent_flaw_hole;
|
||
return;
|
||
}
|
||
|
||
height = heights[i + 3];
|
||
}
|
||
|
||
/* For reg instructions, record the register in the bit mask. */
|
||
if (aop_reg == op - aop_map)
|
||
{
|
||
int reg = read_const (ax, i + 1, 2);
|
||
|
||
ax_reg_mask (ax, reg);
|
||
}
|
||
}
|
||
|
||
/* Check that all the targets are on boundaries. */
|
||
for (i = 0; i < ax->len; i++)
|
||
if (targets[i] && !boundary[i])
|
||
{
|
||
ax->flaw = agent_flaw_bad_jump;
|
||
return;
|
||
}
|
||
|
||
ax->final_height = height;
|
||
}
|