1ced966e34
gdb/testsuite/ * gdb.arch/i386-dr3-watch.exp: Test that the i386 watchpoints backend doesn't leave used debug registers behind. gdb/gdbserver/ * i386-low.c (i386_insert_aligned_watchpoint): Don't pass the info to the inferior here. (i386_remove_aligned_watchpoint): Ditto. (i386_handle_nonaligned_watchpoint): Return immediate on fail to fit part of the watchpoint in the debug registers. (i386_update_inferior_debug_regs): New. (i386_low_insert_watchpoint): Work on a local mirror of the debug registers, and only update the inferior on success. (i386_low_remove_watchpoint): Ditto. gdb/ * i386-nat.c (I386_DR_VACANT, I386_DR_LOCAL_ENABLE) (I386_DR_GLOBAL_ENABLE, I386_DR_DISABLE, I386_DR_SET_RW_LEN) (I386_DR_GET_RW_LEN, I386_DR_WATCH_HIT): Add state parameter and adjust. (dr_mirror, dr_status_mirror, dr_control_mirror): Delete. (struct i386_debug_reg_state): New. (i386_init_dregs): New. (dr_mirror): New. (i386_cleanup_dregs): Use i386_init_dregs. (i386_show_dr): Add state parameter and adjust. (i386_insert_aligned_watchpoint): Ditto. Don't pass the info to the inferior here. (i386_remove_aligned_watchpoint): Likewise. (i386_handle_nonaligned_watchpoint): Add state parameter and adjust. (i386_update_inferior_debug_regs): New. (i386_insert_watchpoint): Work on a local mirror of the debug registers, and only update the inferior on success. (i386_remove_watchpoint): Ditto. (i386_region_ok_for_watchpoint): Adjust. (i386_stopped_data_address): Adjust. (i386_insert_hw_breakpoint): Adjust. (i386_remove_hw_breakpoint): Adjust.
93 lines
3.4 KiB
Text
93 lines
3.4 KiB
Text
# Copyright 2011 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
# x86 and amd64 gdbserver had a bug where a watchpoint triggered by
|
|
# the DR3 debug register would trip on a bogus assertion.
|
|
|
|
# This test relies on being able to set 4 hardware watchpoints. Since
|
|
# that is not a valid assumption across most targets, and we're
|
|
# testing a x86 specific bug, skip everywhere else.
|
|
if { ![istarget "i?86-*-*"] && ![istarget "x86_64-*-*"] } then {
|
|
return 0
|
|
}
|
|
|
|
set testfile "i386-dr3-watch"
|
|
set srcfile ${testfile}.c
|
|
|
|
if [prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} {debug $additional_flags}] {
|
|
untested "failed to compile ${testfile}"
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] then {
|
|
untested "could not run to main"
|
|
return -1
|
|
}
|
|
|
|
gdb_test_no_output "set breakpoint always-inserted on"
|
|
|
|
# Test that we handle watchpoints in all of DR0-DR3.
|
|
|
|
gdb_test "watch i1" "Hardware watchpoint .*: i1"
|
|
gdb_test "watch i2" "Hardware watchpoint .*: i2"
|
|
gdb_test "watch i3" "Hardware watchpoint .*: i3"
|
|
gdb_test "watch i4" "Hardware watchpoint .*: i4"
|
|
|
|
gdb_test "c" "Hardware watchpoint.*: i1.*" "continue to i1 watchpoint"
|
|
gdb_test "c" "Hardware watchpoint.*: i2.*" "continue to i2 watchpoint"
|
|
gdb_test "c" "Hardware watchpoint.*: i3.*" "continue to i3 watchpoint"
|
|
gdb_test "c" "Hardware watchpoint.*: i4.*" "continue to i4 watchpoint"
|
|
|
|
delete_breakpoints
|
|
|
|
# Regression test for a bug where the i386 watchpoints support backend
|
|
# would leave some debug registers occupied even if not enough debug
|
|
# registers were available to cover a single watchpoint location.
|
|
|
|
gdb_test "watch i1" \
|
|
"Hardware watchpoint .*: i1" \
|
|
"set watchpoint occuping one debug register"
|
|
|
|
# gap1 too long to fit the 3 left over debug registers (but would fit
|
|
# 4 if all were available).
|
|
set test "watchpoint on gap1 does not fit debug registers"
|
|
gdb_test_multiple "watch gap1" "$test" {
|
|
-re "Hardware watchpoint .*: gap1.*Warning:.*Could not insert hardware watchpoint.*You may have requested too many.*" {
|
|
pass $test
|
|
}
|
|
-re "Hardware watchpoint .*: gap1\r\n$gdb_prompt $" {
|
|
pass "$test (target emulates hardware watchpoints)"
|
|
return
|
|
}
|
|
-re "Watchpoint .*: gap1\r\n$gdb_prompt $" {
|
|
pass "$test (gdb figured out itself the watchpoint does not fit)"
|
|
return
|
|
}
|
|
}
|
|
|
|
# Start over.
|
|
gdb_test "delete" \
|
|
"" \
|
|
"delete all watchpoints" \
|
|
"Delete all breakpoints.*$" \
|
|
"y"
|
|
|
|
# If debug registers were left occupied by mistake, we'll fail to set
|
|
# some of these watchpoints. Each watchpoint should fit in one of the
|
|
# 4 debug registers available.
|
|
gdb_test "watch i1" "Hardware watchpoint .*: i1" "watch i1 still fits"
|
|
gdb_test "watch i2" "Hardware watchpoint .*: i2" "watch i2 still fits"
|
|
gdb_test "watch i3" "Hardware watchpoint .*: i3" "watch i3 still fits"
|
|
gdb_test "watch i4" "Hardware watchpoint .*: i4" "watch i4 still fits"
|