049109b007
The current tstatus.exp tests shows PASSes if either the target support or not the optional tstatus bits: PASS: gdb.trace/tstatus.exp: tstatus does not report trace stop reason PASS: gdb.trace/tstatus.exp: tstatus reports trace stop reason The former (and any other similar case) should be UNSUPPORTED rather than PASS. That'd make it much easier to spot actually problems with the test (e.g., the one Yao's previous patch addressed), along with regressions and progressions. The "not supported" paths in tstatus.exp explicitly check for output you'd get if the feature wasn't supported, so real unexpected failures will still be caught as FAILs. So now e.g., where we wanted to check if tstatus reports the trace stop reason, and if the target does support it, we get PASS: tstatus reports trace stop reason if the target actually reports what we'd expect if the trace stop reason isn't supported, we get: UNSUPPORTED: tstatus reports trace stop reason and if the target reports something else unexpected, we get: FAIL: tstatus reports trace stop reason That has the added bonus that the test string is always the same and only the test results change (PASS/FAIL/UNSUPPORTED), which makes it easier for testers see regressions, compared to the previous: -PASS: gdb.trace/tstatus.exp: tstatus reports trace stop reason +PASS: gdb.trace/tstatus.exp: tstatus does not report trace stop reason which clearly easily goes by unnoticed, as evidenced by the existing problem Yao's previous patch addressed. Tested on x86_64 Fedora 17. gdb/testsuite/ 2013-03-06 Pedro Alves <palves@redhat.com> * gdb.trace/tstatus.exp (run_trace_experiment): When the target doesn't support the tested optional feature, call "unsupported" with the same test message as the "pass" case, instead of calling "pass" with a different message. Use the same text for the "fail" cases too.
133 lines
4.3 KiB
Text
133 lines
4.3 KiB
Text
# Copyright 2011-2013 Free Software Foundation, Inc.
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
load_lib "trace-support.exp"
|
|
|
|
standard_testfile actions.c
|
|
set executable $testfile
|
|
set expfile tstatus.exp
|
|
|
|
if [prepare_for_testing $expfile $executable $srcfile \
|
|
[list debug]] {
|
|
untested "failed to prepare for trace tests"
|
|
return -1
|
|
}
|
|
|
|
if ![runto_main] {
|
|
fail "Can't run to main to check for trace support"
|
|
return -1
|
|
}
|
|
|
|
if ![gdb_target_supports_trace] {
|
|
unsupported "target does not support trace"
|
|
return -1
|
|
}
|
|
|
|
proc run_trace_experiment {} {
|
|
global gdb_prompt
|
|
global decimal
|
|
|
|
# gdb_test_no_output "set debug remote 1" ""
|
|
|
|
gdb_test "continue" \
|
|
".*Breakpoint \[0-9\]+, begin .*" \
|
|
"advance to trace begin"
|
|
|
|
gdb_test_no_output "tstart my tracing note" "start trace experiment"
|
|
|
|
gdb_test "continue" \
|
|
".*Breakpoint \[0-9\]+, end .*" \
|
|
"advance through tracing"
|
|
|
|
# Now play with tstatus a bit.
|
|
|
|
# Since support for notes, user, stop reason, etc. is optional, we
|
|
# need to match both with and without cases.
|
|
|
|
set test "tstatus reports trace note"
|
|
gdb_test_multiple "tstatus" $test {
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Trace notes: my tracing note\.\[\r\n\]+Not looking at any trace frame\..*\r\n$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Not looking at any trace frame.*\r\n$gdb_prompt $" {
|
|
unsupported $test
|
|
}
|
|
}
|
|
|
|
gdb_test "set trace-notes different note" "" "change tracing note"
|
|
|
|
set test "tstatus reports different trace note"
|
|
gdb_test_multiple "tstatus" $test {
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Trace notes: different note\.\[\r\n\]+Not looking at any trace frame\..*\r\n$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Not looking at any trace frame.*\r\n$gdb_prompt $" {
|
|
unsupported $test
|
|
}
|
|
}
|
|
|
|
gdb_test "set trace-user me me me" "" "change tracing user"
|
|
|
|
set test "tstatus reports trace user"
|
|
gdb_test_multiple "tstatus" $test {
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Trace user is me me me\.\[\r\n\]+Trace notes: different note\.\[\r\n\]+Not looking at any trace frame\..*\r\n$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "Trace is running.*Trace will stop if GDB disconnects\.\[\r\n\]+Not looking at any trace frame.*\r\n$gdb_prompt $" {
|
|
unsupported $test
|
|
}
|
|
}
|
|
|
|
gdb_test_no_output "tstop because I can" "trace stopped with note"
|
|
|
|
set test "tstatus reports trace stop reason"
|
|
gdb_test_multiple "tstatus" $test {
|
|
-re "Trace stopped by a tstop command \\(because I can\\)\..*Trace will stop if GDB disconnects\.\[\r\n\]+Trace user is me me me\.\[\r\n\]+Trace notes: different note\.\[\r\n\]+Not looking at any trace frame\..*\r\n$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "Trace stopped by a tstop command\..*\r\n$gdb_prompt $" {
|
|
unsupported $test
|
|
}
|
|
}
|
|
|
|
set test "info trace reports tracepoint hit count and traceframe usage"
|
|
gdb_test_multiple "info trace" $test {
|
|
-re "actions\.c:\[0-9\]+\[\r\n\]+\[\t ]+tracepoint already hit 1 time\[\r\n\]+\[\t ]+trace buffer usage ${decimal} bytes\.\[\r\n\]+\[\t ]+collect parm.*\r\n$gdb_prompt $" {
|
|
pass $test
|
|
}
|
|
-re "actions\.c:\[0-9\]+\[\r\n\]+\[\t ]+collect parm.*\r\n$gdb_prompt $" {
|
|
unsupported $test
|
|
}
|
|
}
|
|
}
|
|
|
|
proc test_tracepoints {} {
|
|
global gdb_prompt
|
|
|
|
gdb_test "break begin" ".*" ""
|
|
|
|
gdb_test "break end" ".*" ""
|
|
|
|
gdb_test "trace gdb_c_test" "Tracepoint .*" \
|
|
"tracepoint at gdb_c_test"
|
|
|
|
gdb_trace_setactions "collect at set_point: define actions" \
|
|
"" \
|
|
"collect parm" "^$"
|
|
|
|
run_trace_experiment
|
|
|
|
}
|
|
|
|
test_tracepoints
|