31d913c7e4
BASEDIR was added by https://sourceware.org/ml/gdb-patches/2013-10/msg00587.html in order to handle the different directory layout in serial testing and parallel testing. BASEDIR is "gdb.base" in serial testing and is "outputs/gdb.base/TESTNAME" in parallel testing. However, it doesn't work if the GDBserver is in remote target, like this, $ make check RUNTESTFLAGS='--target_board=remote-gdbserver-on-localhost foll-vfork.exp foll-exec.exp' FAIL: gdb.base/foll-exec.exp: continue to first exec catchpoint (the program exited) FAIL: gdb.base/foll-vfork.exp: exec: vfork and exec child follow, to main bp: continue to bp (the program exited) FAIL: gdb.base/foll-vfork.exp: exec: vfork child follow, finish after tcatch vfork: finish (the program exited) FAIL: gdb.base/foll-vfork.exp: exec: vfork relations in info inferiors: continue to bp (the program exited) these tests fail because the executable can't be found. With target board native-gdbserver, the program is spawned this way, spawn ../gdbserver/gdbserver --once :2347 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/gdb.base/foll-vfork so BASEDIR is correct. However, with target board remote-gdbserver-on-localhost, the program is spawned spawn /usr/bin/ssh -l yao localhost /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/../gdbserver/gdbserver --once :2346 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/gdb.base/foll-vfork so BASEDIR (either "gdb.base" or "outputs/gdb.base/TESTNAME") makes no sense. I had a fix that pass absolute directory to BASEDIR, but it assumes that directory structure is the same on build and target, and it doesn't work in remote host case. The current fix in this patch is to get the directory from argv[0]. In any case, the program to be exec'ed is at the same directory with the main program. Note that these tests do "next N" to let program stop at the desired line, but it is fragile, because GDB for different targets may skip function prologue slightly differently, so I replace some of them by "tbreak on LINE NUMBER and continue". gdb/testsuite: 2016-02-04 Yao Qi <yao.qi@linaro.org> * gdb.base/foll-exec-mode.c: Include limits.h. (main): Add parameters argc and argv. Get directory from argv[0]. * gdb.base/foll-exec-mode.exp: Don't pass -DBASEDIR in compilation. * gdb.base/foll-exec.c: Include limits.h. (main): Add parameters argc and argv. Get directory from argv[0]. * gdb.base/foll-exec.exp: Don't pass -DBASEDIR in compilation. Adjust tests on the number of lines as source code changed. * gdb.base/foll-vfork-exit.c: Include limits.h. (main): Add one line of statement before vfork. * gdb.base/foll-vfork.c: Include limits.h and string.h. (main): Add parameters argc and argv. Get directory from argv[0]. * gdb.base/foll-vfork.exp: Don't pass -DBASEDIR in compilation. (setup_gdb): Set tbreak to skip some source lines. * gdb.multi/bkpt-multi-exec.c: Include limits.h. (main): Add parameters argc and argv. Get directory from argv[0]. * gdb.multi/bkpt-multi-exec.exp: Don't pass -DBASEDIR in compilation. * gdb.multi/multi-arch-exec.c: Include limits.h and string.h. (main): Add parameters argc and argv. Get directory from argv[0]. * gdb.multi/multi-arch-exec.exp: Don't pass -DBASEDIR in compilation.
83 lines
2.2 KiB
Text
83 lines
2.2 KiB
Text
# Copyright 2009-2016 Free Software Foundation, Inc.
|
|
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
if { [is_remote target] || ![isnative] } then {
|
|
continue
|
|
}
|
|
|
|
# Until "catch exec" is implemented on other targets...
|
|
#
|
|
if {![istarget "*-linux*"]} then {
|
|
continue
|
|
}
|
|
|
|
set testfile "bkpt-multi-exec"
|
|
|
|
set exec1 "bkpt-multi-exec"
|
|
set srcfile1 ${exec1}.c
|
|
set binfile1 [standard_output_file ${exec1}]
|
|
|
|
set exec2 "crashme"
|
|
set srcfile2 ${exec2}.c
|
|
set binfile2 [standard_output_file ${exec2}]
|
|
|
|
set compile_options {debug}
|
|
|
|
if { [build_executable ${testfile}.exp ${exec1} "${srcfile1}" $compile_options] == -1 } {
|
|
return -1
|
|
}
|
|
|
|
if { [build_executable ${testfile}.exp ${exec2} "${srcfile2}" $compile_options] == -1 } {
|
|
return -1
|
|
}
|
|
|
|
# Start with a fresh gdb
|
|
|
|
clean_restart ${exec1}
|
|
|
|
# Start the program running, and stop at main.
|
|
#
|
|
if ![runto_main] then {
|
|
perror "Couldn't run ${binfile1}"
|
|
return
|
|
}
|
|
|
|
delete_breakpoints
|
|
|
|
# continuing should exec and trigger the bug
|
|
gdb_test "continue" "SIGSEGV.*"
|
|
|
|
# Start over, but this time, set a breakpoint before the app crashes.
|
|
|
|
clean_restart ${exec1}
|
|
|
|
gdb_test "add-inferior -exec ${binfile2}" \
|
|
"Added inferior 2.*" \
|
|
"add inferior 2 with -exec ${exec2}"
|
|
|
|
set bp_location [gdb_get_line_number "set breakpoint here" ${srcfile2}]
|
|
|
|
gdb_test "inferior 2"
|
|
gdb_test "break ${srcfile2}:${bp_location}" ".*"
|
|
|
|
# Start the program running, and stop at main.
|
|
#
|
|
gdb_test "inferior 1"
|
|
|
|
# Now run to the breakpoint. This should cross the exec, and stop at
|
|
# the breakpoint before the crash.
|
|
gdb_test "run" "${srcfile2}:${bp_location}.*set breakpoint here.*"
|
|
|
|
return 0
|