Commit graph

4335 commits

Author SHA1 Message Date
Andrew Cagney
b9a9cde40b Unify (well almost) --enable-build-warnings configuration option
across GDB and SIM directories.
1998-10-28 02:01:32 +00:00
Andrew Cagney
63a0e6b527 Replace syserr_list with more portable strerror(). 1998-10-27 03:42:14 +00:00
Andrew Cagney
cf9d0fd980 * config/rs6000/aix4.mh (NATDEPFILES): Move xcoffread.o from here.
* config/rs6000/aix4.mt (TDEPFILES): To here.
* rdi-share/unixcomm.c: Provide definitions of SERPORT and PARPORT on
  BSD hosts.
1998-10-26 03:26:00 +00:00
Felix Lee
61e6bcc839 * core-sol2.c: #include <sys/types.h>, for sol2.7 weirdness. 1998-10-17 17:40:35 +00:00
Michael Snyder
a93213bcf5 Fri Oct 16 15:31:38 1998 Michael Snyder <msnyder@cleaver.cygnus.com>
* m32r-tdep.c (decode_prologue): Return failure if we reach
        the end of the function without finding the end of the prologue.
1998-10-16 22:35:41 +00:00
Jason Molenda
24418cfbac 1998-10-16 Jason Molenda (jsm@bugshack.cygnus.com)
* command.c copying.c copying.awk core-aout.c core-regset.c
          corelow.c dcache.c i386-tdep.c i386v4-nat.c i387-tdep.c
          infcmd.c infptrace.c infrun.c remote.c solib.c symfile.c
          symmisc.c valarith.c: Add prototypes.

        * defs.h: Add prototype for utils.c::do_run_cleanups.

        * gdbtypes.c: Add prototypes.
        (make_pointer_type): Add braces to remove nested if-else ambiguity.
        (make_reference_type): Ditto.

        * printcmd.c (printf_command): Initialize 'f' and 'string' at
        function startup to suppress possibly-used-before-initialized warning.

        * remote-utils.c: Add prototypes.
        (sr_pollchar): Add braces to remove nested if-else ambiguity.

        * ser-tcp.c: Add prototypes.
        (wait_for): Add braces to remove nested if-else ambiguity.
        (tcp_readchar): Ditto.

        * ser-unix.c: Add prototypes.
        (get_tty_state): Don't define errno here.

        (get_tty_state): Don't define errno here.
        (hardwire_readchar): Only define 't' if we are compiling in a Cygwin
        environment.

        * symtab.c: Add prototypes.
        (find_methods): Add braces to remove nested if-else ambiguity.
        (search_symbols): Set 'i' to an initial value to suppress a
        possibly-used-before-initialized warning.

        * valops.c: Add prototypes.
        (value_cast): Set 'eltype2' to an initial value to suppress a
        possibly-used-before-initialized warning.
        (value_of_variable): Add braces to remove nested if-else ambiguity.
        (value_of_this): Ditto.

        * valprint.c: Add prototypes.
        (print_floating): Add braces to remove nested if-else ambiguity.


Looks like a big change, but it is really just a lot of small stuff.

In the cases where GCC was flagging a possible use-before-initialized
warning on variables, it turned out that these were being used properly
but GCC couldn't see that.
1998-10-16 21:45:06 +00:00
Stan Shebs
7bfe11e286 * tm-sp64.h (SETUP_ARBITRARY_FRAME, RAME_SPECIFICATION_DYADIC):
Remove, nevermore used.
1998-10-16 02:53:37 +00:00
Andrew Cagney
dd87762571 command.c: Include "wait.h" after, rather than before, <wait.h>.
"wait.h" was defining all WIF* macro's instead of filling in those
that <wait.h> missed.  Stops heaps of warnings from <wait.h>
re-defining WIF*s defined in "wait.h".
1998-10-15 06:59:40 +00:00
Felix Lee
37f58dce03 * sol-thread.c (ps_pstop, etc): simple test for proc_service.h
version didn't work for sol2.6; pushed it to autoconf.
        * configure.in (gdb_cv_proc_service_is_old): new test.
        * acconfig.h (PROC_SERVICE_IS_OLD): new define.
        * configure, config.in: regenerate.
1998-10-14 01:15:01 +00:00
Jason Molenda
ad3b8c4a1a 1998-10-13 Jason Molenda (jsm@bugshack.cygnus.com)
* blockframe.c (find_pc_sect_partial_function): Add braces to avoid
        possible nested-if confusion.
        * breakpoint.c (breakpoint_here_p): Ditto.
        (breakpoint_inserted_here_p): Ditto.
        (breakpoint_thread_match): Ditto.

        * gnu-regex.c: Define _REGEX_RE_COMP only if it isn't already defined.
        * gnu-regex.h: Define _REGEX_RE_COMP to pick up old compatability
        prototypes.

        * symtab.h: Add prototype for _initialize_source.
        * value.h: Add prototype for _initialize_value.

        * defs.h: Include sys/types.h or stddef.h to get size_t.
        (make_cleanup): Add make_cleanup_func typedef and switch to using
        a prototype for this function.
        (mfree): Add prototypes for mmalloc, mrealloc, mfree if we aren't
        using mmalloc.

        * ax-gdb.c breakpoint.c coffread.c corelow.c dbxread.c dwarf2read.c
        dwarfread.c elfread.c eval.c exec.c gdbtk-cmds.c gdbtk.c infcmd.c
        infrun.c mipsread.c nlmread.c os9kread.c parse.c printcmd.c symfile.c
        symmisc.c symtab.c thread.c top.c tracepoint.c typeprint.c valops.c:
        Cast parameters passed to make_cleanup to use the new
        make_cleanup_func typedef.


More warning cleanups.  There are still a bunch of places where the first
argument to make_cleanup is not cast to (make_cleanup_func); these are
either due to the function fitting the make_cleanup_func specification
already (e.g. free()) or they are in files that weren't compiled when
I did my make on a Linux native system.  Bwahahaha.  You can see them
like this:

grep make_cleanup\  * | grep -v make_cleanup_func

I'll surely go back and clean up the remaining suspicious calls in
GDB one of these days. :-)
1998-10-14 01:15:00 +00:00
Jason Molenda
6e47b25142 Whoa, somehow this ChangeLog entry didn't get committed along with the
actual changes.  Here is the text:
1998-10-12  Jason Molenda  (jsm@bugshack.cygnus.com)

        * Makefile.in (AWK): Unused; remove.
        * configure.in: Remove unused autoconf checks for MINIX, memcpy,
        poll, select, strings.h.
        * config.in: Regenerated.
        * configure: Regenerated.
1998-10-13 22:18:49 +00:00
Felix Lee
bbee94c77c * sol-thread.c (ps_pstop, etc): different solaris versions have
slightly different prototypes in proc_service.h; compensate.
1998-10-13 00:55:20 +00:00
Jason Molenda
1dee2761ad 1998-10-12 Jason Molenda (jsm@bugshack.cygnus.com)
* configure.in: Check for sys/debugreg.h, asm/debugreg.h.
        * i386v-nat.c: Include asm/debugreg.h, sys/debugreg.h if it is not
        present.

This is to work around a conflict where the Linux 2.1.x kernel and glibc
2.0.x are not in sync; including <sys/debugreg.h> will result in an error.
With luck, these losers will get their act together and we can trash
this hack in the near future.
1998-10-13 00:35:48 +00:00
Peter Schauer
b0a5badb69 * dwarf2read.c (dwarf2_build_psymtabs_hard): Do not adjust the
address range of a compilation unit without children.

	* mdebugread.c (parse_partial_symbols):  Fix handling of stabs
	continuations, use xmalloc and xrealloc.
1998-10-11 19:54:57 +00:00
Mark Alexander
c6d28b22da * rs6000-tdep.c: Don't include tm.h twice. 1998-10-10 01:17:07 +00:00
Keith Seitz
d367c7b447 * main.c (main): Remove calls to {pre,post}_add_symbol_hooks.
There should be sufficient information/hooks now to eliminate
        this hack.

        * exec.c (file_command): Add a new hook here to inform ui's
        when the exec file has changed. Adding it here allows the
        ui to be informed after symbol reading.

        * gdbcore.h: Add declaration of file_changed_hook.
1998-10-08 23:04:53 +00:00
Mark Alexander
70423641d9 * rs6000-tdep.c (get_saved_register): Define only if
USE_GENERIC_DUMMY_FRAMES is defined.
1998-10-08 15:59:23 +00:00
Jason Molenda
87feff9dab 1998-10-06 Jason Molenda (jsm@bugshack.cygnus.com)
Eliminate a few warnings from the compiler.
        * breakpoint.h: Add prototype.
        * breakpoint.c (do_enable_breakpoint): cast mem_cnt, i to (void).
        * configure.in: Check if strdup declaration is necessary.
        * configure: Regenerated.
        * defs.h: Add prototypes.
        * gdb_string.h: Only define strdup if necessary.
        * gdbthread.h: Add prototypes.
        * printcmd.c: Add prototyptes.
        (disassemble_command): Remove unused variable 'section'.
        * symtab.c: Add prototypes.
        * symtab.h: Include gnu-regex.h, add prototype.
        * thread.c: Add prototype.
1998-10-06 22:24:40 +00:00
Stan Shebs
ee31ae2284 From David Purves <purves@apogee.com>:
* stabsread.c (rs6000_builtin_type): Create a complex float instead
	of an error.
	(read_sun_floating_type): Similarly.
	(read_range_type): Create a complex float if self_subrange is
 	true.
1998-10-06 02:52:31 +00:00
Stu Grossman
242c0d8180 * c-lang.c (emit_char c_printchar c_printstr), c-lang.h (c_printstr)
ch-lang.c (chill_printstr chill_printchar) c-valprint.c (c_val_print)
	ch-valprint.c (chill_val_print) expprint.c (print_subexp) f-lang.c
	(f_printstr f_printchar emit_char) f-valprint.c (f_val_print) jv-lang.c
	(java_printchar java_emit_char) jv-valprint.c (java_value_print
	java_val_print) language.c (unk_lang_printchar unk_lang_printstr
	unk_lang_emit_char) language.h (struct language_defn LA_PRINT_STRING
	LA_EMIT_CHAR) m2-lang.c (m2_printstr m2_printchar emit_char) printcmd.c
	(print_formatted) scm-lang.c (scm_printstr) valprint.c
	(val_print_string) value.h (val_print_string):  Add emit_char routines
	to language_desc struct to allow finer control over language specific
	character output issues.  Add character width arg to printstr routines
	to allow handling of wchar_t/Unicode strings.  Fix c_printstr to handle
	wide characters.  Supply width argument to LA_PRINT_STRING and
	val_print_string.

	* jv-lang.c (java_object_type dynamics_objfile java_link_class_type
	get_dynamics_objfile get_java_object_type) jv-lang.h
	(get_java_object_type):  Make lots of things static.

	* expprint.c (dump_prefix_expression dump_subexp):  Move opcode name
	printing to common routine (op_name).
	* (dump_subexp):  Add support for OP_SCOPE.
1998-10-05 19:42:04 +00:00
Stan Shebs
bb9e536843 Search and destroy; kill references to WinGDB bits.
* configure.host (i[3456]86-*-windows): Remove, no longer used.
	* mswin: Remove directory, no longer used.
1998-10-02 23:33:15 +00:00
Fernando Nasser
2d24a02138 Fri Oct 2 18:52:20 1998 Fernando Nasser <fnasser@cygnus.com>
* sol-thread.c: Fixed prototypes and calls to supply_fpregset and
        fill_fpregset
PR 17053
1998-10-02 22:57:12 +00:00
Keith Seitz
80baea8aa5 * remote.c (remote_interrupt): Rewrite to use remote_stop.
(remote_interrupt_twice): Remove. remote_stop now handles it.
        (remote_stop): New function which handles interrupting the
        remote target so that CLUI and GUI use the same core functions
        to achieve the same goal.
        (remote_wait): Change to handle remote_stop properly.
        [interrupted_already]: New static global to help remote_stop.
        [remote_ops, extended_remote_ops]: Add remote_stop for to_stop member.

        * target.c: Rename static function "ignore" to "target_ignore" and
        export it so that gdb can determin if some target vector member is
        actually not defined. Replace all occurances of ignore.

        * target.h: Export target_ignore.
1998-10-02 19:54:42 +00:00
Peter Schauer
47b8a5cef3 * target.c (target_xfer_memory): Handle requests with zero
transfer length right away.

	* values.c (unpack_double):  Set up code, length and signedness of
	type _after_ checking for typedef.
1998-10-02 11:02:00 +00:00
Frank Ch. Eigler
6ee2da947e * Fix for PR 16567, brought over from d30v branch.
Thu Oct  1 15:39:27 EDT 1998 Frank Ch. Eigler <fche@cygnus.com>
	* breakpoint.c (bpstat_stop_status): Do not consider an
	untripped watchpoint as a "hit".
1998-10-01 11:48:25 +00:00
Andrew Cagney
c85a8f0003 More replacing "exec" with "executable". 1998-10-01 11:41:41 +00:00
Andrew Cagney
b8464c1539 Replace "exec" with "executable" in messages. 1998-10-01 11:19:11 +00:00
Keith Seitz
69da960729 Merge with armelf980813:
* rdi-share/unixcomm.c: If using cygwin32, also use the SERPORT and
        PARPORT defines for win32.
        (Unix_MatchValidSerialDevice): For cygwin32, valid serial port names
        start with "com", not "/dev/tty".
        (Unix_OpenSerial): Do not use O_NONBLOCK on cygwin32.

        * rdi-share/devsw.c (DevSW_Close): Free the device's state (SwitcherState)
        so that the device may be reopened.

        * remote-rdi.c (mywritec): Send all output through gdb's *_unfiltered
        functions, ignoring non-ASCII chars, so that non-tty UI's can snarf
        the output from fputs_hook.
        (mywrite): Ditto.
        (arm_rdi_open): Set inferior_pid.
        (arm_rdi_detach): Pop the target off the target stack so that
        users can attach and detach multiple times.
        (arm_rdi_close): Close the opened device and reset inferior_pid, too.
1998-09-25 19:04:46 +00:00
Jason Molenda
4817b40893 1998-09-24 Jason Molenda (jsm@bugshack.cygnus.com)
* configure.in: Change --enable-warnings to --enable-build-warnings.
        * configure: Updated.
1998-09-25 03:04:03 +00:00
Jason Molenda
e3009a74f4 1998-09-24 Jason Molenda (jsm@bugshack.cygnus.com)
* configure.in (WARN_CFLAGS): Add -Wmissing-prototypes.
        * configure: Regenerated.
1998-09-25 01:30:46 +00:00
Jason Molenda
ba68ad5701 1998-09-24 Jason Molenda (jsm@bugshack.cygnus.com)
* configure.in: Add --enable-warnings.
        Adjust whitespace of other --with and --enable options so that
        configure --help lines up correctly.
        * aclocal.m4: Ditto.
        * Makefile.in (WARN_CFLAGS): Add.  Set by configure.
        * configure: Regenerated.
1998-09-25 01:27:47 +00:00
Stan Shebs
f1f8c637ae * remote-rdi.c: Fix formatting, remove some commented-out code.
(init_rdi_ops): Omit needless initializations.
1998-09-24 22:48:48 +00:00
Andrew Cagney
8456141bb2 Allow full 64 bits of an address to be specified in an M' or n' packet.
Add backward compatibility variable `set remoteaddresssize' to handle
regressions.
1998-09-23 08:31:50 +00:00
Andrew Cagney
f8059b97e7 * remote.c (_initialize_remote, packet_command, print_packet): Pretty
* print code.
Delete reference to EMC!
1998-09-23 08:12:14 +00:00
Andrew Cagney
abf80d3b9c * remote.c (packet_command): Test REMOTE_DESC to determine if remote
connection is open.
1998-09-23 08:06:50 +00:00
Mark Alexander
0ec1e44d3d Patch from Dawn Perchik <dawn@cygnus.com>:
* rs6000-tdep.c (pop_frame): Handle generic dummy frames.
	(push_arguments): Likewise.
	(frame_saved_pc): Likewise.
	(rs6000_frame_chain): Likewise.
	(ppc_push_return_address): New function.
	(get_saved_register): New function.
	* config/powerpc/tm-ppc-eabi.h: Add generic dummy frame macros.
1998-09-23 05:41:38 +00:00
Stu Grossman
7b46dd00e4 * defs.h utils.c (fputc_filtered): New function. Does the obvious...
* jv-lang.c (java_printchar):  Fix output of chars > 0xff.  Fold
	java_emit_char into java_printchar.
	* language.h (PRINT_LITERAL_FORM):  Reformat for readability.
1998-09-22 02:34:38 +00:00
Nick Clifton
a63e37257f Support big endian as well as little endian breakpoints. 1998-09-21 21:39:41 +00:00
Ron Unrau
3dc96daa2d * incorporate SKY-B changes (makes dual maintenance easier).
* txvu-tdep.c (check_overlap): new function to guarantee that
          overlays are either mapped or unmapped in their entirety.
        * txvu-tdep.c (compress_blockvector): compress blockvectors correctly
1998-09-21 05:11:13 +00:00
Peter Schauer
d2fce7f74c * sol-thread.c (sol_thread_notice_signals): Use PIDGET when
passing pid down to procfs_notice_signals.
1998-09-18 14:57:16 +00:00
Stu Grossman
082a0803b1 * stabsread.c (resolve_symbol_reference): Return 1 on success, 0 on
failure.
	* (define_symbol):  Check return value from resolve_symbol_reference,
	and drop symbol if it fails.
1998-09-16 21:59:01 +00:00
Nick Clifton
9d561e1e94 prevent multiple attempts at closing remote connection. 1998-09-15 21:03:26 +00:00
Andrew Cagney
b2d5581361 Use value_at_lazy() to examine memory values. For x/i this is very
important as it stops the specified address being fetched twice -
once by value_at() and once somewhere in the disassembler.
1998-09-15 07:50:31 +00:00
Michael Snyder
4a8051a834 Sun Sep 13 01:34:59 1998 Michael Snyder <msnyder@cleaver.cygnus.com>
* blockframe.c (find_pc_sect_partial_function): use bfd section
	  of msymbol for end of section comparison.
1998-09-13 08:37:08 +00:00
Michael Snyder
74c1b0ba6b Fri Sep 11 14:02:49 1998 Michael Snyder <msnyder@cleaver.cygnus.com>
* tracepoint.c: clean up several unused variables and such.
1998-09-11 21:03:29 +00:00
Zdenek Radouch
05f1989d85 Fri Sep 11 12:38:34 EDT 1998 Zdenek Radouch (radouch@cygnus.com)
* arm-tdep.c (arm_push_arguments): fixed frame construction
1998-09-11 16:40:04 +00:00
Michael Snyder
6a5c768569 Thu Sep 10 20:51:23 1998 Michael Snyder <msnyder@cleaver.cygnus.com>
* mn10300-tdep.c (mn10300_analyze_prologue): guard against NULL.
1998-09-11 03:52:21 +00:00
Stan Shebs
d7d7dd1b5a More avoidance of writing documentation in the internals manual.
* dbxread.c (IGNORE_SYMBOL): Remove definition, is never used.
	* os9kread.c: Remove comment mentioning IGNORE_SYMBOL.
1998-09-10 02:58:19 +00:00
Ron Unrau
253ceee6d0 Merges from SKY branch:
* blockframe.c(find_pc_sect_partial_function): look for min syms in
          the same section when trying to guess the end of a function.
        * symfile.c(list_overlays_command): use print_address_numeric
        * remote-sim.c: export simulator_command
        * tm-r5900.h: add COP0 registers
        * txvu-tdep.c: printvector and printvector-order commands
        * tm-txvu.h: add COP0 registers
        * mips-tdep.c: use NUM_CORE_REGS
1998-09-09 17:41:59 +00:00
Jason Molenda
fc4109089c 1998-09-08 Jason Molenda (jsm@bugshack.cygnus.com)
* breakpoint.c (bpstat_stop_status):  Declare a bp match if the
        current fp matches the bp->fp OR if the current fp is less than
        the bp->fp if we're looking at a bp_step_resume breakpoint.

PR 15992.

With a bp_step_resume type breakpoint, the frame pointer check exists in
case we recurse and execute the same text section--we want to not stop
there because it would confuse the user.  So gdb checks to see that the
frame pointer matches the one recorded in the breakpoint.

If the current frame pointer is less than the frame pointer recorded in
the breakpoint, then something odd is happened and we should declare that
we're at the breakpoint so that we clear it out.

This happens in Purify instrumented executables on PA systems, at least.
They insert some calls out to Purify code in the function epilogue and
it confuses GDB (which assumes that the frame pointer does not move
around through the entire execution of a function).
1998-09-09 04:16:53 +00:00