* gdb.base/dump.exp (capture_pointer_with_type): New.
Get value from address instead of name.
Start GDB once, and do `dump' and `restore'
tests together.
Report error on inaccessible memory.
* cli/cli-dump.c: Include gdbcore.h.
(dump_memory_to_file): Call read_memory instead of target_read_memory.
gdb/testsuite/
* gdb.base/dump.exp (inaccessible memory is reported): New test.
* printcmd.c (print_scalar_formatted): Always truncate
unsigned data types.
* cli-dump.c (struct callback_data): Change type of load_offset
to CORE_ADDR.
(restore_binary_file): Update type casts.
(restore_command): Parse load_offset as address, not long.
* utils.c (string_to_core_addr): Do not sign-extend value.
* varobj.c (find_frame_addr_in_frame_chain): Truncate frame_base
before comparing against requested frame address.
testsuite/ChangeLog:
* gdb.base/dump.exp: Handle SPU like 64-bit platforms.
Fix PR testsuite/1729.
* gdb.base/dump.exp: Add test name to callers of capture_value, do
not use capture_value with value 4.
(capture_value): Add optional test name parameter.
(test_reload_saved_value, test_restore_saved_value): Use $msg as
the prefix, pass to capture_value.
* gdb.base/default.exp: Add tests for dump, append, and restore.
* gdb.base/help.exp: Add tests for dump, append, and restore.
* gdb.base/dump.exp: New file, test dump, append and restore.
* gdb.base/dump.c: New file.