darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* objfiles.h (struct objfile): Remove obsolete comment.

Browse source 
* objfiles.c (build_objfile_section_table): Remove obsolete
	comment.
This commit is contained in:
Tom Tromey 2011-12-08 18:08:12 +00:00
parent d8ea793193
commit ff011ed785
3 changed files with 9 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2011-12-08 Tom Tromey <tromey@redhat.com>
* objfiles.h (struct objfile): Remove obsolete comment.
* objfiles.c (build_objfile_section_table): Remove obsolete
comment.
2011-12-07 Stan Shebs <stan@codesourcery.com> 2011-12-07 Stan Shebs <stan@codesourcery.com>
* MAINTAINERS (Responsible Maintainers): Add Yao Qi as * MAINTAINERS (Responsible Maintainers): Add Yao Qi as

6
gdb/objfiles.c
View file

@ -162,12 +162,6 @@ add_to_objfile_sections (struct bfd *abfd, struct bfd_section *asect,
int int
build_objfile_section_table (struct objfile *objfile) build_objfile_section_table (struct objfile *objfile)
{ {
/* objfile->sections can be already set when reading a mapped symbol
file. I believe that we do need to rebuild the section table in
this case (we rebuild other things derived from the bfd), but we
can't free the old one (it's in the objfile_obstack). So we just
waste some memory. */
objfile->sections_end = 0; objfile->sections_end = 0;
bfd_map_over_sections (objfile->obfd, bfd_map_over_sections (objfile->obfd,
add_to_objfile_sections, (void *) objfile); add_to_objfile_sections, (void *) objfile);

16
gdb/objfiles.h
View file

@ -173,19 +173,9 @@ struct objfile
{ {
/* All struct objfile's are chained together by their next pointers. /* All struct objfile's are chained together by their next pointers.
The global variable "object_files" points to the first link in this The program space field "objfiles" (frequently referenced via
chain. the macro "object_files") points to the first link in this
chain. */
FIXME: There is a problem here if the objfile is reusable, and if
multiple users are to be supported. The problem is that the objfile
list is linked through a member of the objfile struct itself, which
is only valid for one gdb process. The list implementation needs to
be changed to something like:
struct list {struct list *next; struct objfile *objfile};
where the list structure is completely maintained separately within
each gdb process. */
struct objfile *next; struct objfile *next;