darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "fix cleanup handling in macho_symfile_read"

Browse source 
This patch indirectly causes a SEGV by creating a dangling pointer.
Reverting this patch while working on a clearer memory management
method for this part of the code.

gdb/Changelog:

        Revert:
        * machoread.c (macho_symfile_read): Assign first cleanup to
        'back_to'.
This commit is contained in:
Joel Brobecker 2013-06-03 13:22:29 +00:00
parent fa549f3baa
commit f6aea118f8
2 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2013-06-03 Joel Brobecker <brobecker@adacore.com>
Revert (indirectly causes a SIGSEGV):
* machoread.c (macho_symfile_read): Assign first cleanup to
'back_to'.
2013-06-03 Yao Qi <yao@codesourcery.com>
* mi/mi-cmd-var.c (mi_no_values, mi_simple_values): Move to

4
gdb/machoread.c
View file

@ -871,10 +871,10 @@ macho_symfile_read (struct objfile *objfile, int symfile_flags)
struct cleanup *back_to;
symbol_table = (asymbol **) xmalloc (storage_needed);
back_to = make_cleanup (xfree, symbol_table);
make_cleanup (xfree, symbol_table);
init_minimal_symbol_collection ();
make_cleanup_discard_minimal_symbols ();
back_to = make_cleanup_discard_minimal_symbols ();
symcount = bfd_canonicalize_symtab (objfile->obfd, symbol_table);