darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* linux-low.c (fetch_register): Avoid passing a non string literal

Browse source 
format to `error'.
	(usr_store_inferior_registers): Ditto.
This commit is contained in:
Pedro Alves 2010-03-15 00:31:16 +00:00
parent 19941bfa37
commit f52cd8cdd8
2 changed files with 8 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/gdbserver/ChangeLog
View file

@ -1,3 +1,9 @@
2010-03-15 Pedro Alves <pedro@codesourcery.com>
* linux-low.c (fetch_register): Avoid passing a non string literal
format to `error'.
(usr_store_inferior_registers): Ditto.
2010-03-14 Pedro Alves <pedro@codesourcery.com>
* linux-low.c (linux_write_memory): Bail out early if peeking

21
gdb/gdbserver/linux-low.c
View file

@ -2217,23 +2217,13 @@ fetch_register (struct regcache *regcache, int regno)
(PTRACE_ARG3_TYPE) (uintptr_t) regaddr, 0);
regaddr += sizeof (PTRACE_XFER_TYPE);
if (errno != 0)
{
/* Warning, not error, in case we are attached; sometimes the
kernel doesn't let us at the registers. */
char *err = strerror (errno);
char *msg = alloca (strlen (err) + 128);
sprintf (msg, "reading register %d: %s", regno, err);
error (msg);
goto error_exit;
}
error ("reading register %d: %s", regno, strerror (errno));
}
if (the_low_target.supply_ptrace_register)
the_low_target.supply_ptrace_register (regcache, regno, buf);
else
supply_register (regcache, regno, buf);
error_exit:;
}
/* Fetch all registers, or just one, from the child process. */
@ -2299,14 +2289,7 @@ usr_store_inferior_registers (struct regcache *regcache, int regno)
return;
if ((*the_low_target.cannot_store_register) (regno) == 0)
{
char *err = strerror (errno);
char *msg = alloca (strlen (err) + 128);
sprintf (msg, "writing register %d: %s",
regno, err);
error (msg);
return;
}
error ("writing register %d: %s", regno, strerror (errno));
}
regaddr += sizeof (PTRACE_XFER_TYPE);
}