Add FIXME explaining include problem.

This commit is contained in:
Andrew Cagney 2002-03-01 06:19:28 +00:00
parent 5ecaa7ddac
commit f33c6cbfe5
17 changed files with 203 additions and 30 deletions

View file

@ -1,3 +1,7 @@
2002-03-01 Andrew Cagney <ac131313@redhat.com>
* utils.c: Add FIXME explaining true/false problem.
2002-02-28 Andrew Cagney <ac131313@redhat.com> 2002-02-28 Andrew Cagney <ac131313@redhat.com>
* MAINTAINERS (Past Maintainers): Add J.T. Conklin. * MAINTAINERS (Past Maintainers): Add J.T. Conklin.

View file

@ -1,3 +1,28 @@
2002-03-01 Andrew Cagney <ac131313@redhat.com>
* tui-hooks.c: Add FIXME to explain true/false problem. Update
copyright.
* tui.c, tuiCommand.c, tuiData.c, tuiDataWin.c: Ditto.
* tuiDisassem.c, tuiGeneralWin.c, tuiIO.c, tuiLayout.c: Ditto.
* tuiRegs.c, tuiSource.c, tuiSourceWin.c, tuiStack.c: Ditto.
* tuiWin.c: Ditto.
2002-02-08 Daniel Jacobowitz <drow@mvista.com>
* tui-hooks.c: Include <curses.h> before "bfd.h".
* tui.c: Likewise.
* tuiCommand.c: Likewise.
* tuiData.c: Likewise.
* tuiDataWin.c: Likewise.
* tuiDisassem.c: Likewise.
* tuiGeneralWin.c: Likewise.
* tuiIO.c: Likewise.
* tuiLayout.c: Likewise.
* tuiRegs.c: Likewise.
* tuiSource.c: Likewise.
* tuiSourceWin.c: Likewise.
* tuiStack.c: Likewise.
* tuiWin.c: Likewise.
2002-02-01 Andrew Cagney <ac131313@redhat.com> 2002-02-01 Andrew Cagney <ac131313@redhat.com>
* tuiWin.c (_initialize_tuiWin): Replace NO_FUNCTION with NULL. * tuiWin.c (_initialize_tuiWin): Replace NO_FUNCTION with NULL.

View file

@ -1,5 +1,6 @@
/* GDB hooks for TUI. /* GDB hooks for TUI.
Copyright 2001 Free Software Foundation, Inc.
Copyright 2001, 2002 Free Software Foundation, Inc.
This file is part of GDB. This file is part of GDB.
@ -18,7 +19,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* General functions for the WDB TUI. /* General functions for the WDB TUI.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* Specific command window processing. /* Specific command window processing.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI data manipulation routines. /* TUI data manipulation routines.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* Data/register window display. /* Data/register window display.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* Disassembly display. /* Disassembly display.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* General window behavior. /* General window behavior.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI support I/O functions. /* TUI support I/O functions.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI layout window management. /* TUI layout window management.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI display registers in window. /* TUI display registers in window.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI display source window. /* TUI display source window.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI display source/assembly window. /* TUI display source/assembly window.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI display locator. /* TUI display locator.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -19,7 +22,14 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -1,5 +1,8 @@
/* TUI window generic functions. /* TUI window generic functions.
Copyright 1998, 1999, 2000, 2001 Free Software Foundation, Inc.
Copyright 1998, 1999, 2000, 2001, 2002 Free Software Foundation,
Inc.
Contributed by Hewlett-Packard Company. Contributed by Hewlett-Packard Company.
This file is part of GDB. This file is part of GDB.
@ -24,7 +27,14 @@
Author: Susan B. Macchia */ Author: Susan B. Macchia */
/* If we need <curses.h>, we must include it before we get "bfd.h". */ /* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
#ifdef HAVE_NCURSES_H #ifdef HAVE_NCURSES_H
#include <ncurses.h> #include <ncurses.h>

View file

@ -20,10 +20,16 @@
Foundation, Inc., 59 Temple Place - Suite 330, Foundation, Inc., 59 Temple Place - Suite 330,
Boston, MA 02111-1307, USA. */ Boston, MA 02111-1307, USA. */
/* FIXME: cagney/2002-02-28: The GDB coding standard indicates that
"defs.h" should be included first. Unfortunatly some systems
(currently Debian GNU/Linux) include the <stdbool.h> via <curses.h>
and they clash with "bfd.h"'s definiton of true/false. The correct
fix is to remove true/false from "bfd.h", however, until that
happens, hack around it by including "config.h" and <curses.h>
first. */
#include "config.h" #include "config.h"
/* Include before "bfd.h" so that we get stdbool.h in time, if <curses.h>
brings it in. */
#ifdef HAVE_CURSES_H #ifdef HAVE_CURSES_H
#include <curses.h> #include <curses.h>
#endif #endif