darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Another fix for an objdump crash when parsing a corrupt binary.

Browse source 
PR binutils/17512
	* mach-o.c (bfd_mach_o_read_symtab_strtab): Zero terminate the
	string table.
This commit is contained in:
Nick Clifton 2015-01-06 22:02:55 +00:00
parent e749cab89d
commit e7287c7f64
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
bfd/ChangeLog
View file

@ -1,6 +1,9 @@
2015-01-06 Nick Clifton <nickc@redhat.com>
PR binutils/17512
* mach-o.c (bfd_mach_o_read_symtab_strtab): Zero terminate the
string table.
* reloc.c (bfd_get_reloc_size): Handle a reloc size of -1.
(bfd_perform_relocation): Include the size of the reloc in the
test for an out of range relocation.

4
bfd/mach-o.c
View file

@ -3675,7 +3675,7 @@ bfd_mach_o_read_symtab_strtab (bfd *abfd)
}
else
{
sym->strtab = bfd_alloc (abfd, sym->strsize);
sym->strtab = bfd_alloc (abfd, sym->strsize + 1);
if (sym->strtab == NULL)
return FALSE;
@ -3688,6 +3688,8 @@ bfd_mach_o_read_symtab_strtab (bfd *abfd)
bfd_set_error (bfd_error_file_truncated);
return FALSE;
}
/* Zero terminate the string table. */
sym->strtab[sym->strsize] = 0;
}
return TRUE;