darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

fix linespec bug noticed by the checker

Browse source 
This fixes a linespec bug noticed by the cleanup checker.

find_linespec_symbols did this:

  cleanup = demangle_for_lookup (name, state->language->la_language,
				 &lookup_name);
[...]
      cleanup = make_cleanup (xfree, canon);

But this is wrong, as it makes a subsequent call to do_cleanups not
clean up all the local state.

	* linespec.c (find_linespec_symbols): Don't reassign to 'cleanup'.
This commit is contained in:
Tom Tromey 2013-05-30 16:57:38 +00:00
parent b81b921f79
commit e61727abf0
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2013-05-30 Tom Tromey <tromey@redhat.com>
* linespec.c (find_linespec_symbols): Don't reassign to 'cleanup'.
2013-05-30 Tom Tromey <tromey@redhat.com>
* cli/cli-script.c (setup_user_args): Don't return after error.

2
gdb/linespec.c
View file

@ -3097,7 +3097,7 @@ find_linespec_symbols (struct linespec_state *state,
if (canon != NULL)
{
lookup_name = canon;
cleanup = make_cleanup (xfree, canon);
make_cleanup (xfree, canon);
}
/* It's important to not call expand_symtabs_matching unnecessarily