darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Revert "elfread.c (elf_symtab_read): Stop memory leak"

Browse source 
It turns out that this change is not correct, and it causes a crash
on sparc-solaris while trying to load ld.so.  This is because the
memory is actually still referenced after elf_symtab_read completes.

gdb/ChangeLog:

        * elfread.c (elf_symtab_read): Revert the previous change
        that tried to stop a memory leak.
This commit is contained in:
Joel Brobecker 2011-05-03 16:22:39 +00:00
parent 9ed350ad08
commit dd3295eed0
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
gdb/ChangeLog
View file

@ -1,3 +1,9 @@
2011-05-03 Joel Brobecker <brobecker@adacore.com>
Revert:
| 2011-03-07 Michael Snyder <msnyder@vmware.com>
| * elfread.c (elf_symtab_read): Stop memory leak.
2011-05-03 Pierre Muller <muller@ics.u-strasbg.fr> 2011-05-03 Pierre Muller <muller@ics.u-strasbg.fr>
* nto-tdep.c (nto_target): Replace deprecated call to * nto-tdep.c (nto_target): Replace deprecated call to

3
gdb/elfread.c
View file

@ -257,7 +257,6 @@ elf_symtab_read (struct objfile *objfile, int type,
char *filesymname = ""; char *filesymname = "";
struct dbx_symfile_info *dbx = objfile->deprecated_sym_stab_info; struct dbx_symfile_info *dbx = objfile->deprecated_sym_stab_info;
int stripped = (bfd_get_symcount (objfile->obfd) == 0); int stripped = (bfd_get_symcount (objfile->obfd) == 0);
struct cleanup *back_to = make_cleanup (null_cleanup, NULL);
for (i = 0; i < number_of_symbols; i++) for (i = 0; i < number_of_symbols; i++)
{ {
@ -486,7 +485,6 @@ elf_symtab_read (struct objfile *objfile, int type,
+ (sizeof (CORE_ADDR) * max_index)); + (sizeof (CORE_ADDR) * max_index));
sectinfo = (struct stab_section_info *) sectinfo = (struct stab_section_info *)
xmalloc (size); xmalloc (size);
make_cleanup (xfree, sectinfo);
memset (sectinfo, 0, size); memset (sectinfo, 0, size);
sectinfo->num_sections = max_index; sectinfo->num_sections = max_index;
if (filesym == NULL) if (filesym == NULL)
@ -595,7 +593,6 @@ elf_symtab_read (struct objfile *objfile, int type,
} }
} }
} }
do_cleanups (back_to);
} }
/* Build minimal symbols named `function@got.plt' (see SYMBOL_GOT_PLT_SUFFIX) /* Build minimal symbols named `function@got.plt' (see SYMBOL_GOT_PLT_SUFFIX)