darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

* linux-nat.c (linux_nat_make_corefile_notes): Fixed a buffer overflow.

Browse source
This commit is contained in:
Jan Kratochvil 2007-09-02 14:04:31 +00:00
parent 4cf31eea6a
commit d99148ef73
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
gdb/ChangeLog
View file

@ -1,3 +1,7 @@
2007-09-02 Jan Kratochvil <jan.kratochvil@redhat.com>
* linux-nat.c (linux_nat_make_corefile_notes): Fixed a buffer overflow.
2007-09-01 Jan Kratochvil <jan.kratochvil@redhat.com>
* Makefile.in (symfile.o): Update dependencies.

17
gdb/linux-nat.c
View file

@ -2686,7 +2686,9 @@ linux_nat_make_corefile_notes (bfd *obfd, int *note_size)
{
struct linux_nat_corefile_thread_data thread_args;
struct cleanup *old_chain;
/* The variable size must be >= sizeof (prpsinfo_t.pr_fname). */
char fname[16] = { '\0' };
/* The variable size must be >= sizeof (prpsinfo_t.pr_psargs). */
char psargs[80] = { '\0' };
char *note_data = NULL;
ptid_t current_ptid = inferior_ptid;
@ -2699,9 +2701,18 @@ linux_nat_make_corefile_notes (bfd *obfd, int *note_size)
strncpy (psargs, get_exec_file (0), sizeof (psargs));
if (get_inferior_args ())
{
strncat (psargs, " ", sizeof (psargs) - strlen (psargs));
strncat (psargs, get_inferior_args (),
sizeof (psargs) - strlen (psargs));
char *string_end;
char *psargs_end = psargs + sizeof (psargs);
/* linux_elfcore_write_prpsinfo () handles zero unterminated
strings fine. */
string_end = memchr (psargs, 0, sizeof (psargs));
if (string_end != NULL)
{
*string_end++ = ' ';
strncpy (string_end, get_inferior_args (),
psargs_end - string_end);
}
}
note_data = (char *) elfcore_write_prpsinfo (obfd,
note_data,