darkkirb/old-cross-binutils
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Rename varobj_pretty_printed_p to varobj_is_dynamic_p

Browse source 
We think varobj with --available-children-only behaves like a dynamic
varobj, so dyanmic varobj is not pretty-printer specific.  We rename
varobj_pretty_printed_p to varobj_is_dynamic_p, so that we can handle
available-children-only checking in varobj_is_dynamic_p in the next
patch.

gdb:

2014-06-12  Yao Qi  <yao@codesourcery.com>

	* varobj.c (varobj_pretty_printed_p): Rename to ...
	(varobj_is_dynamic_p): ... this.  New function.
	* varobj.h (varobj_pretty_printed_p): Remove declaration.
	(varobj_is_dynamic_p): Declare.
	* mi/mi-cmd-var.c (print_varobj): All callers updated.
	(mi_print_value_p, varobj_update_one): Likewise.
This commit is contained in:
Yao Qi 2013-11-23 15:58:04 +08:00
parent 576ea0910f
commit cde5ef40f8
4 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
gdb/ChangeLog
View file

@ -1,3 +1,12 @@
2014-06-12 Yao Qi <yao@codesourcery.com>
* varobj.c (varobj_pretty_printed_p): Rename to ...
(varobj_is_dynamic_p): ... this. New function.
* varobj.h (varobj_pretty_printed_p): Remove declaration.
(varobj_is_dynamic_p): Declare.
* mi/mi-cmd-var.c (print_varobj): All callers updated.
(mi_print_value_p, varobj_update_one): Likewise.
2014-06-12 Pedro Alves <pedro@codesourcery.com>
Yao Qi <yao@codesourcery.com>

6
gdb/mi/mi-cmd-var.c
View file

@ -88,7 +88,7 @@ print_varobj (struct varobj *var, enum print_values print_values,
xfree (display_hint);
}
if (varobj_pretty_printed_p (var))
if (varobj_is_dynamic_p (var))
ui_out_field_int (uiout, "dynamic", 1);
}
@ -352,7 +352,7 @@ mi_print_value_p (struct varobj *var, enum print_values print_values)
if (print_values == PRINT_ALL_VALUES)
return 1;
if (varobj_pretty_printed_p (var))
if (varobj_is_dynamic_p (var))
return 1;
type = varobj_get_gdb_type (var);
@ -777,7 +777,7 @@ varobj_update_one (struct varobj *var, enum print_values print_values,
xfree (display_hint);
}
if (varobj_pretty_printed_p (r->varobj))
if (varobj_is_dynamic_p (r->varobj))
ui_out_field_int (uiout, "dynamic", 1);
varobj_get_child_range (r->varobj, &from, &to);

4
gdb/varobj.c
View file

@ -1066,8 +1066,10 @@ varobj_get_attributes (struct varobj *var)
return attributes;
}
/* Return true if VAR is a dynamic varobj. */
int
varobj_pretty_printed_p (struct varobj *var)
varobj_is_dynamic_p (struct varobj *var)
{
return var->dynamic->pretty_printer != NULL;
}

2
gdb/varobj.h
View file

@ -306,7 +306,7 @@ extern void varobj_enable_pretty_printing (void);
extern int varobj_has_more (struct varobj *var, int to);
extern int varobj_pretty_printed_p (struct varobj *var);
extern int varobj_is_dynamic_p (struct varobj *var);
extern struct cleanup *varobj_ensure_python_env (struct varobj *var);